[PATCH] D46675: [clangd] Add helper for collecting #include directives in file.

ioeric updated this revision to Diff 146074. ioeric added a comment. - Rebase on origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46675 Files: clangd/ClangdLSPServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Headers.cpp clangd/Headers.h clangd

[PATCH] D46675: [clangd] Add helper for collecting #include directives in file.

ioeric updated this revision to Diff 146075. ioeric added a comment. - Unmerge https://reviews.llvm.org/D46670 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46675 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Headers.cpp clangd/Headers.h clangd/XRefs.cpp I

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 146076. aheejin added a comment. - getMSVCDispatchBlock -> getFuncletEHDispatchBlock Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp

[PATCH] D46676: [clangd] Remove LSP command-based #include insertion.

ioeric created this revision. ioeric added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek. clangd will populate #include insertions as addtionalEdits in completion items. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46676

r331962 - [X86] ptwrite intrinsic

Author: gbuella Date: Thu May 10 00:28:54 2018 New Revision: 331962 URL: http://llvm.org/viewvc/llvm-project?rev=331962&view=rev Log: [X86] ptwrite intrinsic Reviewers: craig.topper, RKSimon Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D46540 Added: cfe/trunk

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena updated this revision to Diff 146080. delena added a comment. Given more clarification about memory model of atomic operations. Repository: rC Clang https://reviews.llvm.org/D46386 Files: docs/LanguageExtensions.rst include/clang/Basic/Builtins.def include/clang/Basic/Diagnostic

[PATCH] D46540: [X86] ptwrite intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC331962: [X86] ptwrite intrinsic (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D46540?vs=145681&id=146081#toc Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D46670: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

ioeric updated this revision to Diff 146082. ioeric added a comment. - [clangd] Add helper for collecting #include directives in file. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46670 Files: clangd/ClangdLSPServer.cpp clangd/SourceCode.cpp clangd/SourceCode.h Index:

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

ioeric updated this revision to Diff 146083. ioeric added a comment. - Rebase on https://reviews.llvm.org/D46670, https://reviews.llvm.org/D46675, https://reviews.llvm.org/D46676 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46497 Files: clangd/ClangdServer.cpp clangd/Cod

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

ioeric added a comment. This has been split and now depends on https://reviews.llvm.org/D46670, https://reviews.llvm.org/D46675, https://reviews.llvm.org/D46676. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46497 ___ cfe-commits

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added a comment. In https://reviews.llvm.org/D45616#1093514, @efriedma wrote: > There is no difference between "signalling" and "non-signalling" unless > you're using "#pragma STDC FENV_ACCESS", which is currently not supported. > Presumably the work to implement that will include some

r331963 - Revert "[Itanium] Emit type info names with external linkage."

Author: ericwf Date: Thu May 10 01:10:57 2018 New Revision: 331963 URL: http://llvm.org/viewvc/llvm-project?rev=331963&view=rev Log: Revert "[Itanium] Emit type info names with external linkage." This reverts commit r331957. It seems to be causing failures on ppc64le-linux. Modified: cfe/tru

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

EricWF reopened this revision. EricWF added a comment. This revision is now accepted and ready to land. Re-opening. I had to revert the last commit since it seemed to cause error (which looked unrelated?) on ppc64le-linux. Repository: rC Clang https://reviews.llvm.org/D46665 _

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF updated this revision to Diff 146090. EricWF added a comment. Remove a bunch of nonsense this patch originally had. Specifically remove the bits of overload resolution which disambiguated rewritten expressions after the fact; Instead attempt to validate that the return type of the three-w

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. Thanks ! I would be grateful if anybody could land it for me. https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

sepavloff updated this revision to Diff 146091. sepavloff added a comment. Updated patch Try evaluating initializer value only if the initializer type is integral or pointer. It avoids calculation of large value, which then is discarded. Repository: rC Clang https://reviews.llvm.org/D46241

r331965 - Add support of the next Ubuntu (Ubuntu 18.10 - Cosmic Canimal)

Author: sylvestre Date: Thu May 10 01:45:43 2018 New Revision: 331965 URL: http://llvm.org/viewvc/llvm-project?rev=331965&view=rev Log: Add support of the next Ubuntu (Ubuntu 18.10 - Cosmic Canimal) Patch by Adam Conrad Modified: cfe/trunk/include/clang/Driver/Distro.h cfe/trunk/lib/Driv

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46683 Files: lib/Headers/movdirintrin.h test/CodeGen/builtin-movdir.c Index: test/CodeGen/builtin-movdir.c ===

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

hfinkel added a comment. In https://reviews.llvm.org/D39053#1093977, @asb wrote: > Just wanted to explicitly say that I'm happy the updated patch reflects the > changes to docs and comments I requested. @hfinkel - are you happy for this > to land now? Yes, go ahead. Some of these benefits mi

[PATCH] D46684: [Frontend] Don't skip function body when the return type is dependent on the template parameter.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Otherwise clang will provide an unexpected diagnostic error. Repository: rC Clang https://reviews.llvm.org/D46684 Files: lib/Sema/SemaDecl.cpp test/Index/skipped-auto-fn-templates.cpp Index: test/Index/skipped-auto-f

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

labath created this revision. labath added reviewers: rjmccall, aprantl. Merging of complete and base structors can degrade debug quality as it will leave the debugger unable to locate the full object structor. This is apparent when evaluating an expression in the debugger which requires construct

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

aaron.ballman added inline comments. Comment at: unittests/Lex/PPCallbacksTest.cpp:140 + std::unique_ptr getPreprocessor(const char *SourceText, +const char *HeaderPath, This function appears to be unused?

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

Anastasia added a comment. OpenCL C is based on C99, so OpenMP isn't enabled by default. But in your tests you use `-fopenmp` to activate it. OpenCL general philosophy is that vectors are written explicitly, but it's not always very easy. In OpenCL C++ we have added an attribute hint for auto

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11348 // initialiser -if (var->getTypeSourceInfo()->getType()->isBlockPointerType() && -!var->hasInit()) { +if (var->getType()->isBlockPointerType() && !var->hasInit()) { Diag(var->getL

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

ABataev added a comment. In https://reviews.llvm.org/D46667#1094340, @Anastasia wrote: > OpenCL C is based on C99, so OpenMP isn't enabled by default. But in your > tests you use `-fopenmp` to activate it. > > OpenCL general philosophy is that vectors are written explicitly, but it's > not alwa

r331979 - This patch provides that bitfields are splitted even in case

Author: spetrovic Date: Thu May 10 05:31:12 2018 New Revision: 331979 URL: http://llvm.org/viewvc/llvm-project?rev=331979&view=rev Log: This patch provides that bitfields are splitted even in case when current field is not legal integer type. Differential Revision: https://reviews.llvm.org/D39053

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL331979: This patch provides that bitfields are splitted even in case (authored by spetrovic, committed by ). Herald added

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

ABataev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11348 // initialiser -if (var->getTypeSourceInfo()->getType()->isBlockPointerType() && -!var->hasInit()) { +if (var->getType()->isBlockPointerType() && !var->hasInit()) { Diag(var->getLoc

[PATCH] D46684: [Frontend] Don't skip function body when the return type is dependent on the template parameter.

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12645 +if (FD->isConstexpr() || FD->getReturnType()->isUndeducedType() || +FD->getReturnType()->isInstantiationDependentType()) return false; This is a lot broader than necessary;

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11348 // initialiser -if (var->getTypeSourceInfo()->getType()->isBlockPointerType() && -!var->hasInit()) { +if (var->getType()->isBlockPointerType() && !var->hasInit()) { Diag(var->getL

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:1998 +``__ATOMIC_CONSUME``, ``__ATOMIC_ACQUIRE``, ``__ATOMIC_RELEASE``, +``__ATOMIC_ACQ_REL``, or ``__ATOMIC_SEQ_CST`` following C++11 memory model semantics. + rjmccall wrote: > Thank you f

[PATCH] D44934: [analyzer] Improve the modeling of `memset()`.

MTC added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D44934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46694: [diagtool] Install diagtool

JDevlieghere created this revision. JDevlieghere added reviewers: arphaman, dexonsmith, jkorous, rsmith. Herald added a subscriber: mgorny. Although not very well known, diagtool is an incredibly convenient utility for dealing with diagnostics. I believe it's worth adding this to the install tar

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D46241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D46643: CodeGen: Emit string literal in constant address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1375 +Loc = Address(EmitCastToVoidPtrInAllocaAddrSpace(Loc.getPointer()), + Loc.getAlignment()); yaxunl wrote: > rjmccall wrote: > > I don't understand why a patch about str

[PATCH] D46700: [ThinLTO] Add testing of new summary index format to a couple CFI tests

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: eraman, inglorion, mehdi_amini. Adds testing of combined index summary entries in disassembly format to CFI tests that were already testing the bitcode format. Depends on https://reviews.llvm.org/D46699.

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

rjmccall added a comment. Can we suppress this optimization only when we can't emit an alias? An alias shouldn't degrade debugging experience, and it's good to emit less code at -O0. Repository: rC Clang https://reviews.llvm.org/D46685 ___ cfe-

[PATCH] D46540: [X86] ptwrite intrinsic

Hahnfeld added a comment. In https://reviews.llvm.org/D46540#1092620, @GBuella wrote: > In https://reviews.llvm.org/D46540#1091625, @Hahnfeld wrote: > > > Could you maybe add some short summaries to your patches? It's hard for > > non-Intel employees to guess what all these instructions do... >

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny updated this revision to Diff 146145. jdenny edited the summary of this revision. jdenny added a comment. I've implemented the suggestion to use ElaboratedType. See the last paragraph of the revised summary for details. There might be trouble for CXPrintingPolicyProperty users. That is,

[PATCH] D46694: [diagtool] Install diagtool

dexonsmith added a comment. This SGTM, but I wouldn't mind hearing from others. I wonder if this is worth a quick RFC on cfe-dev? Repository: rC Clang https://reviews.llvm.org/D46694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[libcxx] r332000 - More notes on Rapperswil issues

Author: marshall Date: Thu May 10 10:07:38 2018 New Revision: 332000 URL: http://llvm.org/viewvc/llvm-project?rev=332000&view=rev Log: More notes on Rapperswil issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewv

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

craig.topper added a comment. What effect does this have? Repository: rC Clang https://reviews.llvm.org/D46683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

mikhail.ramalho commandeered this revision. mikhail.ramalho added a reviewer: rnkovacs. mikhail.ramalho added a comment. Commandeering the PR because of GSoC. Repository: rC Clang https://reviews.llvm.org/D45920 ___ cfe-commits mailing list cfe-c

[PATCH] D45517: [analyzer] WIP: False positive refutation with Z3

mikhail.ramalho added a comment. Commandeering the PR because of GSoC. https://reviews.llvm.org/D45517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 146158. juliehockett marked 3 inline comments as done. juliehockett added a comment. Removing unused function https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallba

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

aaron.ballman added inline comments. Comment at: unittests/Lex/PPCallbacksTest.cpp:155-160 +std::unique_ptr PP = llvm::make_unique( +std::make_shared(), Diags, LangOpts, SourceMgr, +PCMCache, HeaderInfo, ModLoader, +/*IILookup =*/nullptr, +/*Ow

r332016 - [OPENMP, NVPTX] Initial support for L2 parallelism in SPMD mode.

Author: abataev Date: Thu May 10 11:32:08 2018 New Revision: 332016 URL: http://llvm.org/viewvc/llvm-project?rev=332016&view=rev Log: [OPENMP, NVPTX] Initial support for L2 parallelism in SPMD mode. Added initial support for L2 parallelism in SPMD mode. Note, though, that the orphaned parallel di

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 146175. https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallbacks.cpp lib/CodeGen/MacroPPCallbacks.h lib/Frontend/DependencyFile.cpp lib/Frontend/DependencyGrap

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D46614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332018 - Allow dllimport non-type template arguments in C++17

Author: rnk Date: Thu May 10 11:57:35 2018 New Revision: 332018 URL: http://llvm.org/viewvc/llvm-project?rev=332018&view=rev Log: Allow dllimport non-type template arguments in C++17 Summary: Fixes PR35772. Reviewers: rsmith Differential Revision: https://reviews.llvm.org/D43320 Added: cfe

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rC332018: Allow dllimport non-type template arguments in C++17 (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D43320?vs=146039&id=146178#toc Repository: rC Clang h

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

GBuella added a comment. In https://reviews.llvm.org/D46683#1094662, @craig.topper wrote: > What effect does this have? Nothing important really, I just guessed it doesn't cost. One contrived example I could come up with in 2 minutes: #include void x(char *restrict a __attribute__((ali

r332021 - Reland '[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective'

Author: juliehockett Date: Thu May 10 12:05:36 2018 New Revision: 332021 URL: http://llvm.org/viewvc/llvm-project?rev=332021&view=rev Log: Reland '[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective' This commit relands r331904. Adding a SrcMgr::CharacteristicKind parameter to t

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

This revision was automatically updated to reflect the committed changes. Closed by commit rC332021: Reland '[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective' (authored by juliehockett, committed by ). Repository: rC Clang https://reviews.llvm.org/D46614 Files: include/c

[clang-tools-extra] r332023 - Reland "[tools] Updating PPCallbacks::InclusionDirective calls"

Author: juliehockett Date: Thu May 10 12:13:14 2018 New Revision: 332023 URL: http://llvm.org/viewvc/llvm-project?rev=332023&view=rev Log: Reland "[tools] Updating PPCallbacks::InclusionDirective calls" This commit relands r331905. r331904 added SrcMgr::CharacteristicKind to the InclusionDirecti

r332028 - [Itanium] Emit type info names with external linkage.

Author: ericwf Date: Thu May 10 12:51:56 2018 New Revision: 332028 URL: http://llvm.org/viewvc/llvm-project?rev=332028&view=rev Log: [Itanium] Emit type info names with external linkage. Summary: The Itanium ABI requires that the type info for pointer-to-incomplete types to have internal linkage

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

This revision was automatically updated to reflect the committed changes. Closed by commit rC332028: [Itanium] Emit type info names with external linkage. (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D46665 Files: lib/CodeGen/ItaniumCXXABI.cpp test/Co

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

rnk added a comment. In https://reviews.llvm.org/D46520#1092681, @mstorsjo wrote: > Reverted in SVN r331858. Thanks! When one attempts to generate pre-processed source with clang and compile it with MSVC, you usually have to remove clang's internal intrinsic headers from the include search pa

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk added a comment. Thanks for the guidance! Comment at: clang/lib/AST/ExprConstant.cpp:1871-1902 if (!CheckConstantExpression(Info, DiagLoc, EltTy, Value.getArrayInitializedElt(I))) return false; } if (!Value.hasAr

[PATCH] D30035: Add const to function parameters

hiraditya abandoned this revision. hiraditya added a comment. Merged with https://reviews.llvm.org/D30268 https://reviews.llvm.org/D30035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[libcxx] r332040 - Fix PR37407 - callable traits don't correctly check complete types.

Author: ericwf Date: Thu May 10 13:59:35 2018 New Revision: 332040 URL: http://llvm.org/viewvc/llvm-project?rev=332040&view=rev Log: Fix PR37407 - callable traits don't correctly check complete types. Checking for complete types is really rather tricky when you consider the amount of specializati

r332045 - implementing Cursor.get_included_file in python bindings

Author: jbcoe Date: Thu May 10 14:39:29 2018 New Revision: 332045 URL: http://llvm.org/viewvc/llvm-project?rev=332045&view=rev Log: implementing Cursor.get_included_file in python bindings Summary: adding function: `Cursor.get_included_file` , so the C API's `clang_getIncludedFile` function is a

[PATCH] D46383: implementing Cursor.get_included_file in python bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rL332045: implementing Cursor.get_included_file in python bindings (authored by jbcoe, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46383?vs=

[PATCH] D46656: [Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to match what the middle and backends understand

rnk added a comment. Thanks! Repository: rL LLVM https://reviews.llvm.org/D46656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1414-1415 +Expr::EvalResult Result; +if (Init->EvaluateAsRValue(Result, CE.CGM.getContext()) && +!Result.hasUnacceptableSideEffect(Expr::SE_NoSideEffects)) + return (Result.Val.isInt() &

r332053 - [clang-cl] Make -f[no-]coverage-mapping available

Author: rnk Date: Thu May 10 15:24:00 2018 New Revision: 332053 URL: http://llvm.org/viewvc/llvm-project?rev=332053&view=rev Log: [clang-cl] Make -f[no-]coverage-mapping available Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL: ht

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

rsmith added inline comments. Comment at: include/clang/AST/ExprCXX.h:4218-4226 + struct ComparisonBits { +/// Whether this rewritten comparison expression has reverse-order +/// parameters. +unsigned IsSynthesized : 1; + }; + + union ExtraRewrittenBits { -

[libcxx] r332066 - Fix failing test due to incorrect use of noexcept

Author: ericwf Date: Thu May 10 17:33:20 2018 New Revision: 332066 URL: http://llvm.org/viewvc/llvm-project?rev=332066&view=rev Log: Fix failing test due to incorrect use of noexcept Modified: libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.other/result_of11.pass.cpp Modified: l

r332070 - Permit -fxray-instrument for NetBSD/amd64

Author: kamil Date: Thu May 10 17:58:55 2018 New Revision: 332070 URL: http://llvm.org/viewvc/llvm-project?rev=332070&view=rev Log: Permit -fxray-instrument for NetBSD/amd64 Summary: Use the same branch as FreeBSD and OpenBSD. Sponsored by Reviewers: joerg, dberris, vitalybuka Reviewed By: vi

[PATCH] D46737: Permit -fxray-instrument for NetBSD/amd64

This revision was automatically updated to reflect the committed changes. Closed by commit rC332070: Permit -fxray-instrument for NetBSD/amd64 (authored by kamil, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46737 Files: lib/Driver/X

[PATCH] D46721: Support XRay in the NetBSD driver

This revision was automatically updated to reflect the committed changes. Closed by commit rC332071: Support XRay in the NetBSD driver (authored by kamil, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46721 Files: lib/Driver/ToolChain

r332071 - Support XRay in the NetBSD driver

Author: kamil Date: Thu May 10 18:00:38 2018 New Revision: 332071 URL: http://llvm.org/viewvc/llvm-project?rev=332071&view=rev Log: Support XRay in the NetBSD driver Summary: While there, perform a small cleanup, reducing delta with drivers for other OSes. Sponsored by Reviewers: joerg, vitaly

r332074 - Don't propagate dllimport to base class template static data members

Author: rnk Date: Thu May 10 18:26:11 2018 New Revision: 332074 URL: http://llvm.org/viewvc/llvm-project?rev=332074&view=rev Log: Don't propagate dllimport to base class template static data members MSVC doesn't, so we shouldn't. Fixes PR37232. Added: cfe/trunk/test/CodeGenCXX/dllimport-temp

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

rsmith added inline comments. Comment at: include/clang/AST/Type.h:4852-4855 +/// \brief Represents a type occurrence that either (1) refers to the type +/// using an elaborated type keyword, e.g., struct S, (2) refers to the type +/// via a qualified name, e.g., N::M::type, (3)

r332076 - Improve diagnostics and error recovery for template name lookup.

Author: rsmith Date: Thu May 10 19:43:08 2018 New Revision: 332076 URL: http://llvm.org/viewvc/llvm-project?rev=332076&view=rev Log: Improve diagnostics and error recovery for template name lookup. For 'x::template y', consistently give a "no member named 'y' in 'x'" diagnostic if there is no suc

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF added inline comments. Comment at: include/clang/AST/ExprCXX.h:4218-4226 + struct ComparisonBits { +/// Whether this rewritten comparison expression has reverse-order +/// parameters. +unsigned IsSynthesized : 1; + }; + + union ExtraRewrittenBits { -

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF updated this revision to Diff 146274. EricWF marked 13 inline comments as done. EricWF added a comment. - Change `CXXRewrittenExpr` to be a non-general wrapper only for rewritten comparison operators. - Start fixing and improving overload resolution diagnostics. https://reviews.llvm.org/

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF marked 2 inline comments as done. EricWF added inline comments. Comment at: lib/Sema/SemaOverload.cpp:12543-12547 + Expr *Original = new (S.Context) + BinaryOperator(OpaqueValueExpr::Create(S.Context, Args[0]), + OpaqueValueExpr::Create(S.Context,

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF marked 11 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/Stmt.h:254 + +unsigned Kind : 1; + }; rsmith wrote: > I don't think you need this either. Does keeping it help save bits in `CXXRewrittenOperatorExpr`? ht

[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

EricWF created this revision. EricWF added reviewers: rsmith, rjmccall, aaron.ballman. Herald added a reviewer: a.sidorin. There are cases where the same string or select is repeated verbatim in a lot of diagnostics. This can be a pain to maintain and update. However, Tablegen provides no way st

[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

EricWF updated this revision to Diff 146279. EricWF added a comment. Fix copy paste error. https://reviews.llvm.org/D46740 Files: include/clang/Basic/Diagnostic.td include/clang/Basic/DiagnosticSemaKinds.td utils/TableGen/ClangDiagnosticsEmitter.cpp Index: utils/TableGen/ClangDiagnostics

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF updated this revision to Diff 146280. EricWF added a comment. Do better english in diagnostics. https://reviews.llvm.org/D45680 Files: include/clang/AST/ComparisonCategories.h include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/c

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

sepavloff added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1414-1415 +Expr::EvalResult Result; +if (Init->EvaluateAsRValue(Result, CE.CGM.getContext()) && +!Result.hasUnacceptableSideEffect(Expr::SE_NoSideEffects)) + return (Result.Val.isInt(

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF updated this revision to Diff 146281. EricWF added a comment. Fix fetching the correct source location information in `CXXRewrittenOperatorExpr`. https://reviews.llvm.org/D45680 Files: include/clang/AST/ComparisonCategories.h include/clang/AST/Expr.h include/clang/AST/ExprCXX.h

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D45680: [C++2a] Implement operator<=> Part 2: Operator Rewritting and Overload Resolution.

EricWF updated this revision to Diff 146285. EricWF added a comment. - Update tests and improve diagnostics. Still more work to be done here though. https://reviews.llvm.org/D45680 Files: include/clang/AST/ComparisonCategories.h include/clang/AST/Expr.h include/clang/AST/ExprCXX.h inclu

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

craig.topper created this revision. craig.topper added reviewers: RKSimon, GBuella, tkrupa. As long as the destination type is a 256 or 128 bit vector we can use __builtin_convertvector to directly generate trunc IR instruction which will be handled natively by the backend. Repository: rC Cl