Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathSeparator);
+LibraryPaths.push_back(
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: ioeric, jkorous-apple, klimek.
DeclrationAndMacrosFinder will find some declarations (not macro!) that are
referened inside the macro somehow, isSearchedLocation() is not sufficient, we
don't know wheth
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:101
json::obj{
-{"textDocumentSync", 1},
+{"textDocumentSync", 2},
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the fix!
https://reviews.llvm.org/D44217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: ioeric, jkorous-apple, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44294
Files:
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
==
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:557
// 64-bit unsigned integer.
if (Version < LastReportedDiagsVersion)
return;
When you'll try remove the `DraftMgr`, this piece of code will be hard to
refactor because i
zinovy.nis created this revision.
zinovy.nis added reviewers: klimek, alexfh.
zinovy.nis added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
Warns if one calls grand-..parent's virtual method in child's virtual method
instead of parent's. Can automatically fix such cases by ret
ilya-biryukov added inline comments.
Comment at: unittests/clangd/XRefsTests.cpp:587
- const char *HeaderContents = R"cpp([[]]int a;)cpp";
+ const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_
+ #define TEST_H_
I would g
lebedev.ri added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D43162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D42684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Fri Mar 9 02:47:14 2018
New Revision: 327111
URL: http://llvm.org/viewvc/llvm-project?rev=327111&view=rev
Log:
[clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith
Patch by Niko Weh!
Reviewers: hokein
Subscribers: klimek, cfe-commits, ioeric, ilya-b
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327111: [clang-tidy] Add check: replace string::find(...)
== 0 with absl::StartsWith (authored by hokein, committed by ).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43847
Files:
hokein updated this revision to Diff 137712.
hokein marked an inline comment as done.
hokein added a comment.
Use #program once
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44294
Files:
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
===
hokein added inline comments.
Comment at: unittests/clangd/XRefsTests.cpp:587
- const char *HeaderContents = R"cpp([[]]int a;)cpp";
+ const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_
+ #define TEST_H_
ilya-biryukov wr
lebedev.ri added a comment.
Might have been better to not start landing until the all differentials are
understood/accepted, but i understand that it is not really up to me to decide.
Let's hope nothing in the next differentials will require changes to this
initial code :)
Co
hokein updated this revision to Diff 137720.
hokein marked 7 inline comments as done.
hokein added a comment.
Herald added a subscriber: mgorny.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44247
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CMakeLi
hokein added a comment.
Thanks for the comments!
Comment at: clangd/SourceCode.cpp:55
+ const auto& SM = D->getASTContext().getSourceManager();
+ SourceLocation SpellingLoc = SM.getSpellingLoc(D->getLocation());
+ if (D->getLocation().isMacroID()) {
sammccal
Author: sammccall
Date: Fri Mar 9 03:47:37 2018
New Revision: 327115
URL: http://llvm.org/viewvc/llvm-project?rev=327115&view=rev
Log:
[clang-tidy] fix header guard
Modified:
clang-tools-extra/trunk/clang-tidy/abseil/StringFindStartswithCheck.h
Modified: clang-tools-extra/trunk/clang-tidy/a
This patch exposes an interface to libclang's clang_getOverriddenCursors
and clang_disposeOverriddenCursors functions to the python api.
The patch is adapted from this stack overflow response but cleaned up to
fit within the existing cindex.py codebase
https://stackoverflow.com/questions/35962473/
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
These have different USRs than the underlying entity, but are not typically
interesting in their own right and can be numerous (e.g. generated traits).
sammccall updated this revision to Diff 137729.
sammccall added a comment.
merge matchers
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44298
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: unittests/clangd/SymbolCollectorTests.cp
sammccall updated this revision to Diff 137731.
sammccall added a comment.
verify that we don't emit extra symbols in other template-related cases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44298
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTe
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: unittests/clangd/SymbolCollectorTests.cpp:200
+ UnorderedElementsAreArray(
+ {QName("Foo"), QName("f1"), QName("f2"), QName("KInt"),
QName("Tm
Author: sammccall
Date: Fri Mar 9 05:25:29 2018
New Revision: 327127
URL: http://llvm.org/viewvc/llvm-project?rev=327127&view=rev
Log:
[clangd] Don't index template specializations.
Summary:
These have different USRs than the underlying entity, but are not typically
interesting in their own righ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327127: [clangd] Don't index template specializations.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44298?vs=137731
aaron.ballman added a comment.
In https://reviews.llvm.org/D44231#1032011, @pfultz2 wrote:
> > If the return type of foo() is changed, then the use for s1 will be
> > automatically updated
>
> But usually you write it as:
>
> using foo_return = uint16_t;
> foo_return foo();
> ...
> size_
Author: hokein
Date: Fri Mar 9 06:00:34 2018
New Revision: 327129
URL: http://llvm.org/viewvc/llvm-project?rev=327129&view=rev
Log:
[clangd] Use identifier range as the definition range.
Summary: This also matches the range in symbol index.
Reviewers: sammccall
Subscribers: klimek, ilya-biryuk
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327129: [clangd] Use identifier range as the definition
range. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44247?vs=137720&id=137736#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327129: [clangd] Use identifier range as the definition
range. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44247?vs=1
Author: ioeric
Date: Fri Mar 9 06:06:43 2018
New Revision: 327130
URL: http://llvm.org/viewvc/llvm-project?rev=327130&view=rev
Log:
[clangd-vscode] Add package-lock.json to .gitignore
Modified:
clang-tools-extra/trunk/clangd/clients/clangd-vscode/.gitignore
Modified: clang-tools-extra/trunk
Author: hokein
Date: Fri Mar 9 06:16:46 2018
New Revision: 327131
URL: http://llvm.org/viewvc/llvm-project?rev=327131&view=rev
Log:
[clangd] Fix failing lit test.
This test is missed in r327129.
Modified:
clang-tools-extra/trunk/test/clangd/xrefs.test
Modified: clang-tools-extra/trunk/test
ilya-biryukov created this revision.
ilya-biryukov added reviewers: bkramer, sammccall, ioeric, hokein.
The relevant failing assertion message is:
../tools/clang/lib/Sema/SemaInit.cpp:8411: PerformCopyInitialization():
Assertion `InitE && "No initialization expression?"' failed.
See the added te
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaOverload.cpp:6251
+ : P->getDefaultArg();
+ if (!DefArg)
+return false;
comment this
ilya-biryukov updated this revision to Diff 137743.
ilya-biryukov added a comment.
- Added a comment
Repository:
rC Clang
https://reviews.llvm.org/D44300
Files:
lib/Sema/SemaOverload.cpp
test/CodeCompletion/enable-if-attr-crash.cpp
Index: test/CodeCompletion/enable-if-attr-crash.cpp
==
Author: ibiryukov
Date: Fri Mar 9 06:43:29 2018
New Revision: 327134
URL: http://llvm.org/viewvc/llvm-project?rev=327134&view=rev
Log:
[SemaOverload] Fixed crash on code completion
Summary:
The relevant failing assertion message is:
../tools/clang/lib/Sema/SemaInit.cpp:8411: PerformCopyInitializ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327134: [SemaOverload] Fixed crash on code completion
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44300
Files:
cfe/
Looks like this broke the Windows bot:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9365 Can you
fix or revert, please?
On Fri, Mar 9, 2018 at 2:06 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Mar 8 23:06:42 2018
> Ne
Hi,
Any downstream users should be able to apply this, the corresponding clang
patch (r325651) and the LLD patch (r325657, and r325713) cleanly to the
release sources of LLVM 6.0, should they require it.
Thanks,
Simon
Author: sdardis
Date: Tue Feb 20 16:06:53 2018
New Revision: 325653
URL: http
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:592
+Twine("lib") + CLANG_LIBDIR_SUFFIX);
+LibraryPaths.emplace_back(DefaultLibPath.c_str());
+
Do you still need `.c_str()` here?
Comment at: test/Driver/ope
gtbercea marked an inline comment as done.
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathS
Author: abataev
Date: Fri Mar 9 07:20:30 2018
New Revision: 327136
URL: http://llvm.org/viewvc/llvm-project?rev=327136&view=rev
Log:
[OPENMP] Fix the address of the original variable in task reductions.
If initialization of the task reductions requires pointer to original
variable, which is stor
grokos added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
-
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Potential use case: argument go-to-definition result with symbol
information (e.g. function definition in cc file) that might not be in the AST.
Reposito
gtbercea updated this revision to Diff 137754.
gtbercea added a comment.
Change test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/lib/libomptarget-nvptx-sm_60.bc
test/Driver
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:592
+Twine("lib") + CLANG_LIBDIR_SUFFIX);
+LibraryPaths.emplace_back(DefaultLibPath.c_str());
+
ABataev wrote:
> Do you still need `.c_str()` here?
Doesn't compile without it b
gtbercea updated this revision to Diff 137755.
gtbercea added a comment.
Revert to c_str().
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/lib/libomptarget-nvptx-sm_60.bc
test/
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
pfultz2 added a comment.
> Again, that only works for C++ and not C.
Typedef has always worked in C.
> Did it report any true positives that would need correcting?
Not for LLVM, but it has in other projects like I mentioned.
> Can you check some other large repos (both C++ and C), such as: Qt,
simark marked 2 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:101
json::obj{
-{"textDocumentSync", 1},
+{"textDocumentSync", 2},
{"documentFormattingProvider", true},
il
Apoloiges all, I spoke too soon. Some tests fail due to mir changes, and one
which a slight different version of the memset intrinsic.
Attached is a patch which resolves the failures.
Thanks,
Simon
From: llvm-commits [llvm-commits-boun...@lists.llvm.org]
Hahnfeld added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
simark marked 2 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdServer.h:159
/// constructor will receive onDiagnosticsReady callback.
void addDocument(PathRef File, StringRef Contents,
+ WantDiagnostics WantDiags = WantDiag
ioeric added inline comments.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:188
-bool mergeAndDeduplicate(const TUReplacements &TUs,
- FileToReplacementsMap &GroupedReplacements,
- clang::SourceManager &SM
gtbercea updated this revision to Diff 137769.
gtbercea added a comment.
Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/lib/libomptarget-nvptx-sm_20.bc
test/Driver/op
gtbercea added inline comments.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp
-fopenmp-targets=nvptx64-nvidia-cuda \
Eric,
Any chance you could have one more look at this and let me know if the
patch is acceptable?
Thanks,
Mike
On Mon, Mar 5, 2018 at 4:16 PM, Mike Edwards via Phabricator <
revi...@reviews.llvm.org> wrote:
> sqlbyme updated this revision to Diff 137104.
> sqlbyme added a comment.
>
> I copied w
aaron.ballman added a comment.
In https://reviews.llvm.org/D44231#1032782, @pfultz2 wrote:
> > Again, that only works for C++ and not C.
>
> Typedef has always worked in C.
This is true.
I think what I'm struggling to say is: I don't think this is a common pattern
in either C or C++. It's als
malcolm.parsons added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:152
+Member->getQualifierLoc().getSourceRange(),
+GetNameAsString(*(Parents.front())) + "::");
+ }
What does this do for templated parent classes?
paulsemel added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1252
+ Types[getContext().getPointerType(getContext().CharTy)] = "%s";
+ GENERATE_TYPE_QUALIFIERS_NO_RESTRICT(getContext().CharTy, "%s")
+}
aaron.ballman wrote:
> paulsemel wrote
paulsemel updated this revision to Diff 137775.
paulsemel added a comment.
Added recursive type pretty-printing as suggested by Aaron.
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
Index
zinovy.nis updated this revision to Diff 137783.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/ParentVirtualCallCheck.cpp
clang-tidy/bugprone/ParentVirtualCallC
zinovy.nis updated this revision to Diff 137781.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/ParentVirtualCallCheck.cpp
clang-tidy/bugprone/ParentVirtualCallC
zinovy.nis added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:152
+Member->getQualifierLoc().getSourceRange(),
+GetNameAsString(*(Parents.front())) + "::");
+ }
malcolm.parsons wrote:
> What does this do for templat
zinovy.nis updated this revision to Diff 137787.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/ParentVirtualCallCheck.cpp
clang-tidy/bugprone/ParentVirtualCallC
sammccall created this revision.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov,
klimek.
This is an important ranking signal.
It's off for the dynamic index for now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44314
Files:
clangd/global-symbol
sammccall created this revision.
sammccall added reviewers: ioeric, hokein.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
This is an important ranking signal.
It's off for the dynamic index for now. Correspondingly, tell the index
infrastructure only to report declar
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:26
+
+bool IsParentOf(const CXXRecordDecl *Parent, const CXXRecordDecl *ThisClass) {
+ assert(Parent);
Please make this function static and remove anonymous namespac
dcoughlin added a comment.
This looks good. Some minor post-commit review inline.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:615
+
+def GCDAsyncSemaphoreChecker : Checker<"GCDAsyncSemaphore">,
+ HelpText<"Checker for performance anti-pattern when using semap
malcolm.parsons added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:152
+Member->getQualifierLoc().getSourceRange(),
+GetNameAsString(*(Parents.front())) + "::");
+ }
zinovy.nis wrote:
> malcolm.parsons wrote:
> > Wh
vsapsai updated this revision to Diff 137801.
vsapsai added a comment.
- Claim the definition data more eagerly.
Not sure that added "different" in the existing comment is actually useful.
It makes sense to me but don't know about others.
https://reviews.llvm.org/D43494
Files:
clang/lib/Seri
lebedev.ri added a comment.
Herald added subscribers: llvm-commits, xazax.hun, mgorny, klimek.
Any further thoughts here?
I was slightly bitten by this recently, and i though that it already existed as
a clang-tidy check (:
Repository:
rL LLVM
https://reviews.llvm.org/D16008
_
george.karpenkov added a comment.
> we often run out of inlining stack depth limit
Can we consider increasing that limit? I'd much rather have a limit on maximum
path *length* (which we currently don't have), as longer paths are more likely
to be false positives.
On the other hand, I don't see
Quuxplusone added a comment.
@rtrieu ping?
Repository:
rC Clang
https://reviews.llvm.org/D43898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenis
Date: Fri Mar 9 11:35:16 2018
New Revision: 327165
URL: http://llvm.org/viewvc/llvm-project?rev=327165&view=rev
Log:
Don't use -pie in relocatable link.
Summary:
Android, in particular, got PIE enabled by default in r316606. It resulted in
relocatable links passing both -r and -p
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327165: Don't use -pie in relocatable link. (authored
by eugenis, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44229?vs=137493&id=137809#toc
Repository:
rC Clang
https://review
Author: pcc
Date: Fri Mar 9 11:37:28 2018
New Revision: 327166
URL: http://llvm.org/viewvc/llvm-project?rev=327166&view=rev
Log:
Fix Clang test case.
Modified:
cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
URL:
h
rsmith added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1789
+ // set fake one.
+ if (!Canon->DefinitionData) {
+Canon->DefinitionData = DD;
No braces around single-line `if` bodies, please.
Comment at: clang/l
pfultz2 added a comment.
> I don't have a script for it. I've used "bear" with at least some of those
> projects because they use makefiles rather than cmake
> (https://github.com/rizsotto/Bear). I'm not tied to those projects
> specifically, either, so if you have a different corpus you'd pref
thegameg added a comment.
Thanks for working on this! Few remarks in the comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:934
+static Value *dumpRecord(CodeGenFunction &CGF, QualType RType,
+ Value*& RecordPtr, CharUnits Align,
`llvm::V
pfultz2 updated this revision to Diff 137822.
https://reviews.llvm.org/D44231
Files:
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
docs/clang-tidy/checks/misc-sizeof-expression.rst
test/clang-tidy/misc-sizeof-expression.cpp
Index: test/clang-tidy/misc-
dfukalov added a comment.
ping...
Repository:
rC Clang
https://reviews.llvm.org/D43281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:12
+
+#include
+#include
Please run Clang-format and remove empty line between headers.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
_
arsenm added a comment.
In https://reviews.llvm.org/D43281#1023962, @dfukalov wrote:
> The problem is that if set addrspace "2" in description string,
> CanT.getAddressSpace() returns target addrspace value "11" (shifted in the
> enum) and compares it with input LangAS addrspace ("2", "opencl_l
compnerd created this revision.
compnerd added a reviewer: gottesmm.
Herald added a subscriber: cfe-commits.
compnerd added a reviewer: ahatanak.
compnerd added subscribers: rnk, majnemer.
In the case that the CallInst that is being moved has an associated
operand bundle which is a funclet, the mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327178: XFAIL: libcpp-no-deduction-guides in
libcxx/test/std/strings/basic. (authored by sqlbyme, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://revie
Author: sqlbyme
Date: Fri Mar 9 14:13:12 2018
New Revision: 327178
URL: http://llvm.org/viewvc/llvm-project?rev=327178&view=rev
Log:
XFAIL: libcpp-no-deduction-guides in
libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
Summary: Refactor the previous version method
majnemer added inline comments.
Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:701
+
+ if (auto *CleanupPad = dyn_cast(BB.getFirstNonPHI()))
+OpBundles.emplace_back("funclet", CleanupPad);
What if the cleanuppad was introduced in a block which branched t
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/include/CMakeLists.txt:19
+DEPENDS ${LIBCXX_BINARY_DIR}/__generated_config)
+ set(generated_config_deps generate_config_header)
+endif()
-
phosek created this revision.
phosek added a reviewer: chandlerc.
Herald added subscribers: cfe-commits, mgorny.
This CMake flag allows setting the default value for the
-f[no]-experimental-new-pass-manager flag.
Repository:
rC Clang
https://reviews.llvm.org/D44330
Files:
clang/CMakeLists
phosek added inline comments.
Comment at: libcxx/include/CMakeLists.txt:19
+DEPENDS ${LIBCXX_BINARY_DIR}/__generated_config)
+ set(generated_config_deps generate_config_header)
+endif()
compnerd wrote:
> Where is `generated_config_deps` used?
Line 69
Repos
Author: compnerd
Date: Fri Mar 9 15:00:29 2018
New Revision: 327183
URL: http://llvm.org/viewvc/llvm-project?rev=327183&view=rev
Log:
test: repair windows build after SVN r327105
Thanks to Nico Weber for pointing out the failure. Add an explicit
target for the test.
Modified:
cfe/trunk/tes
Author: morehouse
Date: Fri Mar 9 15:02:22 2018
New Revision: 327184
URL: http://llvm.org/viewvc/llvm-project?rev=327184&view=rev
Log:
[clangd-fuzzer] Update ClangdLSPServer constructor call.
Build was broken by r326719.
Modified:
clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
Modi
Author: juliehockett
Date: Fri Mar 9 15:26:56 2018
New Revision: 327186
URL: http://llvm.org/viewvc/llvm-project?rev=327186&view=rev
Log:
[clang-tidy] Update run-clang-tidy.py with config arg
Updating the run-clang-tidy.py script to allow specification of the
config argument to the clang-tidy in
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rCTE327186: [clang-tidy] Update run-clang-tidy.py with config
arg (authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.or
Author: az
Date: Fri Mar 9 15:39:34 2018
New Revision: 327189
URL: http://llvm.org/viewvc/llvm-project?rev=327189&view=rev
Log:
[ARM] Add ARMv8.2-A FP16 vector intrinsic
Add the fp16 neon vector intrinsic for ARM as described in the ARM ACLE
document.
Reviews in https://reviews.llvm.org/D43650
vsapsai added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1811
if (Update || Canon != D) {
Canon->DefinitionData = D->DefinitionData;
Reader.PendingDefinitions.insert(D);
This store seems to be dead too. Need to spend more
compnerd updated this revision to Diff 137867.
compnerd added a comment.
Use the BB colorizer to detect the token. Fortunately, there is no BB
removal/splitting happening here, so there is no state to maintain.
Repository:
rL LLVM
https://reviews.llvm.org/D44327
Files:
lib/Transforms/Obj
1 - 100 of 120 matches
Mail list logo
