zinovy.nis added inline comments.
================ Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:152 + Member->getQualifierLoc().getSourceRange(), + GetNameAsString(*(Parents.front())) + "::"); + } ---------------- malcolm.parsons wrote: > What does this do for templated parent classes? Please see my last test case in updated revision. ================ Comment at: docs/clang-tidy/checks/bugprone-parent-virtual-call.rst:6 + +FIXME: Describe what patterns does the check detect and why. Give examples. ---------------- malcolm.parsons wrote: > FIXME. Oops. Thanks! ================ Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:102 + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'AA::virt_1' is a grand-parent's method, not parent's. Did you mean 'BB_1' or 'BB_2'? [bugprone-parent-virtual-call] + // No fix available due to multiple choise of parent class. +}; ---------------- malcolm.parsons wrote: > typo: choice Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
