[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 137244. juliehockett added a comment. Adding hashing to reduce the size of USRs and updating tests. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-doc

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 137245. juliehockett marked 8 inline comments as done. juliehockett added a comment. Adding in support for mapper tests and addressing comments. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-do

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:19 + +void ClangDocBitcodeReader::storeData(llvm::SmallString<4> &Field, + llvm::StringRef Blob) { lebedev.ri wrote: > I think all these `SmallString`

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Nice! Some further notes based on the SHA1 nature. Comment at: clang-doc/BitcodeWriter.cpp:74 + AbbrevGen(Abbrev, +{// 0. Fixed-size integer (ref type) + llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::Fixed, Th

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( alexfh wrote: > I wonder whether it's better to use lit for the tests that require formatting > tha

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

niko updated this revision to Diff 137249. niko marked 4 inline comments as done. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847 Files: clang-tidy/CMakeLists.txt clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StringFindStar

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

niko added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:15 + +#include + hokein wrote: > What is this header used for? Sorry, ended up in the wrong file, moved to StringFindStartswithCheck.cpp. Repository: rCTE Clang Tools Extra https

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak updated this revision to Diff 137250. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D39562 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp lib/Co

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak added inline comments. Comment at: lib/Sema/SemaPseudoObject.cpp:432 + if (capturedRHS->getType()->getAsCXXRecordDecl() && capturedRHS->isRValue()) +capturedRHS->setIsUnique(); + rjmccall wrote: > I think you can unconditionally set this here, actua

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay created this revision. MaskRay added a reviewer: alexfh. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clan

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137256. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.txt

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

rjmccall added inline comments. Comment at: include/clang/AST/Expr.h:875 + /// is set to true. + bool IsUnique = false; + rjmccall wrote: > Humor me and pack this in the bitfields in Stmt, please. :) Thanks! Comment at: lib/CodeGen/CGExpr.cpp

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak added a comment. Sorry, this patch is not ready yet. There are several regression tests that are failing because of the assert in setIsUnique. https://reviews.llvm.org/D39562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added a comment. In https://reviews.llvm.org/D42983#1028241, @alexfh wrote: > In https://reviews.llvm.org/D42983#1028093, @MaskRay wrote: > > > In https://reviews.llvm.org/D42983#1025179, @alexfh wrote: > > > > > A late comment here: should this check start a new "portability" module? >

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

This revision was automatically updated to reflect the committed changes. Closed by commit rL326836: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

r326836 - [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

Author: mgorny Date: Tue Mar 6 13:26:28 2018 New Revision: 326836 URL: http://llvm.org/viewvc/llvm-project?rev=326836&view=rev Log: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars Provide two new CMake cache variables -- CLANG_DEFAULT_STD_C and CLANG_DEFAULT_STD_CXX -- that can

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

djasper added a comment. Right. So the difference is that for blocks, there is always a "(" after the "(^.)". That should be easy to parse, no? Repository: rC Clang https://reviews.llvm.org/D43906 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137259. MaskRay added a comment. index.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeList

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137260. MaskRay added a comment. comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137262. MaskRay added a comment. . Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.txt

[PATCH] D44174: do not register matcher for objc-only checks when analyzing non-objc sources to save resources

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44174 Files: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp clang-tidy/objc/AvoidNSErrorInitCheck.cpp clang-tidy/objc/ForbiddenSubclassingCheck

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 137272. juliehockett marked 6 inline comments as done. juliehockett added a comment. Updating based on parent changes https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Representation.h clang-doc/generators/CMakeLists.txt

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek added a comment. Ping again? Repository: rCXX libc++ https://reviews.llvm.org/D43797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

lebedev.ri added a comment. I should have seen in during the initial review, but better now than never, right? :) Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternativ

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137275. MaskRay added a comment. std::string -> llvm::SmallString Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tid

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternative, otherwise point it out it ---

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl updated this revision to Diff 137279. yaxunl added a comment. Clean up CallArg::getRValue() so that it always return independent value. https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCall.h lib/CodeGen/CGClass.cpp lib/CodeGe

r326844 - [CodeGen] Don't emit lifetime.end without lifetime.start

Author: gbiv Date: Tue Mar 6 15:07:00 2018 New Revision: 326844 URL: http://llvm.org/viewvc/llvm-project?rev=326844&view=rev Log: [CodeGen] Don't emit lifetime.end without lifetime.start EmitLifetimeStart returns a non-null `size` pointer if it actually emits a lifetime.start. Later in this func

r326845 - Fix a typo from r326844; NFC

Author: gbiv Date: Tue Mar 6 15:09:01 2018 New Revision: 326845 URL: http://llvm.org/viewvc/llvm-project?rev=326845&view=rev Log: Fix a typo from r326844; NFC Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c URL: http://llvm.org/viewvc/l

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

vsk requested changes to this revision. vsk added inline comments. This revision now requires changes to proceed. Comment at: test/Driver/fsanitize.c:392 +// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 | FileCheck --check-prefix=CHECK_UBSAN-OPENBSD +// C

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137284. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,12 @@ // RUN

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added inline comments. Comment at: test/Driver/fsanitize.c:392 +// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 | FileCheck --check-prefix=CHECK_UBSAN-OPENBSD +// CHECK-UBSAN-OPENBSD: -fsanitize=undefined + vsk wrote: > Why does

r326856 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 6 16:17:48 2018 New Revision: 326856 URL: http://llvm.org/viewvc/llvm-project?rev=326856&view=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/StaticAnaly

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

Eugene.Zelenko added a comment. Please mention new module in Release Notes. I think new modules should be before new checks there. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm provided the bots are happy. https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137293. MaskRay marked 2 inline comments as done. MaskRay added a comment. Mention new module `portability` in docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New module `portability` and new `portability-simd-intrinsics + `_ check Module and check from it sh

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

vsapsai updated this revision to Diff 137299. vsapsai added a comment. - Don't set to-be-deserialized definition data if there is another decl with definition data. https://reviews.llvm.org/D43494 Files: clang/lib/Serialization/ASTReaderDecl.cpp clang/test/Modules/Inputs/self-referencing-l

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1795 CXXRecordDecl *Canon = D->getCanonicalDecl(); - if (Canon->DefinitionData) { + if (Canon->DefinitionData && Canon->DefinitionData != DD) { MergeDefinitionData(Canon, std::move(*DD)

r326860 - [Driver] Automatically disable incompatible default sanitizers

Author: phosek Date: Tue Mar 6 17:27:03 2018 New Revision: 326860 URL: http://llvm.org/viewvc/llvm-project?rev=326860&view=rev Log: [Driver] Automatically disable incompatible default sanitizers When a sanitizer incompatible with one of the default sanitizers is explicitly enabled, automatically

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rC326860: [Driver] Automatically disable incompatible default sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44064?vs=136893&id=137301#toc Repository:

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL326860: [Driver] Automatically disable incompatible default sanitizers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44

r326862 - Revert r326602, it caused PR36620.

Author: nico Date: Tue Mar 6 18:22:41 2018 New Revision: 326862 URL: http://llvm.org/viewvc/llvm-project?rev=326862&view=rev Log: Revert r326602, it caused PR36620. Removed: cfe/trunk/test/Sema/attr-ownership.cpp Modified: cfe/trunk/include/clang/AST/Attr.h cfe/trunk/include/clang/Ba

Re: r326860 - [Driver] Automatically disable incompatible default sanitizers

Test? (Also below) On Tue, Mar 6, 2018 at 8:27 PM, Petr Hosek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: phosek > Date: Tue Mar 6 17:27:03 2018 > New Revision: 326860 > > URL: http://llvm.org/viewvc/llvm-project?rev=326860&view=rev > Log: > [Driver] Automatically disable inco

r326865 - [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr

Author: george.karpenkov Date: Tue Mar 6 18:32:44 2018 New Revision: 326865 URL: http://llvm.org/viewvc/llvm-project?rev=326865&view=rev Log: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr Currently hasArgument works with both ObjC messages and function calls, but not hasAnyArgument. This

[PATCH] D44169: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC326865: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D44

[PATCH] D44169: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL326865: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

phosek updated this revision to Diff 137312. Repository: rC Clang https://reviews.llvm.org/D44065 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Fuchsia.h clang/test/Driver/fuchsia.c Index: clang/test/Driver/fuchsia.c

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC326867: [Driver] Enable SafeStack by default on Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44065?vs=137312&id=137314#toc Repository: rC Clang htt

r326867 - [Driver] Enable SafeStack by default on Fuchsia

Author: phosek Date: Tue Mar 6 18:49:58 2018 New Revision: 326867 URL: http://llvm.org/viewvc/llvm-project?rev=326867&view=rev Log: [Driver] Enable SafeStack by default on Fuchsia This is already used throughout the entire system, so make it a default. Differential Revision: https://reviews.llv

r326868 - [analyzer] Fix the checker for the performance anti-pattern to accept messages

Author: george.karpenkov Date: Tue Mar 6 18:54:01 2018 New Revision: 326868 URL: http://llvm.org/viewvc/llvm-project?rev=326868&view=rev Log: [analyzer] Fix the checker for the performance anti-pattern to accept messages send to ObjC objects. Differential Revision: https://reviews.llvm.org/D441

[PATCH] D44170: [analyzer] Update GCDAsyncSemaphoreChecker to match messages send to ObjC objects

This revision was automatically updated to reflect the committed changes. Closed by commit rC326868: [analyzer] Fix the checker for the performance anti-pattern to accept messages (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https:

r326869 - Revert 326766 too, after r326862 the test fails and I don't know how to fix.

Author: nico Date: Tue Mar 6 19:00:25 2018 New Revision: 326869 URL: http://llvm.org/viewvc/llvm-project?rev=326869&view=rev Log: Revert 326766 too, after r326862 the test fails and I don't know how to fix. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/test/CodeGenCXX/alloc-size

Re: r326766 - [ExprConstant] Look through ExprWithCleanups for `allocsize`

Apologies, I had to revert the change that touched alloc-size.cpp before this change in r326862. After that revert, your new test here failed, and since I didn't understand how to make it passed, I reverted your change in 326869 too. It should hopefully be easy for you to reland it. On Tue, Mar 6,

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton updated this revision to Diff 137319. benhamilton added a comment. - Simplify logic and assume we have an ObjC block whenever we see rparen at the end of `(^...)(`. Repository: rC Clang https://reviews.llvm.org/D43906 Files: lib/Format/TokenAnnotator.cpp unittests/Format/For

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton added a comment. > Right. So the difference is that for blocks, there is always a "(" after the > "(^.)". That should be easy to parse, no? Yep, I've updated this diff to implement that as you recommended. I just had to handle nested parens (I couldn't find an existing way to de

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton updated this revision to Diff 137320. benhamilton added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D43906 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTest

Re: [libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

Hi Erik, before this change, ___Z10blocksNRVOv_block_invoke demangled to 'invocation function for block in blocksNRVO()', now it's no longer demangled. Was that an intentional change? On Tue, Mar 6, 2018 at 9:21 AM, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: e

Re: [PATCH] D43805: Optionally use nameless IR types

Any feedback? Thanks, --Serge 2018-02-28 0:02 GMT+07:00 Serge Pavlov via Phabricator < revi...@reviews.llvm.org>: > sepavloff marked an inline comment as done. > sepavloff added inline comments. > > > > Comment at: include/clang/Driver/Options.td:1735 > + HelpText<"Whether to u

[PATCH] D43805: Optionally use nameless IR types

pcc added a comment. Why is this a driver flag? This seems like it ought to be a cc1-only flag to me. Repository: rC Clang https://reviews.llvm.org/D43805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D43805: Optionally use nameless IR types

rsmith added inline comments. Comment at: include/clang/Driver/Options.td:644 + HelpText<"Whether to use IR type names (option: auto, none, use)">, + Values<"auto,none,use">; + Having "none" and "use" as values for the same option seems like a category error.

[libcxxabi] r326871 - [demangler] Fix a mistake in r326797.

Author: epilk Date: Tue Mar 6 20:29:33 2018 New Revision: 326871 URL: http://llvm.org/viewvc/llvm-project?rev=326871&view=rev Log: [demangler] Fix a mistake in r326797. Thanks to Nico Weber for pointing this out! Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_d

[PATCH] D43805: Optionally use nameless IR types

sepavloff marked an inline comment as done. sepavloff added a comment. In https://reviews.llvm.org/D43805#1029455, @pcc wrote: > Why is this a driver flag? This seems like it ought to be a cc1-only flag to > me. Yous are right, this is more like development option. But having the driver flag

Re: [libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

No, that was a mistake, fixed in r326871. Thanks for pointing this out! Erik On 2018-03-06 11:10 PM, Nico Weber wrote: Hi Erik, before this change, ___Z10blocksNRVOv_block_invoke demangled to 'invocation function for block in blocksNRVO()', now it's no longer demangled. Was that an intentiona

[PATCH] D43805: Optionally use nameless IR types

sepavloff added inline comments. Comment at: include/clang/Driver/Options.td:644 + HelpText<"Whether to use IR type names (option: auto, none, use)">, + Values<"auto,none,use">; + rsmith wrote: > Having "none" and "use" as values for the same option seems like

Re: [libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

Thanks for the quick fix! On Tue, Mar 6, 2018 at 11:32 PM, Erik Pilkington wrote: > No, that was a mistake, fixed in r326871. Thanks for pointing this out! > Erik > > > On 2018-03-06 11:10 PM, Nico Weber wrote: > > Hi Erik, > > before this change, ___Z10blocksNRVOv_block_invoke demangled to > 'i

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added a comment. I'm sorry, I did a review of your patch on Phabricator but apparently never submitted it. Comment at: lib/CodeGen/CGCall.h:219 + RValue RV; + LValue LV; /// The l-value from which the argument is derived. +}; This could

r326872 - Reland r326766 (with a slightly modified test)

Author: gbiv Date: Tue Mar 6 20:52:34 2018 New Revision: 326872 URL: http://llvm.org/viewvc/llvm-project?rev=326872&view=rev Log: Reland r326766 (with a slightly modified test) The original revert was done in r326869, since reverting r326602 broke the test added by this. The new test should be

Re: r326766 - [ExprConstant] Look through ExprWithCleanups for `allocsize`

Relanded in r326872. Thanks! On Tue, Mar 6, 2018 at 7:03 PM, Nico Weber wrote: > Apologies, I had to revert the change that touched alloc-size.cpp before > this change in r326862. After that revert, your new test here failed, and > since I didn't understand how to make it passed, I reverted your

[PATCH] D43805: Optionally use nameless IR types

pcc added a comment. > If the backend will be changed so that it will not depend on IR type names Are you referring to https://reviews.llvm.org/D43199? If so it seems to me that this should be a cc1 flag that defaults to whether `-flto=thin` is passed. In any case it seems like a bad idea to de

r326873 - Remove a placeholder

Author: gbiv Date: Tue Mar 6 21:02:27 2018 New Revision: 326873 URL: http://llvm.org/viewvc/llvm-project?rev=326873&view=rev Log: Remove a placeholder ...Running tests in the wrong directory will often make them seem to pass. Oops. :) Modified: cfe/trunk/test/CodeGenCXX/alloc-size.cpp Modi

[PATCH] D43805: Optionally use nameless IR types

sepavloff added a comment. In https://reviews.llvm.org/D43805#1029479, @pcc wrote: > > If the backend will be changed so that it will not depend on IR type names > > Are you referring to https://reviews.llvm.org/D43199? If so it seems to me > that this should be a cc1 flag that defaults to wheth

[PATCH] D44189: [RISCV] Verify the input value of -march=

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. This patch doing more check and verify the -march= string and will issue and error if it's a invalid comb

<    1   2