lebedev.ri added a comment.
I should have seen in during the initial review, but better now than never,
right? :)
================
Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141
if (!New.empty()) {
std::string Message;
// If Suggest is true, give a P0214 alternative, otherwise point it out it
----------------
Here too, surely some sane static size can be picked?
================
Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.h:32
private:
+ std::string Std;
const bool Suggest;
----------------
This could be `llvm::SmallString<32> Std;`, actually. (or
`strlen("std::experimental")`)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44173
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
