[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

xazax.hun added a comment. Hi Aleksei! Just a minor high level note. If https://reviews.llvm.org/D32947 will be accepted once, we will need to reorder friends as well. Or alternatively, we have to omit the check of friends in structural equivalence in https://reviews.llvm.org/D32947. Reposit

[PATCH] D44137: [clang-tidy] Fix one corner case in make-unique check.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: xazax.hun, klimek. Previously, we tried to cover all "std::initializer_list" implicit conversion cases in the code, but there are some corner cases that not covered (see newly-added test in the patch).

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a.sidorin added a comment. Hi Gabor, > Just a minor high level note. If https://reviews.llvm.org/D32947 will be > accepted once, we will need to reorder friends as well. Or alternatively, we > have to omit the check of friends in structural equivalence in > https://reviews.llvm.org/D32947. I'

[PATCH] D44138: [clangd] Sort includes when formatting code or inserting new includes.

ioeric created this revision. ioeric added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, jkorous-apple, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44138 Files: clangd/ClangdServer.cpp unittests/clangd/ClangdTests.cpp Index: unittests/cl

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

baloghadamsoftware added a comment. Hi, Thank you for the patch. It seems that the new approach still does not solve a problem with anonymous structures in typedefs.In C++ a copy constructor is automatically generated, and its parameter is the anonymous structure itself. This triggers caching

[PATCH] D43967: [ASTImporter] Add test helper Fixture

xazax.hun added a comment. I think having both kinds of tests might make sense. Overall, this looks good to me. Some nits inline. Comment at: unittests/AST/ASTImporterTest.cpp:143 +class Fixture : public ::testing::Test { + I do not like the name of this clas

Re: r326746 - [analyzer] AST-matching checker to detect global central dispatch performance anti-pattern

On Mon, Mar 5, 2018 at 11:05 PM George Karpenkov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: george.karpenkov > Date: Mon Mar 5 14:03:32 2018 > New Revision: 326746 > > URL: http://llvm.org/viewvc/llvm-project?rev=326746&view=rev > Log: > [analyzer] AST-matching checker to dete

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel marked 4 inline comments as done. paulsemel added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1208 + +assert(RT && "The first argument must be a record type"); + aaron.ballman wrote: > I don't see anything enforcing this constraint, so us

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Aleksei, We should definitely try to synchronize our work between Samsung (?) and Ericsson much much more. Unfortunately, it is often we work on the same issue and this can cause delays for both of us. Actually, we solved the same issue in our branch a year ago, see ht

[PATCH] D44138: [clangd] Sort includes when formatting code or inserting new includes.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Hi Sam, Sorry for the delay. LGTM, I have only minor refactoring suggestion. Thanks, Alexey Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067 + llvm::Value *FuncPtr; + if (!

r326772 - Move test/gcdasyncsemaphorechecker_test.m to a subdirectory

Author: alexfh Date: Tue Mar 6 02:40:11 2018 New Revision: 326772 URL: http://llvm.org/viewvc/llvm-project?rev=326772&view=rev Log: Move test/gcdasyncsemaphorechecker_test.m to a subdirectory Added: cfe/trunk/test/Analysis/gcdasyncsemaphorechecker_test.m - copied, changed from r326767,

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 137141. paulsemel added a comment. Applied Aaron change suggestions Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp Index: lib/CodeGen/CGBuiltin.cpp ===

Re: r326746 - [analyzer] AST-matching checker to detect global central dispatch performance anti-pattern

On Tue, Mar 6, 2018 at 11:03 AM Alexander Kornienko wrote: > On Mon, Mar 5, 2018 at 11:05 PM George Karpenkov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: george.karpenkov >> Date: Mon Mar 5 14:03:32 2018 >> New Revision: 326746 >> >> cfe/trunk/test/gcdasyncsemaphorech

[clang-tools-extra] r326773 - [clangd] Sort includes when formatting code or inserting new includes.

Author: ioeric Date: Tue Mar 6 02:42:50 2018 New Revision: 326773 URL: http://llvm.org/viewvc/llvm-project?rev=326773&view=rev Log: [clangd] Sort includes when formatting code or inserting new includes. Reviewers: hokein, ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits Differenti

[PATCH] D44138: [clangd] Sort includes when formatting code or inserting new includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326773: [clangd] Sort includes when formatting code or inserting new includes. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D44138?vs=137137&id=137142#toc Re

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. My apologies for getting back on this so late! In https://reviews.llvm.org/D41102#1017683, @juliehockett wrote: > So, as an idea (as this diff implements), I updated the string references to > be a struct, which holds the USR of the referenced type (for serialization,

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

alexfh added a comment. In https://reviews.llvm.org/D42983#1028093, @MaskRay wrote: > In https://reviews.llvm.org/D42983#1025179, @alexfh wrote: > > > A late comment here: should this check start a new "portability" module? > > This seems to be the main focus of the check rather than making code

[PATCH] D42624: [clang-tidy] Add a utility Matcher to match the next statement within a statement sequence

alexfh added a comment. In https://reviews.llvm.org/D42624#1027506, @tbourvon wrote: > @alexfh What is your opinion regarding adding this dependency? I'm fine with the dependency, and I'd probably make the matcher local to the check until there is at least one more use case for it in the codeb

[PATCH] D44141: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings

krasimir created this revision. krasimir added reviewers: djasper, sammccall. Herald added subscribers: cfe-commits, klimek. This makes the formatter of raw string literals use NestedBlockIndent for determining the 0 column of the content inside. This makes the formatting use less horizonal space

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: jkorous-apple, mgorny, klimek. The new implementation attaches notes to diagnostic message and shows the original diagnostics in the message of the note. Repository: rCTE Cl

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov added a comment. This revision is still missing tests, but I wanted to get feedback for the overall design and the new diagnostic messages. So sending out for review now. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44142 _

[PATCH] D44143: Create properly seeded random generator check

boga95 created this revision. boga95 added a reviewer: clang-tools-extra. boga95 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. This check flags all pseudo-random number engines and engine adaptors instantiations when it initialized or seeded with default argum

[PATCH] D16403: Add scope information to CFG

m.ostapenko updated this revision to Diff 137150. m.ostapenko added a comment. Rebased and updated. Fix the issue with ordering between ScopeEnds and implicit destructors. Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisDeclContext.h include/cla

[PATCH] D16403: Add scope information to CFG

m.ostapenko added a comment. Now, the cfg for this example: void test_for_implicit_scope() { for (A a; A b = a;) A c; } looks like this: F5874197: CFG-implicit-for.dot Repository: rL LLVM https://reviews.llvm.org/D16403 __

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

MTC updated this revision to Diff 137154. MTC added a comment. Remove the default configuration `-analyzer-store=region` in the test file. Repository: rC Clang https://reviews.llvm.org/D43741 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h lib/StaticAnalyzer/Co

r326776 - [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

Author: henrywong Date: Tue Mar 6 04:29:09 2018 New Revision: 326776 URL: http://llvm.org/viewvc/llvm-project?rev=326776&view=rev Log: [Analyzer] More accurate modeling about the increment operator of the operand with type bool. Summary: There is a problem with analyzer that a wrong value is gi

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326776: [Analyzer] More accurate modeling about the increment operator of the operand… (authored by henrywong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

This revision was automatically updated to reflect the committed changes. Closed by commit rC326776: [Analyzer] More accurate modeling about the increment operator of the operand… (authored by henrywong, committed by ). Repository: rC Clang https://reviews.llvm.org/D43741 Files: include/cla

[clang-tools-extra] r326778 - [clangd] Fix -Wpedantic warning, NFC.

Author: hokein Date: Tue Mar 6 04:56:18 2018 New Revision: 326778 URL: http://llvm.org/viewvc/llvm-project?rev=326778&view=rev Log: [clangd] Fix -Wpedantic warning, NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp URL:

[PATCH] D44137: [clang-tidy] Fix one corner case in make-unique check.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 137162. https://reviews.llvm.org/D35068 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp test/Analysis/security-syntax-checks.m Index: test/Analysis/security-syntax-checks.m

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:7698 +TEST_F(FormatTest, ObjCBlockTypesAndVariables) { + verifyFormat("void DoStuffWithBlockType(int (^)(char));"); This should be in `FormatTestObjC.cpp`. Repository: rC Clang ht

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1208 + +assert(RT && "The first argument must be a record type"); + paulsemel wrote: > aaron.ballman wrote: > > I don't see anything enforcing this constraint, so users are likely to h

[PATCH] D43904: [clang-format] Improve detection of ObjC for-in statements

krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:778 +TEST_F(FormatTest, ObjCForInLoop) { + verifyFormat("for (Foo *x = 0; x != in; x++) {\n}"); Please move the ObjC-specific instances to `FormatTestObjC.cpp`. Repository: rC Clan

[PATCH] D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option

krasimir added a comment. I'll commit this for you. https://reviews.llvm.org/D43731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326781 - [clang-format] Fix documentation for SpaceAfterCStyleCast option

Author: krasimir Date: Tue Mar 6 05:24:01 2018 New Revision: 326781 URL: http://llvm.org/viewvc/llvm-project?rev=326781&view=rev Log: [clang-format] Fix documentation for SpaceAfterCStyleCast option Patch contributed by @EricMarti! Summary: I noticed that the example for SpaceAfterCStyleCast do

[PATCH] D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option

This revision was automatically updated to reflect the committed changes. Closed by commit rL326781: [clang-format] Fix documentation for SpaceAfterCStyleCast option (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren))) { --

r326782 - [analyzer] CStringChecker.cpp: Remove the duplicated check about null dereference on dest-buffer or src-buffer.

Author: henrywong Date: Tue Mar 6 05:38:42 2018 New Revision: 326782 URL: http://llvm.org/viewvc/llvm-project?rev=326782&view=rev Log: [analyzer] CStringChecker.cpp: Remove the duplicated check about null dereference on dest-buffer or src-buffer. Summary: `CheckBufferAccess()` calls `CheckNonNu

[PATCH] D44075: [analyzer] CStringChecker.cpp: Remove the duplicated check about null dereference on dest-buffer or src-buffer.

This revision was automatically updated to reflect the committed changes. Closed by commit rC326782: [analyzer] CStringChecker.cpp: Remove the duplicated check about null… (authored by henrywong, committed by ). Changed prior to commit: https://reviews.llvm.org/D44075?vs=136936&id=137167#toc R

[PATCH] D44143: Create properly seeded random generator check

aaron.ballman added a comment. Thank you for working on this check! Do you think it might be possible to also add a check for `cert-msc32-c` that handles the C side of things, and use a common check to implement both? C won't ever have the C++'isms, but C++ can certainly abuse `std::srand()` so

r326792 - [clang-format] fix handling of consecutive unary operators

Author: krasimir Date: Tue Mar 6 05:56:28 2018 New Revision: 326792 URL: http://llvm.org/viewvc/llvm-project?rev=326792&view=rev Log: [clang-format] fix handling of consecutive unary operators Summary: Code that used to be formatted as `if (! + object) {` is now formatted as `if (!+object) {` (

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL326792: [clang-format] fix handling of consecutive unary operators (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4331

[libcxxabi] r326796 - [demangler] Modernize parse_unresolved_name.

Author: epilk Date: Tue Mar 6 06:21:08 2018 New Revision: 326796 URL: http://llvm.org/viewvc/llvm-project?rev=326796&view=rev Log: [demangler] Modernize parse_unresolved_name. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL: http://llvm.org

[libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

Author: epilk Date: Tue Mar 6 06:21:10 2018 New Revision: 326797 URL: http://llvm.org/viewvc/llvm-project?rev=326797&view=rev Log: [demangler] Modernize the rest of the demangler. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified: libcxx

[PATCH] D44141: [clang-format] Use NestedBlockIndent as a 0 column in formatted raw strings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM, probably want to wait for djasper's opinion. Repository: rC Clang https://reviews.llvm.org/D44141 ___ cfe-commits mailing list cfe

[clang-tools-extra] r326798 - [clangd] Address missed comments from D44003

Author: sammccall Date: Tue Mar 6 06:30:07 2018 New Revision: 326798 URL: http://llvm.org/viewvc/llvm-project?rev=326798&view=rev Log: [clangd] Address missed comments from D44003 Modified: clang-tools-extra/trunk/unittests/clangd/FuzzyMatchTests.cpp Modified: clang-tools-extra/trunk/unitte

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:535 +SmallVector LibraryPaths; +if (char *env = ::getenv("LIBRARY_PATH")) { + StringRef CompilerPath = env; 1. `char *`->`const char *` 2. `::getenv`->`llvm::Process::GetEnv`

[clang-tools-extra] r326799 - [clang-tidy] Fix one corner case in make-unique check.

Author: hokein Date: Tue Mar 6 06:34:35 2018 New Revision: 326799 URL: http://llvm.org/viewvc/llvm-project?rev=326799&view=rev Log: [clang-tidy] Fix one corner case in make-unique check. Summary: Previously, we tried to cover all "std::initializer_list" implicit conversion cases in the code, but

[PATCH] D44137: [clang-tidy] Fix one corner case in make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326799: [clang-tidy] Fix one corner case in make-unique check. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D44137?vs=137136&id=137188#toc Repository: rCTE

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.h:28 +/// DiagList. +struct PersistentDiag { + llvm::StringRef Message; This could probably use a better name Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44142 _

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Look like sensible cleanups/fixes/additions to me. We were struggling whether to pass an i16 or f16 type, which can both be illegal types. Therefore, it perhaps doesn't really matt

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added a comment. Ping. Thanks Repository: rC Clang https://reviews.llvm.org/D43821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

erichkeane added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12598 +// have to apply optnone due to a pragma. +AddRangeBasedOptnone(FD); + Should thi sonly happen if this is a definition? Additionally, does this negate the need for the other call

[libcxx] r326801 - Implement P0767R1 - Deprecate POD

Author: marshall Date: Tue Mar 6 07:01:19 2018 New Revision: 326801 URL: http://llvm.org/viewvc/llvm-project?rev=326801&view=rev Log: Implement P0767R1 - Deprecate POD Modified: libcxx/trunk/test/std/language.support/support.types/byte.pass.cpp libcxx/trunk/test/std/language.support/supp

[libcxx] r326802 - One more test for P0767:

Author: marshall Date: Tue Mar 6 07:01:55 2018 New Revision: 326802 URL: http://llvm.org/viewvc/llvm-project?rev=326802&view=rev Log: One more test for P0767: Modified: libcxx/trunk/test/std/depr/depr.c.headers/stddef_h.pass.cpp Modified: libcxx/trunk/test/std/depr/depr.c.headers/stddef_h.p

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good with a few nits. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:15 + +#include + What is this header used for? Comment at:

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added a comment. Thank you for working on this! Finally trying to review this... I must say i'm **really** not fond of the test 'changes'. But some initial comments added: Comment at: clang-doc/BitcodeReader.cpp:19 + +void ClangDocBitcodeReader::storeData(llvm::Sma

[PATCH] D44154: [checker] PoC : Unsequenced Modification Checker

paulsemel created this revision. Herald added subscribers: cfe-commits, mgorny. \!/ This is only a proof of concept ! The purpose of this checker is to improve the detection of unsequenced modifications. Indeed, there is a warning the tries to detect those, but this is not efficient at all. The

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren)))

r326807 - [X86] Fix typo in cpuid.h, bit_AVX51SER->bit_AVX512ER.

Author: ctopper Date: Tue Mar 6 08:06:44 2018 New Revision: 326807 URL: http://llvm.org/viewvc/llvm-project?rev=326807&view=rev Log: [X86] Fix typo in cpuid.h, bit_AVX51SER->bit_AVX512ER. Modified: cfe/trunk/lib/Headers/cpuid.h Modified: cfe/trunk/lib/Headers/cpuid.h URL: http://llvm.org/v

[PATCH] D43904: [clang-format] Improve detection of ObjC for-in statements

benhamilton updated this revision to Diff 137199. benhamilton marked an inline comment as done. benhamilton added a comment. - Move ObjC-specific tests to `FormatTestObjC.cpp`. Repository: rC Clang https://reviews.llvm.org/D43904 Files: lib/Format/TokenAnnotator.cpp unittests/Format/Form

[PATCH] D43904: [clang-format] Improve detection of ObjC for-in statements

benhamilton added inline comments. Comment at: unittests/Format/FormatTest.cpp:778 +TEST_F(FormatTest, ObjCForInLoop) { + verifyFormat("for (Foo *x = 0; x != in; x++) {\n}"); krasimir wrote: > Please move the ObjC-specific instances to `FormatTestObjC.cpp`. Do

[PATCH] D41958: Create a deduction guide for basic_string

mclow.lists closed this revision. mclow.lists added a comment. This was landed as r324619 https://reviews.llvm.org/D41958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44154: [checker] PoC : Unsequenced Modification Checker

a.sidorin added a comment. Hi Paul, You didn't add any reviewer. Do you need a review for this checker? Are you going to contribute this code to the upstream? Repository: rC Clang https://reviews.llvm.org/D44154 ___ cfe-commits mailing list cfe

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren)))

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137203. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openm

[PATCH] D44154: [checker] PoC : Unsequenced Modification Checker

paulsemel added a comment. Hi Aleksei, In https://reviews.llvm.org/D44154#1028612, @a.sidorin wrote: > Hi Paul, > > You didn't add any reviewer. Do you need a review for this checker? Are you > going to contribute this code to the upstream? I was actually uploading this because Artem Dergache

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

gtbercea updated this revision to Diff 137210. gtbercea added a comment. Add init stack function. Repository: rC Clang https://reviews.llvm.org/D43660 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp li

[PATCH] D44158: [clangd:vscode] Resolve symlinks for file paths from clangd.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. For features like go-to-definition, clangd can point clients to symlink paths (e.g. in bazel execroot) which might not be desired if the symlink points to

[clang-tools-extra] r326809 - [clangd] Don't end completion item labels with '::'

Author: ibiryukov Date: Tue Mar 6 08:45:21 2018 New Revision: 326809 URL: http://llvm.org/viewvc/llvm-project?rev=326809&view=rev Log: [clangd] Don't end completion item labels with '::' Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp clang-tools-extra/trunk/test/clangd/protoco

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:591 +llvm::sys::path::append(DefaultLibPath, "lib" CLANG_LIBDIR_SUFFIX); +LibraryPaths.emplace_back(DriverArgs.MakeArgString(DefaultLibPath)); + Maybe just `LibraryPaths.emplace_bac

Re: r326746 - [analyzer] AST-matching checker to detect global central dispatch performance anti-pattern

Yep, sorry, bad typing skills. > On Mar 6, 2018, at 2:44 AM, Alexander Kornienko wrote: > > On Tue, Mar 6, 2018 at 11:03 AM Alexander Kornienko > wrote: > On Mon, Mar 5, 2018 at 11:05 PM George Karpenkov via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > A

r326815 - [clang-format] Improve detection of ObjC for-in statements

Author: benhamilton Date: Tue Mar 6 09:21:42 2018 New Revision: 326815 URL: http://llvm.org/viewvc/llvm-project?rev=326815&view=rev Log: [clang-format] Improve detection of ObjC for-in statements Summary: Previously, clang-format would detect the following as an Objective-C for-in statement:

[PATCH] D43904: [clang-format] Improve detection of ObjC for-in statements

This revision was automatically updated to reflect the committed changes. Closed by commit rL326815: [clang-format] Improve detection of ObjC for-in statements (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137219. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openm

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067 + llvm::Value *FuncPtr; + if (!CGM.getLangOpts().OpenCL) { bader wrote: > I think it would be more readable if we merge this if statement with the if > statement at the line #1103.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:207-208 +def remark_drv_omp_offload_target_missingbcruntime : Warning< + "Expect degraded performance on the target device due to missing '%0' in LIBRARY_PATH.">, + InGroup; def err_drv_bi

[libclc] r326816 - Move cl_khr_fp64 exntension enablement to gentype include lists

Author: jvesely Date: Tue Mar 6 09:48:35 2018 New Revision: 326816 URL: http://llvm.org/viewvc/llvm-project?rev=326816&view=rev Log: Move cl_khr_fp64 exntension enablement to gentype include lists This will make adding cl_khr_fp16 support easier Reviewed-by: Aaron Watry Signed-off-by: Jan Vese

[libclc] r326817 - maxmag: Condition variable needs to be the same bitwidth as operands

Author: jvesely Date: Tue Mar 6 09:48:38 2018 New Revision: 326817 URL: http://llvm.org/viewvc/llvm-project?rev=326817&view=rev Log: maxmag: Condition variable needs to be the same bitwidth as operands No changes wrt CTS Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc

[libclc] r326818 - minmag: Condition variable needs to be the same bitwidth as operands

Author: jvesely Date: Tue Mar 6 09:48:40 2018 New Revision: 326818 URL: http://llvm.org/viewvc/llvm-project?rev=326818&view=rev Log: minmag: Condition variable needs to be the same bitwidth as operands No changes wrt CTS Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc

[libclc] r326819 - select: Add vector implementation

Author: jvesely Date: Tue Mar 6 09:48:43 2018 New Revision: 326819 URL: http://llvm.org/viewvc/llvm-project?rev=326819&view=rev Log: select: Add vector implementation Passes CTS on Carrizo Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/include/clc/relation

[libclc] r326820 - frexp: Reuse types provided by gentype.inc

Author: jvesely Date: Tue Mar 6 09:48:45 2018 New Revision: 326820 URL: http://llvm.org/viewvc/llvm-project?rev=326820&view=rev Log: frexp: Reuse types provided by gentype.inc v2: Use select instead of bitselect to consolidate scalar and vector versions Passes CTS on Carrizo Reviewed-by: Aaron

[libclc] r326821 - lgamma_r: Move code from .inc to .cl file

Author: jvesely Date: Tue Mar 6 09:48:47 2018 New Revision: 326821 URL: http://llvm.org/viewvc/llvm-project?rev=326821&view=rev Log: lgamma_r: Move code from .inc to .cl file Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/lib/math/lgamma_r.cl libclc/

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1028228, @Athosvk wrote: > This seems like quite a decent approach! That being said, I don't see the > pointer yet? I assume you mean that you will be adding this? Additionally, a > slight disadvantage of doing this generic approa

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Let's do this. I thought we'd already have a higher C++ standard version by now, but apparently not. https://reviews.llvm.org/D34365 ___ cfe-commits m

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137226. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openm

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

sammccall added a comment. Behavior looks good. I think we can do a bit better with (most) fixits - your call on whether it makes sense to do here. As discussed i'd simplify the diagnostic containers until we know there's a strong need. Comment at: clangd/ClangdLSPServer.cpp

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny updated this revision to Diff 137227. mgorny added a comment. @rnk, could you confirm the rebased patch? I'm not sure if I should override `InputKind::RenderScript` as well. https://reviews.llvm.org/D34365 Files: CMakeLists.txt include/clang/Config/config.h.cmake lib/Frontend/Comp

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137230. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offloa

r326822 - TableGen: Give up on exact fixits for diagnostic groups

Author: nha Date: Tue Mar 6 09:55:00 2018 New Revision: 326822 URL: http://llvm.org/viewvc/llvm-project?rev=326822&view=rev Log: TableGen: Give up on exact fixits for diagnostic groups With recent changes in the TableGen frontend, we no longer have usable location information for anonymous defs.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137233. gtbercea added a comment. - Fix message and test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver

r326827 - [OPENMP] Fix generation of the unique names for task reduction

Author: abataev Date: Tue Mar 6 10:59:43 2018 New Revision: 326827 URL: http://llvm.org/viewvc/llvm-project?rev=326827&view=rev Log: [OPENMP] Fix generation of the unique names for task reduction variables. If the task has reduction construct and this construct for some variable requires unique

[PATCH] D44143: Create properly seeded random generator check

Quuxplusone added inline comments. Comment at: docs/clang-tidy/checks/cert-properly-seeded-random-generator.rst:26 +std::random_device dev; +std::mt19937 engine3(dev()); // Good + } Seeding MT19937 with a single 32-bit integer is //not// "Good". It makes

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren))) { --

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

rnk added a comment. Yep, looks good. I'd leave renderscript alone. I think it's deprecated. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

vsapsai added a comment. Ping. https://reviews.llvm.org/D43494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1795 CXXRecordDecl *Canon = D->getCanonicalDecl(); - if (Canon->DefinitionData) { + if (Canon->DefinitionData &

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren)))

  1   2   >