ABataev added inline comments.
================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:207-208
+def remark_drv_omp_offload_target_missingbcruntime : Warning<
+ "Expect degraded performance on the target device due to missing '%0' in
LIBRARY_PATH.">,
+ InGroup<OpenMPTarget>;
def err_drv_bitcode_unsupported_on_toolchain : Error<
----------------
Fix the message in the warning, it does not follow the logic of the patch
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:586
+ if (DeviceOffloadingKind == Action::OFK_OpenMP) {
+ SmallVector<std::string, 8> LibraryPaths;
+ // Add path to lib and/or lib64 folders.
----------------
Do you really need `std::string` here? Or StringRef is enough?
Repository:
rC Clang
https://reviews.llvm.org/D43197
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
