[clang-tools-extra] r325868 - [clangd] BindWithForward -> Bind. NFC

Author: sammccall Date: Thu Feb 22 23:54:17 2018 New Revision: 325868 URL: http://llvm.org/viewvc/llvm-project?rev=325868&view=rev Log: [clangd] BindWithForward -> Bind. NFC Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/Function.h clang-tools

[PATCH] D40731: Integrate CHash into CLang

stettberger updated this revision to Diff 135598. stettberger added a comment. [CHash] Stable TU-level AST Hashing for local and global hashes This patch does integrate the AST hashing parts of the CHash project[1][2] into CLang. The extension provided by this patch accomplishes 2 things: - loca

[PATCH] D43671: [clangd] Address FIXME and fix comment

omtcyfz created this revision. omtcyfz added a reviewer: ioeric. omtcyfz added a project: clang-tools-extra. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov. - Address a FIXME by warning the user that both -run-synchronously and -j X are passed. - Fix a comment to suppress cla

[PATCH] D43671: [clangd] Address FIXME and fix comment

ioeric added a comment. Thanks for the cleanup Kirill :) Comment at: clangd/tool/ClangdMain.cpp:153 + if (RunSynchronously) { +if (WorkerThreadsCount != 0) { + llvm::errs() `-j` is non-zero by default, and we shouldn't show warning if users only spec

[PATCH] D43648: [clangd] Debounce streams of updates.

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:140 + // Time to wait after an update to see whether another update obsoletes it. + steady_clock::duration UpdateDebounce; }; Maybe make it `const` and put beside `RunSync`? Both are sched

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib updated this revision to Diff 135603. chrib added a comment. Herald added a subscriber: mehdi_amini. hello, realizing that this has been stuck for a while now. did I answer all the concerns ? rebased patch, gentle ping :-) many thanks, Christian https://reviews.llvm.org/D31140 Files:

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib updated this revision to Diff 135610. chrib added a comment. damn it last diff was the llvm part (https://reviews.llvm.org/D31139). Here is the clang part. sorry for the noise, still not experienced with Phabricator. https://reviews.llvm.org/D31140 Files: include/clang/Driver/ToolChai

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

lebedev.ri added a comment. Somewhat related thing i have noticed: https://godbolt.org/g/ow58JV I wonder whether that also should be diagnosed? Where though, as clang-tidy check? Repository: rC Clang https://reviews.llvm.org/D43322 ___ cfe-commi

[PATCH] D43671: [clangd] Address FIXME and fix comment

omtcyfz updated this revision to Diff 135626. omtcyfz added a comment. Addressed review comment by actually checking whether -j option was actually passed to clangd. https://reviews.llvm.org/D43671 Files: clangd/Context.cpp clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp ===

[PATCH] D43671: [clangd] Address FIXME and fix comment

omtcyfz marked an inline comment as done. omtcyfz added inline comments. Comment at: clangd/tool/ClangdMain.cpp:153 + if (RunSynchronously) { +if (WorkerThreadsCount != 0) { + llvm::errs() ioeric wrote: > `-j` is non-zero by default, and we shouldn't sh

[PATCH] D43673: Make module use diagnostics refer to the top-level module

djasper created this revision. djasper added a reviewer: rsmith. All use declarations need to be directly placed in the top-level module anyway, knowing the submodule doesn't really help. The header that has the offending #include can easily be seen in the diagnostics source location. https://

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

aaron.ballman added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl->getName() << generateFixItHint(Decl, true); ---

Re: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

Hi Davide, This patch broke ARM and AArch64 bots (x86_64 apple targets are not available on these bots). Logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/15940/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adebug-info-section-macho.c Thanks Yvan On 23 F

r325872 - [mips] Reland r310704

Author: smaksimovic Date: Fri Feb 23 00:37:48 2018 New Revision: 325872 URL: http://llvm.org/viewvc/llvm-project?rev=325872&view=rev Log: [mips] Reland r310704 Recommit this change which was previously reverted for the 5.0.0 release since the failures identified were dealt with in r325782. Added

[PATCH] D43614: Define _PTHREADS for -pthread on NetBSD

krytarowski abandoned this revision. krytarowski added a comment. As discussed with Joerg, `_PTHREADS` is considered legacy and we can bear with lack of it and inconsistency with GCC. Repository: rL LLVM https://reviews.llvm.org/D43614 ___ cfe-c

r325901 - Support for the mno-stack-arg-probe flag

Author: hans Date: Fri Feb 23 05:47:36 2018 New Revision: 325901 URL: http://llvm.org/viewvc/llvm-project?rev=325901&view=rev Log: Support for the mno-stack-arg-probe flag Adds support for this flag. There is also another piece for llvm (separate review). More info: https://bugs.llvm.org/show_bug

[PATCH] D43108: Support for the mno-stack-arg-probe flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC325901: Support for the mno-stack-arg-probe flag (authored by hans, committed by ). Changed prior to commit: https://reviews.llvm.org/D43108?vs=134377&id=135631#toc Repository: rC Clang https://revi

[PATCH] D43510: [clangd] don't insert new includes if either original header or canonical header is already included.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, and sorry for the delay! Comment at: clangd/Headers.cpp:45 private: - std::set &Headers; + std::set &WrittenHeaders; + std::set &ResolvedHeaders; --

r325899 - [mips] Revert r325872

Author: smaksimovic Date: Fri Feb 23 05:46:14 2018 New Revision: 325899 URL: http://llvm.org/viewvc/llvm-project?rev=325899&view=rev Log: [mips] Revert r325872 There are still outstanding issues with byVal arguments that prevent this from being committed. Revert for now. Removed: cfe/trunk/t

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

sdardis added a subscriber: arichardson. sdardis added a comment. This works as expected with your corresponding libcxx patch. However @arichardson 's https://reviews.llvm.org/D42139 does similar things for libcxx. We should wait for that to land, and ensure that this patch is rebased against t

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:555 Work.clear(); + WrapperFunctionsMap.clear(); Do we need this? Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:640-641 + GlobalRecordSizeArg); + aut

[libcxxabi] r325907 - Creating release candidate rc3 from release_600 branch

Author: hans Date: Fri Feb 23 07:09:53 2018 New Revision: 325907 URL: http://llvm.org/viewvc/llvm-project?rev=325907&view=rev Log: Creating release candidate rc3 from release_600 branch Added: libcxxabi/tags/RELEASE_600/rc3/ - copied from r325906, libcxxabi/branches/release_60/ ___

[libcxx] r325906 - Creating release candidate rc3 from release_600 branch

Author: hans Date: Fri Feb 23 07:09:46 2018 New Revision: 325906 URL: http://llvm.org/viewvc/llvm-project?rev=325906&view=rev Log: Creating release candidate rc3 from release_600 branch Added: libcxx/tags/RELEASE_600/rc3/ (props changed) - copied from r325905, libcxx/branches/release_

[libunwind] r325913 - Creating release candidate rc3 from release_600 branch

Author: hans Date: Fri Feb 23 07:10:42 2018 New Revision: 325913 URL: http://llvm.org/viewvc/llvm-project?rev=325913&view=rev Log: Creating release candidate rc3 from release_600 branch Added: libunwind/tags/RELEASE_600/rc3/ - copied from r325912, libunwind/branches/release_60/ ___

[PATCH] D42139: Allow passing additional compiler/linker flags for the tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL325914: Allow passing additional compiler/linker flags for the tests (authored by arichardson, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D421

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

amccarth added a comment. In https://reviews.llvm.org/D43621#1017027, @ruiu wrote: > > That's weird, because lots of lldb tests compile and link test binaries on > > Windows with `-fuse-ld=lld` (without the `.exe`). What makes you say the > > `.exe` is necessary? > > Maybe he is using clang (n

[PATCH] D43514: Start settinng dso_local for COFF

espindola closed this revision. espindola added a comment. 325915 https://reviews.llvm.org/D43514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43681: [WebAssembly] Add exception handling option

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, jfb. Add exception handling option to clang. Repository: rC Clang https://reviews.llvm.org/D43681 Files: docs/ClangCommandLineReference.rst include/

[libcxx] r325914 - Allow passing additional compiler/linker flags for the tests

Author: arichardson Date: Fri Feb 23 07:19:48 2018 New Revision: 325914 URL: http://llvm.org/viewvc/llvm-project?rev=325914&view=rev Log: Allow passing additional compiler/linker flags for the tests Summary: These flags can be specified using the CMake variables LIBCXX_TEST_LINKER_FLAGS and LIBCX

r325920 - Revert "[Darwin] Add a test to check clang produces accelerator tables."

Author: probinson Date: Fri Feb 23 08:36:48 2018 New Revision: 325920 URL: http://llvm.org/viewvc/llvm-project?rev=325920&view=rev Log: Revert "[Darwin] Add a test to check clang produces accelerator tables." This reverts commit 7e24e5f8bff77b7e78da3bfcc68abf42457a66c9. aka r325850. Clang should

Re: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

Apologies, I'm taking a look now. On Fri, Feb 23, 2018 at 5:33 AM, Yvan Roux wrote: > Hi Davide, > > > This patch broke ARM and AArch64 bots (x86_64 apple targets are not > available on these bots). > Logs are available here: > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/15940/

RE: r325850 - [Darwin] Add a test to check clang produces accelerator tables.

Hi Davide, Clang does not have end-to-end tests like this. To verify we produce the apple accelerator tables, you want a .ll source in llvm/test/CodeGen/X86. In the meantime I've reverted the commit in r325920. Thanks, --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-b

[PATCH] D43461: [CUDA] Include single GPU binary, NFCI.

Hahnfeld updated this revision to Diff 135649. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Update comment. https://reviews.llvm.org/D43461 Files: include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGCUDANV.cpp lib/Driver/ToolChains/Clang.cpp lib/Frontend/Compil

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. In https://reviews.llvm.org/D43322#1017190, @lebedev.ri wrote: > Somewhat related thing i have noticed: https://godbolt.org/g/ow58JV IIUC, you're asking whether it would be possible to detect instances of return take(mysharedptr); and rewrite them into return

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Next, i suggest to look into code self-debugging, see comments. Also, i have added a few questions, it would be great to know that my understanding is correct? I'm sorry that it seems like we are going over and over and over over the same code again, this is the ver

[PATCH] D41102: Setup clang-doc frontend framework

Athosvk added a comment. The change to USR seems like quite an improvement already! That being said, I do think that it might be preferable to opt out of the use of strings for linking things together. What we did with our clang-doc is that we directly used pointers to refer to other types. So

r325930 - Convert test to FileCheck. NFC.

Author: rafael Date: Fri Feb 23 10:18:01 2018 New Revision: 325930 URL: http://llvm.org/viewvc/llvm-project?rev=325930&view=rev Log: Convert test to FileCheck. NFC. Modified: cfe/trunk/test/CodeGen/tentative-decls.c Modified: cfe/trunk/test/CodeGen/tentative-decls.c URL: http://llvm.org/vie

[PATCH] D43648: [clangd] Debounce streams of updates.

sammccall added inline comments. Comment at: clangd/TUScheduler.cpp:324 +if (*Deadline) + RequestsCV.wait_until(Lock, **Deadline); +else ilya-biryukov wrote: > It looks like if we unwrap `Optional` to `Deadline`, we could > replace this

[PATCH] D43648: [clangd] Debounce streams of updates.

sammccall updated this revision to Diff 135660. sammccall marked 3 inline comments as done. sammccall added a comment. Make Deadline a real type with 0/finite/inf semantics. Pull out another wait() overload. Expose debounce delay option in clangdserver. Repository: rCTE Clang Tools Extra http

[PATCH] D43648: [clangd] Debounce streams of updates.

sammccall updated this revision to Diff 135661. sammccall added a comment. rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43648 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/TUScheduler.cpp clangd/TUScheduler.h clangd/Threading.cpp clangd/Thread

[PATCH] D43667: [clang-doc] Implement a YAML generator

Eugene.Zelenko added a comment. Please run Clang-format and Clang-tidy modernize over new code. Comment at: clang-doc/generators/Generators.h:29 + Generator(std::unique_ptr &IS, StringRef Root, StringRef Format) + : IS(IS), Root(Root), Format(Format){}; + virtual ~Genera

[PATCH] D43667: [clang-doc] Implement a YAML generator

Eugene.Zelenko added a comment. I may be mistaken, but Clang source code didn't use llvm namespace by default. Insetad you should include clang/Basic/LLVM.h and use llvm:: for rest of things. Comment at: clang-doc/tool/ClangDocMain.cpp:42 namespace { Ther

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41102: Setup clang-doc frontend framework

Eugene.Zelenko added a comment. Please run Clang-format and Clang-tidy modernize. Comment at: clang-doc/Representation.h:80 + : LineNumber(LineNumber), Filename(std::move(Filename)) {} + int LineNumber; + std::string Filename; Please separate constructor

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

Eugene.Zelenko added a comment. Please run Clang-format and Clang-tidy modernize. Comment at: clang-doc/BitcodeReader.h:36 + public: + ClangDocBitcodeReader() {} + using RecordData = SmallVector; Please use = default; https://reviews.llvm.org/D43341

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

Eugene.Zelenko added a comment. Please run Clang-format and Clang-tidy modernize. Comment at: clang-doc/generators/Generators.h:46 +public: + MDGenerator(std::unique_ptr &IS, StringRef Root, StringRef Format) : Generator(IS, Root, Format) {}; + virtual ~MDGenerator() {}; ---

[PATCH] D43533: [CFG] [analyzer] NFC: Refactor ConstructionContext into a finite set of cases.

NoQ updated this revision to Diff 135667. NoQ added a comment. Missing break!~~ https://reviews.llvm.org/D43533 Files: include/clang/Analysis/CFG.h include/clang/Analysis/ConstructionContext.h lib/Analysis/CFG.cpp lib/Analysis/CMakeLists.txt lib/Analysis/ConstructionContext.cpp lib/

[PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

tmsriram added a comment. Ping. https://reviews.llvm.org/D42217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43689: [analyzer] Disable constructor inlining when lifetime extension through fields occurs.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. As i mentioned in https://reviews.llvm.org/D43497, automatic destructors are missing in the CFG in situations like const int &x = C().x;

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

aaron.ballman added inline comments. Comment at: test/Sema/attr-nocf_check.c:1 +// RUN: %clang_cc1 -verify -fcf-protection=branch -target-feature +ibt -fsyntax-only %s + You likely need to specify an explicit triple here, or some of the bots fail this test beca

r325942 - Fix one last test on a windows host.

Author: rafael Date: Fri Feb 23 11:36:20 2018 New Revision: 325942 URL: http://llvm.org/viewvc/llvm-project?rev=325942&view=rev Log: Fix one last test on a windows host. Modified: cfe/trunk/test/CodeGenCUDA/filter-decl.cu Modified: cfe/trunk/test/CodeGenCUDA/filter-decl.cu URL: http://llvm.

r325943 - Really fix test on windows.

Author: rafael Date: Fri Feb 23 11:38:41 2018 New Revision: 325943 URL: http://llvm.org/viewvc/llvm-project?rev=325943&view=rev Log: Really fix test on windows. Sorry for the noise. Modified: cfe/trunk/test/CodeGenCUDA/filter-decl.cu Modified: cfe/trunk/test/CodeGenCUDA/filter-decl.cu URL:

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

weimingz added a comment. ping? https://reviews.llvm.org/D41316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

Sriraman Tallam via Phabricator writes: > + if (CodeGenOpts.NoPLT) { > +getModule().setAvoidPLT(); > + } > + You don't need the {}. LGTM with that. Cheers, Rafael ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

On Fri, Feb 23, 2018 at 11:54 AM, Rafael Avila de Espindola wrote: > Sriraman Tallam via Phabricator writes: >> + if (CodeGenOpts.NoPLT) { >> +getModule().setAvoidPLT(); >> + } >> + > > You don't need the {}. > > LGTM with that. Thanks! Sri > > Cheers, > Rafael ___

[PATCH] D43545: [Driver] Make -fno-common default for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL325945: [Driver] Make -fno-common default for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43545?vs=135193&id=

r325945 - [Driver] Make -fno-common default for Fuchsia

Author: phosek Date: Fri Feb 23 12:10:14 2018 New Revision: 325945 URL: http://llvm.org/viewvc/llvm-project?rev=325945&view=rev Log: [Driver] Make -fno-common default for Fuchsia We never want to generate common symbols on Fuchsia. Differential Revision: https://reviews.llvm.org/D43545 Modified

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135678. juliehockett marked 29 inline comments as done. juliehockett added a comment. 1. Continued refactoring the bitcode writer 2. Added a USR attribute to infos 3. Created a Reference struct to replace the string references to other infos https://rev

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017499, @Athosvk wrote: > Disadvantage is of course that you add complexity to certain parts of the > deserialization (/serialization) for nested types and inheritance, by either > having to do so in the correct order or having t

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135682. juliehockett added a comment. Fixing CMakeLists formatting https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-doc/ClangDoc.h clang-doc/Mapper.cp

r325961 - Set Module Metadata "RtLibUseGOT" when fno-plt is used.

Author: tmsriram Date: Fri Feb 23 13:27:33 2018 New Revision: 325961 URL: http://llvm.org/viewvc/llvm-project?rev=325961&view=rev Log: Set Module Metadata "RtLibUseGOT" when fno-plt is used. Differential Revision: https://reviews.llvm.org/D42217 Modified: cfe/trunk/lib/CodeGen/CodeGenModule.

[PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL325961: Set Module Metadata "RtLibUseGOT" when fno-plt is used. (authored by tmsriram, committed by ). Herald added a subs

[PATCH] D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent.

v.g.vassilev added a comment. Could you double-check if we can add this to an existing test? Would `test/SemaCXX/pr25181-crash-on-invalid.cpp` fit and potentially rename it. Comment at: test/SemaCXX/cxx11-odr-use-crash-on-invalid.cpp:8 +c : d() { // expected-error {{unexpected

[PATCH] D43696: Reduce hash collisions for reference and pointer types

v.g.vassilev created this revision. v.g.vassilev added reviewers: rtrieu, rsmith. While investigating the work done in D41416 I found out that the hash values for pointer and reference types are the same. Repository: rC Clang https://reviews.llvm.org/D43696

[PATCH] D32111: [modules] Attempt to fix PR31905 - #include "stddef.h" breaks module map search paths; causes redefinitions.

rsmith added inline comments. Comment at: lib/Serialization/ASTReader.cpp:2554-2556 + Module *M = PP.getHeaderSearchInfo().lookupModule( + F.ModuleName, + /*AllowSearch*/ true, /*SearchTopLevelOnly*/ true); This is only trying to catch the

r325966 - [CFG] [analyzer] NFC: Allow more complicated construction contexts.

Author: dergachev Date: Fri Feb 23 14:20:39 2018 New Revision: 325966 URL: http://llvm.org/viewvc/llvm-project?rev=325966&view=rev Log: [CFG] [analyzer] NFC: Allow more complicated construction contexts. ConstructionContexts introduced in D42672 are an additional piece of information included wit

[PATCH] D43428: [CFG] [analyzer] NFC: Allow more complicated construction contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325966: [CFG] [analyzer] NFC: Allow more complicated construction contexts. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D43673: Make module use diagnostics refer to the top-level module

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Makes sense -- as dependencies can only be declared on top-level modules, that's what we should be talking about here. https://reviews.llvm.org/D43673 _

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak updated this revision to Diff 135703. ahatanak marked 9 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D41228 Files: docs/LanguageExtensions.rst include/clang/AST/Decl.h include/clang/AST/Type.h include/clang/Basic/Diagnosti

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1108 +PCK_ARCStrong, // objc strong pointer. +PCK_Struct // non-trivial C struct. + }; rjmccall wrote: > These should all be /// documentation comments, and they mostly shouldn't >

[PATCH] D40218: [Clang] Add __builtin_launder

rsmith added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1947-1948 +const auto *Record = ArgTy->getAsCXXRecordDecl(); +if (CGM.getCodeGenOpts().StrictVTablePointers && Record && +Record->isDynamicClass()) + Ptr = Builder.CreateInvariantGroupBarrier

r325969 - [CFG] NFC: Speculative attempt to fix MSVC internal compiler error on buildbot.

Author: dergachev Date: Fri Feb 23 14:49:25 2018 New Revision: 325969 URL: http://llvm.org/viewvc/llvm-project?rev=325969&view=rev Log: [CFG] NFC: Speculative attempt to fix MSVC internal compiler error on buildbot. Don't use fancy initialization and member access in a DenseMap. Modified: cf

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

vsapsai updated this revision to Diff 135708. vsapsai added a comment. - Override `This` for indirect field initializer more like it is done for `InitListExpr`. I rebased my changes, so the diff between different versions can be noisy. https://reviews.llvm.org/D42498 Files: clang/lib/AST/Ex

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Could you please add a bit more tests? In particular, i'd like to see how blocks-in-blocks work. I.e. class-in-class, class-in-function, ... Is there some (internal to `BitstreamWriter`) logic that would 'assert()' if trying to output some recordid which is, accordin

[PATCH] D42766: [DebugInfo] Support DWARFv5 source code embedding extension

scott.linder added a comment. With https://reviews.llvm.org/D42765 committed I think this is ready for review. Repository: rC Clang https://reviews.llvm.org/D42766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D43584: [test] Permit additional CFLAGS for tests to be set via config.test_cflags.

bsdjhb abandoned this revision. bsdjhb added a comment. Obsoleted by https://reviews.llvm.org/rCXX325914. Repository: rCXX libc++ https://reviews.llvm.org/D43584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! In https://reviews.llvm.org/D42498#1015419, @vsapsai wrote: > In https://reviews.llvm.org/D42498#1007028, @rsmith wrote: > > > […] your approach will still go wrong if the

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb marked 2 inline comments as done. bsdjhb added a comment. My only question is if this should be named LIBUNWIND_TEST_COMPILER_FLAGS to match the name used in libc++? Repository: rUNW libunwind https://reviews.llvm.org/D43585 ___ cfe-commi

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb updated this revision to Diff 135714. bsdjhb added a comment. - Use STRING instead of PATH. - Update for committed libcxx change. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index: test/lit.site.cfg.in ===

r325975 - [analyzer] Consider switch- and goto- labels when constructing the set of executed lines

Author: george.karpenkov Date: Fri Feb 23 15:26:54 2018 New Revision: 325975 URL: http://llvm.org/viewvc/llvm-project?rev=325975&view=rev Log: [analyzer] Consider switch- and goto- labels when constructing the set of executed lines When viewing the report in the collapsed mode the label signifyi

r325976 - [analyzer] mark returns of functions where the region passed as parameter was not initialized

Author: george.karpenkov Date: Fri Feb 23 15:26:56 2018 New Revision: 325976 URL: http://llvm.org/viewvc/llvm-project?rev=325976&view=rev Log: [analyzer] mark returns of functions where the region passed as parameter was not initialized In the wild, many cases of null pointer dereference, or uni

r325977 - [analyzer] Relax the assert used when traversing the node graph.

Author: george.karpenkov Date: Fri Feb 23 15:26:57 2018 New Revision: 325977 URL: http://llvm.org/viewvc/llvm-project?rev=325977&view=rev Log: [analyzer] Relax the assert used when traversing the node graph. The assertion gets exposed when changing the exploration order. This is a quick hacky fix

r325978 - [CFG] Try to narrow down MSVC compiler crash via binary search.

Author: dergachev Date: Fri Feb 23 15:38:41 2018 New Revision: 325978 URL: http://llvm.org/viewvc/llvm-project?rev=325978&view=rev Log: [CFG] Try to narrow down MSVC compiler crash via binary search. Split the presumably offending function in two to see which part of it causes the crash to occur.

[PATCH] D43696: Reduce hash collisions for reference and pointer types

rsmith added a comment. Looks reasonable, can you add a testcase that shows the ODR checker now distinguishes pointers/references to distinct types? Comment at: lib/AST/ODRHash.cpp:581 + void VisitType(const Type *T) { +ID.AddInteger(T->getTypeClass()); + } -

r325994 - [Sema][ObjC] Process category attributes before checking protocol uses

Author: arphaman Date: Fri Feb 23 15:49:43 2018 New Revision: 325994 URL: http://llvm.org/viewvc/llvm-project?rev=325994&view=rev Log: [Sema][ObjC] Process category attributes before checking protocol uses This ensures that any availability attributes are attached to the category before the avail

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

zturner created this revision. zturner added a reviewer: rnk. Although the supported way of invoking clang on Windows is via the cl driver, some people may wish to use the g++ driver. and manually specify `-gcodeview`. This codepath is currently broken, as it will cause column information to be

[PATCH] D42766: [DebugInfo] Support DWARFv5 source code embedding extension

probinson added a comment. Looks generally straightforward. I'd give other people a chance to chime in but I have only minor comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:411 // If the location is not valid then use main input file. -return DBuilder.createFile(re

r325997 - [ExprConstant] Fix crash when initialize an indirect field with another field.

Author: vsapsai Date: Fri Feb 23 15:59:20 2018 New Revision: 325997 URL: http://llvm.org/viewvc/llvm-project?rev=325997&view=rev Log: [ExprConstant] Fix crash when initialize an indirect field with another field. When indirect field is initialized with another field, you have MemberExpr with CXXT

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

This revision was automatically updated to reflect the committed changes. Closed by commit rC325997: [ExprConstant] Fix crash when initialize an indirect field with another field. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D42498?vs=135708&id=135725#

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325997: [ExprConstant] Fix crash when initialize an indirect field with another field. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. Seems good to me! I'll give it a test on my end. One alternate implementation idea though, what if you defaulted EmitCodeView to the hasArg check instead of false, then removed the `else *EmitCodeView = false;` block on line 4999? https://reviews.llvm.org/D43700 ___

r325998 - Add another test for PR36157.

Author: rsmith Date: Fri Feb 23 16:00:58 2018 New Revision: 325998 URL: http://llvm.org/viewvc/llvm-project?rev=325998&view=rev Log: Add another test for PR36157. Modified: cfe/trunk/test/Sema/vla.c Modified: cfe/trunk/test/Sema/vla.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

vsapsai added a comment. Thanks for the review. Explicit `this` usage is a good test, added it. Checked that it happened to work with my previous approach because initializer was `CXXDefaultInitExpr` with expression ImplicitCastExpr 0x7fe966808c40 'void *' `-CXXThisExpr 0x7fe966808c28 'str

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

zturner added a comment. In https://reviews.llvm.org/D43700#1018042, @colden wrote: > Seems good to me! I'll give it a test on my end. > > One alternate implementation idea though, what if you defaulted EmitCodeView > to the hasArg check instead of false, then removed the `else *EmitCodeView =

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

colden added a comment. In https://reviews.llvm.org/D43700#1018087, @zturner wrote: > In https://reviews.llvm.org/D43700#1018042, @colden wrote: > > > Seems good to me! I'll give it a test on my end. > > > > One alternate implementation idea though, what if you defaulted > > EmitCodeView to the

[PATCH] D43696: Reduce hash collisions for reference and pointer types

rtrieu added inline comments. Comment at: lib/AST/ODRHash.cpp:581 + void VisitType(const Type *T) { +ID.AddInteger(T->getTypeClass()); + } rsmith wrote: > This looks redundant, the above `Visit(const Type*)` function seems to > already do this. That's corr

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 135744. enyquist added a comment. Rebased on current master. No functional changes, just a minor conflict where a variable got re-named Repository: rL LLVM https://reviews.llvm.org/D28462 Files: docs/ClangFormatStyleOptions.rst include/clang/Format

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore updated this revision to Diff 135745. stephanemoore marked 3 inline comments as done. stephanemoore added a comment. Removed the regex from the diagnostic ✂️ Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43581 Files: clang-tidy/google/GlobalVariableDeclarationC

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

stephanemoore marked 2 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl-

r326014 - [CFG] Provide construction contexts for lifetime-extended temporaries.

Author: dergachev Date: Fri Feb 23 18:00:30 2018 New Revision: 326014 URL: http://llvm.org/viewvc/llvm-project?rev=326014&view=rev Log: [CFG] Provide construction contexts for lifetime-extended temporaries. When constructing a temporary that is going to be lifetime-extended through a MaterializeT

  1   2   >