sammccall added inline comments.
================ Comment at: clangd/TUScheduler.cpp:324 + if (*Deadline) + RequestsCV.wait_until(Lock, **Deadline); + else ---------------- ilya-biryukov wrote: > It looks like if we unwrap `Optional<Deadline>` to `Deadline`, we could > replace this code with `wait` helper from `Threading.h`. > The tracing code (e.g. `if (!Requests.empty) { /*...*/}`) could be changed to > log only when `*Deadline - steady_clock::now()` is positive. > Will probably make the code simpler. WDYT? Made Deadline a real type, and added a wait() overload without a condition. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits