aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:26
+.bind("base")),
+ anyOf(isClass(), ast_matchers::isStruct()),
+ ast_matchers::isDe
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me, but you should wait a few days to commit in case
someone more into CodeGen has comments.
Your choice on updating the code you factored into a functio
aaron.ballman updated this revision to Diff 133791.
aaron.ballman added a comment.
Added the remaining ObjC, NS, and CF attributes. I think that's the last of the
Apple-related attributes (I plan to continue to work on the other attributes as
well, but in separate patches). @rjmccall, do you see
Author: asmith
Date: Sat Feb 10 13:28:55 2018
New Revision: 324824
URL: http://llvm.org/viewvc/llvm-project?rev=324824&view=rev
Log:
Fix test clang-diff-json.cpp
Summary:
This test would fail if the python path had spaces. Add a quote around the path
to fix this problem and update some test valu
dim added a comment.
LGTM minus a few nits, though it would be nice if you can verify that all the
changed headers still compile in `-std=c++98` and/or `-std=gnu++98` mode.
Comment at: include/functional:1573
return &__f_.first();
-return (const void*)0;
+retu
saar.raz updated this revision to Diff 133799.
saar.raz added a comment.
- Addressed comments: Added semantic tests for value and template concepts,
removed extra period and modified CSE ctor to fit in nicer.
Repository:
rC Clang
https://reviews.llvm.org/D41217
Files:
include/clang/AST/De
yaxunl created this revision.
yaxunl added reviewers: t-tye, b-sumner, arsenm.
Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl.
https://reviews.llvm.org/D43171
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/Basic/Targets/AMDGPU.cpp
test/CodeGen/target-data.c
test/Cod
jroelofs added a comment.
Is it worth adding `-Werror=zero-as-null-pointer-constant` to the build?
Repository:
rCXX libc++
https://reviews.llvm.org/D43159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
EricWF added inline comments.
Comment at: CMakeLists.txt:141
+set(LIBCXX_CXX_ABI_LIBNAME "libcxxrt")
+set(LIBCXX_CXX_ABI_INCLUDE_PATHS "/usr/include/c++/v1")
else()
Actually, I'm not sure how much I love having other libc++ header on the
include path.
EricWF added inline comments.
Comment at: CMakeLists.txt:141
+set(LIBCXX_CXX_ABI_LIBNAME "libcxxrt")
+set(LIBCXX_CXX_ABI_INCLUDE_PATHS "/usr/include/c++/v1")
else()
EricWF wrote:
> Actually, I'm not sure how much I love having other libc++ header on th
EricWF added a comment.
So my main concern with this patch is that `nullptr` is actually `#defined`'ed
in C++03 mode. That definition comes from the `__nullptr` header, and therefore
we would need to add that header to each include which uses it. Which kind of
sucks.
Repository:
rCXX libc+
Author: marshall
Date: Sun Feb 11 13:51:49 2018
New Revision: 324851
URL: http://llvm.org/viewvc/llvm-project?rev=324851&view=rev
Log:
Fix a typo in the synopsis comment. NFC. Thanks to K-ballo for the catch
Modified:
libcxx/trunk/include/utility
Modified: libcxx/trunk/include/utility
URL:
tvanslyke added a comment.
Hello. I would just like to follow up on the status of this patch. Is there
anything else that is needed from me? I just want to make sure that nobody is
waiting on me for anything; I'm still not 100% familiar with the process.
Thanks in advance.
https://reviews
Author: ericwf
Date: Sun Feb 11 13:57:25 2018
New Revision: 324852
URL: http://llvm.org/viewvc/llvm-project?rev=324852&view=rev
Log:
Mark two issues as complete
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm
Author: ericwf
Date: Sun Feb 11 14:00:19 2018
New Revision: 324853
URL: http://llvm.org/viewvc/llvm-project?rev=324853&view=rev
Log:
Fix libcxx MSVC C++17 redefinition of 'align_val_t'
Patch from charli...@outlook.com
Reviewed as https://reviews.llvm.org/D42354
When the following command i
EricWF closed this revision.
EricWF added a comment.
Committed as r324853.
Repository:
rCXX libc++
https://reviews.llvm.org/D42354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dim
Date: Sun Feb 11 14:31:05 2018
New Revision: 324855
URL: http://llvm.org/viewvc/llvm-project?rev=324855&view=rev
Log:
Add default C++ ABI libname and include paths for FreeBSD
Summary:
As noted in a discussion about testing the LLVM 6.0.0 release candidates
(with libc++) for FreeBSD,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324855: Add default C++ ABI libname and include paths for
FreeBSD (authored by dim, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43166
Files:
dim added a comment.
In https://reviews.llvm.org/D43159#1004625, @EricWF wrote:
> So my main concern with this patch is that `nullptr` is actually
> `#defined`'ed in C++03 mode. That definition comes from the `__nullptr`
> header, and therefore we would need to add that header to each include
nruslan added a comment.
@craig.topper, @MatzeB, @hans: Can someone take a look at this change?
Repository:
rC Clang
https://reviews.llvm.org/D43108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
kito-cheng added a comment.
Hi Eli:
> but you want to make int128_t opt-in to avoid the possibility of someone
> getting a link error trying to link code built with clang against libgcc.a?
Yes, that's the problem we want to avoid, and we actually get the problem if we
built libc (newlib) with
kito-cheng added inline comments.
Comment at: lib/Basic/Targets/RISCV.h:85
+ bool hasInt128Type(const LangOptions &Opts) const override {
+return Opts.UseInt128;
+ }
efriedma wrote:
> Maybe make this a cross-platform flag, rather than riscv-specific?
+1, th
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
No, this LGTM.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Fznamznon added a comment.
Yes, we don't have anything OpenCL specific for atomic pointers.
But we have OpenCL specific in pointers and atomics separately and we have
address spaces.
Why not to test all at once?
Repository:
rC Clang
https://reviews.llvm.org/D42844
___
24 matches
Mail list logo
