lebedev.ri added inline comments.
Comment at: test/SemaCXX/constexpr-default-arg.cpp:3
+
+// expected-no-diagnostics
+
Down the line, it won't be obvious *what* this testcase is checking.
At the very least wrap it into `namespace rdar_problem_36505742 {}`
https
sammccall added a comment.
In https://reviews.llvm.org/D41102#994311, @juliehockett wrote:
> I'm going to take a stab at refactoring the serialization part of this next
> -- rather than keeping it all in memory and dumping it at the end, it should
> serialize as it goes and do some sort of redu
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Thu, Feb 1, 2018 at 2:42 AM, Richard Smith wrote:
> On 31 January 2018 at 16:42, Shoaib Meenai via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Is this viable for backporting to 6.0? It fixes a bug that's been hit in
>> various forms by quite a few people: https://bugs.llvm.org/show
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:78
{"documentHighlightProvider", true},
+{"configurationChangeProvider", true},
{"renameProvider", true},
simark wrote:
> ilya-biryukov wrote:
> > si
MTC created this revision.
MTC added reviewers: NoQ, dcoughlin.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
Herald added a reviewer: george.karpenkov.
MTC edited the summary of this revision.
`VisitCommonDeclRefExpr()` should accept the ExplodedNode in `CheckedSet` as an
Author: sammccall
Date: Thu Feb 1 02:01:25 2018
New Revision: 323949
URL: http://llvm.org/viewvc/llvm-project?rev=323949&view=rev
Log:
[clangd] Use pthread instead of thread_local to support more runtimes.
Summary:
thread_local has nice syntax and semantics, but requires __cxa_thread_atexit,
and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323949: [clangd] Use pthread instead of thread_local to
support more runtimes. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
krasimir added a comment.
Looks good! Just some comments for the include guard states would be helpful.
Comment at: lib/Format/UnwrappedLineParser.h:259
+IG_Rejected,
+ };
+
Please put a short comment explaining each of these states.
Repository:
rC Cla
Typz updated this revision to Diff 132341.
Typz added a comment.
If the template declaration spans multiple lines, force wrap before the
function/class declaration
Repository:
rC Clang
https://reviews.llvm.org/D42684
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.c
Typz created this revision.
Typz added reviewers: krasimir, djasper, klimek.
There should be no extra indent when wrapping only the expression used
as last argument. This is consistent with the behavior when the first
(and only) argument's expression is wrapped.
foo(a, bb +
sdesmalen marked an inline comment as done.
sdesmalen added a comment.
Thanks for your review @aprantl!
https://reviews.llvm.org/D41698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323952: [DebugInfo] Enable debug information for C99 VLA
types (authored by s.desmalen, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41698?vs=132275&id=132350#toc
Repository:
rC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323952: [DebugInfo] Enable debug information for C99 VLA
types (authored by s.desmalen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41698?
miyuki updated this revision to Diff 132352.
miyuki edited the summary of this revision.
miyuki added a comment.
Updated __parse_QUOTED_CHAR_ERE. Added more test cases.
https://reviews.llvm.org/D42693
Files:
include/regex
test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp
Index: t
miyuki added inline comments.
Comment at: include/regex:3490
{
switch (*__temp)
{
mclow.lists wrote:
> Do we need any more cases here?
Probably not, but we should throw an exception here as well.
https://reviews.ll
djasper added a comment.
I am against this change. The current behavior here is intentional and IMO more
consistent. If there is more than one precedence level in a set of parentheses,
we add the additional indentation. If you don't like it, surround it with extra
parentheses.
Generally, it'd
Author: ioeric
Date: Thu Feb 1 04:44:52 2018
New Revision: 323957
URL: http://llvm.org/viewvc/llvm-project?rev=323957&view=rev
Log:
[clangd] Fix URI scheme conflict and an unused variable warning in tests. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra
Typz added a comment.
I doubt this particular was intentional, esp. since this case never happens in
the tests. I think it is more a side-effect of the (general) indent in "fake"
parenthesis.
Here is an exemple:
Before this change:
foo(a, bb +
c);
Author: hokein
Date: Thu Feb 1 05:06:58 2018
New Revision: 323960
URL: http://llvm.org/viewvc/llvm-project?rev=323960&view=rev
Log:
[clangd] remove the unused code NFC.
Modified:
clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp
Modified: clang-tools-extra/trunk/unittests/cl
bkramer added inline comments.
Comment at: lib/Tooling/Tooling.cpp:404
if (CompileCommandsForFile.empty()) {
// FIXME: There are two use cases here: doing a fuzzy
// "find . -name '*.cc' |xargs tool" match, where as a user I don't care
ioeric w
devnexen added a comment.
Another example with pcre2, more specifically its JIT engine
In file included from
/home/dcarlier/Contribs/php-src/ext/pcre/pcre2lib/pcre2_jit_compile.c:78:
In file included from
/home/dcarlier/Contribs/php-src/ext/pcre/pcre2lib/sljit/sljitLir.c:261:
/home/dcarl
ioeric added inline comments.
Comment at: lib/Tooling/Tooling.cpp:404
if (CompileCommandsForFile.empty()) {
// FIXME: There are two use cases here: doing a fuzzy
// "find . -name '*.cc' |xargs tool" match, where as a user I don't care
bkramer w
thakis added a comment.
The powers that be updated the SDK on the chromium clang bots, so we need some
solution for this issue soon.
The approach in this patch should work, but it seems conservative. Now libc++
only uses utimesat() if it's built with a deployment target of macOS 10.13. But
if
mzeren-vmw added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:244
PPBranchLevel = -1;
- IfNdefCondition = nullptr;
- FoundIncludeGuardStart = false;
- IncludeGuardRejected = false;
+ IncludeGuard = IG_Inited;
+ IncludeGuardToken = nullptr;
-
djasper added a comment.
You might doubt it, but having written the code I can tell you that it's the
case. Shame on me for not writing a test, though.
I see the argument why this indentation is not necessary in exactly the case
where the last parameter is multi-line and not wrapped to a new li
Typz added a comment.
> You might doubt it, but having written the code I can tell you that it's the
> case.
Ok, you win :-)
> I see the argument why this indentation is not necessary in exactly the case
> where the last parameter is multi-line and not wrapped to a new line itself:
> You alwa
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
ilya-biryukov wrote:
> simark wrote:
> > simark wrote:
> > > ilya-biryukov wrote:
> > >
djasper added a comment.
I don't mean trivial with a diff. What I mean is, users will find it surprising
if whether or not a parameter gets wrapped leads to a different indentation
internal to that parameter. I have not heard of a single user that would be
surprised by this extra indentation.
Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.
Can you please add a summary that describes which filesystem this problem can
be seen with? I think outside people can't access rdar tickets, so I can only
guess that it's relate
djasper added a comment.
Ah, Manuel and Krasimir are already on this thread, maybe they can comment? I
also added Chandler and Sam who I know care about formatting somewhat.
Repository:
rC Clang
https://reviews.llvm.org/D42787
___
cfe-commits ma
Typz added a comment.
> I don't think cases where there is only a semicolon-less macro are
> particularly frequent/important either. You probably could even add a
> semicolon in those cases, right? How frequent are such cases in your
> codebase? Either way, they aren't fixed by this patch, so t
Author: marshall
Date: Thu Feb 1 06:54:25 2018
New Revision: 323971
URL: http://llvm.org/viewvc/llvm-project?rev=323971&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/libcxx/experimental/optional/
libcxx/trunk/test/std/exp
djasper added a comment.
- Of course you find all sorts of errors while testing clang-format on a
large-enough codebase. That doesn't mean that users run into them much.
- We have had about 10k clang-format users internally for several years. The
semicolon issue comes up but really rarely and if
robot added a comment.
In https://reviews.llvm.org/D42644#993506, @kubamracek wrote:
> Cool. Can we get a lit test as well?
This is our first patch so we're unfamiliar with the LLVM testing
infrastructure. Could you please tell us what kind of test you'd like? An
example would also be great.
Author: dfukalov
Date: Wed Jan 31 10:49:49 2018
New Revision: 323896
URL: http://llvm.org/viewvc/llvm-project?rev=323896&view=rev
Log:
Revert "[AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions"
This reverts https://reviews.llvm.org/rL323890
This reverts commit 251524ebd8c346a936f0e74b09d
Author: s.desmalen
Date: Thu Feb 1 04:27:13 2018
New Revision: 323956
URL: http://llvm.org/viewvc/llvm-project?rev=323956&view=rev
Log:
Reverting patch rL323952 due to build errors that I
haven't encountered in local builds.
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
cfe/trunk/lib/Cod
Author: s.desmalen
Date: Thu Feb 1 03:25:10 2018
New Revision: 323952
URL: http://llvm.org/viewvc/llvm-project?rev=323952&view=rev
Log:
[DebugInfo] Enable debug information for C99 VLA types
Summary:
This patch enables debugging of C99 VLA types by generating more precise
LLVM Debug metadata, us
mzeren-vmw updated this revision to Diff 132394.
mzeren-vmw added a comment.
- Add comments to IncludeGuardState.
- Fix re-initialization of IncludeGuard in UnwrappedLineParser::reset.
- Remove unnecessary block after if.
- Rebase
Repository:
rC Clang
https://reviews.llvm.org/D42035
Files:
Author: marshall
Date: Thu Feb 1 07:21:14 2018
New Revision: 323972
URL: http://llvm.org/viewvc/llvm-project?rev=323972&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/libcxx/experimental/any/
libcxx/trunk/test/std/experime
mzeren-vmw updated this revision to Diff 132395.
mzeren-vmw added a comment.
- Reviewers: drop euhlmann, add djasper
- Rebase
- Ping
Repository:
rC Clang
https://reviews.llvm.org/D42034
Files:
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
Author: marshall
Date: Thu Feb 1 07:49:27 2018
New Revision: 323975
URL: http://llvm.org/viewvc/llvm-project?rev=323975&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/std/experimental/numeric/
Modified:
libcxx/trunk/includ
ioeric created this revision.
ioeric added reviewers: sammccall, hokein.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42796
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorT
jyknight added a comment.
Is there some way to figure out what's going on in
clang-x86_64-linux-selfhost-modules?
I believe there should be no linux builders which are missing this function --
it was added to libgcc in 4.8, and we don't support older versions, so I think
missing this function
yaxunl created this revision.
yaxunl added reviewers: gregrodgers, jlebar, b-sumner, t-tye, arsenm.
Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl, jholewinski.
Currently CUDA toolchain only supports nvptx.
This patch will let CUDA toolchain support amdgpu target. It can also
Author: marshall
Date: Thu Feb 1 08:36:08 2018
New Revision: 323979
URL: http://llvm.org/viewvc/llvm-project?rev=323979&view=rev
Log:
Remove std::experimental::sample; use std::sample instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/std/experimental/algori
benhamilton added a comment.
Ping! Any comments?
Repository:
rC Clang
https://reviews.llvm.org/D42704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:69
+// qualifier. Inline namespaces and unscoped enums are skipped.
+llvm::Expected getScope(const NamedDecl *ND) {
+ llvm::SmallVector Contexts;
There is a `SuppressUnwrittenScope` optio
Author: alexfh
Date: Thu Feb 1 08:39:12 2018
New Revision: 323980
URL: http://llvm.org/viewvc/llvm-project?rev=323980&view=rev
Log:
[clang-tidy] misc-redundant-expression: fix a crash under ubsan
Modified:
clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tools-e
Using runtime availability checking doesn't make sense for a system Libc++, as
you point out. If we add runtime checks they ought to be non-default, and
hidden behind configuration flags.
Also, do I remember correctly that __builtin_available requires linking against
Foundation (and thus the O
Hahnfeld added a comment.
Only commenting on parts that I'm a bit familiar with. In general, does it make
sense to split this patch, are there different "stages" of support? Like 1)
being able to compile an empty file, 2) generate optimized code, 3) allow using
math functions?
==
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice catch, and nice fix! Might be worth adding a motivating example to the
patch description.
Comment at: clangd/index/SymbolCollector.cpp:68
+// For a symbol "a::b::
(To be clear, the patch as-is is 100% fine with me.)
On Thu, Feb 1, 2018 at 11:44 AM, Duncan P. N. Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Using runtime availability checking doesn't make sense for a system
> Libc++, as you point out. If we add runtime checks they ought
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, sammccall.
Herald added subscribers: jkorous-apple, klimek.
clangd drops diagnostics coming outside the main file, but it is still
useful to see that something went wrong in the logs.
Repository:
rCTE Clang Too
sammccall requested changes to this revision.
sammccall added a comment.
This revision now requires changes to proceed.
Doh, nevermind - SuppressUnwrittenScopes is way simpler. Thanks @hokein for
catching!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42796
m.ostapenko updated this revision to Diff 132393.
m.ostapenko added a comment.
Fix scope ends order (as discussed above) and adjust a testcase.
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisDeclContext.h
include/clang/Analysis/CFG.h
include/c
yaxunl added a comment.
In https://reviews.llvm.org/D42800#994955, @Hahnfeld wrote:
> Only commenting on parts that I'm a bit familiar with. In general, does it
> make sense to split this patch, are there different "stages" of support? Like
> 1) being able to compile an empty file, 2) generate
avt77 added a comment.
In fact we have here another problem: it is not an attempt to assign to const
variable but it is an attempt to use the field assingment inside const method:
I'm working on it.
https://reviews.llvm.org/D42530
___
cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19
+
+/// Check for several deprecated types and classes from header
+///
alexfh wrote:
> aaron.ballman wrote:
> > alexfh wrote:
> > > Quuxplusone wrote:
> > > > aaron.b
chill updated this revision to Diff 132414.
chill added a comment.
Minor update, the parameter to `createEnumerator` is `IsUnsigned` now (instead
of `IsSigned`), changed caller.
https://reviews.llvm.org/D42736
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-enum.cpp
test/CodeG
arsenm added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.cpp:437
+ case CudaArch::UNKNOWN:
+assert(false && "No GPU arch when compiling CUDA device code.");
+return "";
llvm_unreachable
Comment at: lib/Driver/Tool
dblaikie added inline comments.
Comment at: test/CodeGen/debug-info-enum.cpp:2
+// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s
+enum class E0 : signed char {
+ A0 = -128,
Could you summarize the purpose of each of these tests (possib
Author: adrian
Date: Thu Feb 1 10:10:20 2018
New Revision: 323986
URL: http://llvm.org/viewvc/llvm-project?rev=323986&view=rev
Log:
Mark fallthrough with LLVM_FALLTHROUGH
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp
URL:
http://llvm.
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdUnit.cpp:182
+ SmallString<64> Message;
+ D.FormatDiagnostic(Message);
+
does Message include file:line? we probably wan
tra added a comment.
I don't have enough knowledge about compute on AMD's GPU and would appreciate
if you could share your thoughts on how you think CUDA on AMD should work. Is
there a good document describing how compute currently works (how do I launch a
kernel using rough equivalent of nvidi
dcasadevall added a comment.
Was this lost in the woods? I believe this is a valid change when working in
Objective-C
https://reviews.llvm.org/D17700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
kubamracek added a comment.
> This is our first patch so we're unfamiliar with the LLVM testing
> infrastructure. Could you please tell us what kind of test you'd like? An
> example would also be great.
Thank you for your first contribution! I'm going to comment on the testing
infrastructure o
ksuther added a comment.
It seems to have been. I've been using a modified version of clang-format with
this change applied (as well as http://reviews.llvm.org/D17922) since I
submitted this.
https://reviews.llvm.org/D17700
___
cfe-commits mailing
Author: marshall
Date: Thu Feb 1 10:45:57 2018
New Revision: 323989
URL: http://llvm.org/viewvc/llvm-project?rev=323989&view=rev
Log:
Put the exception classes for experimental::optional and experimental::any back
in the dylib for binary compatibility
Modified:
libcxx/trunk/src/any.cpp
ilya-biryukov updated this revision to Diff 132430.
ilya-biryukov added a comment.
- Show location of dropped diagnostic.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42803
Files:
clangd/ClangdUnit.cpp
Index: clangd/ClangdUnit.cpp
=
Author: ibiryukov
Date: Thu Feb 1 11:06:45 2018
New Revision: 323992
URL: http://llvm.org/viewvc/llvm-project?rev=323992&view=rev
Log:
[clangd] Log dropped diagnostics.
Summary:
clangd drops diagnostics coming outside the main file, but it is still
useful to see that something went wrong in the
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:182
+ SmallString<64> Message;
+ D.FormatDiagnostic(Message);
+
sammccall wrote:
> does Message include file:line? we probably want that in the log line.
No, it didn't include the line befor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323992: [clangd] Log dropped diagnostics. (authored by
ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42803
Files:
clang-tools-extr
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323992: [clangd] Log dropped diagnostics. (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42803?vs=132430&id=132432#toc
Repository:
rCTE Clang Tools Extra
+Hans Wennborg +tstel...@redhat.com
So the retpoline patch series we should get back ported start with this
revision and have two follow ups:
r323155
r323288
r323915
+Reid Kleckner was going to look at doing the (likely more
involved) backport to the 5 branch
On Mon, Jan 22, 2018 at 2:06
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Ew. So it means that checker transitions are currently discarded. Great catch.
I guess we don't use this functionality yet, so we can't test it, but the fix
should definitely go in.
Then, again, i'
vitalybuka added a comment.
Could you please reformat it?
With git I usually use: git clang-format -f --style=file HEAD^
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D42644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
rjmccall added a comment.
That's still just const-propagation. The const qualifier on the pointee type
of this should propagate to the l-value resulting from the member access, and
the vector-specific projection logic should continue to propagate const to the
type of the element l-value.
htt
vitalybuka added a comment.
I would not worry about cross platform here. You can patch just Linux and
whoever have access (and issues) on other platforms can send a patch with
similar changes.
Mac should use libc++.
I'd put the test outside of Posix, and mark failing platforms as "// XFAIL:",
t
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: bkramer.
It should be safe, since other code paths are already generating
implicit members even in invalid CXXRecordDecls (e.g. lookup).
If we don't generate implicit members on CXXRecordDecl's completion,
they will be generated
ilya-biryukov added a comment.
The following assertion from `DeclContext::removeDecl` was failing before:
assert((D->NextInContextAndBits.getPointer() || D == LastDecl) &&
"decl is not in decls list");
Repository:
rC Clang
https://reviews.llvm.org/D42810
___
Author: rsmith
Date: Thu Feb 1 12:01:49 2018
New Revision: 323998
URL: http://llvm.org/viewvc/llvm-project?rev=323998&view=rev
Log:
PR36157: When injecting an implicit function declaration in C89, find the right
DeclContext rather than injecting it wherever we happen to be.
This avoids creating
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:62
+
+ ExplodedNode *N = C.generateErrorNode();
+ if (!N)
You should also use `generateNonFatalErrorNode()` here so that not to prevent
the analyzer from findin
mgrang abandoned this revision.
mgrang added a comment.
For now, by setting the full triple (riscv-unknown-linux-gnu) we are able to
invoke the correct gnu linker. So will abandon this patch.
Repository:
rC Clang
https://reviews.llvm.org/D42673
NoQ updated this revision to Diff 132450.
NoQ added a comment.
Switched to plain bools and in-class initializers.
https://reviews.llvm.org/D42457
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
lib/StaticAnalyzer/Core/ExprEngin
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D42810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
erichkeane created this revision.
erichkeane added reviewers: rsmith, rjmccall.
When trying to track down a different bug, we discovered
that calling `__builtin_va_arg` on a vec3f type caused
the SROA pass to issue a warning that there was an illegal
access.
Further research showed that the vec3f
benhamilton created this revision.
benhamilton added reviewers: alexfh, hokein.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
The following Objective-C code currently incorrectly triggers
clang-tidy's performance-unnecessary-value-param check:
% cat /tmp/performance-unnecessary-valu
devnexen updated this revision to Diff 132459.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
Index: lib/StaticAnalyzer/Checkers
mattd added a comment.
Ping :)
https://reviews.llvm.org/D42549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
Hi Akira, thanks for working on this!
Comment at: lib/AST/ExprConstant.cpp:1165-1173
+ auto LB = Temporaries.lower_bound(Key);
+
+ // If an element with key Key is found, reset the value and return it. This
+ // can happen if Key is part of a
mattd created this revision.
mattd added a reviewer: rsmith.
mattd edited the summary of this revision.
This change aims to simplify debugging by annotating the range-for loop
artificial variables (range, begin, end) with the scope depth.
https://reviews.llvm.org/D42813
Files:
SemaStmt.cpp
mattd updated this revision to Diff 132464.
mattd added a comment.
Updating the diff, missed a few deltas that should have been in the original
patch.
https://reviews.llvm.org/D42813
Files:
include/clang/Sema/Scope.h
lib/Sema/SemaStmt.cpp
test/CodeGenCXX/debug-for-range-scope-hints.cpp
On Wed, Jan 31, 2018 at 7:23 PM, Paul Robinson via Phabricator <
revi...@reviews.llvm.org> wrote:
> probinson added a comment.
>
> In https://reviews.llvm.org/D42758#993936, @ruiu wrote:
>
> > > I also wonder which is better `#pragma comment(lib, "m")` or `#pragma
> comment(lib, "m")`.
> >
> > Sor
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This is actually consistent with what Microsoft does for dllimport classes.
They don't have key functions, but they do import vftables when a class is
dllimport and the constructor is inline. They n
Author: dergachev
Date: Thu Feb 1 14:17:05 2018
New Revision: 324018
URL: http://llvm.org/viewvc/llvm-project?rev=324018&view=rev
Log:
[analyzer] Don't communicate evaluation failures through memregion hierarchy.
We use CXXTempObjectRegion exclusively as a bailout value for construction
targets
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324018: [analyzer] Don't communicate evaluation
failures through memregion hierarchy. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
Author: rsmith
Date: Thu Feb 1 14:24:45 2018
New Revision: 324020
URL: http://llvm.org/viewvc/llvm-project?rev=324020&view=rev
Log:
Make std::get_temporary_buffer respect overaligned types when possible
Patch by Chris Kennelly!
Differential Revision: https://reviews.llvm.org/D41746
Added:
Author: george.karpenkov
Date: Thu Feb 1 14:25:18 2018
New Revision: 324021
URL: http://llvm.org/viewvc/llvm-project?rev=324021&view=rev
Log:
[analyzer] [tests] Add an option to show the histogram of path differences
between the analyzer runs
Differential Revision: https://reviews.llvm.org/D427
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX324020: Make std::get_temporary_buffer respect overaligned
types when possible (authored by rsmith, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41746
Files:
include/memory
1 - 100 of 138 matches
Mail list logo
