NoQ added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:62 + + ExplodedNode *N = C.generateErrorNode(); + if (!N) ---------------- You should also use `generateNonFatalErrorNode()` here so that not to prevent the analyzer from finding other bugs on that path, because your bug doesn't cause abnormal program termination or otherwise leave the analyzer in an inconsistent state. Repository: rC Clang https://reviews.llvm.org/D42645 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
