[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth added inline comments. Comment at: clangd/ClangdLSPServer.cpp:78 {"documentHighlightProvider", true}, +{"configurationChangeProvider", true}, {"renameProvider", true}, simark wrote: > I find `configurationChangeProvi

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:78 {"documentHighlightProvider", true}, +{"configurationChangeProvider", true}, {"renameProvider", true}, Nebiroth wrote: > simark wrote: > > I find `config

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai added a comment. Checked that suggested change also fixes another OSS-Fuzz bug https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4664 https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap added a comment. Herald added a reviewer: george.karpenkov. switched to checking (*I)->getType() Repository: rL LLVM https://reviews.llvm.org/D42396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r323257 - AST: correct mangling for SEL on MS ABI

Author: compnerd Date: Tue Jan 23 12:56:52 2018 New Revision: 323257 URL: http://llvm.org/viewvc/llvm-project?rev=323257&view=rev Log: AST: correct mangling for SEL on MS ABI We would previously treat `SEL` as a pointer-only type. This is not the case. It should be treated similarly to `id` and

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark updated this revision to Diff 131131. simark added a comment. Fix formatting, remove capability - Fix some formatting nits - Remove the entry in the capabilities object Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp clangd/Cla

Re: r323218 - clang-format: Support formatting Java 8 interface default methods.

Hello Nico, This commit broke one of our builders: http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4701 . . . FAILED: /usr/local/gcc-7.1/bin/g++-7.1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Fo

r323267 - Fix test Driver/solaris-ld.c

Author: rtrieu Date: Tue Jan 23 13:58:56 2018 New Revision: 323267 URL: http://llvm.org/viewvc/llvm-project?rev=323267&view=rev Log: Fix test Driver/solaris-ld.c Allow test to accept calls to ld without full path. Modified: cfe/trunk/test/Driver/solaris-ld.c Modified: cfe/trunk/test/Driver/

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

WeiChungChang added a comment. Dear mclow: Thanks a lot for your kindly reply! I would like to briefly describe the purpose of this fix here. **`This patch is in a series of 3 aimed targets.`** I could explain them item-by-item in detail with experiment. **//However, I mainly focus on algorithm

r323281 - Adjust MaxAtomicInlineWidth for i386/i486 targets.

Author: wmi Date: Tue Jan 23 15:27:57 2018 New Revision: 323281 URL: http://llvm.org/viewvc/llvm-project?rev=323281&view=rev Log: Adjust MaxAtomicInlineWidth for i386/i486 targets. This is to fix the bug reported in https://bugs.llvm.org/show_bug.cgi?id=34347#c6. Currently, all MaxAtomicInlineW

[PATCH] D42154: Don't generate inline atomics for i386/i486

This revision was automatically updated to reflect the committed changes. Closed by commit rL323281: Adjust MaxAtomicInlineWidth for i386/i486 targets. (authored by wmi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42154?vs=130076&i

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r323285 - Fix test Driver/solaris-ld.c for Windows.

Author: dyung Date: Tue Jan 23 16:05:01 2018 New Revision: 323285 URL: http://llvm.org/viewvc/llvm-project?rev=323285&view=rev Log: Fix test Driver/solaris-ld.c for Windows. - Test needs to be able to handle "clang.exe" on Windows - Test needs to be able to handle either '/' or '\\' used as the p

[PATCH] D42452: [CUDA] Disable PGO and coverage instrumentation in NVPTX.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. NVPTX does not have runtime support necessary for profiling to work and even call arc collection is prohibitively expensive. Furthermore, there's no easy way to collect the samples. NVPTX also does not supp

Buildbot numbers for the week of 1/07/2018 - 1/13/2018

Hello everyone, Below are some buildbot numbers for the week of 1/07/2018 - 1/13/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the last week of 1/14/2018 - 1/20/2018

Hello everyone, Below are some buildbot numbers for the last week of 1/14/2018 - 1/20/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

r323293 - Fix typo in comment.

Author: nico Date: Tue Jan 23 17:45:57 2018 New Revision: 323293 URL: http://llvm.org/viewvc/llvm-project?rev=323293&view=rev Log: Fix typo in comment. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp URL: http://llvm.org/viewvc/llvm-projec

Re: r323218 - clang-format: Support formatting Java 8 interface default methods.

Does 323294 help? On Tue, Jan 23, 2018 at 4:58 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Nico, > > This commit broke one of our builders: > > http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4701 > . . . > FAILED: /usr/local/gcc-7.1/bin/g++-7.1

r323294 - Attempt to fix implicit-fallthrough warning after r323218.

Author: nico Date: Tue Jan 23 17:47:22 2018 New Revision: 323294 URL: http://llvm.org/viewvc/llvm-project?rev=323294&view=rev Log: Attempt to fix implicit-fallthrough warning after r323218. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified: cfe/trunk/lib/Format/UnwrappedLinePar

[libcxx] r323296 - Implement P0463R1: 'Endian just Endian'. Reviewed as https://reviews.llvm.org/D35472

Author: marshall Date: Tue Jan 23 17:53:24 2018 New Revision: 323296 URL: http://llvm.org/viewvc/llvm-project?rev=323296&view=rev Log: Implement P0463R1: 'Endian just Endian'. Reviewed as https://reviews.llvm.org/D35472 Added: libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.

[PATCH] D35472: Implement P0463R1: "Endian just Endian"

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 323296 https://reviews.llvm.org/D35472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

dyung added a comment. LGTM! https://reviews.llvm.org/D41888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. - If we are unable to determine a good target region for a C++ constructor call, we come up with a temporary region and construct into that.

[PATCH] D42455: Don't create hidden dllimport global values

colden added a comment. Confirmed, this fixes my issue! Thanks! https://reviews.llvm.org/D42455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:570 + struct EvalCallFlags { +bool IsConstructorWithImproperlyModeledTargetRegion : 1; Those are not really flags. Perhaps options? =

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson updated this revision to Diff 131191. aemerson added a comment. I've added two kinds of warnings, one for targets which have incomplete GISel support, and another for unsupported optimisation levels (for ARM64 -O{1,2,3,s,z}). Repository: rC Clang https://reviews.llvm.org/D42276 Fi

[libcxx] r323300 - libcxx: Allow auto-linking to be disabled with a macro.

Author: pcc Date: Tue Jan 23 20:30:19 2018 New Revision: 323300 URL: http://llvm.org/viewvc/llvm-project?rev=323300&view=rev Log: libcxx: Allow auto-linking to be disabled with a macro. Some users may have a custom build system which gives a different name to the libc++ archive (or does not creat

[PATCH] D42459: [cmake] Call llvm_setup_rpath() when adding shared libraries.

hintonda created this revision. hintonda added reviewers: beanz, compnerd, phosek, EricWF. Herald added subscribers: cfe-commits, mgorny. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath usage across all projects. Repository: rCXX libc++ https://reviews

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

hintonda created this revision. hintonda added reviewers: beanz, compnerd, phosek, EricWF. Herald added subscribers: cfe-commits, mgorny. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath usage across all projects. Repository: rCXXA libc++abi https://rev

[libcxx] r323306 - include to get uint32_t

Author: marshall Date: Tue Jan 23 21:38:51 2018 New Revision: 323306 URL: http://llvm.org/viewvc/llvm-project?rev=323306&view=rev Log: include to get uint32_t Modified: libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.cpp Modified: libcxx/trunk/test/std/utilities/meta/meta.t

Please subscribe "rUNW libunwind" to cfe-commits.

Currently, herald doesn't subscribe libunwind to any group. Should it be added to cfe-commits? https://reviews.llvm.org/H268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-property-declarati

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

WeiChungChang added a comment. Here gives the comparison between GCC & LLVM's std c++ library. It is shown that libc++ soon suffers from rotate speed under limited allocated buffer and slower than GCC's corresponding version. Both LLVM & GCC run the same test program. F5782010: 0124.png

<    1   2