[PATCH] D41622: [cmake] [libcxx] Fix find_path() problems when cross compiling.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323143: [cmake] [libcxx] Fix find_path() problems when cross compiling. (authored by dhinton, committed by ). Herald added

[libcxx] r323143 - [cmake] [libcxx] Fix find_path() problems when cross compiling.

Author: dhinton Date: Mon Jan 22 11:26:38 2018 New Revision: 323143 URL: http://llvm.org/viewvc/llvm-project?rev=323143&view=rev Log: [cmake] [libcxx] Fix find_path() problems when cross compiling. When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake recommends setting CMAKE_FIND_ROOT_PATH_MO

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

alexshap created this revision. alexshap added reviewers: NoQ, dcoughlin. Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun. The check (inside StackHintGeneratorForSymbol::getMessage) if (!N) return getMessageForSymbolNotFound() is moved to the beginning of the functio

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

NoQ accepted this revision. NoQ added a reviewer: george.karpenkov. NoQ added a comment. This revision is now accepted and ready to land. Neat. I wonder if you've actually found it by running the analyzer :) Did it crash or just made sense to fix, i.e. should there be tests? Repository: rL LL

[libcxxabi] r323145 - [cmake] [libcxxabi] Fix find_path() problems when cross compiling

Author: dhinton Date: Mon Jan 22 11:41:05 2018 New Revision: 323145 URL: http://llvm.org/viewvc/llvm-project?rev=323145&view=rev Log: [cmake] [libcxxabi] Fix find_path() problems when cross compiling When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake recommends setting CMAKE_FIND_ROOT_PATH_

[PATCH] D41623: [cmake] [libcxxabi] Fix find_path() problems when cross compiling

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL323145: [cmake] [libcxxabi] Fix find_path() problems when cross compiling (authored by dhinton, committed by ). Herald a

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

alexshap added a comment. no, i have not seen any crashes related to this particular case, but i've been working on a fix for a separate issue (a bit more involved) (not far from here) (I will send a diff for review soon) and decided to clean it up as well. Repository: rL LLVM https://revi

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Do you need me to commit on your behalf? Repository: rC Clang https://reviews.llvm.org/D42213 ___ cfe-commits m

[PATCH] D42273: Add hasTrailingReturn AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D42273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp:45 + + if ((C = Result.Nodes.getNodeAs("call_expr"))) { +BeginLoc = C->getLocStart(); Can remove spurious parens. Comment at: docs/clang-t

r323146 - [analyzer] Protect against dereferencing a null pointer

Author: alexshap Date: Mon Jan 22 12:18:42 2018 New Revision: 323146 URL: http://llvm.org/viewvc/llvm-project?rev=323146&view=rev Log: [analyzer] Protect against dereferencing a null pointer The check (inside StackHintGeneratorForSymbol::getMessage) if (!N) return getMessageForSymbolNotFound(

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL323146: [analyzer] Protect against dereferencing a null pointer (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D42388?vs=130935&id=130946#toc Repository: rL

r323148 - [CodeComplete] Omit templated constructors from member list too.

Author: sammccall Date: Mon Jan 22 12:44:47 2018 New Revision: 323148 URL: http://llvm.org/viewvc/llvm-project?rev=323148&view=rev Log: [CodeComplete] Omit templated constructors from member list too. Also avoid printing a 'void' return type for constructor expressions. Modified: cfe/trunk/l

[libcxx] r323147 - Still more P0202 constexpr-ifying. This batch is: for_each/for_each_n/lexicographical_compare

Author: marshall Date: Mon Jan 22 12:44:33 2018 New Revision: 323147 URL: http://llvm.org/viewvc/llvm-project?rev=323147&view=rev Log: Still more P0202 constexpr-ifying. This batch is: for_each/for_each_n/lexicographical_compare Modified: libcxx/trunk/include/algorithm libcxx/trunk/test

[clang-tools-extra] r323149 - [clangd] Drop ~destructor completions - rarely helpful and work inconsistently

Author: sammccall Date: Mon Jan 22 13:05:00 2018 New Revision: 323149 URL: http://llvm.org/viewvc/llvm-project?rev=323149&view=rev Log: [clangd] Drop ~destructor completions - rarely helpful and work inconsistently Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp clang-tools-extr

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth added a comment. The guideline authors will focus on mixing integer length and integer signdness. > Thank you for the suggestion! Per our editor's discussion, we agree with "If > one then mixes integer lengths and signedness in calculations confusion on > what happens might occur" and

[libcxx] r323152 - Another batch of P0202 constepr algirithms. remove/remove_if/remove_copy/remove_copy_if/reverse_copy, and tests (commented out) for rotate_copy, because that depends on std::copy

Author: marshall Date: Mon Jan 22 13:43:04 2018 New Revision: 323152 URL: http://llvm.org/viewvc/llvm-project?rev=323152&view=rev Log: Another batch of P0202 constepr algirithms. remove/remove_if/remove_copy/remove_copy_if/reverse_copy, and tests (commented out) for rotate_copy, because that dep

r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injec

Author: chandlerc Date: Mon Jan 22 14:05:25 2018 New Revision: 323155 URL: http://llvm.org/viewvc/llvm-project?rev=323155&view=rev Log: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton created this revision. benhamilton added reviewers: jolesiak, krasimir. Herald added a subscriber: cfe-commits. `clang-format -dump-config path/to/file.h` never passed anything for the Code parameter to clang::format::getStyle(). This meant the logic to guess Objective-C from the cont

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

xazax.hun updated this revision to Diff 130961. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Address review comments. https://reviews.llvm.org/D42335 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp ==

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

xazax.hun added a comment. In https://reviews.llvm.org/D42335#983878, @a.sidorin wrote: > Hello Peter, > > Thank you for the patch! It is almost LGTM, just a few minor questions inline. > Am I understand correctly that it is partially based on > https://github.com/haoNoQ/clang/blob/summary-ipa-

r323156 - Reland "[CodeGen] Fix crash when a function taking transparent union is redeclared."

Author: vsapsai Date: Mon Jan 22 14:29:24 2018 New Revision: 323156 URL: http://llvm.org/viewvc/llvm-project?rev=323156&view=rev Log: Reland "[CodeGen] Fix crash when a function taking transparent union is redeclared." When a function taking transparent union is declared as taking one of union m

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

This revision was automatically updated to reflect the committed changes. Closed by commit rC323156: Reland "[CodeGen] Fix crash when a function taking transparent union is… (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41311?vs=130038&id=130964#toc R

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

This revision was automatically updated to reflect the committed changes. Closed by commit rC323157: [ASTMatchers] [NFC] Fix code examples (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42213?vs=130922&id=130965#toc Repository: rC Clang https://revi

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap created this revision. alexshap added reviewers: NoQ, dcoughlin. Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun. Do not attempt to get the pointee of void* while generating a bug report (otherwise it will trigger an assert inside RegionStoreManager::getBinding asse

r323158 - Add hasTrailingReturn AST matcher

Author: juliehockett Date: Mon Jan 22 14:45:23 2018 New Revision: 323158 URL: http://llvm.org/viewvc/llvm-project?rev=323158&view=rev Log: Add hasTrailingReturn AST matcher Adds AST matcher for a FunctionDecl that has a trailing return type. Differential Revision: https://reviews.llvm.org/D42273

[PATCH] D42273: Add hasTrailingReturn AST matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rC323158: Add hasTrailingReturn AST matcher (authored by juliehockett, committed by ). Repository: rC Clang https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/AST

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap updated this revision to Diff 130967. alexshap added a comment. indents Repository: rL LLVM https://reviews.llvm.org/D42396 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c ==

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

tra added a comment. In https://reviews.llvm.org/D42319#983377, @jlebar wrote: > How does this affect e.g. calling memcpy()? There isn't a standard library > implementation of this on nvptx, but we do want calls to memcpy() to be > lowered to llvm.memcpy so that they can be optimized. We imp

[libcxx] r323159 - Last batch of P0202 constexpr additions: includes/set_intersection/exchange

Author: marshall Date: Mon Jan 22 15:10:40 2018 New Revision: 323159 URL: http://llvm.org/viewvc/llvm-project?rev=323159&view=rev Log: Last batch of P0202 constexpr additions: includes/set_intersection/exchange Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/utility lib

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton updated this revision to Diff 130970. benhamilton added a comment. - Support AssumeFileName with stdin. Repository: rC Clang https://reviews.llvm.org/D42395 Files: test/Format/dump-config-cxx.h test/Format/dump-config-objc.h test/Format/lit.local.cfg tools/clang-format/Cl

[libcxx] r323160 - Update cxx2a status

Author: marshall Date: Mon Jan 22 15:17:20 2018 New Revision: 323160 URL: http://llvm.org/viewvc/llvm-project?rev=323160&view=rev Log: Update cxx2a status Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-project/libcx

[PATCH] D42036: [clang-format] Keep comments aligned to macros

djasper added a comment. While I agree that there is probably a bug to fix, I don't (yet) agree with what is proposed in this patch. I think a comment in between preprocessor directives should always either: - Be considered part of the code in between the #-lines - Be considered to be commentin

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

NoQ added a comment. Hmm, the original code seems quite quick-and-dirty. It, indeed, tries to blindly dereference something that's accidentally "some pointer". Could you change the type check to consider AST types instead, i.e. check that `(*I)->getType()` is a double-pointer type? And then pas

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie added a comment. In https://reviews.llvm.org/D42354#984067, @STL_MSFT wrote: > Seems reasonable to me. Thanks Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap updated this revision to Diff 130979. Repository: rL LLVM https://reviews.llvm.org/D42396 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/

[PATCH] D42376: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1579 (Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")"))) { + unsigned UnbreakableTailLength = (State.NextToken && canBreak(State)) +

[PATCH] D42036: [clang-format] Keep comments aligned to macros

mzeren-vmw added a comment. In https://reviews.llvm.org/D42036#984401, @djasper wrote: > To me, aligning with the define seems fundamentally wrong. we definitely have code that does that internally. It can also be seen in the wild e.g.: https://github.com/boostorg/config/blob/develop/include/b

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Got it, thanks for the explanation. https://reviews.llvm.org/D42319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

r323167 - NewPM: Improve/fix GCOV - which needs to run early in the pass pipeline.

Author: dblaikie Date: Mon Jan 22 17:25:24 2018 New Revision: 323167 URL: http://llvm.org/viewvc/llvm-project?rev=323167&view=rev Log: NewPM: Improve/fix GCOV - which needs to run early in the pass pipeline. Using a new extension point in the new PM, register GCOV at the start of the pipeline rat

[PATCH] D42154: Don't generate inline atomics for i386/i486

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well, my point is that the example in the linked bug is asking for 486 code-generation, which is apparently unsupported by LLVM. Anyway, it's not a good reason to hold up this patch, since

[PATCH] D35472: Implement P0463R1: "Endian just Endian"

mclow.lists updated this revision to Diff 130991. mclow.lists added a comment. Update macro checks. https://reviews.llvm.org/D35472 Files: include/type_traits test/std/utilities/meta/meta.type.synop/endian.pass.cpp Index: test/std/utilities/meta/meta.type.synop/endian.pass.cpp ===

[libcxx] r323169 - libcxx: Move Windows threading support into a .cpp file.

Author: pcc Date: Mon Jan 22 17:59:43 2018 New Revision: 323169 URL: http://llvm.org/viewvc/llvm-project?rev=323169&view=rev Log: libcxx: Move Windows threading support into a .cpp file. This allows us to avoid polluting the namespace of users of with the definitions in windows.h. Differential

[libcxx] r323170 - libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

Author: pcc Date: Mon Jan 22 18:07:27 2018 New Revision: 323170 URL: http://llvm.org/viewvc/llvm-project?rev=323170&view=rev Log: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows. This is an MSVC standard library extension. It seems like a reasona

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323170: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t*… (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

vsapsai added inline comments. Comment at: Parse/ParseTemplate.cpp:492 + // Is there just a typo in the input code? ('typedef' instead of 'typename') + if (Tok.is(tok::kw_typedef)) { +Diag(Tok.getLocation(), diag::err_expected_template_parameter); How does

[libcxx] r323171 - [cmake] Always respect existing CMAKE_REQUIRED_FLAGS when adding additional ones.

Author: dhinton Date: Mon Jan 22 19:30:23 2018 New Revision: 323171 URL: http://llvm.org/viewvc/llvm-project?rev=323171&view=rev Log: [cmake] Always respect existing CMAKE_REQUIRED_FLAGS when adding additional ones. * Previously part of https://reviews.llvm.org/D41622. Modified: libcxx/trun

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152 + llvm::sys::path::append(P, normalizeTriple(Triple)); + return P.str(); +} mcgrathr wrote: > The GCC behavior (if --with-sysroot is given to configure) is > tooldir/sys-root, not

r323177 - [NFC] fix trivial typos in comments

Author: inouehrs Date: Mon Jan 22 21:50:06 2018 New Revision: 323177 URL: http://llvm.org/viewvc/llvm-project?rev=323177&view=rev Log: [NFC] fix trivial typos in comments "the the" -> "the" Modified: cfe/trunk/include/clang/Basic/AddressSpaces.h cfe/trunk/include/clang/CodeGen/ConstantI

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe added inline comments. Comment at: docs/ReleaseNotes.rst:226 +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT) + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you observe + a measurable performance impact on one

[PATCH] D42408: [clang-format] Align preprocessor comments with #

mzeren-vmw created this revision. mzeren-vmw added reviewers: krasimir, klimek, djasper. r312125, which introduced preprocessor indentation, shipped with a known issue where "indentation of comments immediately before indented preprocessor lines is toggled on each run". For example these two forms

[PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! Maybe the assertion message could be clearer about why this is a problem though? ("binds to a temporary whose lifetime has ended" maybe?) https://reviews.llvm.org/D41977

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

wmi added a comment. Thanks for the size evaluation. I regarded the change as a natural and limited extension to the current fine-grain bitfield access mode, so I feel ok with the change. Hal, what do you think? https://reviews.llvm.org/D39053 ___

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld added inline comments. Comment at: docs/ReleaseNotes.rst:226 +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT) + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you observe + a measurable performance impact on one

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe added inline comments. Comment at: docs/ReleaseNotes.rst:226 +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT) + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you observe + a measurable performance impact on one

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld updated this revision to Diff 131004. Hahnfeld marked 3 inline comments as done. Hahnfeld added a comment. Fix `macOS`. https://reviews.llvm.org/D42352 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === ---

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe accepted this revision. omalyshe added a comment. LGTM https://reviews.llvm.org/D42352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

This revision was automatically updated to reflect the committed changes. Closed by commit rL323179: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

<    1   2