xazax.hun added a comment. In https://reviews.llvm.org/D42335#983878, @a.sidorin wrote:
> Hello Peter, > > Thank you for the patch! It is almost LGTM, just a few minor questions inline. > Am I understand correctly that it is partially based on > https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp? > Also, FYI: you can use ASTMerge and clang-import-test facilities for > testing. ASTMatchers are completely fine, but usage of imported AST samples > as Sema lookup source can uncover some subtle issues in the built AST. Yeah that is right. One reason I prefer matcher based tests because they tend to be more lightweight, but I think you are right, it is not a bad idea to utilize other tools as well. https://reviews.llvm.org/D42335 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
