[PATCH] D42360: [6.0.0 Release] Release notes for configuration files in clang

sepavloff created this revision. sepavloff added reviewers: hfinkel, hans. Repository: rC Clang https://reviews.llvm.org/D42360 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/R

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. One more Ping! https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41946: [clangd] Add support for different file URI schemas.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with some nits addressed Comment at: clangd/URI.cpp:138 + + auto Pos = Uri.find(':'); + if (Pos == llvm::StringRef::npos) ioeric wrote: > sammccal

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun added a comment. In https://reviews.llvm.org/D41535#981928, @ilya-biryukov wrote: > This looks good, but we should add a test. > Should've noticed that before, sorry for the slowing this down a bit more. > After the test is there, I'm happy to commit this change for you. II

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

bebuch added a comment. Thanks for the amazing patch! I get another error: /home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_default_handlers.cpp: In function ‘void demangling_terminate_handler()’: /home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_default_handlers.cpp:41:58: err

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:47 + +.. option:: AdditionalAcronyms + benhamilton wrote: > hokein wrote: > > It seems

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

ioeric created this revision. ioeric added a reviewer: hokein. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D42361 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp ===

[PATCH] D42362: [YAML] Plain scalars can not begin with most indicators.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: llvm-commits, ioeric, ilya-biryukov. Discovered when clangd loads YAML symbols, some symbol documentations start with indicators (e.g. "-"), but YAML prints them as plain scalars (no quotes), which make the

[PATCH] D42173: [clangd] Simplify code handling compile commands

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdUnit.h:62 +/// Information required to run clang (e.g., to parse AST or do code +/// completion). +struct ParseInputs { sa

[PATCH] D42362: [YAML] Plain scalars can not begin with most indicators.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/llvm/Support/YAMLTraits.h:524 + // ambiguity with other YAML constructs. + // FIXME: However, the “:”, “?” and “-” indicators may be used as t

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

hokein added a subscriber: bkramer. hokein added inline comments. Comment at: include/clang/Tooling/Tooling.h:331 + /// \returns 0 on success; 1 if any error occured; 2 if there is no error but + /// some files are skipped due to missing compile commands. int run(ToolAction

[PATCH] D42363: [clang-tidy] Don't generate fixes for invalid new expr location in modernize-make-unique.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: xazax.hun, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42363 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/modernize-make-unique.cpp Index: test/cl

[PATCH] D42362: [YAML] Plain scalars can not begin with most indicators.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323097: [YAML] Plain scalars can not begin with most indicators. (authored by hokein, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42362 Files: llvm/trunk/include/llvm/Support/YAMLT

[PATCH] D42362: [YAML] Plain scalars can not begin with most indicators.

hokein updated this revision to Diff 130854. hokein added a comment. Remove fixme. Repository: rL LLVM https://reviews.llvm.org/D42362 Files: include/llvm/Support/YAMLTraits.h unittests/Support/YAMLIOTest.cpp Index: unittests/Support/YAMLIOTest.cpp =

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

ioeric added inline comments. Comment at: include/clang/Tooling/Tooling.h:331 + /// \returns 0 on success; 1 if any error occured; 2 if there is no error but + /// some files are skipped due to missing compile commands. int run(ToolAction *Action); hokein wr

[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:664 + if (SS.isValid()) { // Resolved qualifier. +// FIXME: Disable Sema typo correction dureing code completion. +// The resolved qualifier might not perfectly match the written qualifier.

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

ilya-biryukov added a comment. In https://reviews.llvm.org/D41535#983435, @vladimir.plyashkun wrote: > IIUC, it will be little bit difficult to test it, because whole logic placed > in the `ClangTidyMain`. > All existing clang-tidy unit tests use direct calls of `ToolInvocation` > which is do

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4699 +else + CmdArgs.push_back("-global-isel=0"); + } qcolombet wrote: > qcolombet wrote: > > I think that it would be useful to also set -global-isel-abort=2, so that > > user

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^3 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42307: [OpenCL][6.0.0 Release] Release notes for OpenCL in Clang

svenvh accepted this revision. svenvh added inline comments. Comment at: docs/ReleaseNotes.rst:233 +- Added private address space explicitly in AST and refactored address space support + with several simplifications and bug fixes (llvm.org/pr33419 and llvm.org/pr33420). +

[PATCH] D41946: [clangd] Add support for different file URI schemas.

ioeric updated this revision to Diff 130862. ioeric marked 4 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41946 Files: clangd/CMakeLists.txt clangd/URI.cpp clangd/URI.h unittests/clangd/CMak

[PATCH] D41946: [clangd] Add support for different file URI schemas.

ioeric added inline comments. Comment at: clangd/URI.h:31 +public: + /// \brief Returns decoded scheme e.g. "https" + llvm::StringRef scheme() const { return Scheme; } sammccall wrote: > nit: prefer to omit `\brief` unless you want the brief comment to be > so

[clang-tools-extra] r323101 - [clangd] Add support for different file URI schemas.

Author: ioeric Date: Mon Jan 22 03:48:20 2018 New Revision: 323101 URL: http://llvm.org/viewvc/llvm-project?rev=323101&view=rev Log: [clangd] Add support for different file URI schemas. Summary: I will replace the existing URI struct in Protocol.h with the new URI and rename FileURI to URI in a

[PATCH] D41946: [clangd] Add support for different file URI schemas.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323101: [clangd] Add support for different file URI schemas. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41946 Files:

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer added inline comments. Comment at: lib/Tooling/Tooling.cpp:404 if (CompileCommandsForFile.empty()) { // FIXME: There are two use cases here: doing a fuzzy // "find . -name '*.cc' |xargs tool" match, where as a user I don't care This com

Re: r322984 - Allow BlockDecl in CXXRecord scope to have no access specifier.

Thanks! r323108. On Sat, Jan 20, 2018 at 12:24 AM, Richard Trieu wrote: > Hans, > > I recommend merging this revision into the release. It fixes an assertion > error when mixing modules and blocks. > > Richard > > > On Fri, Jan 19, 2018 at 12:46 PM, Richard Trieu via cfe-commits > wrote: >> >>

Re: r322813 - Fix Scope::dump()

Thanks! r323109. On Sat, Jan 20, 2018 at 12:53 AM, Richard Smith wrote: > Sounds like a good idea to me. > > On 19 Jan 2018 15:23, "Richard Trieu via cfe-commits" > wrote: >> >> Hans, >> >> I recommend merging this revision into the release. It fixes an infinite >> loop in Scope::dump() >> >> R

[clang-tools-extra] r323111 - [clangd] Try to fix build bot failue in r323101

Author: ioeric Date: Mon Jan 22 05:03:25 2018 New Revision: 323111 URL: http://llvm.org/viewvc/llvm-project?rev=323111&view=rev Log: [clangd] Try to fix build bot failue in r323101 Modified: clang-tools-extra/trunk/unittests/clangd/URITests.cpp Modified: clang-tools-extra/trunk/unittests/cla

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

hans added a comment. In https://reviews.llvm.org/D42349#983180, @Hahnfeld wrote: > @hans I'd also like to merge this to `release_60` because the support landed > before the branching. Is this ok? Sounds good to me. Go ahead and merge, or let me know and I'll do it. Repository: rC Clang h

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Sounds good to me. Comment at: docs/ReleaseNotes.rst:230 + applications, please rebuild the runtime library with `-DLIBOMP_OMPT_SUPPORT=OFF` + and file a bug at `LLVM's Bugzil

[PATCH] D42360: [6.0.0 Release] Release notes for configuration files in clang

hans added a comment. Would it be possible to include a link to the documentation for configuration files? Repository: rC Clang https://reviews.llvm.org/D42360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[clang-tools-extra] r323112 - Fix MSVC implicit double-float truncation warning. NFCI.

Author: rksimon Date: Mon Jan 22 05:15:16 2018 New Revision: 323112 URL: http://llvm.org/viewvc/llvm-project?rev=323112&view=rev Log: Fix MSVC implicit double-float truncation warning. NFCI. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/clangd/Co

[PATCH] D42307: [OpenCL][6.0.0 Release] Release notes for OpenCL in Clang

hans accepted this revision. hans added a comment. Looks good to me (though hyperlinks would be nice). Go ahead and commit directly to the branch, or let me know if you'd like me to do it. Comment at: docs/ReleaseNotes.rst:224 +- All function calls are marked by the convergent

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe added inline comments. Comment at: docs/ReleaseNotes.rst:227 + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. Performance + measurements show that the changes result in a slowdown of at most 4 percent + in micro-benchmarks. However, if you observe a

r323115 - [analyzer] Model and check unrepresentable left shifts

Author: xazax Date: Mon Jan 22 05:32:10 2018 New Revision: 323115 URL: http://llvm.org/viewvc/llvm-project?rev=323115&view=rev Log: [analyzer] Model and check unrepresentable left shifts Patch by: Reka Nikolett Kovacs Differential Revision: https://reviews.llvm.org/D41816 Modified: cfe/trun

[PATCH] D41816: [analyzer] Model and check unrepresentable left shifts

This revision was automatically updated to reflect the committed changes. Closed by commit rC323115: [analyzer] Model and check unrepresentable left shifts (authored by xazax, committed by ). Changed prior to commit: https://reviews.llvm.org/D41816?vs=129905&id=130868#toc Repository: rC Clan

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev created this revision. kosarev added reviewers: rjmccall, hfinkel. kosarev added a project: clang. Herald added a subscriber: llvm-commits. This patch does two things. First, it fixes creating TBAA access descriptors for may_alias-marked access types. Currently, for such types we generate

[PATCH] D42363: [clang-tidy] Don't generate fixes for invalid new expr location in modernize-make-unique.

ilya-biryukov added a comment. Should we fix the endloc bug instead? Or is that too hard? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D42360: [6.0.0 Release] Release notes for configuration files in clang

sepavloff updated this revision to Diff 130870. sepavloff added a comment. Use web link to reference documentation Repository: rC Clang https://reviews.llvm.org/D42360 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ==

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie updated this revision to Diff 130871. https://reviews.llvm.org/D42354 Files: include/new Index: include/new === --- include/new +++ include/new @@ -160,6 +160,7 @@ #endif // defined(_LIBCPP_BUILDING_NEW) || (_LIBCPP_

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D42349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch fixes an issue where the UnbreakableTailLength would be counted towards the length of a token during breaking, even though we can break after the token. For example, this proto text with column limit 20

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir updated this revision to Diff 130885. krasimir added a comment. - Cleanup Repository: rC Clang https://reviews.llvm.org/D42372 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestTextProto.cpp Index

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir updated this revision to Diff 130882. krasimir added a comment. - Cleanup Repository: rC Clang https://reviews.llvm.org/D42372 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestTextProto.cpp Index

[PATCH] D42360: [6.0.0 Release] Release notes for configuration files in clang

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, please commit directly to the branch of let me know if you'd like me to do it. Repository: rC Clang https://reviews.llvm.org/D42360 ___ cfe

[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

hokein updated this revision to Diff 130883. hokein marked 13 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42073 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp Index: unittes

[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

hokein added a comment. Thanks for the comments! Comment at: clangd/CodeComplete.cpp:319 +// +// FIXME: we might want to make Sema code completion smarter on handling +// unresolved qualified-id completion. sammccall wrote: > it's not totally clear to me whethe

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think we can go ahead with this. I expect code completion in the middle of a token not to be used much though, so there might be more broken cases. Repository: rC Clang https://reviews

[PATCH] D42373: [clang-format] Disable string literal breaking for text protos

krasimir created this revision. krasimir added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. Commonly string literals in protos are already multiline, so breaking them further is undesirable. Repository: rC Clang https://reviews.llvm.org/D42373 Files: lib/Format/Forma

[PATCH] D42363: [clang-tidy] Don't generate fixes for invalid new expr location in modernize-make-unique.

hokein added a comment. In https://reviews.llvm.org/D42363#983641, @ilya-biryukov wrote: > Should we fix the endloc bug instead? Or is that too hard? Yeah, we should fix the clang bug (root cause). But I think this patch still makes sense -- as we usually ignore invalid cases in clang-tidy che

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

djasper added a comment. I don't understand why the closing braces would count towards the string literals UnbreakableTailLength. Isn't that a bug? Repository: rC Clang https://reviews.llvm.org/D42372 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun updated this revision to Diff 130891. vladimir.plyashkun added a comment. Thanks, now all should be fine! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/tool/ClangTidyMain.cpp tes

r323122 - [modules] Correctly overload getModule in the MultiplexExternalSemaSource

Author: teemperor Date: Mon Jan 22 07:27:25 2018 New Revision: 323122 URL: http://llvm.org/viewvc/llvm-project?rev=323122&view=rev Log: [modules] Correctly overload getModule in the MultiplexExternalSemaSource Summary: The MultiplexExternalSemaSource doesn't correctly overload the `getModule` fu

r323123 - [DOCS] Mention OpenMP Tools Interface in runtime library

Author: hahnfeld Date: Mon Jan 22 07:27:45 2018 New Revision: 323123 URL: http://llvm.org/viewvc/llvm-project?rev=323123&view=rev Log: [DOCS] Mention OpenMP Tools Interface in runtime library Also list supported configurations (architectures + operating systems). Differential Revision: https://r

[PATCH] D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource

This revision was automatically updated to reflect the committed changes. Closed by commit rC323122: [modules] Correctly overload getModule in the MultiplexExternalSemaSource (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D39416 Files: include/clang/Se

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

This revision was automatically updated to reflect the committed changes. Closed by commit rC323123: [DOCS] Mention OpenMP Tools Interface in runtime library (authored by Hahnfeld, committed by ). Repository: rC Clang https://reviews.llvm.org/D42349 Files: docs/OpenMPSupport.rst Index: do

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

djasper added a comment. I think I understand now. I think I'd prefer pulling all of the "+ UnbreakableTailLength" calculations out of getRemainingLength so that you don't have to pass around the new parameter CanBreakAfter. Instead, only add it if necessary outside of the function.

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

Hahnfeld added a comment. In https://reviews.llvm.org/D42349#983611, @hans wrote: > In https://reviews.llvm.org/D42349#983180, @Hahnfeld wrote: > > > @hans I'd also like to merge this to `release_60` because the support > > landed before the branching. Is this ok? > > > Sounds good to me. Go ahe

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} aaron.ballman wrote: > rjmccall wrote: > > aaron.ballman wrote: > > > rjmccall wrote: > > > > aaron.ballman wrote: > > > > > rjmccall wrote: > > > > > > I

[PATCH] D42376: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D42376 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestTextProto.cpp Index: uni

[clang-tools-extra] r323130 - [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

Author: benhamilton Date: Mon Jan 22 07:45:25 2018 New Revision: 323130 URL: http://llvm.org/viewvc/llvm-project?rev=323130&view=rev Log: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms Summary: The existing option objc-property-declaration.Acronyms replaces the built-in

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir added a comment. Thanks! I created https://reviews.llvm.org/D42376 which does the same in a much simpler way! Repository: rC Clang https://reviews.llvm.org/D42372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir abandoned this revision. krasimir added a comment. Superseded by https://reviews.llvm.org/D42376 Repository: rC Clang https://reviews.llvm.org/D42372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D41311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rL323130: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323130: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42261?vs=130661&id=130899#

[PATCH] D41039: Add support for attribute "trivial_abi"

rjmccall accepted this revision. rjmccall added a comment. Looks great to me! Thanks for taking this on, it's a pretty major improvement for users. Would you like to create an issue with itanium-cxx-abi to document this, or do you want me to handle that? https://reviews.llvm.org/D41039 __

[PATCH] D42154: Don't generate inline atomics for i386/i486

rjmccall added a comment. In https://reviews.llvm.org/D42154#977991, @wmi wrote: > In https://reviews.llvm.org/D42154#977975, @efriedma wrote: > > > The LLVM backend currently assumes every CPU is Pentium-compatible. If > > we're going to change that in clang, we should probably fix the backend

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld updated this revision to Diff 130900. Hahnfeld marked 2 inline comments as done. Hahnfeld added a comment. Address review comments. https://reviews.llvm.org/D42352 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld added inline comments. Comment at: docs/ReleaseNotes.rst:230 + applications, please rebuild the runtime library with `-DLIBOMP_OMPT_SUPPORT=OFF` + and file a bug at `LLVM's Bugzilla

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

rjmccall added a comment. Thank you. Maybe there should be an overload of EmitAggregateCopy that takes LValues? A lot of these cases start with an LValue on at least one side, and there are already some convenience functions to turn an Address into a naturally-typed LValue. https://reviews.

[PATCH] D42318: [ARM] Pass _Float16 as int or float

samparker added a comment. Hi Sjoerd, Seems sensible to me to treat these two types the same way, though I must admit having different half types confuses me... So a few questions for my understanding: - What issue are you trying to workaround? -What would the ideal solution be? - Why do we

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

a.sidorin added a comment. Hello Peter, Thank you for the patch! It is almost LGTM, just a few minor questions inline. Am I understand correctly that it is partially based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp? Also, FYI: you can use ASTMerge and clang

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

koldaniel updated this revision to Diff 130905. https://reviews.llvm.org/D40787 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.h docs/ReleaseNotes

[PATCH] D42360: [6.0.0 Release] Release notes for configuration files in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL323132: [6.0.0 Release] Release notes for configuration files in clang (authored by sepavloff, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D423

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rjmccall added a comment. This is definitely something that the personality function should handle. If we want to do heroic things in the absence of personality function support, we can, but the code should at least be written to be conditional on personality support. If we can rev the person

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett updated this revision to Diff 130908. juliehockett added a comment. Adding test case -- thank you for the advice! https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/

[PATCH] D42318: [ARM] Pass _Float16 as int or float

SjoerdMeijer added a comment. Thanks for reviewing! We are trying to achieve correct AAPCS parameter passing: "If the argument is a Half-precision Floating Point Type its size is set to 4 bytes as if it had been copied to the least significant bits of a 32-bit register and the remaining bits

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenTBAA.h:67 /* BaseType= */ nullptr, /* AccessType= */ nullptr, - /* Offset= */ 0, /* Size= */ 0); + /* Offset= */ 0, /* Size= */ UINT64_MAX);

[PATCH] D42036: [clang-format] Keep comments aligned to macros

krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1725 + NextNonComment.Type == LT_ImportStatement) && + NextNonComment.Level > 0 && !Comment.InPPDirective) +return NextNonComment.First->Next && Why are we checking `NextNonC

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

sammccall added a comment. Herald added a subscriber: ioeric. So, I simultaneously think this is basically ready to land, and I want substantial changes :-) This is much better already than what we have, and where I think we can further improve the design, this is a natural point on the way. M

r323133 - [CodeComplete] Fix completion in the middle of idents in macro calls

Author: ibiryukov Date: Mon Jan 22 09:18:28 2018 New Revision: 323133 URL: http://llvm.org/viewvc/llvm-project?rev=323133&view=rev Log: [CodeComplete] Fix completion in the middle of idents in macro calls Summary: This patch removes IdentifierInfo from completion token after remembering the ident

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL323133: [CodeComplete] Fix completion in the middle of idents in macro calls (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.or

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks for adding the test! LGTM, will submit it shortly. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

aprantl added a comment. If we take https://reviews.llvm.org/D42350, taking this is fairly obvious, though it could use a testcase. Repository: rC Clang https://reviews.llvm.org/D42351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D42154: Don't generate inline atomics for i386/i486

wmi added a comment. In https://reviews.llvm.org/D42154#983840, @rjmccall wrote: > In https://reviews.llvm.org/D42154#977991, @wmi wrote: > > > In https://reviews.llvm.org/D42154#977975, @efriedma wrote: > > > > > The LLVM backend currently assumes every CPU is Pentium-compatible. If > > > we'r

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

mclow.lists added inline comments. Comment at: include/algorithm:2511 +difference_type __len1, __len2; +__len1 = __middle - __first; +__len2 = __last - __middle; These iterator calculations only work for random access iterators. Does this actually wor

[PATCH] D41039: Add support for attribute "trivial_abi"

ahatanak added a comment. Yes, please document this in itanium-cxx-abi. Thanks! https://reviews.llvm.org/D41039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

vsk added a reviewer: arphaman. vsk added a comment. In https://reviews.llvm.org/D42043#981409, @elsteveogrande wrote: > Fixes, but first, a question for reviewers: > > Looking at the description of `clang_disposeString`: > > /** >* \brief Free the given string. >*/ > CINDEX_LINKAGE v

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130922. MaskRay added a comment. Regenerate HTML docs $ cd docs/tools # yes, cd $ ./dump_ast_matchers.py Repository: rC Clang https://reviews.llvm.org/D42213 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h Index: in

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington added a comment. Ping! Repository: rCXXA libc++abi https://reviews.llvm.org/D41885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42370: Issue local statics in correct DWARF lexical scope

probinson added subscribers: cfe-commits, probinson. probinson added a comment. +cfe-commits See also the LLVM change in https://reviews.llvm.org/D42369 and a debuginfo-tests test in https://reviews.llvm.org/D42371. https://reviews.llvm.org/D42370

[PATCH] D42371: Issue local statics in correct DWARF lexical scope

probinson added subscribers: cfe-commits, probinson. probinson added a comment. +cfe-commits See also the LLVM change in https://reviews.llvm.org/D42369 and Clang change in https://reviews.llvm.org/D42370. https://reviews.llvm.org/D42371 ___ cfe-co

[libcxx] r323137 - Add (commented out) constexpr tests for copy/copy_backwards/copy_if/copy_n. These will be enabled when that part of P0202 is implemented. NFC at this time.

Author: marshall Date: Mon Jan 22 10:38:18 2018 New Revision: 323137 URL: http://llvm.org/viewvc/llvm-project?rev=323137&view=rev Log: Add (commented out) constexpr tests for copy/copy_backwards/copy_if/copy_n. These will be enabled when that part of P0202 is implemented. NFC at this time. Modi

[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:868 +} +log(Ctx, "Query scopes: ["); +for (auto &R : Req.Scopes) hokein wrote: > sammccall wrote: >

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

STL_MSFT added a comment. Seems reasonable to me. Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Thanks for working on this! Comment at: src/cxa_demangle.cpp:260-261 + +#if 0 + void dump() const { +char *Buffer = static_cast(std::malloc(1024)); ---

[libunwind] r323141 - [cmake] [libunwind] Fix find_path() problems when cross compiling

Author: dhinton Date: Mon Jan 22 11:15:06 2018 New Revision: 323141 URL: http://llvm.org/viewvc/llvm-project?rev=323141&view=rev Log: [cmake] [libunwind] Fix find_path() problems when cross compiling When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake recommends setting CMAKE_FIND_ROOT_PATH_

[PATCH] D41621: [cmake] [libunwind] Fix find_path() problems when cross compiling

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL323141: [cmake] [libunwind] Fix find_path() problems when cross compiling (authored by dhinton, committed by ). Herald a

  1   2   >