a.sidorin added a comment. Hello Peter,
Thank you for the patch! It is almost LGTM, just a few minor questions inline. Am I understand correctly that it is partially based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp? Also, FYI: you can use ASTMerge and clang-import-test facilities for testing. ASTMatchers are completely fine, but usage of imported AST samples as Sema lookup source can uncover some subtle issues in the built AST. ================ Comment at: lib/AST/ASTImporter.cpp:523 + QualType ToElementType = Importer.Import(T->getElementType()); + + if (ToElementType.isNull()) ---------------- Redundant newline? (Same below). ================ Comment at: lib/AST/ASTImporter.cpp:5829 +Expr *ASTNodeImporter::VisitCXXOperatorCallExpr(CXXOperatorCallExpr *E) { + QualType T = Importer.Import(E->getType()); ---------------- This can be merged with VisitCallExpr to avoid code duplication. Repository: rC Clang https://reviews.llvm.org/D42335 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
