[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

kongyi created this revision. kongyi added a reviewer: delesley. kongyi added a project: clang. Herald added a subscriber: cfe-commits. There are many more expr types that can be a capability expr, like CXXThisExpr, CallExpr, MemberExpr. Instead of enumerating all of them, just check typeHasCapabi

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the split & refactoring! This looks nice. Just nits, plus some thoughts on the test. Comment at: clangd/index/Index.cpp:11 #include "Index.h" - +#include "

[clang-tools-extra] r320678 - [clangd] Fix the unitttest build error on buildbot.

Author: hokein Date: Thu Dec 14 01:20:21 2017 New Revision: 320678 URL: http://llvm.org/viewvc/llvm-project?rev=320678&view=rev Log: [clangd] Fix the unitttest build error on buildbot. Modified: clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/unittes

[PATCH] D40488: [clangd] Implemented tracing using Context

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/Trace.cpp:123 + // Clone the context, so that the original Context can be moved. + this->Ctx.emplace(Ctx.clone()); + This is a

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. Herald added a subscriber: mgorny. ObjectiveC ARC in C mode currently disallows having __strong and __weak pointers in structs. This patch takes the first step towards lifting that restriction. In order to p

[PATCH] D41178: [clangd] Construct SymbolSlab from YAML format.

hokein updated this revision to Diff 126909. hokein marked 5 inline comments as done. hokein added a comment. Address the review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41178 Files: clangd/CMakeLists.txt clangd/index/Index.cpp clangd/index/Index.h clang

[PATCH] D41178: [clangd] Construct SymbolSlab from YAML format.

hokein added a comment. Thanks for the comments! Comment at: clangd/index/SymbolFromYAML.cpp:32 +// supported in YAML I/O. +struct NPArray { + NPArray(IO &) {} sammccall wrote: > what does NP stand for? Ah, P is a typo here. N stands for Normalized. Renamed it

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki updated this revision to Diff 126915. miyuki added a comment. Added a test for partial specialization. https://reviews.llvm.org/D41179 Files: lib/Sema/SemaTemplate.cpp test/SemaTemplate/class-template-spec.cpp test/SemaTemplate/function-template-specialization.cpp Index: test/Sem

[PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

xgsa added a comment. In https://reviews.llvm.org/D39622#954585, @probinson wrote: > Philosophically, mangled names and DWARF information serve different > purposes, and I don't think you will find one true solution where both of > them can yield the same name that everyone will be happy with.

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

ioeric updated this revision to Diff 126916. ioeric marked 7 inline comments as done. ioeric added a comment. - Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 Files: clangd/CMakeLists.txt clangd/index/Index.h clangd/index/MemIndex.cpp clang

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

ioeric updated this revision to Diff 126917. ioeric marked an inline comment as done. ioeric added a comment. - Fix comment for fuzzyFind Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 Files: clangd/CMakeLists.txt clangd/index/Index.h clangd/index/MemIndex.cpp cla

Re: Status of CET support? (Re: [PATCH] D40224:...)

Hi Kostya, Long time no see. :) I would estimate that everything (glibc, kernel, loader, simulator) should be available approx. February 2018 as soon as implementation finished and tested on our side. CET is enabled already in GCC, glibc branch with CET is available (https://sourceware.org/git/?p=g

[PATCH] D41178: [clangd] Construct SymbolSlab from YAML format.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Index.h:17 #include "llvm/ADT/StringExtras.h" +#include "llvm/Support/YAMLTraits.h" This isn't needed anymore (if you r

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

sammccall accepted this revision. sammccall added inline comments. Comment at: unittests/clangd/IndexTests.cpp:29 + +struct SlabAndPointers { + SymbolSlab Slab; this could be local to generateNumSymbols, up to you Comment at: unittests/clangd/

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

ioeric updated this revision to Diff 126919. ioeric marked 3 inline comments as done. ioeric added a comment. - Address more comments. # I am going to land it now. - Merge remote-tracking branch 'origin/master' into index Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 Fil

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

rsmith added a comment. I would prefer that we make the more-invasive fix, and make each error case within template argument deduction set all the deduction failure information. (Consider factoring out the error setup into helper functions too.) The current approach is a maintenance problem in

[clang-tools-extra] r320688 - [clangd] Symbol index interfaces and an in-memory index implementation.

Author: ioeric Date: Thu Dec 14 03:25:49 2017 New Revision: 320688 URL: http://llvm.org/viewvc/llvm-project?rev=320688&view=rev Log: [clangd] Symbol index interfaces and an in-memory index implementation. Summary: o Index interfaces to support using different index sources (e.g. AST index, globa

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE320688: [clangd] Symbol index interfaces and an in-memory index implementation. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D40548?vs=126919&id=126924#toc R

[PATCH] D40731: Integrate CHash into CLang

stettberger updated this revision to Diff 126925. stettberger added a comment. @rtrieu: Fixed the checking of Decl::hasAttrs() before using Decl::attrs() Repository: rC Clang https://reviews.llvm.org/D40731 Files: include/clang/AST/AttrDataCollectors.td include/clang/AST/CHashVisitor.h

[PATCH] D41178: [clangd] Construct SymbolSlab from YAML format.

hokein updated this revision to Diff 126927. hokein marked 2 inline comments as done. hokein added a comment. MappingTraits is not Symbol's friend. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41178 Files: clangd/CMakeLists.txt clangd/index/Index.cpp clangd/index/Index.

[clang-tools-extra] r320694 - [clangd] Construct SymbolSlab from YAML format.

Author: hokein Date: Thu Dec 14 04:17:14 2017 New Revision: 320694 URL: http://llvm.org/viewvc/llvm-project?rev=320694&view=rev Log: [clangd] Construct SymbolSlab from YAML format. Summary: This will be used together with D40548 for the global index source (experimental). Reviewers: sammccall

[PATCH] D41178: [clangd] Construct SymbolSlab from YAML format.

This revision was automatically updated to reflect the committed changes. Closed by commit rL320694: [clangd] Construct SymbolSlab from YAML format. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D41178?vs=126927&id=126929#toc Repository: rL LLVM http

[clang-tools-extra] r320695 - [clangd] Fix a potential use-after-move bug.

Author: ioeric Date: Thu Dec 14 04:31:04 2017 New Revision: 320695 URL: http://llvm.org/viewvc/llvm-project?rev=320695&view=rev Log: [clangd] Fix a potential use-after-move bug. Modified: clang-tools-extra/trunk/unittests/clangd/IndexTests.cpp Modified: clang-tools-extra/trunk/unittests/clan

r320696 - [Frontend] Treat function with skipped body as definition

Author: ibiryukov Date: Thu Dec 14 05:00:33 2017 New Revision: 320696 URL: http://llvm.org/viewvc/llvm-project?rev=320696&view=rev Log: [Frontend] Treat function with skipped body as definition Summary: This fixes an invalid warning about missing definition of a function when parsing with SkipFun

[PATCH] D41189: [Frontend] Treat function with skipped body as definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC320696: [Frontend] Treat function with skipped body as definition (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41189?vs=126787&id=126932#toc Repository:

r320697 - Warn if we find a Unicode homoglyph for a symbol in an identifier.

Author: rsmith Date: Thu Dec 14 05:15:08 2017 New Revision: 320697 URL: http://llvm.org/viewvc/llvm-project?rev=320697&view=rev Log: Warn if we find a Unicode homoglyph for a symbol in an identifier. Specifically, warn if: * we find a character that the language standard says we must treat as an

Re: r320697 - Warn if we find a Unicode homoglyph for a symbol in an identifier.

On Thu, Dec 14, 2017 at 8:15 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Dec 14 05:15:08 2017 > New Revision: 320697 > > URL: http://llvm.org/viewvc/llvm-project?rev=320697&view=rev > Log: > Warn if we find a Unicode homoglyph for a symbol in an identifier. > > Specifical

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41232 Files: clangd/CMakeLists.txt clangd/index/FileSymbols.cpp clangd/index/FileSymbols.h

[PATCH] D41102: Setup clang-doc frontend framework

JDevlieghere added inline comments. Comment at: tools/clang-doc/ClangDoc.h:40 + + void ParseUnattachedComments(); + bool ParseNewDecl(const NamedDecl *D); I know it's confusing given the amount of existing code that uses UpperCamelCase for functions, but I thi

[PATCH] D41102: Setup clang-doc frontend framework

JDevlieghere added a comment. I don't know what basis is used to differentiate between the two, but should this be part of clang tools or clang-tools-extra? https://reviews.llvm.org/D41102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/FileSymbols.h:39 + + /// \brief Removes snapshots of \p Path. + void remove(PathRef Path); Consider just accepting `upda

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle requested changes to this revision. malaperle added a comment. This revision now requires changes to proceed. Herald added a subscriber: mgrang. Needs to be rebased. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 ___

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

lebedev.ri added a comment. Hi. I don't want to hijack the thread, but is PR32954 likely unrelated to this fix, and the problem (if it is a bug) is likely elsewhere? Repository: rC Clang https://reviews.llvm.org/D41224 ___

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

ioeric updated this revision to Diff 126943. ioeric marked 2 inline comments as done. ioeric added a comment. - Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41232 Files: clangd/CMakeLists.txt clangd/index/FileSymbols.cpp clangd/index/FileSymbols.

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik added a comment. Ping... "Please submit as I don't have the permissions." https://reviews.llvm.org/D40072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik added a comment. Ping..."Please submit as I don't have the permissions for this." https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

ioeric updated this revision to Diff 126944. ioeric added a comment. - fix HEADER_GUARD Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41232 Files: clangd/CMakeLists.txt clangd/index/FileSymbols.cpp clangd/index/FileSymbols.h unittests/clangd/CMakeLists.txt unittests/

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

danzimm added a comment. @dexonsmith Here are my results after passing those extra flags with `-O3` (/Users/danzimm/oss/build/bin/clang -cc1 -internal-isystem /Users/danzimm/oss/build/lib/clang/6.0.0/include -nostdsysteminc -triple x86_64-apple-macosx10.12.0 -emit-llvm -disable-llvm-passes -O3

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r320701 - [clangd] Add a FileSymbols container that manages symbols from multiple files.

Author: ioeric Date: Thu Dec 14 06:50:58 2017 New Revision: 320701 URL: http://llvm.org/viewvc/llvm-project?rev=320701&view=rev Log: [clangd] Add a FileSymbols container that manages symbols from multiple files. Reviewers: sammccall Reviewed By: sammccall Subscribers: klimek, mgorny, ilya-biryu

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL320701: [clangd] Add a FileSymbols container that manages symbols from multiple files. (authored by ioeric, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41232 Files: clang-tools-ext

r320702 - Renamed test file to use proper naming convention

Author: ibiryukov Date: Thu Dec 14 06:51:17 2017 New Revision: 320702 URL: http://llvm.org/viewvc/llvm-project?rev=320702&view=rev Log: Renamed test file to use proper naming convention Also changed the order of CHECK statements. CHEKC-NOT must come before CHECK in skipped-function-bodies.cpp Ad

[PATCH] D41237: [Frontend] Handle skipped bodies in template instantiations

ilya-biryukov created this revision. ilya-biryukov added reviewers: sepavloff, bkramer. - Fixed an assert in Sema::InstantiateFunctionDefinition and added support for instantiating a function template with skipped body. - Properly call setHasSkippedBody for FunctionTemplateDecl passed to Sema::A

[PATCH] D40489: [clangd] Changed tracing interfaces

ilya-biryukov added inline comments. Comment at: clangd/Trace.cpp:134 + Callback = T->beginSpan(Ctx, Name); + if (!Callback) +return; sammccall wrote: > I'm not sure this is useful. Tracers that aren't interested in args can't opt > out by providing a null

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

danzimm added a comment. Also, I don't have commit access. Could someone else commit this for me? Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:196 + /// \brief Counter indicating how often the preamble was build in total. + unsigned PreambleCounter; + ilya-biryukov wrote: > nik wrote: > > Any better name for this one? Otherwise I

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 126950. saar.raz added a comment. - Fixed indentation problems Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/D

[PATCH] D40488: [clangd] Implemented tracing using Context

ilya-biryukov updated this revision to Diff 126951. ilya-biryukov added a comment. - Renamed TracingSession to Session (it is always used qualified via trace::Session anyway) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40488 Files: clangd/ClangdUnit.cpp clangd/JSONRPCDi

[clang-tools-extra] r320706 - [clangd] Implemented tracing using Context

Author: ibiryukov Date: Thu Dec 14 07:04:59 2017 New Revision: 320706 URL: http://llvm.org/viewvc/llvm-project?rev=320706&view=rev Log: [clangd] Implemented tracing using Context Reviewers: sammccall, ioeric, hokein Reviewed By: sammccall Subscribers: klimek, luckygeck, cfe-commits Differentia

[PATCH] D40488: [clangd] Implemented tracing using Context

This revision was automatically updated to reflect the committed changes. Closed by commit rL320706: [clangd] Implemented tracing using Context (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D40488 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 126953. saar.raz added a comment. Previous updated diff mistakenly included https://reviews.llvm.org/D40381, fixed that. Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h incl

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz marked 2 inline comments as done. saar.raz added a comment. Fixed indentations. Repository: rC Clang https://reviews.llvm.org/D41217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Frontend/PrecompiledPreamble.h:263 const MacroDirective *MD); + /// Adds list of Preprocesso

r320707 - [c++20] P0515R3: Parsing support and basic AST construction for operator <=>.

Author: rsmith Date: Thu Dec 14 07:16:18 2017 New Revision: 320707 URL: http://llvm.org/viewvc/llvm-project?rev=320707&view=rev Log: [c++20] P0515R3: Parsing support and basic AST construction for operator <=>. Adding the new enumerator forced a bunch more changes into this patch than I would hav

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added a comment. In https://reviews.llvm.org/D40548#947081, @ioeric wrote: > Hi Marc, the patch is not ready for review yet. I am still cleaning up the > prototype and will let you know when it's ready for review. I guess it was ready to review since it was submitted? ;) =

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

mclow.lists accepted this revision. mclow.lists added inline comments. This revision is now accepted and ready to land. Comment at: include/__hash_table:2141 __n = 2; else if (__n & (__n - 1)) __n = __next_prime(__n); danalbert wrote: > Wit

[PATCH] D40489: [clangd] Changed tracing interfaces

ilya-biryukov updated this revision to Diff 126957. ilya-biryukov added a comment. Merged with head Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40489 Files: clangd/Trace.cpp clangd/Trace.h Index: clangd/Trace.h ===

[PATCH] D41239: Turn a config macro (_LIBCPP_HAS_NO_INLINE_VARIABLES) into an attribute macro (_LIBCPP_INLINE_VAR)

mclow.lists created this revision. mclow.lists added a reviewer: EricWF. We're going to be defining a lot of inline variables going forward, and the current way of doing it is ... long-winded. Add an attribute macro which we can put everywhere we need, and handles the conditional. Instead of wr

[clang-tools-extra] r320708 - [clangd] Changed tracing interfaces

Author: ibiryukov Date: Thu Dec 14 07:33:38 2017 New Revision: 320708 URL: http://llvm.org/viewvc/llvm-project?rev=320708&view=rev Log: [clangd] Changed tracing interfaces Summary: EventTracer interface now contains two methods: - spanEvent for events that have duration, - instant for events that

[PATCH] D41239: Turn a config macro (_LIBCPP_HAS_NO_INLINE_VARIABLES) into an attribute macro (_LIBCPP_INLINE_VAR)

mclow.lists added a comment. There are no tests because this should not change any functionality. https://reviews.llvm.org/D41239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40489: [clangd] Changed tracing interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE320708: [clangd] Changed tracing interfaces (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D40489?vs=126957&id=126959#toc Repository: rCTE Clang Tools Ext

r320709 - When attempting to complete an incomplete array bound type in an expression,

Author: rsmith Date: Thu Dec 14 07:40:16 2017 New Revision: 320709 URL: http://llvm.org/viewvc/llvm-project?rev=320709&view=rev Log: When attempting to complete an incomplete array bound type in an expression, update the type from the definition even if we didn't instantiate a definition. We may

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I ran into a few instances of In file included from /vol/llvm/src/compiler-rt/local/test/asan/TestCases/Posix/asan-symboli

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. I forgot: this patch is on top of https://reviews.llvm.org/D35755. Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

ioeric added a comment. In https://reviews.llvm.org/D40548#955289, @malaperle wrote: > In https://reviews.llvm.org/D40548#947081, @ioeric wrote: > > > Hi Marc, the patch is not ready for review yet. I am still cleaning up the > > prototype and will let you know when it's ready for review. > > >

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. When looking at lib/Basic/Targets/OSTargets.h, I noticed that _REENTRANT is defined unconditionally on Solaris, unlike all other targets and what either Studio cc (only define it with -mt) or gcc (on

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. During make check-all on Solaris, I see several instances of this warning: clang-6.0: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Since Solaris 10, libpt

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman added a comment. In https://reviews.llvm.org/D40671#954906, @xgsa wrote: > In https://reviews.llvm.org/D40671#954661, @alexfh wrote: > > > In https://reviews.llvm.org/D40671#953888, @aaron.ballman wrote: > > > > > FWIW, I think we should do something about unknown check names in NOL

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

rsmith added a comment. Mechanically, the code change looks fine, but I can't comment on whether this is a correct change for Solaris, or whether the type provided by `__float128` would use the right floating-point representation. You will also need to provide a test for this change. Reposito

[clang-tools-extra] r320713 - Add support for NOLINT and NOLINTNEXTLINE comments mentioning specific check names.

Author: aaronballman Date: Thu Dec 14 08:13:57 2017 New Revision: 320713 URL: http://llvm.org/viewvc/llvm-project?rev=320713&view=rev Log: Add support for NOLINT and NOLINTNEXTLINE comments mentioning specific check names. Supports a comma-separated list of check names to be disabled on the give

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. Ping? The patch is ready to go, just needs a final approval... https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

benhamilton updated this revision to Diff 126969. benhamilton marked an inline comment as done. benhamilton added a comment. - Use 40 column limit for test. Repository: rC Clang https://reviews.llvm.org/D41195 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unit

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

benhamilton added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:388 + // Wrapped method parameters should be indented. + verifyFormat("- (VeryLongReturnTypeName)\n" + "veryLongMethodParameter:(VeryLongParameterName)" djasper

r320714 - [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

Author: benhamilton Date: Thu Dec 14 08:17:38 2017 New Revision: 320714 URL: http://llvm.org/viewvc/llvm-project?rev=320714&view=rev Log: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style Summary: If we write the following code, it goes over 100 columns, so we need

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

This revision was automatically updated to reflect the committed changes. Closed by commit rC320714: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41195?vs=126969&id=1

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r320713. https://reviews.llvm.org/D40671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

aaron.ballman added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virtual-inheritance] + // CHECK-NEXT: D(int valu

r320717 - [OPENMP] Add codegen for target data constructs with `nowait` clause.

Author: abataev Date: Thu Dec 14 09:00:17 2017 New Revision: 320717 URL: http://llvm.org/viewvc/llvm-project?rev=320717&view=rev Log: [OPENMP] Add codegen for target data constructs with `nowait` clause. Added codegen for the `nowait` clause in target data constructs. Modified: cfe/trunk/lib

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth updated this revision to Diff 126980. Nebiroth marked 5 inline comments as done. Nebiroth added a comment. Removed test file Added mutex lock when changing CDB Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Nebiroth updated this revision to Diff 126984. Nebiroth marked an inline comment as done. Nebiroth added a comment. Minor code cleanup Repository: rC Clang https://reviews.llvm.org/D39375 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/PrecompiledPreamble.cpp Index: li

[PATCH] D40651: Implement most of P0451 - Constexpr for std::complex

mclow.lists updated this revision to Diff 126986. mclow.lists added a comment. More context in the diff, and removed some tabs. Also commented out the constexpr tests for divide, since they fail at the moment. https://reviews.llvm.org/D40651 Files: include/complex test/std/numerics/complex

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

vitalybuka added a comment. Can you please add some details about why someone wants to customize LIBXX here? Or even better attach a patch which uses this. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 ___ cfe-commits mailing

[PATCH] D41248: [libcxx] Suppress unused warning on apple.

hintonda created this revision. hintonda added a reviewer: EricWF. This warning is already suppressed on non-apple platforms, so this change just suppresses it on apple as well. Repository: rCXX libc++ https://reviews.llvm.org/D41248 Files: src/experimental/filesystem/operations.cpp Inde

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

rjmccall closed this revision. rjmccall added a comment. Sure, r320721. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320721 - In an ARC lambda-to-block conversion thunk, reclaim the return value of

Author: rjmccall Date: Thu Dec 14 10:21:14 2017 New Revision: 320721 URL: http://llvm.org/viewvc/llvm-project?rev=320721&view=rev Log: In an ARC lambda-to-block conversion thunk, reclaim the return value of the lambda so that we don't over-release it. Patch by Dan Zimmerman! Added: cfe/trunk

r320730 - [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

Author: rnk Date: Thu Dec 14 11:00:21 2017 New Revision: 320730 URL: http://llvm.org/viewvc/llvm-project?rev=320730&view=rev Log: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic Summary: InterlockedCompareExchange128 is a bit more complicated than the other InterlockedCompareExc

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC320730: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41032?vs=126641&id=126997#toc Repository:

[PATCH] D41250: [analyzer] Model implied cast around operator new().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. C++ overridable `operator new()` has the following prototype: void *operator new(size_t size, user-defined arguments...); The retu

Re: Status of CET support? (Re: [PATCH] D40224:...)

On Thu, Dec 14, 2017 at 2:39 AM, Pavel Chupin wrote: > Hi Kostya, > Long time no see. :) > Yey!! Thanks for the update! --kcc > I would estimate that everything (glibc, kernel, loader, simulator) > should be available approx. February 2018 as soon as implementation > finished and tested on ou

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

This revision was automatically updated to reflect the committed changes. Closed by commit rC320734: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D41087?vs=126856&id=1270

r320734 - [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like

Author: arphaman Date: Thu Dec 14 11:22:02 2017 New Revision: 320734 URL: http://llvm.org/viewvc/llvm-project?rev=320734&view=rev Log: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros This patch implements the __is_target_arch, __is_target_vendor, __i

r320735 - Commit missing tests for r320734

Author: arphaman Date: Thu Dec 14 11:22:41 2017 New Revision: 320735 URL: http://llvm.org/viewvc/llvm-project?rev=320735&view=rev Log: Commit missing tests for r320734 Added: cfe/trunk/test/Preprocessor/is_target.c cfe/trunk/test/Preprocessor/is_target_arm.c cfe/trunk/test/Preprocesso

Re: r320734 - [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like

Sorry, I forgot to add the tests in SVN. I committed them in 320735 On 14 December 2017 at 11:22, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Thu Dec 14 11:22:02 2017 > New Revision: 320734 > > URL: http://llvm.org/viewvc/llvm-project?rev=320734&vie

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333-9335 + "multiversion function would have identical mangling to a previous " + "definition. Duplicate declarations must have identical target attribute " + "values">; -

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added inline comments. Comment at: clangd/index/Index.h:134 + virtual bool + fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req, +std::function Callback) const = 0; ioeric wrote: > malaperle wrote: > > I think a more generic std::function

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333 +def err_multiversion_duplicate : Error< + "multiversion function duplicate declarations require identical target " + "attributes">; aaron.ballman wrote: > instead of

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

kongyi added a comment. In https://reviews.llvm.org/D41224#955213, @lebedev.ri wrote: > Hi. > I don't want to hijack the thread, but is PR32954 > likely unrelated to this fix, > and the problem (if it is a bug) is likely elsewhere? Should be unre

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

On Thu, Dec 14, 2017 at 2:21 AM Anton via Phabricator < revi...@reviews.llvm.org> wrote: > xgsa added a comment. > > In https://reviews.llvm.org/D39622#954585, @probinson wrote: > > > Philosophically, mangled names and DWARF information serve different > purposes, and I don't think you will find o

[PATCH] D41253: [analyzer] WIP: trackNullOrUndefValue: track last store to symbolic pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. `bugreporter::trackNullOrUndefValue()` checker API function extends a bug report with a recursive family of bug report visitors (`Ret

  1   2   >