sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/Trace.cpp:123
+ // Clone the context, so that the original Context can be moved.
+ this->Ctx.emplace(Ctx.clone());
+
----------------
This is a little unfortunate. Oh, well.
================
Comment at: clangd/Trace.h:42
+/// set up before calling any clangd-specific functions.
+class TracingSession {
+public:
----------------
hmm, `trace::TracingSession` seems redundant? Up to you
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40488
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
