aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D40448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper added a comment.
-mibt isn't required for inline assembly, There's no AssemblePredicate defined
with HasIBT in X86InstrInfo.td. We don't normally do fine grained assembler
feature enabling so I believe we should always support it.
Repository:
rL LLVM
https://reviews.llvm.org/D4
pcc added inline comments.
Comment at: include/clang/Driver/Options.td:1035
HelpText<"Instrument function entry only, after inlining, without arguments
to the instrumentation call">;
-
+def finstrument_control_flow : Flag<["-"], "finstrument-control-flow">,
+ Group, Flags<[C
ioeric updated this revision to Diff 126775.
ioeric added a comment.
- Remove everything except for SymbolIndex interface and MemIndex
- Added unit tests for MemIndex
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
Files:
clangd/CMakeLists.txt
clangd/index/Index.cpp
alekseyshl added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
StringRef Sanitizer) {
+ // Solaris ld doesn't need this. Inhibit use of non-existant
+ // --export-dynamic.
Can you elaborate why Solar
Author: lichray
Date: Wed Dec 13 10:12:55 2017
New Revision: 320604
URL: http://llvm.org/viewvc/llvm-project?rev=320604&view=rev
Log:
[libcxx] Fix basic_stringbuf constructor
Summary:
[libcxx] Fix basic_stringbuf constructor
The C++ Standard [stringbuf.cons]p1 defines the effects of the basic_st
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320604: [libcxx] Fix basic_stringbuf constructor (authored
by lichray, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40707?vs=126739&id=126779#toc
Repository:
rL LLVM
https://re
miyuki added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7021
+ // C++ [temp]p6:
+ // A template, a template explicit specialization, and a class template
+ // partial specialization shall not have C linkage.
rogfer01 wrote:
> Can you add a test
erichkeane marked 17 inline comments as done.
erichkeane added a comment.
Patch incoming, Thank you very much for the review @aaron.ballman
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333-9335
+ "multiversion function would have identical mangling to a previous "
erichkeane updated this revision to Diff 126781.
erichkeane marked 2 inline comments as done.
erichkeane added a comment.
Fixed all of @aaron.ballman comments.
https://reviews.llvm.org/D40819
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKin
ilya-biryukov created this revision.
ilya-biryukov added reviewers: bkramer, sepavloff.
This fixes an invalid warning about missing definition of a function when
parsing with SkipFunctionBodies=true
Repository:
rC Clang
https://reviews.llvm.org/D41189
Files:
include/clang/AST/Decl.h
test
ilya-biryukov updated this revision to Diff 126787.
ilya-biryukov added a comment.
- Reverted accidental whitespace change.
Repository:
rC Clang
https://reviews.llvm.org/D41189
Files:
include/clang/AST/Decl.h
test/Index/skipped_function_bodies.cpp
Index: test/Index/skipped_function_bod
compnerd added inline comments.
Comment at: include/__libunwind_config.h:73
+# elif defined(_ABIN32) && defined(__mips_soft_float)
+#define _LIBUNWIND_TARGET_MIPS_NEWABI 1
+#define _LIBUNWIND_CONTEXT_SIZE 35
Minor nit: I prefer either `NABI` or `NEW_ABI`
Quuxplusone added inline comments.
Comment at: include/ostream:225
+basic_ostream& operator<<(nullptr_t)
+{ return *this << (const void*)0; }
+
mclow.lists wrote:
> lichray wrote:
> > Oh, common, I persuaded the committee to allow you to print a `(null)`
lodato updated this revision to Diff 126792.
lodato added a comment.
Re-add check for `len(commits) > 2`.
https://reviews.llvm.org/D41145
Files:
google3/third_party/llvm/llvm/tools/clang/tools/clang-format/git-clang-format
Index: google3/third_party/llvm/llvm/tools/clang/tools/clang-format/g
lodato added a comment.
Oops! Fixed. Thanks for catching this!
https://reviews.llvm.org/D41145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
It would be good to straighten out the corner case of the canonicalized vs
specified triple before merging this as that would make it harder to change.
Minor nit with the style, I'm not to
lodato updated this revision to Diff 126793.
lodato added a comment.
Update after change to https://reviews.llvm.org/D41145 that fixed `len(commits)
> 2` case.
https://reviews.llvm.org/D41147
Files:
google3/third_party/llvm/llvm/tools/clang/tools/clang-format/git-clang-format
Index: google3
pcc added a comment.
Ping.
https://reviews.llvm.org/D41036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett added inline comments.
Comment at: tools/clang-doc/ClangDocReporter.cpp:228
+ for (comments::Comment *Child :
+ llvm::make_range(C->child_begin(), C->child_end())) {
+CommentInfo ChildCI;
JonasToth wrote:
> Extract range into utility metho
juliehockett updated this revision to Diff 126797.
juliehockett marked 10 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41102
Files:
tools/CMakeLists.txt
tools/clang-doc/CMakeLists.txt
tools/clang-doc/ClangDoc.cpp
tools/clang-doc/ClangD
rogfer01 added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7021
+ // C++ [temp]p6:
+ // A template, a template explicit specialization, and a class template
+ // partial specialization shall not have C linkage.
miyuki wrote:
> rogfer01 wrote:
>
efriedma added reviewers: mgorny, efriedma, bkramer, sylvestre.ledru.
efriedma added a comment.
Adding some reviewers to hopefully find someone comfortable reviewing the Linux
multilib bits. (Not sure I'm adding the right people; this stuff hasn't been
touched for a while, as far as I can tell.
arphaman added inline comments.
Comment at: lib/Lex/PPMacroExpansion.cpp:1923
+ Tok, *this, diag::err_feature_check_malformed);
+ return II ? getTargetInfo().getTriple().getArchName().equals_lower(
+ II->getName())
c
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: test/Preprocessor/is_target_os_darwin.c:22
+
+#if __is_target_os(ios)
+ #error "mismatching os"
compnerd wrote:
> Is this supposed to be within the `MAC` clause?
Yep, this sho
ABataev updated this revision to Diff 126800.
ABataev added a comment.
Status update
Repository:
rC Clang
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/inde
JonasToth added inline comments.
Comment at: tools/clang-doc/ClangDocReporter.cpp:157
+ if (C->getNumAttrs() > 0) {
+for (unsigned i = 0, e = C->getNumAttrs(); i != e; ++i) {
+ const HTMLStartTagComment::Attribute &Attr = C->getAttr(i);
minor nit: the l
juliehockett updated this revision to Diff 126804.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Updated matcher to only match direct virtual base classes.
https://reviews.llvm.org/D40813
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyM
juliehockett added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36
+ // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that
inherits a virtual base class is disallowed [fuchsia-virtual-inheritance]
+ // CHECK-NEXT: D(int value
sbc100 added a comment.
Do you want to land this dan? Or I can if you prefer.
Repository:
rCXX libc++
https://reviews.llvm.org/D41073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
K-ballo added inline comments.
Comment at: include/ostream:225
+basic_ostream& operator<<(nullptr_t)
+{ return *this << (const void*)0; }
+
Quuxplusone wrote:
> mclow.lists wrote:
> > lichray wrote:
> > > Oh, common, I persuaded the committee to allow you
sdardis added inline comments.
Comment at: include/__libunwind_config.h:73
+# elif defined(_ABIN32) && defined(__mips_soft_float)
+#define _LIBUNWIND_TARGET_MIPS_NEWABI 1
+#define _LIBUNWIND_CONTEXT_SIZE 35
compnerd wrote:
> Minor nit: I prefer either `N
vsapsai added a comment.
Ping. The change can be still applied on trunk without changes, all tests are
passing.
https://reviews.llvm.org/D39133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
benhamilton updated this revision to Diff 126806.
benhamilton added a comment.
Herald added a subscriber: klimek.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D41074
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
halyavin added a comment.
@EricWF , could you please look at this change? It doesn't have any functional
changes.
https://reviews.llvm.org/D40775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
craig.topper added inline comments.
Comment at: include/clang/Driver/Options.td:1035
HelpText<"Instrument function entry only, after inlining, without arguments
to the instrumentation call">;
-
+def finstrument_control_flow : Flag<["-"], "finstrument-control-flow">,
+ Group,
efriedma added inline comments.
Comment at: test/CodeGen/builtins-overflow.c:402
+ int result;
+ if (__builtin_mul_overflow(y, x, &result))
+return LongLongErrorCode;
I think the rules for __builtin_mul_overflow say you have to check whether the
truncate c
sunfish added a comment.
Either way. I won't be able to get to it until next week, so feel free to land
it earlier.
Repository:
rCXX libc++
https://reviews.llvm.org/D41073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
timshen updated this revision to Diff 126813.
timshen added a comment.
Address comments:
- Generator ctor is implementable
- Format issues of tests
- SFINAE on __is_non_narrowing_convertible for arithmetics only.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/simd
libcx
timshen marked 4 inline comments as done.
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:1069
+std::is_same<_Abi, simd_abi::fixed_size>::value &&
+__is_non_narrowing_convertible<_Up, _Tp>()>::type>
+ simd(const simd<_U
benhamilton created this revision.
benhamilton added reviewers: krasimir, djasper, klimek.
Herald added a subscriber: cfe-commits.
If we write the following code, it goes over 100 columns, so we need to wrap it:
-
(VeryLongReturnTypeName)veryLongMethodParameter:(VeryLongParameterName)thisIsAVery
juliehockett updated this revision to Diff 126814.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
Fixing typos
https://reviews.llvm.org/D41102
Files:
tools/CMakeLists.txt
tools/clang-doc/CMakeLists.txt
tools/clang-doc/ClangDoc.cpp
tools/clang-doc/ClangDoc.h
juliehockett added inline comments.
Comment at: tools/clang-doc/ClangDocReporter.cpp:171
+ CurrentCI->Name = getCommandName(C->getCommandID());
+ for (unsigned i = 0, e = C->getNumArgs(); i > e; ++i)
+CurrentCI->Args.push_back(C->getArgText(i));
JonasToth w
Author: abataev
Date: Wed Dec 13 13:04:20 2017
New Revision: 320613
URL: http://llvm.org/viewvc/llvm-project?rev=320613&view=rev
Log:
[OPENMP] Add codegen for `nowait` clause in target directives.
Added basic codegen for `nowait` clauses in target-based directives.
Modified:
cfe/trunk/includ
ABataev updated this revision to Diff 126820.
ABataev added a comment.
Status update
Repository:
rC Clang
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/inde
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8145
+ case X86::BI__builtin_ia32_sqrtpd512_mask_nr:
+ case X86::BI__builtin_ia32_sqrtps512_mask_nr: {
+Function *F = CGM.getIntrinsic(Intrinsic::sqrt, Ops[0]->getType());
I would sug
erichkeane updated this revision to Diff 126829.
erichkeane added a comment.
@aaron.ballman reminded me that this should only work on ELF targets, so this
patch enforces that constraint.
https://reviews.llvm.org/D40819
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/c
Author: pcc
Date: Wed Dec 13 13:53:04 2017
New Revision: 320638
URL: http://llvm.org/viewvc/llvm-project?rev=320638&view=rev
Log:
IRGen: When performing CFI checks, load vtable pointer from vbase when
necessary.
Under the Microsoft ABI, it is possible for an object not to have
a virtual table po
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D41032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320638: IRGen: When performing CFI checks, load vtable
pointer from vbase when… (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41036?vs=126220&id=126831#toc
Reposi
spatel added a comment.
Ping * 4.
https://reviews.llvm.org/D39812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
colden added a comment.
Thanks Reid! Would you mind submitting this for me?
https://reviews.llvm.org/D41032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added inline comments.
Comment at: libcxx/include/experimental/simd:1
+#ifndef _LIBCPP_EXPERIMENTAL_SIMD
+#define _LIBCPP_EXPERIMENTAL_SIMD
Please add the license header similar to `experimental/filesystem`.
Comment at: libcxx/include/ex
rnk added a comment.
Looks good!
Repository:
rL LLVM
https://reviews.llvm.org/D41036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bsdjhb marked 2 inline comments as done.
bsdjhb added inline comments.
Comment at: src/AddressSpace.hpp:201
+inline uint64_t LocalAddressSpace::getRegister(pint_t addr) {
+#if defined(__LP64__) || (defined(__mips__) && defined(_ABIN32))
+ return get64(addr);
com
xgsa updated this revision to Diff 126826.
xgsa retitled this revision from "Fix type debug information generation for
enum-based template specialization" to "Fix type name generation in DWARF for
template instantiations with enum types and template specializations".
xgsa edited the summary of th
bsdjhb updated this revision to Diff 126841.
bsdjhb marked an inline comment as done.
bsdjhb added a comment.
- Use __SIZEOF_POINTER__ instead of __LP64__.
- Adjust comment for newabi register class.
https://reviews.llvm.org/D39074
Files:
include/__libunwind_config.h
src/AddressSpace.hpp
probinson added a comment.
Philosophically, mangled names and DWARF information serve different purposes,
and I don't think you will find one true solution where both of them can yield
the same name that everyone will be happy with. Mangled names exist to provide
unique and reproducible identi
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
george.karpenkov updated this revision to Diff 126853.
george.karpenkov edited the summary of this revision.
https://reviews.llvm.org/D40809
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
lib/StaticAnalyzer/Core
vsk added inline comments.
Comment at: test/CodeGen/builtins-overflow.c:402
+ int result;
+ if (__builtin_mul_overflow(y, x, &result))
+return LongLongErrorCode;
efriedma wrote:
> I think the rules for __builtin_mul_overflow say you have to check whether
>
vsk updated this revision to Diff 126854.
vsk marked an inline comment as done.
vsk edited the summary of this revision.
vsk added a comment.
- Handle unsigned result types.
- Extend the test driver to validate 54 different combinations of signed,
unsigned, and result types:
https://gist.github
101 - 162 of 162 matches
Mail list logo
