juliehockett added inline comments.
================ Comment at: tools/clang-doc/ClangDocReporter.cpp:171 + CurrentCI->Name = getCommandName(C->getCommandID()); + for (unsigned i = 0, e = C->getNumArgs(); i > e; ++i) + CurrentCI->Args.push_back(C->getArgText(i)); ---------------- JonasToth wrote: > Now I have a question :) > > the condition `i > e` seems odd to me. `i == 0` in the first iteration and i > expect `e > 0` so this loop should never execute or did I oversee something? > > Same below Oops my bad -- you're right. Same above/below. https://reviews.llvm.org/D41102 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
