On 10/25/2017 11:54 AM, Reid Kleckner wrote:
On Wed, Oct 25, 2017 at 10:56 AM, Friedman, Eli
mailto:efrie...@codeaurora.org>> wrote:
On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote:
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
http://llvm
aaron.ballman added a comment.
I'll let Richard comment on whether this pattern is reasonable or not, but I
have some very minor nits in the meantime.
Comment at: include/clang/AST/Decl.h:1683
// Since a Deduction Guide [C++17] will never have a body, we can share the
- //
lichray updated this revision to Diff 120295.
lichray added a comment.
One more test case
https://reviews.llvm.org/D39284
Files:
include/clang/Sema/DeclSpec.h
lib/Parse/ParseExprCXX.cpp
lib/Sema/SemaDeclCXX.cpp
test/Parser/cxx2a-decomposition.cpp
test/SemaCXX/cxx2a-decomposition.cpp
aaron.ballman added a comment.
I'm still a bit concerned about how to silence this diagnostic if the code is
actually correct. Would it make sense to diagnose `malloc(strlen(s + 1))` but
silence the diagnostic if the argument to `strlen()` is explicitly
parenthesized? That means a user could si
On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli
wrote:
> Maybe we should just ignore -fno-short-wchar, instead? I think that's
> what gcc and released versions of clang do (that means -fno-short-wchar
> doesn't do anything for Windows targets, but that's probably fine).
>
No, the intention of t
lichray added a comment.
In https://reviews.llvm.org/D39284#906899, @aaron.ballman wrote:
> We typically diagnose vendor extensions to the language, and I think we
> should apply that consistently. Otherwise, your code will compile fine in
> Clang with warning levels cranked all the way up and
Author: erichkeane
Date: Wed Oct 25 13:23:13 2017
New Revision: 316605
URL: http://llvm.org/viewvc/llvm-project?rev=316605&view=rev
Log:
Ignore implicity casts for zero-as-null-pointer-constant warning
The repro in https://bugs.llvm.org/show_bug.cgi?id=34362
caused the left nullptr to be cast to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316605: Ignore implicity casts for
zero-as-null-pointer-constant warning (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D39301?vs=120289&id=120301#toc
Repository:
rL LLVM
frutiger added a comment.
It looks like the `my_var:2:1` refers to the result from
`clang_getCursorReferenced`:
https://github.com/llvm-mirror/clang/blob/d454549fce04dfedda6cc2825b66efca94effe3f/tools/c-index-test/c-index-test.c#L709-L711.
I'm not sure what a referenced cursor is in this conte
lebedev.ri updated this revision to Diff 120305.
lebedev.ri added a comment.
Rebased now that https://reviews.llvm.org/D39301 has landed.
Repository:
rL LLVM
https://reviews.llvm.org/D38954
Files:
docs/ReleaseNotes.rst
lib/Sema/Sema.cpp
test/SemaCXX/Inputs/warn-zero-nullptr.h
test/Se
On 10/25/2017 12:49 PM, Reid Kleckner wrote:
On Wed, Oct 25, 2017 at 12:14 PM, Friedman, Eli
mailto:efrie...@codeaurora.org>> wrote:
Maybe we should just ignore -fno-short-wchar, instead? I think
that's what gcc and released versions of clang do (that means
-fno-short-wchar doesn't
dcoughlin added a comment.
I agree with Alexander here. The LLVM naming convention is not going to change
and we should err on the side of using descriptive names. How about
"FunctionBodyFarm"?
Repository:
rL LLVM
https://reviews.llvm.org/D39220
__
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:89
cast(Right)->getValue();
+
case Stmt::IntegerLiteralClass: {
I would remove the formatting changes from this function.
Comment at: c
Hm, that's a lot of overhead. Granted, it's a synthetic benchmark, but I
think it'd be good to try this on some real codebase to make sure it really
is negligible overhead in real-world scenarios.
On Wed, Oct 25, 2017 at 3:09 PM, Roman Lebedev via Phabricator via
cfe-commits wrote:
> lebedev.ri
Author: eugenis
Date: Wed Oct 25 13:39:22 2017
New Revision: 316606
URL: http://llvm.org/viewvc/llvm-project?rev=316606&view=rev
Log:
Enable -pie and --enable-new-dtags by default on Android.
Summary:
Also enable -no-pie on Gnu toolchain (previously available on Darwin only).
Non-PIE executables
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316606: Enable -pie and --enable-new-dtags by default on
Android. (authored by eugenis).
Changed prior to commit:
https://reviews.llvm.org/D38430?vs=117229&id=120306#toc
Repository:
rL LLVM
https://
Sure, I’ll add a release note.
The type for the -fno-short-wchar shouldn’t have changed on ARM. That
sounds like a mistake. We could just promote the -fsigned-wchar to a
driver level flag. Every target seems to use signed int, not unsigned int
for wchar_t.
On Wed, Oct 25, 2017 at 1:32 PM Fried
lebedev.ri added a comment.
> Hm, that's a lot of overhead. Granted, it's a synthetic benchmark, but I
> think it'd be good to try this on some real codebase to make sure it really
> is negligible overhead in real-world scenarios.
Hm wait, i'm comparing apples and oranges here, my local build a
hintonda updated this revision to Diff 120308.
hintonda added a comment.
Reimplement at a python module.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /dev/null
+++ utils/clangdiag.p
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:102
+const unsigned short Nesting; /// How deeply nested is Loc located?
+const Criteria C : 3; /// The criteria of the increment
+
lebede
mstorsjo added inline comments.
Comment at: src/UnwindRegistersRestore.S:72
+ movq 56(%rcx), %rax # rax holds new stack pointer
+ subq $16, %rax
+ movq %rax, 56(%rcx)
mstorsjo wrote:
> compnerd wrote:
> > Hmm, why is this `$16`? The `$rsp` was adjusted by
clayborg added a comment.
Looks good. A little bit of cleanup. Let me know what you think of the comments.
Comment at: utils/clangdiag.py:17
+import os
+from subprocess import check_output as qx;
+
I would rather just do:
```
import subprocess
```
Then later
aprantl created this revision.
The exisiting code goes out of its way to put block parameters into an alloca
at -O0 only, but then describes the function argument (instead of the alloca)
with a dbg.declare and the value loaded from the alloca with a dbg.value.
Describing a function argument wit
hintonda added a comment.
Thanks for the quick feedback. I'll make all you suggested changes, but need
to think a little more about `diagtool`.
Comment at: utils/clangdiag.py:75-78
+diagtool = os.path.join(exe.GetDirectory(), 'diagtool')
+if not os.path.exists(diagtoo
Author: jlebar
Date: Wed Oct 25 14:32:06 2017
New Revision: 316611
URL: http://llvm.org/viewvc/llvm-project?rev=316611&view=rev
Log:
[CUDA] Print an error if you try to compile with < sm_30 on CUDA 9.
Summary:
CUDA 9's minimum sm is sm_30.
Ideally we should also make sm_30 the default when compi
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Use the form of the command that gets an SBExecutionContext, then you can avoid
having to cache the target at all.
Comment at: utils/clangdiag.py:98-100
+def the
lebedev.ri updated this revision to Diff 120316.
lebedev.ri added a comment.
Add `Diags.isIgnored()` early return + move `C++11` early return earlier too.
At least partially should help avoid the penalty of `findMacroSpelling()`
I don't think i see any way to avoid `findMacroSpelling()` :/
Repos
jingham added a comment.
Yes definitely use names for your breakpoints. It makes them easier to handle.
Note starting a month or two ago you can set names to not get deleted except
by an explicit gesture. That hasn't shown up in releases yet, but once you can
rely on its being there, you can
clayborg added inline comments.
Comment at: utils/clangdiag.py:62
+
+def enable(debugger, args):
+# Always disable existing breakpoints
Pass exe_ctx or target into this instead of the debugger (see Jim's comment on
execution contexts below.
===
george.karpenkov added a comment.
@dcoughlin OK, I'll commit that [I assuming not doing the review would be fine
here]
Repository:
rL LLVM
https://reviews.llvm.org/D39220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: george.karpenkov
Date: Wed Oct 25 14:49:41 2017
New Revision: 316617
URL: http://llvm.org/viewvc/llvm-project?rev=316617&view=rev
Log:
[Analyzer] Give more descriptive name to BdyFrm field.
Discussion at: https://reviews.llvm.org/D39220
Modified:
cfe/trunk/include/clang/Analysis/Anal
Author: george.karpenkov
Date: Wed Oct 25 14:49:46 2017
New Revision: 316618
URL: http://llvm.org/viewvc/llvm-project?rev=316618&view=rev
Log:
[Analyzer] [Tests] Do not discard output from CmpRuns.py when running
integration tests
Contrary to the deleted comment, in most cases CmpRuns.py produce
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
In general, "I don't see any way to prevent $slow_thing" just means the patch
can't move ahead. But in this case, this looks like fairly small overhead for a
worst-case input, so this won't be
Author: arphaman
Date: Wed Oct 25 15:01:23 2017
New Revision: 316621
URL: http://llvm.org/viewvc/llvm-project?rev=316621&view=rev
Log:
Handle PragmaDebug in PPChainedCallbacks
The test is in clang-tools-extra/test/pp-trace
Modified:
clang-tools-extra/trunk/test/pp-trace/pp-trace-pragma-gener
Author: arphaman
Date: Wed Oct 25 15:01:23 2017
New Revision: 316621
URL: http://llvm.org/viewvc/llvm-project?rev=316621&view=rev
Log:
Handle PragmaDebug in PPChainedCallbacks
The test is in clang-tools-extra/test/pp-trace
Modified:
cfe/trunk/include/clang/Lex/PPCallbacks.h
Modified: cfe/tr
jingham added a comment.
Note, BTW, Enrico also added a form of the command add that allows you to use a
Python class to wrap the callable. That was in early 2015 so it's probably
safe to use as well by now. That's even more convenient, and obviates the need
for globals at all. One instance
krytarowski planned changes to this revision.
krytarowski added a comment.
Rescheduled for future. Maybe I will need to check and improve how good is this
i386 __float128 support.
Repository:
rL LLVM
https://reviews.llvm.org/D34018
___
cfe-commi
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
Build abstraction on regex's allocation
This fixes a fuzzer crasher from a huge input (provided by Marshall), which
seems to be a stackoverflow during destruction. However, I can't reproduce
Marsh
timshen updated this revision to Diff 120334.
timshen added a comment.
Add an assertion to __push.
https://reviews.llvm.org/D39308
Files:
libcxx/include/regex
Index: libcxx/include/regex
===
--- libcxx/include/regex
+++ libcxx/i
arphaman added a comment.
In https://reviews.llvm.org/D38985#906893, @sammccall wrote:
> Thanks, this looks a bunch simpler.
>
> I have a question about the direction here: AFAICS there's various efforts in
> the refactoring infrastructure to allow consumers of the Refactor libs (e.g.
> clang-r
arphaman updated this revision to Diff 120335.
arphaman added a comment.
- Refactoring operations like ExtractFunction should be declared in headers and
should contain the initiation checks.
- Refactoring actions can now be all created in one "engine" file.
- A new descriptor interface describes
arphaman updated this revision to Diff 120336.
arphaman added a comment.
Remove unused function
Repository:
rL LLVM
https://reviews.llvm.org/D38985
Files:
include/clang/Tooling/Refactoring/Extract/ExtractFunction.h
include/clang/Tooling/Refactoring/RefactoringActionRegistry.def
include
arphaman added a comment.
The updated patch introduces some redundancy between the `RefactoringAction`
and the descriptor interface. I will address this in a follow-up patch.
Repository:
rL LLVM
https://reviews.llvm.org/D38985
___
cfe-commits ma
vsapsai added inline comments.
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095
+fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType();
+ }
+
rjmccall wrote:
> vsapsai wrote:
> > rjmccall wrote:
> > > You can't just use isa<> here; there can be typ
vsapsai updated this revision to Diff 120337.
vsapsai added a comment.
- Address rjmccall review comment about nested arrays.
https://reviews.llvm.org/D38774
Files:
clang/lib/CodeGen/CGObjCMac.cpp
clang/test/CodeGenObjC/ivar-layout-flexible-array.m
Index: clang/test/CodeGenObjC/ivar-layou
hintonda updated this revision to Diff 120340.
hintonda edited the summary of this revision.
hintonda added a comment.
Herald added a subscriber: ilya-biryukov.
- Addressed comments.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
=
hintonda added inline comments.
Comment at: utils/clangdiag.py:83
+# Remove all diag breakpoints.
+bkpts = lldb.SBBreakpointList(target)
+target.FindBreakpointsByName("clang::Diagnostic", bkpts)
Can't use iterator because it gets invalidated and not a
jingham added a comment.
Ack, my bad. I should remember not to rely on my memory...
I thought at one point I was going to do it that way, then got annoyed I'd have
to have "BreakpointDisableByName" etc... So apparently I made:
SBTarget.FindBreakpointByName
that takes a name & an SBBreakpoint
vsk created this revision.
Instead of only setting a non-zero debug location on the return
instruction in *_helper_block functions, set a proper location on all
instructions within these functions. Pick the start location of the
block literal expr for maximum clarity.
The debugger does not step i
vsk updated this revision to Diff 120342.
vsk added a comment.
- Simplify the checks by not hardcoding a line number.
https://reviews.llvm.org/D39310
Files:
lib/CodeGen/CGBlocks.cpp
test/CodeGenObjC/debug-info-blocks.m
Index: test/CodeGenObjC/debug-info-blocks.m
==
dcoughlin added a comment.
In https://reviews.llvm.org/D39220#907160, @george.karpenkov wrote:
> @dcoughlin OK, I'll commit that [I assuming not doing the review would be
> fine here]
Yes, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D39220
_
sammccall added a comment.
Thanks, I think this is looking much better.
A couple of bits of the interface could be yet simpler :-)
Comment at: include/clang/Tooling/Refactoring/Extract/ExtractFunction.h:21
+/// then called from the place where the original code was.
+class Extr
alekseyshl created this revision.
.
https://reviews.llvm.org/D39312
Files:
lib/Driver/ToolChains/Linux.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@
Author: arphaman
Date: Wed Oct 25 17:56:54 2017
New Revision: 316631
URL: http://llvm.org/viewvc/llvm-project?rev=316631&view=rev
Log:
Allow StmtPrinter to supress implicit 'this' and 'self' base expressions
This will be useful for certain refactoring actions.
rdar://34202062
Modified:
cfe/
JDevlieghere added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1651
StartFunction(FD, C.VoidTy, Fn, FI, args);
- // Create a scope with an artificial location for the body of this function.
- auto AL = ApplyDebugLocation::CreateArtificial(*this);
+ ApplyDebugLocat
Author: george.karpenkov
Date: Wed Oct 25 18:13:22 2017
New Revision: 316632
URL: http://llvm.org/viewvc/llvm-project?rev=316632&view=rev
Log:
[Analyzer] [Tests] Consistently use exit codes. Use code=42 to signify
different results
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
cfe/tr
vsk added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1651
StartFunction(FD, C.VoidTy, Fn, FI, args);
- // Create a scope with an artificial location for the body of this function.
- auto AL = ApplyDebugLocation::CreateArtificial(*this);
+ ApplyDebugLocation NL{*t
faisalv updated this revision to Diff 120346.
faisalv marked 4 inline comments as done.
faisalv added a comment.
Incorporated Aaron's feedback (although not sure if I caugh tall the white
space issues).
Additionally, I was thinking of reordering the bits - and using UseSEHTry (this
bit really m
mclow.lists added a comment.
A couple of notes.
- This change means that now requires C++11 (the new `__push` function
w/ the varargs). I don't know how important that is; but I'm pretty sure
libc++ currently provides `` in C++03 mode.
- This is an ABI change; existing code that was compiled
mclow.lists added a comment.
I can confirm that with this patch the (large) regex that used to cause a stack
overflow does not any more.
https://reviews.llvm.org/D39308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Hello everyone,
Below are some buildbot numbers for the week of 10/8/2017 - 10/14/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 10/15/2017 -
10/21/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Author: alekseyshl
Date: Wed Oct 25 20:09:53 2017
New Revision: 316636
URL: http://llvm.org/viewvc/llvm-project?rev=316636&view=rev
Log:
[LSan] Enable -fsanitize=leak for PPC64 Linux.
Summary: .
Reviewers: eugenis
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D39312
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316636: [LSan] Enable -fsanitize=leak for PPC64 Linux.
(authored by alekseyshl).
Repository:
rL LLVM
https://reviews.llvm.org/D39312
Files:
cfe/trunk/lib/Driver/ToolChains/Linux.cpp
cfe/trunk/test
hfinkel added inline comments.
Comment at: lib/Driver/Driver.cpp:630
+ for (const char *Dir : Directories) {
+assert(Dir);
+FilePath.clear();
assert(Dir && "Directory path should not be null");
Comment at: lib/Driver/Driver.cpp:637
+
hfinkel added inline comments.
Comment at: lib/Driver/Driver.cpp:661
+
+ // If not found, try searching the directory where executable resides.
+ FilePath.clear();
hfinkel wrote:
> Why not just add this directory to the end of the list of directories?
(by which
thakis created this revision.
Herald added a subscriber: srhines.
clang currently uses .init_array instead of .ctors on Linux if it detects gcc
4.7+. Make it so that it also uses .init_array if no gcc installation is found
at all – if there's no old gcc, there's nothing we need to be compatible
On Fri, Oct 20, 2017 at 11:56 AM, Friedman, Eli
wrote:
> On 10/17/2017 5:00 PM, Saleem Abdulrasool via cfe-commits wrote:
>
>> Author: compnerd
>> Date: Tue Oct 17 17:00:50 2017
>> New Revision: 316046
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=316046&view=rev
>> Log:
>> Basic: fix __{,U}
sabel83 updated this revision to Diff 120358.
sabel83 marked 2 inline comments as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
hintonda updated this revision to Diff 120360.
hintonda added a comment.
- Add diagtool option used to set arbitrary diagtool path.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /dev
compnerd created this revision.
compnerd added a project: clang.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
Centralise the definitions of these compiler vended types to aid
inspection to ensure that they are defined similarly. The one case that
stands out is the Darwin case w
yvvan added a comment.
one more ping...
https://reviews.llvm.org/D36390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 172 of 172 matches
Mail list logo
