vsapsai added inline comments.
================ Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095 + fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType(); + } + ---------------- rjmccall wrote: > vsapsai wrote: > > rjmccall wrote: > > > You can't just use isa<> here; there can be typedefs of incomplete array > > > type. > > Thanks for catching it. > Oh, and C allows you to have incomplete arrays of array type, e.g. int x[][4]; Right, thanks. I've checked only that `int x[][];` isn't accepted but forgot about mixing different arrays. https://reviews.llvm.org/D38774 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits