george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar,
aemerson.
https://reviews.llvm.org/D39208
Files:
include/clang/Analysis/AnalysisDeclContext.h
include/clang/Analysis/BodyFarm.h
lib/Analysis/AnalysisDeclContext.cpp
lib/Analys
arphaman accepted this revision.
arphaman added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29
+ // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar
c#>, <#ns::baz d#>
+ // C
tmsriram added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1859
+if (auto *Fn = dyn_cast(TargetDecl)) {
+ if (!Fn->isDefined() && !AttrOnCallSite) {
+FuncAttrs.addAttribute(llvm::Attribute::NonLazyBind);
rnk wrote:
> Remind me what happen
vsapsai updated this revision to Diff 119951.
vsapsai added a comment.
- Address rjmccall review comment about isa<>.
Decided to keep in test only cases with typedefs because test coverage is the
same and there is less similar code.
https://reviews.llvm.org/D38774
Files:
clang/include/clang/
vsapsai updated this revision to Diff 119952.
vsapsai added a comment.
- Resubmit my last change without files from underlying branch.
https://reviews.llvm.org/D38774
Files:
clang/lib/CodeGen/CGObjCMac.cpp
clang/test/CodeGenObjC/ivar-layout-flexible-array.m
Index: clang/test/CodeGenObjC/i
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095
+fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType();
+ }
+
vsapsai wrote:
> rjmccall wrote:
> > You can't just use isa<> here; there can be typedefs of incomplete a
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
@doug.gregor Ping
Repository:
rL LLVM
https://reviews.llvm.org/D36790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eandrews created this revision.
Added support for regcall as default calling convention. Also added code to
exclude main when applying default calling conventions.
https://reviews.llvm.org/D39210
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/LangOptions.h
include/clang/Drive
Lekensteyn added a comment.
(FWIW, the suggestion to use `FileManager:getCanonicalName` did not work
because I have no DirectoryEntry. And `-no-canonical-prefixes` it used very
early and stripped from normal options, it seems used for a different purpose.
Given the opposition, I think that this
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Content-wise, LGTM. There is a style nit inline.
Also, can you avoid reformatting the lines that haven't changed? This will help
preserve the history of the file and make it clear what c
george.karpenkov added a comment.
@dcoughlin that's not me, that's clang-format.
If we agree on always running it, I think the changes should stay there.
https://reviews.llvm.org/D39208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Oct 23 16:19:30 2017
New Revision: 316394
URL: http://llvm.org/viewvc/llvm-project?rev=316394&view=rev
Log:
More fuzzing interfaces
Added:
libcxx/trunk/fuzzing/RoutineNames.txt
Modified:
libcxx/trunk/fuzzing/fuzzing.cpp
libcxx/trunk/fuzzing/fuzzing.h
Added:
frutiger abandoned this revision.
frutiger added a subscriber: AlisdairM.
frutiger added a comment.
@AlisdairM maybe you want to commandeer this? This revision is probably not
going anywhere any time soon...
https://reviews.llvm.org/D16967
___
cfe
arphaman marked an inline comment as done.
arphaman added a comment.
In https://reviews.llvm.org/D37341#869042, @vsapsai wrote:
> Does your fix work for deeper nesting too (e.g. template in template in
> template)? Looks like it should, just want to confirm.
Yes.
> Are there other places wher
frutiger abandoned this revision.
frutiger added a comment.
@AlisdairM maybe you want to commandeer this revision? I don't think this is
going anywhere...
https://reviews.llvm.org/D16970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
arphaman updated this revision to Diff 119967.
arphaman added a comment.
Use just the `isInvalidDecl` check.
Repository:
rL LLVM
https://reviews.llvm.org/D37341
Files:
lib/Sema/SemaDecl.cpp
test/SemaTemplate/deduction-crash.cpp
test/SemaTemplate/explicit-specialization-member.cpp
Ind
frutiger created this revision.
- Add a 'Location' class that represents the four properties of a physical
location
- Enhance 'SourceLocation' to provide 'expansion' and 'spelling' locations,
maintaining backwards compatibility with existing code by forwarding the four
properties to 'expansion'
probinson added a comment.
Anytime the code between saveIP() and restoreIP() could set the current debug
location, it needs to be saved/restored along with the insertion point. I have
to say the problem is not obvious to me here, so maybe saveIP/restoreIP should
be changed (or eliminated in fa
I created a new revision to review and to fix the tests:
https://reviews.llvm.org/D39217.
On Sat, Oct 21, 2017 at 6:24 PM, Masud Rahman wrote:
> Thanks, I will take a look.
>
> On Sat, Oct 21, 2017 at 5:53 PM, Aaron Ballman
> wrote:
>
>> I've reverted back to green in r316279 due to more bots f
frutiger updated this revision to Diff 119971.
frutiger added a comment.
Add context to the patch.
https://reviews.llvm.org/D39217
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
test/Index/annotate-tokens.c
test/Index/blocks.c
test/Index/c-index-a
frutiger added a comment.
I would very much appreciate some guidance on whether or not this kind of a
change in behaviour for `clang_getSpellingLocation` is an acceptable thing to
do.
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cf
Author: alexshap
Date: Mon Oct 23 16:46:06 2017
New Revision: 316399
URL: http://llvm.org/viewvc/llvm-project?rev=316399&view=rev
Log:
[analyzer] Fix handling of labels in getLValueElement
In getLValueElement Base may represent the address of a label
(as in the newly-added test case), in this ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316399: [analyzer] Fix handling of labels in
getLValueElement (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D39174?vs=119808&id=119972#toc
Repository:
rL LLVM
https://rev
dcoughlin added a comment.
I think a good strategy is to look at your diffs and consider whether the
benefits of normalizing the style outweigh the cost of losing the history. In
this case, I think keeping the history makes sense. (Imagine you are a future
maintainer and want to know when and w
Author: george.karpenkov
Date: Mon Oct 23 16:59:52 2017
New Revision: 316400
URL: http://llvm.org/viewvc/llvm-project?rev=316400&view=rev
Log:
[Analyzer] Do not use static storage to for implementations created in
BodyFarm.cpp
Differential Revision: https://reviews.llvm.org/D39208
Added:
cf
george.karpenkov added a comment.
@dcoughlin the context I was thinking about is that if everyone consistently
runs `clang-format` (if we want that), then we never would have discussion.
The alternative is that every run of `clang-format` would be followed by
manually reverting changes which wer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316400: [Analyzer] Do not use static storage to for
implementations created in BodyFarm. (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39208?vs=119949&id=119974#toc
dcoughlin added a comment.
That would require going into the past and requiring everyone back then to run
clang-format as well. Unfortunately they didn't -- so human judgment is needed
when modifying code that doesn't obey the guidelines.
Repository:
rL LLVM
https://reviews.llvm.org/D39208
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:3269-3273
+ bool IsMain = false;
+ if (D.getIdentifier() && D.getIdentifier()->isStr("main") &&
+ S.CurContext->getRedeclContext()->isTranslationUnit() &&
+ !S.getLangOpts().Freestanding)
+IsMain = true;
george.karpenkov added a comment.
@dcoughlin OK sorry, I haven't considered the point that codebase predates the
requirement, and the master format-all commit was never done.
I've committed this one already, but I will be more careful with applying
clang-format to future changes.
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316402: [Analyzer] Handle implicit function reference in
bodyfarming std::call_once (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39201?vs=119911&id=119975#toc
Repo
Author: george.karpenkov
Date: Mon Oct 23 17:13:18 2017
New Revision: 316402
URL: http://llvm.org/viewvc/llvm-project?rev=316402&view=rev
Log:
[Analyzer] Handle implicit function reference in bodyfarming std::call_once
Differential Revision: https://reviews.llvm.org/D39201
Modified:
cfe/trun
erichkeane added inline comments.
Comment at: lib/Sema/SemaType.cpp:3269-3273
+ bool IsMain = false;
+ if (D.getIdentifier() && D.getIdentifier()->isStr("main") &&
+ S.CurContext->getRedeclContext()->isTranslationUnit() &&
+ !S.getLangOpts().Freestanding)
+IsMain
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:3269-3273
+ bool IsMain = false;
+ if (D.getIdentifier() && D.getIdentifier()->isStr("main") &&
+ S.CurContext->getRedeclContext()->isTranslationUnit() &&
+ !S.getLangOpts().Freestanding)
+IsMain = true;
rnk added inline comments.
Comment at: lib/AST/Type.cpp:2226
+Context.getFieldOffset(*Record->field_begin()));
+for (const auto *Field : Record->fields()) {
+ if (!Field->getType().hasUniqueObjectRepresentations(Context))
What about base classes?
dschuff added inline comments.
Comment at: lib/Driver/ToolChain.cpp:318
+ else
+OSLibName = getOS();
llvm::sys::path::append(Path, "lib", OSLibName);
Is this logic intended to replace what was removed from CommonArgs.cpp? Should
there be an assert here t
hfinkel added a comment.
> With this patch we avoid unaligned loads and stores, at least on MIPS
> architecture.
Can you please explain the nature of the problematic situations?
Also, this patch does not update the comments that describe the splitting
algorithm. That should be improved.
If th
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added a comment.
In https://reviews.llvm.org/D39005#900973, @jlebar wrote:
> > The first question that comes to mind is what is the link between data
> > layout and name mangling conventions?
>
> I pulled up http://llvm.org/doxygen/classllvm_1_1DataLayout.html and searched
> for "mangli
lichray added a comment.
ping?
https://reviews.llvm.org/D39162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Mon Oct 23 18:09:43 2017
New Revision: 316403
URL: http://llvm.org/viewvc/llvm-project?rev=316403&view=rev
Log:
[Analyzer] Fix for the memory leak: fix typo in if-statement.
Modified:
cfe/trunk/lib/Analysis/AnalysisDeclContext.cpp
Modified: cfe/trunk/lib/Analys
JDevlieghere added inline comments.
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:80
+
+ // Unsigned overflow occured. Returning max() is sufficient, since noone
+ // writes so many case labels in source code.
Maybe merge this with the function com
erichkeane added inline comments.
Comment at: lib/AST/Type.cpp:2226
+Context.getFieldOffset(*Record->field_begin()));
+for (const auto *Field : Record->fields()) {
+ if (!Field->getType().hasUniqueObjectRepresentations(Context))
rnk wrote:
> What
erichkeane added inline comments.
Comment at: lib/Sema/SemaType.cpp:3269-3273
+ bool IsMain = false;
+ if (D.getIdentifier() && D.getIdentifier()->isStr("main") &&
+ S.CurContext->getRedeclContext()->isTranslationUnit() &&
+ !S.getLangOpts().Freestanding)
+IsMain
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, aemerson.
While by using `.get()` method we don't get the full protection offered by
`std::unique_ptr`, given that two bugs were already encountered
(http://lab.llvm.org:8011/builders/sanitizer-x8
george.karpenkov added a comment.
@dcoughlin
> Is it when an end-user is running a build with assertions and can't provide a
> reproducer but can provide the console output?
Yes, or just for developer staring at the crash for the first time, or for the
crashers in CI.
> Does llvm_unreachable(
klimek added a comment.
Ok, I think this is starting to look really good. Now we should try to grab
Richard's attention to make sure it's fine to submit with the current set of
FIXMEs.
Comment at: lib/Frontend/FrontendActions.cpp:386
+ // This part is normally done by ASTFro
Author: erichkeane
Date: Mon Oct 23 18:39:56 2017
New Revision: 316405
URL: http://llvm.org/viewvc/llvm-project?rev=316405&view=rev
Log:
Fix template parameter default args missed if redecled
This bug was found via self-build on lld, and worked around
here: https://reviews.llvm.org/rL316180
The
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316405: Fix template parameter default args missed if
redecled (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D39127?vs=119665&id=119991#toc
Repository:
rL LLVM
https://
CaseyCarter created this revision.
Update aligned `new` tests to use `__STDCPP_DEFAULT_NEW_ALIGNMENT__ * 2` for
"over-aligned" instead of `alignof(std::max_align_t) * 2`.
https://reviews.llvm.org/D39221
Files:
test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_alig
Author: jrose
Date: Mon Oct 23 19:17:07 2017
New Revision: 316408
URL: http://llvm.org/viewvc/llvm-project?rev=316408&view=rev
Log:
Unnamed bitfields don't block constant evaluation of constexpr ctors
C++14 [dcl.constexpr]p4 states that in the body of a constexpr
constructor,
> every non-variant
jordan_rose closed this revision.
jordan_rose added a comment.
Landed in https://reviews.llvm.org/rL316408.
Repository:
rL LLVM
https://reviews.llvm.org/D39035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
rnk added a comment.
I think you forgot to svn add the test case
Repository:
rL LLVM
https://reviews.llvm.org/D39127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lichray added inline comments.
Comment at: lib/Analysis/AnalysisDeclContext.cpp:606
-AnalysisDeclContextManager::~AnalysisDeclContextManager() {
- if (BdyFrm)
-delete BdyFrm;
-}
+AnalysisDeclContextManager::~AnalysisDeclContextManager() {}
Why having emp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316411: [test] Fix clang-test for FreeBSD and NetBSD
(authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D39162?vs=119803&id=119995#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: timshen
Date: Mon Oct 23 20:11:02 2017
New Revision: 316411
URL: http://llvm.org/viewvc/llvm-project?rev=316411&view=rev
Log:
[test] Fix clang-test for FreeBSD and NetBSD
Lit tries to inject the shared library paths, but no action is taken
when platform.system() is not recognized, results
compnerd added a subscriber: akyrtzi.
compnerd added a comment.
I think that this is reasonable given that it is addressing a long standing
issue. CC'ing @akyrtzi for his opinion as well.
https://reviews.llvm.org/D39217
___
cfe-commits mailing lis
compnerd accepted this revision.
compnerd added a comment.
I'd say out of range rather than too big.
https://reviews.llvm.org/D39206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
akyrtzi added a subscriber: arphaman.
akyrtzi added a comment.
CC'ed @arphaman.
https://reviews.llvm.org/D39217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jina.nahias added inline comments.
Comment at: test/CodeGen/avx512cdintrin.c:106
+ // CHECK: insertelement <16 x i32> %{{.*}}, i32 %{{.*}}
+ return _mm512_broadcastmw_epi32(_mm512_cmpeq_epi32_mask ( a, b));
}
RKSimon wrote:
> Any reason why you can't use the
rjmccall added a comment.
In https://reviews.llvm.org/D39069#904507, @probinson wrote:
> Anytime the code between saveIP() and restoreIP() could set the current debug
> location, it needs to be saved/restored along with the insertion point. I
> have to say the problem is not obvious to me here
rjmccall added a comment.
AFAIK, this is pointless because that alloca will be trivially eliminated by
mem2reg. Am I missing something? Is this important for some sort of
consistency check?
Repository:
rL LLVM
https://reviews.llvm.org/D39138
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2171
+ LValueBaseInfo *ReferenceeBaseInfo,
+ TBAAAccessInfo *ReferenceeTBAAInfo) {
+ llvm::LoadInst *Load = Builder.CreateLoad(ReferenceAddr
101 - 165 of 165 matches
Mail list logo
