rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:337
+Mask = (Mask & ~ImplicitAddrSpaceMask) |
+ (((uint32_t)Value) << ImplicitAddrSpaceShift);
+ }
This is probably cleaner as:
Mask = (Value ? (Mask | ImplicitAddrSpaceMask) :
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great. Probably one more reason to turn all `Loc`s into regions.
Repository:
rL LLVM
https://reviews.llvm.org/D39174
___
cfe-commits mailing list
cf
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Well, I've been agreeing so far that it makes sense to propagate TBAA
information separately from LValueBaseInfo, and this seems like a logical part
of that, so okay.
Repository:
rL LL
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:500
+if (!RefactoringClient)
+ RefactoringClient =
llvm::make_unique();
+Results = clangd::findAvailableRefactoringCommands(*RefactoringClient,
*AST,
Maybe initialize `Refacto
mstorsjo added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:4811
+ TemplateParameterList *Params =
+ cast(Template->getMostRecentDecl())
+ ->getTemplateParameters();
erichkeane wrote:
> mstorsjo wrote:
> > erichkeane wrote:
> > > mstorsjo
rjmccall added a comment.
Hmm. I'm not sure I like the design of merging TBAAAccessInfo into
LValueBaseInfo. LValueBaseInfo is currently the set of information that's
generally preserved across l-value manipulations. It was extracted from LValue
specifically to create an encapsulated entity
rjmccall added a comment.
If this is something we generally need to be doing in all the places we
temporarily save and restore the insertion point, we should fix the basic
behavior of saveIP instead of adding explicit code to a bunch of separate
places. Can we just override saveIP() on CGBuild
yvvan added a comment.
ping
https://reviews.llvm.org/D38618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev created this revision.
kosarev added a project: clang.
Repository:
rL LLVM
https://reviews.llvm.org/D39177
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/tbaa-ref
kosarev added inline comments.
Comment at: test/CodeGen/tbaa-reference.cpp:1
// RUN: %clang_cc1 -triple x86_64-linux -O1 -disable-llvm-passes %s -emit-llvm
-o - | FileCheck %s
//
Changes for this test look somewhat complicated, so here's a short summary:
* We
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:59
void ClangdLSPServer::onShutdown(Ctx C, ShutdownParams &Params) {
- IsDone = true;
+ // Before we reply, we could serialize the preambles to disk. For now, let's
+ // just say we're ready to exit.
Author: hokein
Date: Mon Oct 23 01:58:50 2017
New Revision: 316314
URL: http://llvm.org/viewvc/llvm-project?rev=316314&view=rev
Log:
[rename] Don't overwrite the template argument when renaming a template
function.
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: cierpuchaw, cfe-commits, kli
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316314: [rename] Don't overwrite the template argument when
renaming a template… (authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39120
Files:
cfe/trunk/lib/Tooling/Refactoring/Re
hokein added inline comments.
Comment at: unittests/Rename/RenameFunctionTest.cpp:232
+ std::string Expected = R"(
+ namespace na {
+ template T Y();
cierpuchaw wrote:
> Shouldn't this be `namespace nb {`?
It is intended. We don't change the namespace
nik updated this revision to Diff 119823.
nik added a comment.
Rebased and took over better wording/description from Ilya.
https://reviews.llvm.org/D37554
Files:
tools/libclang/CIndex.cpp
tools/libclang/CIndexCodeCompletion.cpp
tools/libclang/Indexing.cpp
Index: tools/libclang/Indexing.
nik added a comment.
Hmm, apparently "arc diff --update https://reviews.llvm.org/D37554"; did not
take the new commit message into account. Changed it manually with the web
interface.
Ilya, I hope it's OK if I take your description :)
> That said, I am not familiar with the code you're changin
mstorsjo added inline comments.
Comment at: src/UnwindRegistersRestore.S:98
+ # skip fs
+ # skip gs
+ movq 56(%rcx), %rsp # cut back rsp to new location
mstorsjo wrote:
> compnerd wrote:
> > Doesn't Win64 ABI require some of the MMX registers be saved/restor
hokein created this revision.
Herald added subscribers: mgorny, klimek.
https://reviews.llvm.org/D39178
Files:
lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
unittests/Rename/CMakeLists.txt
unittests/Rename/RenameMemberTest.cpp
Index: unittests/Rename/RenameMemberTest.cpp
This seems to have had the side effect of introducing a new warning in
Chromium builds:
../../third_party/expat/files/lib/xmlparse.c(2429,24): error:
comparison of integers of different signs: 'enum XML_Error' and
'unsigned int' [-Werror,-Wsign-compare]
if (code > 0 && code < sizeof(message)/si
lebedev.ri updated this revision to Diff 119833.
lebedev.ri retitled this revision from "[Sema] -Wzero-as-null-pointer-constant:
don't warn for system macros." to "[Sema] -Wzero-as-null-pointer-constant:
don't warn for system macros other than NULL.".
lebedev.ri edited the summary of this revisio
On Mon, Oct 23, 2017 at 2:13 PM, Hans Wennborg wrote:
Hi.
> This seems to have had the side effect of introducing a new warning in
> Chromium builds:
>
> ../../third_party/expat/files/lib/xmlparse.c(2429,24): error:
> comparison of integers of different signs: 'enum XML_Error' and
> 'unsigned in
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:103
+ void AfterExecute(CompilerInstance &CI) override {
+const SourceManager &SM = CI.getSourceManager();
Nebiroth wrote:
> ilya-biryukov wrote:
> > There's a much better public API to
peter.smith created this revision.
Herald added subscribers: javed.absar, rengolin, aemerson.
When -mtune is used on AArch64 the -target-cpu is passed the value of the cpu
given to -mtune. As well as setting micro-architectural features of the -mtune
cpu, this will also add the architectural fea
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Oh, and other than those NITs, LGTM.
@rwols, you have commit access now, right?)
https://reviews.llvm.org/D38939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Sorry for late response, was on vacation.
The following commit (r315325) adds code coverage for this case.
But you are correct, we were missing usages of the class with non-void
return type before that.
On Mon, Oct 16, 2017 at 7:12 PM, David Blaikie wrote:
> Is there missing test coverage for
On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote:
Attributes come with multiple spelling flavors, but when it comes to
adding new attributes that are not present in other compiler tools
such as GCC or MSVC, we have done a poor job of being consistent with
which spelling flavors we ado
ilya-biryukov added a comment.
In https://reviews.llvm.org/D35894#895023, @Nebiroth wrote:
> I would like some feedback/suggestions on whether it's possible to "append"
> information to a MarkedString to be displayed on client?
You mean append **after** returning `MarkedString` to the client?
ilya-biryukov added a comment.
> Another note: current implementation does not seem to handle macros at all
> (it will only highlight definition of a macro, not its usages).
Current implementation still doesn't highlight macro references, only
definitions. I'd either disable `documentHighlight`
Author: ibiryukov
Date: Mon Oct 23 07:08:52 2017
New Revision: 316323
URL: http://llvm.org/viewvc/llvm-project?rev=316323&view=rev
Log:
[clangd] Updated outdated test comment. NFC.
Modified:
clang-tools-extra/trunk/test/clangd/input-mirror.test
Modified: clang-tools-extra/trunk/test/clangd/i
Missed that, will do, thanks.
On Wed, Oct 11, 2017 at 1:39 AM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> On Tue, Oct 10, 2017 at 2:08 AM, Ilya Biryukov via cfe-commits
> wrote:
> > Author: ibiryukov
> > Date: Tue Oct 10 02:08:47 2017
> > New Revision: 315287
> >
> > URL: http://llv
ilya-biryukov added a comment.
Friendly ping.
Would it be okay to make the new behaviour optional? (Leaving old behaviour to
be the default).
https://reviews.llvm.org/D38538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
malaperle added a comment.
In https://reviews.llvm.org/D35894#903542, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D35894#895023, @Nebiroth wrote:
>
> > I would like some feedback/suggestions on whether it's possible to "append"
> > information to a MarkedString to be displayed on client?
On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote:
>
> On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote:
>>
>> Attributes come with multiple spelling flavors, but when it comes to
>> adding new attributes that are not present in other compiler tools
>> such as GCC or MSVC, we have done
Author: ibiryukov
Date: Mon Oct 23 07:46:48 2017
New Revision: 316327
URL: http://llvm.org/viewvc/llvm-project?rev=316327&view=rev
Log:
[clangd] Allow to pass code completion opts to ClangdServer.
Reviewers: bkramer, krasimir, sammccall
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Di
ilya-biryukov added a comment.
In https://reviews.llvm.org/D38731#898539, @krasimir wrote:
> Great! I like the unit testing approach a lot!
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D38731
___
cfe-commits mailing list
cfe-commits@li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316327: [clangd] Allow to pass code completion opts to
ClangdServer. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D38731?vs=118385&id=119849#toc
Repository:
rL LLVM
htt
ilya-biryukov added a comment.
In https://reviews.llvm.org/D37554#903401, @nik wrote:
> Ilya, I hope it's OK if I take your description :)
Sure, no problem.
https://reviews.llvm.org/D37554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm. Nice!
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:251
+ // Ignore implicit initializers.
+ if (!Initializer->isWritten())
+continue;
-
ilya-biryukov added a comment.
In https://reviews.llvm.org/D35894#903552, @malaperle wrote:
> I think he meant to have multiple sections in the hover, one C/C++ and one
> not. But we noticed you can have an array of MarkedString in Hover so it
> should be fine.
I totally misunderstood the que
On Mon, Oct 23, 2017 at 7:33 AM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote:
> > On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote:
> >>
> >> Attributes come with multiple spelling flavors, but when it comes to
malaperle added a comment.
In https://reviews.llvm.org/D35894#903594, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D35894#903552, @malaperle wrote:
>
> > I think he meant to have multiple sections in the hover, one C/C++ and one
> > not. But we noticed you can have an array of MarkedStrin
Nebiroth added a comment.
In https://reviews.llvm.org/D35894#903594, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D35894#903552, @malaperle wrote:
>
> > I think he meant to have multiple sections in the hover, one C/C++ and one
> > not. But we noticed you can have an array of MarkedString
ilya-biryukov added a comment.
In https://reviews.llvm.org/D35894#903607, @malaperle wrote:
> Exactly! Although the without-language part, maybe it'll be "scope"
> information first. Maybe documentation/comments in a second patch.
Sure, whatever works/looks best.
In https://reviews.llvm.org/D
Author: nico
Date: Mon Oct 23 08:54:44 2017
New Revision: 316335
URL: http://llvm.org/viewvc/llvm-project?rev=316335&view=rev
Log:
clang-cl: Expose --version.
This is for consistency with lld-link, see https://reviews.llvm.org/D38972
Also give --version a help text so it shows up in --help / /? o
yaxunl created this revision.
https://reviews.llvm.org/D39184
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenOpenCL/amdgcn-automatic-variable.cl
Index: test/CodeGenOpenCL/amdgcn-automatic-variable.cl
===
--- test/CodeGenOpenCL/amdgc
On Mon, Oct 23, 2017 at 11:16 AM, Arthur O'Dwyer
wrote:
> On Mon, Oct 23, 2017 at 7:33 AM, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Mon, Oct 23, 2017 at 9:48 AM, Hal Finkel wrote:
>> > On 10/21/2017 10:14 AM, Aaron Ballman via cfe-commits wrote:
>> >>
>> >> Attributes come with multiple s
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clangd/Trace.cpp:87
+
+static Tracer* T = nullptr;
+} // namespace
ilya-biryukov wrote:
> Maybe use `unique_ptr` (or even `llvm::Optional`)? Otherwise
> we leak memory and d
sammccall updated this revision to Diff 119864.
sammccall added a comment.
Address FIXME now that r316330 is in.
https://reviews.llvm.org/D39086
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/ProtocolHandlers.cpp
clangd
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
This looks much better than the previous solution. Thanks!
https://reviews.llvm.org/D38704
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: erichkeane
Date: Mon Oct 23 09:20:15 2017
New Revision: 316338
URL: http://llvm.org/viewvc/llvm-project?rev=316338&view=rev
Log:
Pull X86 "CPUKind" checking into .cpp file. [NFC]
Preparing to do a refactor of CPU/feature checking, this
patch pulls the one CPU implementation from the .h fi
sammccall added a comment.
As noted on the other patch, I'm not sure EditorCommands is a useful
abstraction.
This shows up one of the problems: clangd is mostly decoupled from the actual
behavior/semantics of the commands by the EditorCommands abstraction. However
LSP doesn't say what the stru
Rakete added inline comments.
Comment at: lib/Sema/Sema.cpp:445
+ // If it is a macro from system header, and if the macro name is not "NULL",
+ // do not warn.
+ SourceLocation MaybeMacroLoc = E->getLocStart();
That comment doesn't really add anything IMO
Author: marshall
Date: Mon Oct 23 09:46:44 2017
New Revision: 316343
URL: http://llvm.org/viewvc/llvm-project?rev=316343&view=rev
Log:
Fix misguided error message in debug mode. No functional change. Fixes PR#34966
Modified:
libcxx/trunk/include/list
Modified: libcxx/trunk/include/list
URL:
majnemer accepted this revision.
majnemer added a comment.
LGTM
https://reviews.llvm.org/D38704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Mon Oct 23 09:48:46 2017
New Revision: 316344
URL: http://llvm.org/viewvc/llvm-project?rev=316344&view=rev
Log:
[ASTMatchers] Expose forEachOverriden in dynamic AST matchers.
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatchers/Dynami
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
lebedev.ri updated this revision to Diff 119892.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
Use `MaybeMacroLoc` variable in the other place too.
Repository:
rL LLVM
https://reviews.llvm.org/D38954
Files:
docs/ReleaseNotes.rst
lib/Sema/Sema.cpp
test/SemaCXX
hintonda added a comment.
Thanks for all the feedback. I'll report back once I've addressed all your
suggestions.
Thanks again...
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
lebedev.ri added inline comments.
Comment at: lib/Sema/Sema.cpp:445
+ // If it is a macro from system header, and if the macro name is not "NULL",
+ // do not warn.
+ SourceLocation MaybeMacroLoc = E->getLocStart();
Rakete wrote:
> That comment doesn't rea
smeenai added a comment.
BTW LLVM requires a minimum of Windows 7 according to
https://releases.llvm.org/3.8.0/docs/ReleaseNotes.html, so you can rely on SRW
locks always being present. If LLVM still has a fallback path for when SRW
locks are absent, that could be cleaned up.
https://reviews.
schroedersi added a comment.
Ping
https://reviews.llvm.org/D30946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yaxunl
Date: Mon Oct 23 10:49:26 2017
New Revision: 316353
URL: http://llvm.org/viewvc/llvm-project?rev=316353&view=rev
Log:
CodeGen: Fix invalid bitcast in partial initialization of automatic arrary
variable
Differential Revision: https://reviews.llvm.org/D39184
Modified:
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316353: CodeGen: Fix invalid bitcast in partial
initialization of automatic arrary… (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D39184?vs=119861&id=119900#toc
Repository:
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This should be fine for now. Thanks!
-eric
https://reviews.llvm.org/D39179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
What John said, but also a narrower test would be good - checking that the
appropriate call instruction gets a debug location, rather than checking
that a bunch of inlining doesn't cause the assertion/verifier failure,
would be good. (Clang tests should, as much as possible, not rely on or run
the
I will simplify the test. Thanks.
Sam
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Monday, October 23, 2017 2:08 PM
To: reviews+d39069+public+8da79e110d303...@reviews.llvm.org; Yaxun Liu via
Phabricator ; Liu, Yaxun (Sam) ;
rjmcc...@gmail.com
Cc: cfe-commits@lists.llvm.org
Subject: Re:
yaxunl added a comment.
In https://reviews.llvm.org/D39069#903344, @rjmccall wrote:
> If this is something we generally need to be doing in all the places we
> temporarily save and restore the insertion point, we should fix the basic
> behavior of saveIP instead of adding explicit code to a bun
vsk added a comment.
In https://reviews.llvm.org/D27607#901882, @fjricci wrote:
> On platforms where `BOOL` == `signed char`, is it actually undefined behavior
> (or is it just bad programming practice) to store a value other than 0 or 1
> in your `BOOL`? I can't find any language specs suggest
tmsriram added a comment.
Ping.
https://reviews.llvm.org/D39079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hahnfeld
Date: Mon Oct 23 12:01:35 2017
New Revision: 316362
URL: http://llvm.org/viewvc/llvm-project?rev=316362&view=rev
Log:
[OpenMP] Avoid VLAs for some reductions on array sections
In some cases the compiler can deduce the length of an array section
as constants. With this information
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316362: [OpenMP] Avoid VLAs for some reductions on array
sections (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D39136?vs=119689&id=119909#toc
Repository:
rL LLVM
https:/
lebedev.ri added a comment.
No tests?
https://reviews.llvm.org/D39079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fjricci added a comment.
Awesome, good to know. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D27607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar,
aemerson.
https://reviews.llvm.org/D39201
Files:
lib/Analysis/BodyFarm.cpp
test/Analysis/call_once.cpp
Index: test/Analysis/call_once.cpp
===
Author: mstorsjo
Date: Mon Oct 23 12:29:36 2017
New Revision: 316364
URL: http://llvm.org/viewvc/llvm-project?rev=316364&view=rev
Log:
Abstract rwlocks into a class, provide a SRW lock implementation for windows
This requires _WIN32_WINNT >= 0x0600.
If someone wants to spend effort on supporting
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316364: Abstract rwlocks into a class, provide a SRW lock
implementation for windows (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D38704?vs=119094&id=119914#toc
Repository:
yaxunl updated this revision to Diff 119918.
yaxunl added a comment.
Use InsertPointGuard and simplify test.
https://reviews.llvm.org/D39069
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenOpenCL/func-call-dbg-loc.cl
Index: test/CodeGenOpenCL/func-call-dbg-loc.cl
===
phosek updated this revision to Diff 119923.
Repository:
rL LLVM
https://reviews.llvm.org/D39176
Files:
lib/Driver/ToolChains/Fuchsia.cpp
lib/Driver/ToolChains/Fuchsia.h
test/Driver/fuchsia.c
test/Driver/fuchsia.cpp
Index: test/Driver/fuchsia.cpp
=
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
This seems like how it always should have been, since -fuse-ld=lld sets it to
ld.lld, not lld.
Looks to me like the existing MipsLinux and WebAssembly implementations are
wrong too and onl
hfinkel added a comment.
In https://reviews.llvm.org/D39160#902918, @spatel wrote:
> Oops - I wrongly made llvm-commits a subscriber rather than cfe-commits. Let
> me know if I should reopen under a new thread to get the patch to hit the
> right mailing list.
Yes, please reopen.
https://rev
spatel created this revision.
Herald added a subscriber: mcrosier.
This patch is intended to answer a question raised in PR27435:
https://bugs.llvm.org/show_bug.cgi?id=27435
Is a programmer using __builtin_sqrt() invoking the compiler's intrinsic
definition of sqrt or the mathlib definition of s
spatel abandoned this revision.
spatel added a comment.
Reincarnated as https://reviews.llvm.org/D39204.
https://reviews.llvm.org/D39160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rnk added a comment.
In https://reviews.llvm.org/D39079#904050, @lebedev.ri wrote:
> No tests?
+1, there should be an -emit-llvm test in clang/test/CodeGen/.
Comment at: lib/CodeGen/CGCall.cpp:1859
+if (auto *Fn = dyn_cast(TargetDecl)) {
+ if (!Fn->isDefined() && !A
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Overall LGTM, just a couple of comments:
Comment at: include/clang/Sema/Scope.h:131
+
+/// We are between inheritance colon and the real class/struct definition
scop
rnk added inline comments.
Comment at: src/UnwindRegistersRestore.S:98
+ # skip fs
+ # skip gs
+ movq 56(%rcx), %rsp # cut back rsp to new location
mstorsjo wrote:
> mstorsjo wrote:
> > compnerd wrote:
> > > Doesn't Win64 ABI require some of the MMX register
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316379: [Driver] Use ld.lld directly for Fuchsia rather than
passing flavor (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D39176?vs=119923&id=119938#toc
Repository:
rL LLVM
Author: phosek
Date: Mon Oct 23 14:31:05 2017
New Revision: 316379
URL: http://llvm.org/viewvc/llvm-project?rev=316379&view=rev
Log:
[Driver] Use ld.lld directly for Fuchsia rather than passing flavor
Passing a flavor to LLD requires command line argument, but if these
are being passed through a
mstorsjo added inline comments.
Comment at: src/UnwindRegistersRestore.S:98
+ # skip fs
+ # skip gs
+ movq 56(%rcx), %rsp # cut back rsp to new location
rnk wrote:
> mstorsjo wrote:
> > mstorsjo wrote:
> > > compnerd wrote:
> > > > Doesn't Win64 ABI require
Nice. Dispatching based on argv[0] is more common and probably a
recommended way now, so this patch aligned with that.
On Mon, Oct 23, 2017 at 2:31 PM, Petr Hosek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: phosek
> Date: Mon Oct 23 14:31:05 2017
> New Revision: 316379
>
> URL:
mstorsjo created this revision.
Herald added a subscriber: JDevlieghere.
Most other cases that touch `savedRegisters[reg]` have got this check, but
these three seemed to lack it.
https://reviews.llvm.org/D39206
Files:
src/DwarfParser.hpp
Index: src/DwarfParser.hpp
=
rwols updated this revision to Diff 119941.
rwols added a comment.
- Clarify why we invert the tests in protocol.test,
- Use a variable name to clarify why we exit with status code 1 (when run()
returns true),
- Reword misleading comment in onShutdown method.
https://reviews.llvm.org/D38939
Fi
efriedma added a comment.
The gcc documentation says "GCC includes built-in versions of many of the
functions in the standard C library. These functions come in two forms: one
whose names start with the `__builtin_` prefix, and the other without. Both
forms have the same type (including prototy
rwols marked 3 inline comments as done.
rwols added a comment.
> you have commit access now, right?
I'll have to think about if I want that responsibility!
https://reviews.llvm.org/D38939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: vsapsai
Date: Mon Oct 23 15:01:41 2017
New Revision: 316381
URL: http://llvm.org/viewvc/llvm-project?rev=316381&view=rev
Log:
[Sema] Add support for flexible array members in Obj-C.
Allow Obj-C ivars with incomplete array type but only as the last ivar.
Also add a requirement for ivars th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316381: [Sema] Add support for flexible array members in
Obj-C. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D38773?vs=118990&id=119943#toc
Repository:
rL LLVM
https://re
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D39201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rjmccall added a comment.
The code looks fine to me. The test seems very vague to me, but I'd like Dave
to weigh in on that, because I'm not sure it's reasonable to test the exact
pattern here.
Also, Dave, I don't know what the IR invariants around debug info are. Is this
something we should
vsapsai added inline comments.
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095
+fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType();
+ }
+
rjmccall wrote:
> You can't just use isa<> here; there can be typedefs of incomplete array type.
Thanks fo
tmsriram updated this revision to Diff 119950.
tmsriram added a comment.
Added test test/CodeGen/noplt.c
https://reviews.llvm.org/D39079
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGCall.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Frontend
1 - 100 of 165 matches
Mail list logo
