nik added a comment.
Ping 2
https://reviews.llvm.org/D37554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Wed Sep 20 00:22:00 2017
New Revision: 313729
URL: http://llvm.org/viewvc/llvm-project?rev=313729&view=rev
Log:
Implement C++ [basic.link]p8.
If a function or variable has a type with no linkage (and is not extern "C"),
any use of it requires a definition within the same tran
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313730: [clangd] Introduced Logger interface. (authored by
ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D37972
Files:
clang-tools-extra/trunk/clangd/CMakeLists.txt
clang-tools-extra/tr
Author: ibiryukov
Date: Wed Sep 20 00:24:15 2017
New Revision: 313730
URL: http://llvm.org/viewvc/llvm-project?rev=313730&view=rev
Log:
[clangd] Introduced Logger interface.
Summary: This fixes a bunch of logging-related FIXMEs.
Reviewers: bkramer, krasimir, malaperle
Reviewed By: malaperle
Su
ilya-biryukov added a comment.
In https://reviews.llvm.org/D36150#875623, @Nebiroth wrote:
> In https://reviews.llvm.org/D36150#867971, @ilya-biryukov wrote:
>
> > Overall looks good, but still needs at least a few tests.
>
>
> I have a test for this commit that uses included source and header fi
Typz added a comment.
This cannot be implemented where we currently call breakProtrudingToken(),
since this function starts by 'creating' the BreakableToken and dealing with
meany corner cases: so this should be done before in any case.
But the code at the end of breakProtrudingToken() is actual
chrib added a comment.
oops yes of course. I forgot some bits while switching from testing the arch to
testing the platform.
indeed --target=arm-none-linux-gnueabihf lost its unwind info in c++.
Surprisingly not caught by the llvm tests, will add some.
thanks
https://reviews.llvm.org/D31140
klimek added a comment.
In https://reviews.llvm.org/D33589#876196, @Typz wrote:
> This cannot be implemented where we currently call breakProtrudingToken(),
> since this function starts by 'creating' the BreakableToken and dealing with
> meany corner cases: so this should be done before in any
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Thanks for the patch. Overall looks good, just a few comments.
Could you also add some tests?
Comment at: clangd/ClangdServer.h:243
+ /// Provide sig
joerg added a comment.
Well, the background for the use of the option in NetBSD is related to inducted
differences in reproducable builds. From that perspective, it is even worth to
sometimes shorten the dependency and sometimes not.
https://reviews.llvm.org/D37954
_
alexfh added a comment.
Actually, after looking at the getBestDynamicClassType() implementation, I'm
pretty sure it does all things IgnoreImpCasts() used to do that are relevant to
the use case. So the patch seems to be trivially correct. Other reviewers'
comments (if any) can be addressed post
alberto_magni added a comment.
Hi all,
this change is causing busybox to fail to compile.
The faulty enum is here:
https://git.busybox.net/busybox/tree/include/libbb.h#n639
The nested union is inside a sizeof statement.
Something like this:
enum {
A = sizeof(union {
int x;
int
klimek added a comment.
I think instead of introducing more and more special cases of macros we might
want to handle, we should instead allow specifying macro productions globally.
https://reviews.llvm.org/D37813
___
cfe-commits mailing list
cfe-co
Author: klimek
Date: Wed Sep 20 02:29:37 2017
New Revision: 313742
URL: http://llvm.org/viewvc/llvm-project?rev=313742&view=rev
Log:
Fix clang-format's detection of structured bindings.
Correctly determine when [ is part of a structured binding instead of a
lambda.
To be able to reuse the implem
klimek added a comment.
1. Can you rebase after r313742? I fixed detection of structured bindings in
the UnwrappedLineParser, that might affect this patch
2. Isn't LLVM style the reverse? That is, shouldn't that be
LLVM style:
auto &&[a, b] = ...
Pointer/Ref-to-type-style:
auto&& [a,
Author: klimek
Date: Wed Sep 20 02:51:03 2017
New Revision: 313744
URL: http://llvm.org/viewvc/llvm-project?rev=313744&view=rev
Log:
clang-format clang-format.
Modified:
cfe/trunk/lib/Format/BreakableToken.cpp
cfe/trunk/lib/Format/ContinuationIndenter.cpp
cfe/trunk/lib/Format/Format.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313745: [Sema] Move some stuff into
-Wtautological-unsigned-enum-zero-compare (authored by lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D37629?vs=115903&id=115977#toc
Repository:
rL
Author: lebedevri
Date: Wed Sep 20 02:54:47 2017
New Revision: 313745
URL: http://llvm.org/viewvc/llvm-project?rev=313745&view=rev
Log:
[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare
Recommit. Original commit was reverted because buildbots broke.
The error was only reproduc
Author: lebedevri
Date: Wed Sep 20 03:15:27 2017
New Revision: 313747
URL: http://llvm.org/viewvc/llvm-project?rev=313747&view=rev
Log:
[Sema] CheckTautologicalComparisonWithZero(): always complain about enums
Hopefully fixes test-clang-msc-x64-on-i686-linux-RA build.
The underlying problem is t
tcanens created this revision.
tcanens added a project: clang.
https://bugs.llvm.org/show_bug.cgi?id=34668
Pretty straightforward.
Repository:
rL LLVM
https://reviews.llvm.org/D38075
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx2a-pointer-to-const-ref-member.cpp
Index: test/SemaCXX
On Sat, Sep 9, 2017 at 12:56 AM, Aaron Ballman wrote:
> On Fri, Sep 8, 2017 at 5:49 PM, Hans Wennborg via cfe-commits
> wrote:
>> On Fri, Sep 8, 2017 at 2:26 PM, Friedman, Eli
>> wrote:
>>> On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote:
On Fri, Sep 8, 2017 at 2:09 PM, Roman
klimek added inline comments.
Comment at: clangd/ClangdServer.cpp:321-324
+// FIXME(ibiryukov): get rid of '<' comparison here. In the current
+// implementation diagnostics will not be reported after version counters'
+// overflow. This should not happen in practice,
Author: ibiryukov
Date: Wed Sep 20 03:46:58 2017
New Revision: 313749
URL: http://llvm.org/viewvc/llvm-project?rev=313749&view=rev
Log:
[clangd] Run clang-format on ClangdUnit.cpp. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUni
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:321-324
+// FIXME(ibiryukov): get rid of '<' comparison here. In the current
+// implementation diagnostics will not be reported after version counters'
+// overflow. This should not happen in pr
ilya-biryukov created this revision.
https://reviews.llvm.org/D38077
Files:
clangd/ClangdUnit.cpp
test/clangd/authority-less-uri.test
test/clangd/completion-priorities.test
test/clangd/completion-snippet.test
test/clangd/completion.test
test/clangd/protocol.test
Index: test/clangd/pr
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clangd/ClangdServer.h:287
+ std::mutex DiagnosticsMutex;
+ llvm::StringMap ReportedDiagnosticVersions;
};
Comment what it maps from.
ilya-biryukov updated this revision to Diff 115985.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Added a comment to version map.
- Fixed compilation after rebase.
https://reviews.llvm.org/D38032
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clang
ilya-biryukov added a comment.
Thanks for the review!
https://reviews.llvm.org/D38032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Wed Sep 20 05:16:35 2017
New Revision: 313752
URL: http://llvm.org/viewvc/llvm-project?rev=313752&view=rev
Log:
[clang-tidy] Fix linkage-related compiler errors in clang-tidy tests
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-inefficient-algorithm.cpp
clang-
On Wed, Sep 20, 2017 at 6:15 AM, Roman Lebedev via cfe-commits
wrote:
> Author: lebedevri
> Date: Wed Sep 20 03:15:27 2017
> New Revision: 313747
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313747&view=rev
> Log:
> [Sema] CheckTautologicalComparisonWithZero(): always complain about enums
>
>
curdeius abandoned this revision.
curdeius added a comment.
This was fixed by https://reviews.llvm.org/rL312904 and other commits.
https://reviews.llvm.org/D13811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: ibiryukov
Date: Wed Sep 20 05:58:55 2017
New Revision: 313754
URL: http://llvm.org/viewvc/llvm-project?rev=313754&view=rev
Log:
[clangd] Serialize onDiagnosticsReady callbacks for the same file.
Summary:
Calls to onDiagnosticsReady were done concurrently before. This sometimes
led to olde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313754: [clangd] Serialize onDiagnosticsReady callbacks for
the same file. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38032
Files:
clang-tools-extra/trunk/clangd/ClangdSe
On 16 August 2017 at 02:49, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Aug 15 18:49:53 2017
> New Revision: 310983
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310983&view=rev
> Log:
> PR19668, PR23034: Fix handling of move constructors and
Author: lebedevri
Date: Wed Sep 20 06:50:01 2017
New Revision: 313756
URL: http://llvm.org/viewvc/llvm-project?rev=313756&view=rev
Log:
Replace r313747, don't always warn on enums, rework testcases.
As Aaron Ballman has pointed out, that is not really correct.
So the key problem there is the inva
krasimir added a comment.
This is how you could add a test in `NamespaceEndCommentsFixerTest.cpp`:
TEST_F(NamespaceEndCommentsFixerTest, FixesNamespaceCommentsInAllmanStyle) {
FormatStyle AllmanStyle = getLLVMStyle();
AllmanStyle.BreakBeforeBraces = FormatStyle::BS_Allman;
EXPECT_EQ
ilya-biryukov created this revision.
Herald added a subscriber: eraman.
It will move destructors and operators to the end of completion list.
Destructors and operators are currently very high on the completion
list, as they have the same priority as member functions. However,
they are clearly not
krasimir updated this revision to Diff 115998.
krasimir added a comment.
- Stable sort using declarations
https://reviews.llvm.org/D37263
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/UsingDeclarationsSorterTest.cpp
Index: unittests/Format/UsingDeclarationsSorterTest.cpp
=
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Makes sense.
https://reviews.llvm.org/D38077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
krasimir added a comment.
+1! I totally agree with this!
https://reviews.llvm.org/D38081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov created this revision.
Completion results look much nicer without them.
Informative qualifiers are stored for every method from a base class, even when
calling those methods does not require any qualifiers. For example,
struct Foo { int foo(); };
struct Bar : Foo { };
void tes
Author: ibiryukov
Date: Wed Sep 20 08:09:14 2017
New Revision: 313759
URL: http://llvm.org/viewvc/llvm-project?rev=313759&view=rev
Log:
[clangd] Put inacessible items to the end of completion list.
Reviewers: bkramer, krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313759: [clangd] Put inacessible items to the end of
completion list. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38077
Files:
clang-tools-extra/trunk/clangd/ClangdUnit.cp
ilya-biryukov added a comment.
Thanks for quick review!
https://reviews.llvm.org/D38077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
curdeius added a comment.
That's precisely what I've written, but, as I'd said before, such tests pass
already without any modification in `NamespaceEndCommentsFixer`.
https://reviews.llvm.org/D37904
___
cfe-commits mailing list
cfe-commits@lists.l
Author: sepavloff
Date: Wed Sep 20 08:22:27 2017
New Revision: 313760
URL: http://llvm.org/viewvc/llvm-project?rev=313760&view=rev
Log:
Put target deduced from executable name at the start of argument list
When clang is called as 'target-clang', put deduced target option at
the start of argument
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:24
+withInitializer(cxxConstructExpr(unless(hasDescendant(implicitCastExpr(
+.bind("cruct-expr")));
+
You pick a more readable name than
Author: zturner
Date: Wed Sep 20 09:01:50 2017
New Revision: 313763
URL: http://llvm.org/viewvc/llvm-project?rev=313763&view=rev
Log:
Make libcxx tests work when llvm sources are not present.
Despite a strong CMake warning that this is an unsupported
libcxx build configuration, some bots still re
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One small nit. LGTM otherwise.
Comment at: test/Driver/openmp-offload-gpu.c:133
+/// Check that the flag is passed when -fopenmp-relocatable-target is used.
+// RUN: %clang -###
tra added inline comments.
Comment at: test/OpenMP/target_map_codegen.cpp:4845
+///==///
+// RUN: %clang_cc1 -DCK30 -std=c++11 -fopenmp -S -emit-llvm -fopenmp
-fopenmp-targets=nvptx64-nvidia-cuda %s -o - 2>&
Author: jvesely
Date: Wed Sep 20 10:28:58 2017
New Revision: 313773
URL: http://llvm.org/viewvc/llvm-project?rev=313773&view=rev
Log:
Add travis CI configuration file
Signed-off-by: Jan Vesely
Added:
libclc/trunk/.travis.yml
Added: libclc/trunk/.travis.yml
URL:
http://llvm.org/viewvc/llvm
Author: marshall
Date: Wed Sep 20 10:34:11 2017
New Revision: 313776
URL: http://llvm.org/viewvc/llvm-project?rev=313776&view=rev
Log:
Fix a bit of UB in __independent_bits_engine. Fixes PR#34663
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://l
Thanks for looking.
It seems your commit exposed some other issue. Now, unfortunately, it has
stopped being reproducible.
Thanks for looking anyway.
A good bug will show itself sooner or later.
Thanks
Galina
On Mon, Sep 18, 2017 at 3:49 PM, Douglas Gregor wrote:
>
> On Sep 18, 2017, at 3:11
Author: akaylor
Date: Wed Sep 20 11:06:44 2017
New Revision: 313784
URL: http://llvm.org/viewvc/llvm-project?rev=313784&view=rev
Log:
Remove offset size check in nullptr arithmetic handling
Differential Revision: https://reviews.llvm.org/D37042
Modified:
cfe/trunk/lib/AST/Expr.cpp
cfe/t
vsapsai added a comment.
Thanks for following up, Alberto. I haven't expected such a use case. It is
possible to achieve the same with `LSA_SIZEOF_SA = sizeof(((len_and_sockaddr
*)0)->u)` but I don't like it and don't want to force developers using such
approach.
For solving this problem I thi
On Wed, Sep 20, 2017 at 2:17 PM, Volodymyr Sapsai via Phabricator via
cfe-commits wrote:
> vsapsai added a comment.
>
> Thanks for following up, Alberto. I haven't expected such a use case. It is
> possible to achieve the same with `LSA_SIZEOF_SA = sizeof(((len_and_sockaddr
> *)0)->u)` but I don
tra created this revision.
Herald added subscribers: hiraditya, sanjoy, jholewinski.
https://reviews.llvm.org/D38090
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Headers/__clang_cuda_intrinsics.h
clang/test/CodeGen/builtins-nvptx-ptx60.
This commit causes the formatting.test to fail on macOS with an uncaught
exception:
libc++abi.dylib: terminating with uncaught exception of type
std::__1::system_error: mutex lock failed: Invalid argument
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/35642/
I'm still looking
Nebiroth updated this revision to Diff 116038.
Nebiroth added a comment.
Added unit test.
https://reviews.llvm.org/D36150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHandlers.h
unittests/clangd/ClangdTest
kfunk added a comment.
Bump? This is a trivial one
https://reviews.llvm.org/D37482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DIVYA added a comment.
ping
https://reviews.llvm.org/D36423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Wed Sep 20 11:32:08 2017
New Revision: 313789
URL: http://llvm.org/viewvc/llvm-project?rev=313789&view=rev
Log:
Mark the __eval methods on independent_bits_engine (and
__independent_bits_engine) as const, since they make no changes to the object.
NFC.
Modified:
libcxx
jlebar added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_intrinsics.h:161
+#endif // __CUDA_VERSION >= 9000 && (!defined(__CUDA_ARCH__) || __CUDA_ARCH__
>=
+ // 300)
+
Nit, better linebreaking in the comment?
Comment at:
cameron314 updated this revision to Diff 116043.
cameron314 added a comment.
Final diff. Test passes!
https://reviews.llvm.org/D37491
Files:
include/clang/Frontend/PrecompiledPreamble.h
include/clang/Lex/Lexer.h
include/clang/Lex/PreprocessorOptions.h
lib/Frontend/FrontendActions.cpp
tra updated this revision to Diff 116047.
tra added a comment.
Addressed Justin's comments.
https://reviews.llvm.org/D38090
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Headers/__clang_cuda_intrinsics.h
clang/test/CodeGen/builtins-nvp
erichkeane created this revision.
__interface types are allowed in MSVC to have "property" data members
(marked with declspec property). This patch alters Sema to allow property
data members.
https://reviews.llvm.org/D38092
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ms-interface.cpp
In
erichkeane added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:2871
+ InvalidDecl =
+ (DS.getStorageClassSpec() == DeclSpec::SCS_typedef || MSPropertyAttr)
+ ? 0
Note: Clang format did this craziness... I'm open to whatever form
Author: cameron314
Date: Wed Sep 20 12:03:37 2017
New Revision: 313796
URL: http://llvm.org/viewvc/llvm-project?rev=313796&view=rev
Log:
[PCH] Fixed preamble breaking with BOM presence (and particularly, fluctuating
BOM presence)
This patch fixes broken preamble-skipping when the preamble region
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313796: [PCH] Fixed preamble breaking with BOM presence (and
particularly, fluctuating… (authored by cameron314).
Changed prior to commit:
https://reviews.llvm.org/D37491?vs=116043&id=116049#toc
Reposi
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
Anastasia wr
Rakete added a comment.
Thanks! That was an oversight on my part, sorry.
Comment at: lib/Sema/SemaExprCXX.cpp:5185
if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) {
// C++2a allows functions with ref-qualifier & if they are also
'const'.
+
I think I know what's wrong. I've already seen those failures. std::mutex
gets destroyed before threads waiting on it are joined.
Will submit a fix shortly.
On Wed, Sep 20, 2017 at 8:22 PM, Alex L wrote:
> This commit causes the formatting.test to fail on macOS with an uncaught
> exception:
>
>
Author: ibiryukov
Date: Wed Sep 20 12:32:06 2017
New Revision: 313801
URL: http://llvm.org/viewvc/llvm-project?rev=313801&view=rev
Log:
[clangd] Fixed crash on MacOS.
Caused by invalid order of members in ClangdServer.
DiagnosticsMutex was used after destruction.
Modified:
clang-tools-extra/
rwols added inline comments.
Comment at: test/clangd/completion-qualifiers.test:12
+# CHECK: {"jsonrpc":"2.0","id":2,"result":[
+# CHEKC-DAG: {"label":"foo()
const","kind":2,"detail":"int","sortText":"00035foo","filterText":"foo","insertText":"foo","insertTextFormat":1}
+# CHEKC
Fixed by r313801.
Sorry for all the trouble.
On Wed, Sep 20, 2017 at 9:22 PM, Ilya Biryukov wrote:
> I think I know what's wrong. I've already seen those failures. std::mutex
> gets destroyed before threads waiting on it are joined.
> Will submit a fix shortly.
>
> On Wed, Sep 20, 2017 at 8:22 P
Author: cameron314
Date: Wed Sep 20 12:37:37 2017
New Revision: 313802
URL: http://llvm.org/viewvc/llvm-project?rev=313802&view=rev
Log:
Fixed unused variable warning introduced in r313796 causing build failure
Modified:
cfe/trunk/lib/Lex/Lexer.cpp
Modified: cfe/trunk/lib/Lex/Lexer.cpp
URL:
Author: marshall
Date: Wed Sep 20 12:38:43 2017
New Revision: 313803
URL: http://llvm.org/viewvc/llvm-project?rev=313803&view=rev
Log:
Revert 313789 because gcc doesn't like it
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/include/random
Modified: libcxx/trunk/include/algorithm
U
vsapsai updated this revision to Diff 116056.
vsapsai added a comment.
- Rename SavePendingDelayedStateRAII to SavePendingParsedClassStateRAII.
https://reviews.llvm.org/D37881
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaTemplateInstantiate.cpp
clang/test/SemaTemplate/crash-u
tcanens added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5185
if (!isIndirect && !LHS.get()->Classify(Context).isLValue()) {
// C++2a allows functions with ref-qualifier & if they are also
'const'.
+if (Proto->isConst() && !Proto->isVolatile())
Author: abataev
Date: Wed Sep 20 13:11:31 2017
New Revision: 313805
URL: http://llvm.org/viewvc/llvm-project?rev=313805&view=rev
Log:
[OPENMP] Support for re-declarations when checking captured variables.
Need to check for variables re-declarations when checking that the
variable was already capt
rnkovacs updated this revision to Diff 116060.
rnkovacs added a comment.
- Accidentally left-in comment removed.
- Checker file clang-formatted.
https://reviews.llvm.org/D35796
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAn
Perfect, thanks!
On 20 September 2017 at 20:33, Ilya Biryukov wrote:
> Fixed by r313801.
> Sorry for all the trouble.
>
> On Wed, Sep 20, 2017 at 9:22 PM, Ilya Biryukov
> wrote:
>
>> I think I know what's wrong. I've already seen those failures. std::mutex
>> gets destroyed before threads waiti
alberto_magni added a comment.
Yes, restricting the error to C++ would work. Many thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D37089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: jvesely
Date: Wed Sep 20 13:42:14 2017
New Revision: 313810
URL: http://llvm.org/viewvc/llvm-project?rev=313810&view=rev
Log:
Implement cl_khr_int64_base_atomics builtins
Signed-off-by: Jan Vesely
Reviewed-by: Aaron Watry
Tested-by: Aaron Watry
Added:
libclc/trunk/generic/include/
Author: jvesely
Date: Wed Sep 20 13:42:19 2017
New Revision: 313811
URL: http://llvm.org/viewvc/llvm-project?rev=313811&view=rev
Log:
Implement cl_khr_int64_extended_atomics builtins
Signed-off-by: Jan Vesely
Reviewed-by: Aaron Watry
Tested-by: Aaron Watry
Added:
libclc/trunk/amdgcn/lib/c
andrew.w.kaylor closed this revision.
andrew.w.kaylor added a comment.
This was committed as r313784. I put the wrong differential revision number in
the comment for that check-in.
https://reviews.llvm.org/D38060
___
cfe-commits mailing list
cfe-c
efriedma added a comment.
Needs testcase.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
I don't think we need to mess with MaxAtomicPromoteWidth?
Probably more intuitive to check "if (hasFea
morehouse updated this revision to Diff 116072.
morehouse added a comment.
- Add test case.
- Use SanitizerScope.
https://reviews.llvm.org/D38063
Files:
clang/lib/CodeGen/CGClass.cpp
clang/test/CodeGenCXX/sanitize-dtor-callback.cpp
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
Author: tra
Date: Wed Sep 20 14:23:07 2017
New Revision: 313820
URL: http://llvm.org/viewvc/llvm-project?rev=313820&view=rev
Log:
[NVPTX] Implemented shfl.sync instruction and supporting intrinsics/builtins.
Differential Revision: https://reviews.llvm.org/D38090
Added:
cfe/trunk/test/CodeGen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313820: [NVPTX] Implemented shfl.sync instruction and
supporting intrinsics/builtins. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38090?vs=116047&id=116073#toc
Repository:
r
lebedev.ri created this revision.
lebedev.ri added a project: clang.
Currently, clang only diagnoses completely out-of-range comparisons (e.g.
`char` and constant `300`),
and comparisons of unsigned and `0`. But gcc also does diagnose the comparisons
with the
`std::numeric_limits<>::max()` / `st
wmi added inline comments.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
efriedma wrote:
> I don't think we need to mess with MaxAtomicPromoteWidth?
>
> Probably more intuitive to check "if (h
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Sema/SemaDeclCXX.cpp:2871
+ InvalidDecl =
+ (DS.getStorageClassSpec() == DeclSpec::SCS_typedef || MSPropertyAttr)
+ ? 0
efriedma added inline comments.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
wmi wrote:
> efriedma wrote:
> > I don't think we need to mess with MaxAtomicPromoteWidth?
> >
> > Probably more i
Thank you!
On 20 September 2017 at 05:16, Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Wed Sep 20 05:16:35 2017
> New Revision: 313752
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313752&view=rev
> Log:
> [clang-tidy] Fix linkage-related co
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
Please also add a tiny LLVM test that call instructions with nosanitize
metadata are not instrumented.
https://reviews.llvm.org/D38063
___
cfe
Author: rsmith
Date: Wed Sep 20 15:17:55 2017
New Revision: 313827
URL: http://llvm.org/viewvc/llvm-project?rev=313827&view=rev
Log:
Give external linkage and mangling to lambdas inside inline variables and
variable templates.
This implements the proposed approach in
https://github.com/itanium-
chh updated this revision to Diff 116092.
chh edited the summary of this revision.
https://reviews.llvm.org/D35743
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
-
Author: erichkeane
Date: Wed Sep 20 15:28:24 2017
New Revision: 313828
URL: http://llvm.org/viewvc/llvm-project?rev=313828&view=rev
Log:
[MS Compat]Allow __interfaces to have properties.
__interface types are allowed in MSVC to have "property" data members
(marked with declspec property). This pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313828: [MS Compat]Allow __interfaces to have properties.
(authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D38092?vs=116046&id=116097#toc
Repository:
rL LLVM
https://revie
1 - 100 of 123 matches
Mail list logo
