coby updated this revision to Diff 114536.
coby added reviewers: myatsina, m_zuckerman.
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/ms-inline-asm-enu
PriMee updated this revision to Diff 114538.
PriMee added a comment.
Done :) Could you please commit this for me?
https://reviews.llvm.org/D37566
Files:
clang-tidy/misc/UnusedParametersCheck.cpp
test/clang-tidy/misc-unused-parameters.cpp
Index: test/clang-tidy/misc-unused-parameters.cpp
=
Author: djasper
Date: Mon Sep 11 00:35:01 2017
New Revision: 312897
URL: http://llvm.org/viewvc/llvm-project?rev=312897&view=rev
Log:
Revert r312830: "Reinstall the patch "Use EmitPointerWithAlignment to get
alignment information of the pointer used in atomic expr"."
This triggers llvm.org/PR316
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D37662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:334
+case OO_Arrow:
+case OO_Call:
+case OO_Subscript:
Why do we need to swap for calls?
https://reviews.llvm.org/D37663
___
kristof.beyls added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:145-146
+ // choose soft mode.
+ if (ThreadPointer == ReadTPMode::Invalid)
+ThreadPointer = ReadTPMode::Soft;
+ return ThreadPointer;
spetrovic wrote:
> kristof.beyls wrote
klimek added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:98-100
+if (CDB)
+ return CDB;
+return nullptr;
Isn't that the same as "return CDB"?
https://reviews.llvm.org/D37150
___
c
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D37634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
NorenaLeonetti marked an inline comment as done.
NorenaLeonetti added a comment.
In https://reviews.llvm.org/D33826#861226, @aaron.ballman wrote:
> Have you run this check over any large code bases to see what the quality of
> the diagnostics are?
`-checks=-*,cert-exp36-c,modernize-unary-stati
NorenaLeonetti updated this revision to Diff 114544.
Repository:
rL LLVM
https://reviews.llvm.org/D33826
Files:
clang-tidy/cert/AvoidPointerCastToMoreStrictAlignmentCheck.cpp
clang-tidy/cert/AvoidPointerCastToMoreStrictAlignmentCheck.h
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#866133, @NorenaLeonetti wrote:
> In https://reviews.llvm.org/D33826#861226, @aaron.ballman wrote:
>
> > Have you run this check over any large code bases to see what the quality
> > of the diagnostics are?
>
>
> `-checks=-*,cert-exp3
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Looks good, just a few minor style comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:100
/// PreambleBounds used to build the preamble
JonasToth added a comment.
There is an exception to the general rule (EXP36-C-EX2), stating that the
result of `malloc` and friends is allowed to be casted to stricter alignments,
since the pointer is known to be of correct alignment.
Could you add a testcase for this case, i think there would c
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
This patch can rely on a post commit review if necessary.
https://reviews.llvm.org/D37416
___
cfe-commits mailing list
cfe-commits@li
dennis.luxen created this revision.
This task is listed in TODO.txt. The implementation swaps mutex against a
spinlock based on atomic_flag. The spin lock itself is implemented as a nested
class in a protected context of the associated state.
https://reviews.llvm.org/D37677
Files:
include/f
ilya-biryukov added a comment.
@rwols, do you have access to svn repo? If not, I can submit this change for
you.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#866161, @JonasToth wrote:
> There is an exception to the general rule (EXP36-C-EX2), stating that the
> result of `malloc` and friends is allowed to be casted to stricter
> alignments, since the pointer is known to be of correct ali
Author: jonastoth
Date: Mon Sep 11 02:20:07 2017
New Revision: 312901
URL: http://llvm.org/viewvc/llvm-project?rev=312901&view=rev
Log:
[clang-tidy] add more aliases for the hicpp module
This patch will introduce even more aliases for the hicpp-module to already
existing
checks and is a follow u
lebedev.ri updated this revision to Diff 114549.
lebedev.ri added a comment.
@alexfh et al: friendly ping :)
Repository:
rL LLVM
https://reviews.llvm.org/D36836
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp
clang-tidy/readabili
hamzasood updated this revision to Diff 114550.
hamzasood added a comment.
- Replaced an unneeded `STLExtras.h` include with ``.
- Assert that the lambda template scope has a parent before accessing it.
- Added an equals in a braced init as per the LLVM coding standards.
Thanks @Rakete
http
Author: krasimir
Date: Mon Sep 11 03:12:16 2017
New Revision: 312904
URL: http://llvm.org/viewvc/llvm-project?rev=312904&view=rev
Log:
[clang-format] Fixed one-line if statement
Summary:
**Short overview:**
Fixed bug: https://bugs.llvm.org/show_bug.cgi?id=34001
Clang-format bug resulting in a st
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312904: [clang-format] Fixed one-line if statement (authored
by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D37140?vs=113979&id=114558#toc
Repository:
rL LLVM
https://reviews.llvm.o
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
https://reviews.llvm.org/D36642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D37642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
PriMee added a comment.
ping
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Overall the code looks good, thanks for the clean-ups.
Only a few minor style comments and a major one about returning value when no
file is matching.
Please add tests
It's a good idea to merge the two. I'll work on moving the ObjC traversal
change when I get the time.
Thanks for the quick patches Johannes!
On 9 September 2017 at 12:03, Johannes Altmanninger
wrote:
> Richard Smith writes:
>
> > I am extremely uncomfortable about the direction this patch seri
szepet updated this revision to Diff 114567.
szepet marked 3 inline comments as done.
szepet added a comment.
Updates based on the comments. Thanks for the reduced test case and the fast
review!
Not sure if in these cases am I allowed to commit (since it was accepted) or
since it was accepted a
RKSimon updated this revision to Diff 114569.
RKSimon added a comment.
Added checks to test case
Repository:
rL LLVM
https://reviews.llvm.org/D37448
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/pr34021.c
Index: test/CodeGen/pr34021.c
==
spetrovic updated this revision to Diff 114573.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
test/Driver/clang-
spetrovic added a comment.
Comments addressed.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kristof.beyls added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:137
+ const Driver &D = TC.getDriver();
+ arm::ReadTPMode ThreadPointer = ReadTPMode::Invalid;
+ if (Arg *A =
With the new version of the code, there's no need to have a Thread
spetrovic added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:149-150
+else
+ D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args);
+ }
+ return ReadTPMode::Soft;
kristof.beyls wrote:
> a return ReadTPMode::Invalid is missing her
arphaman created this revision.
Herald added a subscriber: mgorny.
This patch tries to simplify the interface for the refactoring action rules and
refactoring requirements. It merges the selection constraints and selection
requirements into one class. The refactoring actions rules must now be
i
arphaman added a comment.
@klimek I've added a patch that simplifies the interface and the template code
- https://reviews.llvm.org/D37681. Hopefully you'll find that the code there is
cleaner.
Repository:
rL LLVM
https://reviews.llvm.org/D36574
__
ioeric added a comment.
Feel free to land the patch now if comments are addressed.
Repository:
rL LLVM
https://reviews.llvm.org/D36574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: lebedevri
Date: Mon Sep 11 06:12:31 2017
New Revision: 312912
URL: http://llvm.org/viewvc/llvm-project?rev=312912&view=rev
Log:
[clang-tidy] FunctionSizeCheck: wrap FunctionASTVisitor into anon namespace, NFC
This check is relatively simple, and is often being used
as an example. I'm awar
Author: krobelus
Date: Mon Sep 11 06:12:30 2017
New Revision: 312911
URL: http://llvm.org/viewvc/llvm-project?rev=312911&view=rev
Log:
[AST] Make RecursiveASTVisitor visit TemplateDecls in source order
Summary:
This causes template arguments to be traversed before the templated
declaration, which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312911: [AST] Make RecursiveASTVisitor visit TemplateDecls
in source order (authored by krobelus).
Repository:
rL LLVM
https://reviews.llvm.org/D37662
Files:
cfe/trunk/include/clang/AST/LexicallyOrd
spetrovic updated this revision to Diff 114582.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
test/Driver/clang-
bcraig added a comment.
Is there a benchmark where this demonstrates some performance improvement? I
fear that the switch to condition_variable_any will swamp any performance gains
from the switch to a spin lock.
Also, the spin lock is being held during allocating operations (the exception
th
kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.
Thanks Strahinja!
I thought that some indentations looked a bit strange, so I'd just still check
that clang-format formats your changes the same way.
Otherwise LGTM!
https://rev
On Fri, Sep 8, 2017 at 9:33 PM, Roman Lebedev via Phabricator via
cfe-commits wrote:
> lebedev.ri added a comment.
>
> In https://reviews.llvm.org/D37629#865068, @lebedev.ri wrote:
>
>> And finish reducing the code by for-range-loop`ing over array + use
>> `std::array`.
>
>
> I will need to fix h
spetrovic added a comment.
Thanks for the review! I will check indentations with clang format.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
Still LG. Fine to commit.
Thanks for the fix!
If you find time to construct the test case that triggers both affected code
paths (my test seems to only inspect one of them, IIUC), it would be nice to do
as a follow up.
https://reviews.ll
johannes added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:334
+case OO_Arrow:
+case OO_Call:
+case OO_Subscript:
klimek wrote:
> Why do we need to swap for calls?
The idea is that the opening parenthesis/bracket comes after
jina.nahias updated this revision to Diff 114594.
jina.nahias added a comment.
delete from include/clang/Basic/BuiltinsX86.def and
include/clang/Basic/BuiltinsX86_64.def
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
Inde
chrib updated this revision to Diff 114589.
chrib added a comment.
Hello Eli,
You were right, using IsUnwindTablesDefault is the correct way to abstract the
need for UnwindTables. I missed the relationship between the driver
munwind-table and GodeGenOpts.UnwindTables use in Codegen.
Here is a
cameron314 updated this revision to Diff 114604.
cameron314 added a comment.
Final diff, will commit soon. Thanks!
https://reviews.llvm.org/D37474
Files:
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/ASTUnit.cpp
unittests/Frontend/CMakeLists.txt
unittests/Frontend/PCHPreambl
cameron314 added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:100
/// PreambleBounds used to build the preamble
PreambleBounds getBounds() const;
ilya-biryukov wrote:
> Not introduced by this change, but could you also add a f
Author: cameron314
Date: Mon Sep 11 08:03:23 2017
New Revision: 312917
URL: http://llvm.org/viewvc/llvm-project?rev=312917&view=rev
Log:
[PCH] Allow VFS to be used for tests that generate PCH files
When using a virtual file-system (VFS) and a preamble file (PCH) is generated,
it is generated on-d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312917: [PCH] Allow VFS to be used for tests that generate
PCH files (authored by cameron314).
Changed prior to commit:
https://reviews.llvm.org/D37474?vs=114604&id=114612#toc
Repository:
rL LLVM
ht
erichkeane added a comment.
By my reading of the code, you still haven't fixed this example:
struct __declspec(uuid("---C000-0046")) IUnknown {};
struct IPropertyPageBase : public IUnknown {};
struct IPropertyPage : public IPropertyPageBase {};
__interface foo {
uriel.k created this revision.
This patch, together with a matching llvm patch
(https://reviews.llvm.org/D37693), implements the lowering of X86 ABS
intrinsics to IR.
https://reviews.llvm.org/D37694
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx2-builtins.c
test/CodeGen/avx512bw-buil
krasimir created this revision.
Herald added a subscriber: klimek.
This patch enables `BreakableToken` to manage the formatting of non-trailing
block comments. It is a refinement of https://reviews.llvm.org/D37007.
We discovered that the optimizer outsmarts us on cases where breaking the
comment
Author: mprobst
Date: Mon Sep 11 08:22:52 2017
New Revision: 312918
URL: http://llvm.org/viewvc/llvm-project?rev=312918&view=rev
Log:
clang-format: [JS] wrap and indent `goog.setTestOnly` calls.
Summary:
While `goog.setTestOnly` usually appears in the imports section of a file, it is
not actually
krasimir updated this revision to Diff 114617.
krasimir added a comment.
- Add the original test cases
https://reviews.llvm.org/D37695
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
unittests/Forma
krasimir added a comment.
Yes, I meant that it should at least be controlled by a flag. However, adding
flags to clang-format requires careful consideration, we usually would accept
options that are necessary for commonly used styles with style guides and with
a community willing to support the
Typz added a comment.
ping?
https://reviews.llvm.org/D33589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
https://reviews.llvm.org/D33440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping?
https://reviews.llvm.org/D32478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic updated this revision to Diff 114618.
spetrovic added a comment.
Indentations fixed.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/
compnerd added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
Can we add a test case for static TLS as well please? Also, I think that we
should add a test case for `__
Author: marshall
Date: Mon Sep 11 09:05:42 2017
New Revision: 312923
URL: http://llvm.org/viewvc/llvm-project?rev=312923&view=rev
Log:
Add include of to , since things in there return
strings. Fixes PR#34529.
Added:
libcxx/trunk/test/std/diagnostics/syserr/syserr.errcode/syserr.errcode.ove
compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.
Comment at: lib/CMakeLists.txt:189
+macro(add_msvcrt_defs_if_needed target)
+ if(WIN32 AND NOT MINGW)
Please use `function` rather than
craig.topper added a comment.
I think when you uploaded the changes to remove it from BuiltinsX86.def you
lost your earlier changes to the header files
https://reviews.llvm.org/D37668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Rakete abandoned this revision.
Rakete added a comment.
Agreed. Closing this.
https://reviews.llvm.org/D37667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper added a comment.
Remove the builtins from BuiltinsX86.def
https://reviews.llvm.org/D37694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dennis.luxen added a comment.
In https://reviews.llvm.org/D37677#866362, @bcraig wrote:
> Is there a benchmark where this demonstrates some performance improvement? I
> fear that the switch to condition_variable_any will swamp any performance
> gains from the switch to a spin lock.
>
> Also, t
frutiger added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
compnerd wrote:
> Can we add a test case for static TLS as well please? Also, I think that we
> should add
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I was hoping for a test case that didn't require assertions, but this is enough
to land the fix.
Repository:
rL LLVM
https://reviews.llvm.org/D37448
frutiger added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
frutiger wrote:
> compnerd wrote:
> > Can we add a test case for static TLS as well please? Also, I think t
ilya-biryukov created this revision.
This fixes PR34547.
`Lexer::LexEndOfFile` handles recording of ConditionalStack for
preamble and reporting errors about unmatched conditionalal PP
directives.
However, SkipExcludedConditionalBlock contianed duplicated logic for
reporting errors and clearing Con
ilya-biryukov updated this revision to Diff 114634.
ilya-biryukov added a comment.
Fixed description of the change.
https://reviews.llvm.org/D37700
Files:
lib/Lex/PPDirectives.cpp
test/Index/preamble-conditionals-inverted-with-error.cpp
test/Index/preamble-conditionals-inverted.cpp
Inde
Quuxplusone added a comment.
TODO.txt says "future should use for synchronization." I would have
interpreted this as meaning that the line
unsigned __state_;
should become
std::atomic __state_;
and appropriate loads and stores used so that `__is_ready()` can be checked
without having to
On Tue, Sep 5, 2017 at 2:47 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Sep 5 14:46:22 2017
> New Revision: 312580
>
> URL: http://llvm.org/viewvc/llvm-project?rev=312580&view=rev
> Log:
> Fix memory leak after r312467. The ModuleMap is the o
rwols added a comment.
No, I don't have access to the repo, sorry forgot to mention this.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
In https://reviews.llvm.org/D37677#866743, @Quuxplusone wrote:
> This current patch just swaps out std::mutex for a std::mutex-alike class
> that claims to be faster for uncontested accesses. Definitely safer than my
> interpretation. :) If this patch actually helps, the
Author: marshall
Date: Mon Sep 11 11:10:33 2017
New Revision: 312932
URL: http://llvm.org/viewvc/llvm-project?rev=312932&view=rev
Log:
mark mersenne_twister_engine<>::seed(result_type __sd) with
_LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK to placate UBSAN. Fixes PR#34160
Modified:
libcxx/
frutiger updated this revision to Diff 114640.
frutiger added a comment.
Add test cases for `__declspec(thread)` and static TLS. Clean up formatting to
adhere to the project style.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls
yaxunl created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl.
https://reviews.llvm.org/D37703
Files:
lib/Basic/Targets/AMDGPU.h
test/CodeGenOpenCL/opencl_types.cl
Index: test/CodeGenOpenCL/opencl_types.cl
===
vivekvpandya marked an inline comment as done.
vivekvpandya added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:882-883
BEConsumer = Result.get();
-
+ VMContext->setDiagnosticHandler(llvm::make_unique(
+ CI.getCodeGenOpts(), Result.get()));
// Enable gene
vivekvpandya updated this revision to Diff 114645.
vivekvpandya added a comment.
Update
https://reviews.llvm.org/D37196
Files:
lib/CodeGen/CodeGenAction.cpp
Index: lib/CodeGen/CodeGenAction.cpp
===
--- lib/CodeGen/CodeGenAction
vivekvpandya updated this revision to Diff 114647.
vivekvpandya marked 8 inline comments as done.
https://reviews.llvm.org/D33514
Files:
include/llvm/Analysis/OptimizationDiagnosticInfo.h
include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
include/llvm/IR/DiagnosticHandler.h
include/l
Nebiroth marked 5 inline comments as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:234
+ else
+ResultUri = URI::fromFile("");
+
ilya-biryukov wrote:
> Running `unparse` on an instance created via `URI::fromFile("")` will resul
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/lib/CodeGen/CodeGenModule.h:517
+ /// Return true if we should emit location information for nested
expressions.
+ bool getNestedExpressionLocationsEnable
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D37530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
In https://reviews.llvm.org/D37530#865333, @mstorsjo wrote:
> Attempted implementing Reid's suggestion.
>
> On the mingw-w64 mailing list
> (https://sourceforge.net/p/mingw-w64/mailman/message/36030072/), there were
> points made that it would be better with some mechanism
Nebiroth updated this revision to Diff 114652.
Nebiroth added a comment.
Return value when no file is found is now an empty string instead of file://
Minor code style changes and cleanup.
Ran clang-format on ClangdServer.h
https://reviews.llvm.org/D36150
Files:
clangd/ClangdLSPServer.cpp
cl
Nebiroth updated this revision to Diff 114654.
Nebiroth added a comment.
Simpilified a pointer return value.
https://reviews.llvm.org/D37150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/GlobalCompilationDatabase.cpp
clangd/GlobalCompilation
Author: vmiklos
Date: Mon Sep 11 13:18:38 2017
New Revision: 312942
URL: http://llvm.org/viewvc/llvm-project?rev=312942&view=rev
Log:
clang-rename: let -force handle multiple renames
Summary:
The use case is that renaming multiple symbols in a large enough codebase is
much faster if all of these
Author: compnerd
Date: Mon Sep 11 13:18:09 2017
New Revision: 312941
URL: http://llvm.org/viewvc/llvm-project?rev=312941&view=rev
Log:
Driver: default to `-fno-use-cxatexit` on Windows
This primarily impacts the Windows MSVC and Windows itanium
environments. Windows MSVC does not use `__cxa_atex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312942: clang-rename: let -force handle multiple renames
(authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D37634?vs=114402&id=114663#toc
Repository:
rL LLVM
https://reviews.l
majnemer added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.h:32
#include "clang/Basic/XRayLists.h"
+#include "clang/Frontend/CodeGenOptions.h"
#include "llvm/ADT/DenseMap.h"
Any reason to do this? I'd just keep getNestedExpressionLocationsEnabl
Author: vedantk
Date: Mon Sep 11 13:47:42 2017
New Revision: 312947
URL: http://llvm.org/viewvc/llvm-project?rev=312947&view=rev
Log:
[Lexer] Report more precise skipped regions (PR34166)
This patch teaches the preprocessor to report more precise source ranges for
code that is skipped due to cond
Author: vedantk
Date: Mon Sep 11 13:47:45 2017
New Revision: 312948
URL: http://llvm.org/viewvc/llvm-project?rev=312948&view=rev
Log:
[pp-trace] Update skipped source ranges in tests
Depends on D36642
Modified:
clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
clang-tools-extra/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312947: [Lexer] Report more precise skipped regions
(PR34166) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D36642?vs=114433&id=114676#toc
Repository:
rL LLVM
https://revi
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:32
+__declspec(thread) int tls_declspec;
+""", lang = 'cpp', flags=['-fms-extensions', '-target', 'amd64-win
rnk added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.h:32
#include "clang/Basic/XRayLists.h"
+#include "clang/Frontend/CodeGenOptions.h"
#include "llvm/ADT/DenseMap.h"
majnemer wrote:
> Any reason to do this? I'd just keep getNestedExpressionL
1 - 100 of 127 matches
Mail list logo
