frutiger added inline comments.
================ Comment at: bindings/python/tests/cindex/test_tls_kind.py:14 +int tls_none; +thread_local tls_dynamic; +""", lang = 'cpp') ---------------- compnerd wrote: > Can we add a test case for static TLS as well please? Also, I think that we > should add a test case for `__declspec(thread)`. I will add a test case for static TLS. `__declspec(thread)` is not implemented as a TLS kind on a cursor; instead it is implemented as a child attribute of the cursor. Would you like me to add a test case for that here? ================ Comment at: tools/libclang/CIndex.cpp:7426 + } + } + ---------------- compnerd wrote: > This block is not properly formatted. Please clang-format your code. I will fix this, thank you for the feedback. https://reviews.llvm.org/D37577 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
