[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

ahatanak added a comment. clang currently rejects "void foo(int = a);" and so does gcc. I'm trying to search the defect reports, but it looks like the c++ standard's site is currently unreachable. https://reviews.llvm.org/D36915 ___ cfe-commits m

[PATCH] D33852: Enable __declspec(selectany) on linux

hans added a comment. In https://reviews.llvm.org/D33852#854213, @aaron.ballman wrote: > In https://reviews.llvm.org/D33852#854176, @Prazek wrote: > > > In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote: > > > > > In https://reviews.llvm.org/D33852#853410, @Prazek wrote: > > > > > >

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

rsmith added a comment. This patch appears to be missing some necessary changes in the following places: - lib/Serialization -- round-trip the new information through PCH / modules - lib/AST/StmtPrinter.cpp -- pretty-printing lambdas with explicit template parameters - lib/Sema/TreeTransform.h -

r311935 - [analyzer] Fix crash in modeling arithmetic

Author: alexshap Date: Mon Aug 28 14:15:21 2017 New Revision: 311935 URL: http://llvm.org/viewvc/llvm-project?rev=311935&view=rev Log: [analyzer] Fix crash in modeling arithmetic This diff fixes modeling of arithmetic expressions where pointers are treated as integers (i.e. via C-style / reinte

[PATCH] D37120: [analyzer] Fix modeling arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rL311935: [analyzer] Fix crash in modeling arithmetic (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D37120?vs=112784&id=112967#toc Repository: rL LLVM https://reviews.llvm.

Re: r311857 - Emit static constexpr member as available_externally definition

Sorry for the inconvenience! I will follow-up in the PR. -- Mehdi 2017-08-28 12:42 GMT-07:00 Hans Wennborg : > I reverted this in r311898 as it caused Chromium builds to fail with > an assertion; see PR34348. > > On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Amini via cfe-commits > wrote: > > Autho

LLVM buildmaster will be updated and restarted in 3 hours

Hello everyone, LLVM buildmaster will be updated and restarted in about 3 hours (after 5 PM Pacific time). Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

rsmith added a comment. In https://reviews.llvm.org/D36527#854600, @rsmith wrote: > We'll also need to agree within the cxx-abi-dev list how to mangle lambda > closure types for this form I filed https://github.com/itanium-cxx-abi/cxx-abi/issues/31 for this. https://reviews.llvm.org/D36527

r311936 - Remove trailing space.

Author: ruiu Date: Mon Aug 28 14:38:14 2017 New Revision: 311936 URL: http://llvm.org/viewvc/llvm-project?rev=311936&view=rev Log: Remove trailing space. Modified: cfe/trunk/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp URL:

[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

thakis created this revision. Makes the warning useful again in a std::unique_ptr world, PR28460. https://reviews.llvm.org/D37235 Files: include/clang/Basic/DiagnosticSemaKinds.td test/SemaCXX/destructor.cpp Index: test/SemaCXX/destructor.cpp ==

Re: [PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

I had compiled a bunch of code with this, but right after I sent this out my local build of something failed with this: ../../buildtools/third_party/libc++/trunk/include/type_traits:2156:51: error: destructor called on non-final 'Ice::VariableDeclaration::RelocInitializer' that has virtual functio

[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

thakis updated this revision to Diff 112981. thakis edited the summary of this revision. thakis added a comment. Don't warn in unevaluated contexts. Ready for a look now. https://reviews.llvm.org/D37235 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/SemaCX

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. Trying to understand the broader context here, I looked back through the list of revisions mentioned in PR33930 to see if that helped. When called on a method, CodeGenModule::EmitGlobalDefinition() calls CodeGenModule::EmitGlobalFunctionDefinition(), which in turn cal

[PATCH] D34512: Add preliminary Cross Translation Unit support library

dcoughlin added a comment. Except for some drive-by nits, this is a high-level review. I have some high-level questions about the design of the library: 1. **How do you intend to handle the case when there are multiple function definitions with the same USR?** Whose responsibility it is to deal

r311947 - [analyzer] Adjust ptr arithmetic test

Author: alexshap Date: Mon Aug 28 15:58:54 2017 New Revision: 311947 URL: http://llvm.org/viewvc/llvm-project?rev=311947&view=rev Log: [analyzer] Adjust ptr arithmetic test Replace "long" with __UINTPTR_TYPE__ to make the test added in rL311935 Windows-friendly. Caught by the buildbot llvm-clang-

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

mclow.lists added a comment. I committed as r311952 which fixes this - based on Jan's suggestion, but not quite the same as this patch. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. (if you'd prefer to wait for Reid or Richard to take a look, that's OK too :) ) Looks good to me, though wouldn't mind if the tests were a bit simpler - if they can be made so.

[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

rsmith added inline comments. Comment at: test/SemaCXX/destructor.cpp:27 +#define BE_THE_HEADER +#include __FILE__ + Do we guarantee that `__FILE__` names a path that can be used to include the current file? In other tests, we add `-include %s` to the `RUN:` lin

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Seems like a rather complex test case - could you explain what's going on there? (maybe in the form of a comment in the code - what path through all those classes is required to tickle this) On Wed, Aug 23, 2017 at 2:25 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Autho

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

It's possible that this testcase can be golfed some more. I copied it almost verbatim from the PR. I'll see what I can do. The important thing is that it needs to trigger the situation where the frontend is creating an inlined function. -- adrian > On Aug 28, 2017, at 4:43 PM, David Blaikie wr

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

*nod* Thanks - let me know if you have trouble simplifying or explaining it & I'll see if fresh eyes help :) On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl wrote: > It's possible that this testcase can be golfed some more. I copied it > almost verbatim from the PR. I'll see what I can do. The imp

Re: [PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

On Fri, Aug 18, 2017 at 6:59 PM Stephan T. Lavavej via Phabricator via cfe-commits wrote: > STL_MSFT added a comment. > > In https://reviews.llvm.org/D36860#846232, @thakis wrote: > > > Many driver tests check in a basic representative directory structure > (e.g. test/Driver/Inputs/basic_freebsd_

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. In https://reviews.llvm.org/D37038#854722, @probinson wrote: > finalizeSubprogram() retrieves the variables from the subprogram and handles > them; what is it missing? For temp-md-nodes2.cpp, the assertion in mapTopLevelUniquedNode() trips on a DICompositeType for C

Re: [PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator via cfe-commits wrote: > rsmith added inline comments. > > > > Comment at: test/SemaCXX/destructor.cpp:27 > +#define BE_THE_HEADER > +#include __FILE__ > + > > Do we guarantee that `__FILE_

Re: [PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

On 28 August 2017 at 13:47, Akira Hatanaka via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > clang currently rejects "void foo(int = a);" and so does gcc. > > I'm trying to search the defect reports, but it looks like the c++ > standard's site is currently unreachable. It's

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

Feels like this alignment attribute may be a bit of a death trap, then? Should other uses of the attribute be scrutinized, or could we come up with a portable way to use it safely? (using a different attribute on different compilers - sounded like maybe one form worked with MSVC and a different for

r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Author: yamaguchi Date: Mon Aug 28 17:09:31 2017 New Revision: 311958 URL: http://llvm.org/viewvc/llvm-project?rev=311958&view=rev Log: Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags" This reverts commit 7c46b80c022e18d43c1fdafb117b0c409c5a6d1e. r311552 brok

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote: > Feels like this alignment attribute may be a bit of a death trap, then? > Should other uses of the attribute be scrutinized, or could we come up with > a portable way to use it safely? (using a different attribute on different > compilers -

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

On Mon, Aug 28, 2017 at 5:21 PM Reid Kleckner wrote: > On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote: > >> Feels like this alignment attribute may be a bit of a death trap, then? >> Should other uses of the attribute be scrutinized, or could we come up with >> a portable way to use it saf

[PATCH] D36057: Use class to pass information about executable name

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Fine with me. -eric https://reviews.llvm.org/D36057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D37188#854144, @mgorny wrote: > I might be missing something but currently clang-tidy is not built at all > when static analyzer is disabled. Yes, but it could be

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. Dumping the whole module, the temporary DICompositeType node for CBdVfsImpl is used both as the scope node for the DISubprogram, and also as the baseType of a DIDerivedType which is a pointer type in the type list for the subprogram. Given that the DICompositeType is

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added a comment. In https://reviews.llvm.org/D36527#854600, @rsmith wrote: > This patch appears to be missing some necessary changes in the following > places: > > - lib/Serialization -- round-trip the new information through PCH / modules Shouldn't the explicit template parameter info

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added a comment. In https://reviews.llvm.org/D36527#854883, @faisalv wrote: > > Interestingly we don't (explicitly) visit the lambda's function parameters? This is obviously false - sorry :) https://reviews.llvm.org/D36527 ___ cfe-comm

[libcxx] r311967 - Fix test for C++03

Author: marshall Date: Mon Aug 28 18:10:51 2017 New Revision: 311967 URL: http://llvm.org/viewvc/llvm-project?rev=311967&view=rev Log: Fix test for C++03 Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.merge/inplace_merge_comp.pass.cpp Modified: libcxx/trunk/test/std/algorithms/

r311970 - Improve constant expression evaluation of arrays of unknown bound.

Author: rsmith Date: Mon Aug 28 18:52:13 2017 New Revision: 311970 URL: http://llvm.org/viewvc/llvm-project?rev=311970&view=rev Log: Improve constant expression evaluation of arrays of unknown bound. The standard is not clear on how these are supposed to be handled, so we conservatively treat as

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

This revision was automatically updated to reflect the committed changes. Closed by commit rL311971: [Bash-autocompletion] Add support for -std= (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D36820?vs=111804&id=113009#toc Repository: rL LLVM https://reviews.llvm

r311971 - [Bash-autocompletion] Add support for -std=

Author: yamaguchi Date: Mon Aug 28 19:01:56 2017 New Revision: 311971 URL: http://llvm.org/viewvc/llvm-project?rev=311971&view=rev Log: [Bash-autocompletion] Add support for -std= Summary: Add support for autocompleting values of -std= by including LangStandards.def. This patch relies on D36782,

r311975 - revert r311839 (ongoing cwg discussion)

Author: faisalv Date: Mon Aug 28 20:04:13 2017 New Revision: 311975 URL: http://llvm.org/viewvc/llvm-project?rev=311975&view=rev Log: revert r311839 (ongoing cwg discussion) apologies. Modified: cfe/trunk/lib/Sema/SemaExprMember.cpp cfe/trunk/test/SemaCXX/member-expr.cpp Modified: cfe/t

[PATCH] D37203: [Bash-autocompletion] Follow up patch for D36782

yamaguchi abandoned this revision. yamaguchi added a comment. https://reviews.llvm.org/D37217 has already landed, so we don't need this anymore. https://reviews.llvm.org/D37203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

yamaguchi created this revision. We wrote many codes in HandleImediateArgs, so I've refactored it into handleAutocompletions. https://reviews.llvm.org/D37249 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp ==

r311981 - Use class to pass information about executable name

Author: sepavloff Date: Mon Aug 28 22:22:26 2017 New Revision: 311981 URL: http://llvm.org/viewvc/llvm-project?rev=311981&view=rev Log: Use class to pass information about executable name Information about clang executable name components, such as target and driver mode, was passes in std::pair.

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete updated this revision to Diff 113020. Rakete added a comment. Updated test to use the -std=c++17 option + friendly ping https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp Index: test/CXX/expr/expr.prim/expr.prim.fold

[PATCH] D36057: Use class to pass information about executable name

This revision was automatically updated to reflect the committed changes. Closed by commit rL311981: Use class to pass information about executable name (authored by sepavloff). Repository: rL LLVM https://reviews.llvm.org/D36057 Files: cfe/trunk/include/clang/Driver/Driver.h cfe/trunk/in

[PATCH] D36057: Use class to pass information about executable name

sepavloff added a comment. @echristo Committed, thanks. Repository: rL LLVM https://reviews.llvm.org/D36057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer

mgorny added a comment. Thanks for the clarification. Repository: rL LLVM https://reviews.llvm.org/D37188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL311983: [cmake] Support running extra clang tool tests without static analyzer (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D37188?vs=112811&id=113024#toc Repository: rL LL

[clang-tools-extra] r311983 - [cmake] Support running extra clang tool tests without static analyzer

Author: mgorny Date: Mon Aug 28 22:58:08 2017 New Revision: 311983 URL: http://llvm.org/viewvc/llvm-project?rev=311983&view=rev Log: [cmake] Support running extra clang tool tests without static analyzer Support running the extra clang tool tests when the static analyzer is disabled. Disable the

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

teemperor added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1160 +void Driver::handleAutocompletions(const llvm::opt::Arg *A) const { + // Print out all options that start with a given argument. This is used for I think a more generic interface wo

[clang-tools-extra] r311984 - [clang-tidy] Fix 'misc-misplaced-widening-cast' assertion error.

Author: danielmarjamaki Date: Mon Aug 28 23:25:24 2017 New Revision: 311984 URL: http://llvm.org/viewvc/llvm-project?rev=311984&view=rev Log: [clang-tidy] Fix 'misc-misplaced-widening-cast' assertion error. Reviewers: alexfh, xazax.hun, danielmarjamaki Differential Revision: http://reviews.llvm.

[PATCH] D36670: misc-misplaced-widening-cast: fix assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rL311984: [clang-tidy] Fix 'misc-misplaced-widening-cast' assertion error. (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D36670?vs=110940&id=113026#toc Repository: rL

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

yamaguchi updated this revision to Diff 113027. yamaguchi marked an inline comment as done. yamaguchi added a comment. Update diff. I agree that this is more generic. https://reviews.llvm.org/D37249 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp Index: clang/lib/Dri

<    1   2