faisalv added inline comments.
Comment at: lib/AST/ExprCXX.cpp:979
+SourceRange LambdaExpr::getExplicitTemplateParameterListRange() const {
+ TemplateParameterList *List = getTemplateParameterList();
I think this should return an invalid range if getExplicitCo
NoQ added a comment.
I guess we'd need more assertions to catch invalid symbols, will have a look.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:371-373
+return makeSymExprValNN(
+state, op, lhs.castAs(),
+rhs.castAs(), re
hamzasood added inline comments.
Comment at: lib/AST/ExprCXX.cpp:979
+SourceRange LambdaExpr::getExplicitTemplateParameterListRange() const {
+ TemplateParameterList *List = getTemplateParameterList();
faisalv wrote:
> I think this should return an invalid ran
arphaman marked 5 inline comments as done.
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRules.h:33
+///
+/// - requiredSelection: The refactoring function won't be invoked unless the
+/// given selection req
arphaman updated this revision to Diff 112678.
arphaman added a comment.
- Get rid of `RefactoringResult` in favour of different rule types.
- Rename `RefactoringOperation` to `RefactoringRuleContext`.
- Address a couple more comments.
Repository:
rL LLVM
https://reviews.llvm.org/D36075
Fil
PriMee created this revision.
Herald added a subscriber: klimek.
**Short overview:**
Fixed bug: https://bugs.llvm.org/show_bug.cgi?id=34001
Clang-format bug resulting in a strange behavior of control statements short
blocks. Different flags combinations do not guarantee expected result. Turned
arphaman added a comment.
Can you remove `getNodeValue` now or do you still need it?
https://reviews.llvm.org/D37001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst created this revision.
Herald added a subscriber: klimek.
Previously, clang-format would try to wrap template string substitutions
by indenting relative to the openening `${`. This helped with
indenting structured strings, such as strings containing HTML, as the
substitutions would be alig
PriMee created this revision.
Herald added a subscriber: klimek.
Bug: https://bugs.llvm.org/show_bug.cgi?id=34016
**Problem:**
Clang format does not allow the flag **BraceWrapping.AfterEnum** control the
case when our **enum** is preceded by **typedef** keyword (what is common in C
language).
arphaman added a comment.
I don't think AST manipulation is the right way to do patching. You've already
hit the limitations here in this patch where you can't really remove a
statement unless its parent is a `CompoundStmt`.
I think the right way to do AST patching is to take a 3rd AST(lets cal
krasimir added a comment.
These look like they could be two separate patches: I like the `typedef enum`
part, not convinced about the `extern` part. Also, please add unit tests.
https://reviews.llvm.org/D37143
___
cfe-commits mailing list
cfe-commi
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Please don't forget go add cfe-commits to subscribers when you create a
differential revision.
LG with one comment.
Comment at: clang-tidy/tool/run-clang-tidy.py:242
#
arphaman added a comment.
@doug.gregor Ping
Repository:
rL LLVM
https://reviews.llvm.org/D36790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
johannes added a comment.
In https://reviews.llvm.org/D37001#852442, @arphaman wrote:
> Can you remove `getNodeValue` now or do you still need it?
It is only used in the client, I think it makes sense to move it there, or to
remove it altogether.
I think I'd keep it in the client for now, to d
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3851
+ ->getType()
+ ->getPointerAddressSpace();
const unsigned ArgAddrSpace =
--
johannes added inline comments.
Comment at: tools/clang-diff/ClangDiff.cpp:319
+ "A Binary operator is supposed to have two arguments.");
+for (int I : {1, 0, 2})
+ Offset = printHtmlForNode(OS, Diff, Tree, IsLeft, Children[I], Offset);
arphama
arphaman added inline comments.
Comment at: tools/clang-diff/ClangDiff.cpp:319
+ "A Binary operator is supposed to have two arguments.");
+for (int I : {1, 0, 2})
+ Offset = printHtmlForNode(OS, Diff, Tree, IsLeft, Children[I], Offset);
johanne
Author: abataev
Date: Fri Aug 25 08:43:55 2017
New Revision: 311777
URL: http://llvm.org/viewvc/llvm-project?rev=311777&view=rev
Log:
[OPENMP] Fix for PR34321: ustom OpenMP reduction in C++ template causes
SEGFAULT at compile time
Compiler crashed when tried to rebuild non-template expression in
Author: arphaman
Date: Fri Aug 25 08:48:00 2017
New Revision: 311778
URL: http://llvm.org/viewvc/llvm-project?rev=311778&view=rev
Log:
[Basic] Add a DiagnosticError llvm::ErrorInfo subclass
Clang's DiagnosticError is an llvm::Error payload that stores a partial
diagnostic and its location. I'll b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311778: [Basic] Add a DiagnosticError llvm::ErrorInfo
subclass (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36969?vs=112327&id=112700#toc
Repository:
rL LLVM
https://re
On Thu, Aug 24, 2017 at 1:04 PM, Reid Kleckner via Phabricator via
cfe-commits wrote:
> rnk added a comment.
>
> Re: jumps out of __try, I wonder if you can tie __finally into whatever
> the CFG does for C++ destructors.
>
Given
$ cat test.cc
struct C {
C();
~C();
};
bool g();
void h();
vo
Nebiroth created this revision.
Adds compileCommands command line argument to specify an absolute path directly
to the requested compile_commands.json for flags.
https://reviews.llvm.org/D37150
Files:
clangd/GlobalCompilationDatabase.cpp
Index: clangd/GlobalCompilationDatabase.cpp
=
Author: arphaman
Date: Fri Aug 25 09:12:17 2017
New Revision: 311779
URL: http://llvm.org/viewvc/llvm-project?rev=311779&view=rev
Log:
[ObjC] Add a -Wobjc-messaging-id warning
-Wobjc-messaging-id is a new, non-default warning that warns about
message sends to unqualified id in Objective-C. This w
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:202
+
+ // Initializer of class constructors, that initialize owners.
+ if (OwnerInitializer) {
Can remove the comma.
Comment at: clang-tidy/c
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:364
if (symLHS && symRHS &&
- (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
+ (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
re
andrew.w.kaylor added a comment.
In https://reviews.llvm.org/D37042#850676, @hfinkel wrote:
> I'd really like to see this done in some way such that we can issue a warning
> along with generating well-defined code. The warning can specifically state
> that the code is using an extension, etc.
johannes updated this revision to Diff 112707.
johannes added a comment.
test ordering, class template
https://reviews.llvm.org/D36998
Files:
include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h
include/clang/AST/RecursiveASTVisitor.h
unittests/Tooling/LexicallyOrderedRecursiveASTVisit
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3861
< Align.getQuantity()) ||
(ArgInfo.getIndirectByVal() && (RVAddrSpace != ArgAddrSpace))) {
// Create an aligned temporary, and co
efriedma added a comment.
It would be nice to warn on any nullptr arithmetic, yes. (We probably want the
wording of the warning to be a bit different if we're activating this
workaround.)
https://reviews.llvm.org/D37042
___
cfe-commits mailing li
hfinkel added a comment.
In https://reviews.llvm.org/D37042#852733, @efriedma wrote:
> It would be nice to warn on any nullptr arithmetic, yes. (We probably want
> the wording of the warning to be a bit different if we're activating this
> workaround.)
+1 (I'll likely want the ability to tur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311787: [Frontend] Fix printing policy for AST context
loaded from file (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D35271?vs=112334&id=112718#toc
Repository:
rL LLVM
ht
Author: vedantk
Date: Fri Aug 25 11:07:03 2017
New Revision: 311787
URL: http://llvm.org/viewvc/llvm-project?rev=311787&view=rev
Log:
[Frontend] Fix printing policy for AST context loaded from file
In ASTUnit::LoadFromASTFile, the context object is set up using
default-constructed LangOptions (wh
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:371-373
+return makeSymExprValNN(
+state, op, lhs.castAs(),
+rhs.castAs(), resultTy);
NoQ wrote:
> For now this code would return
Author: faisalv
Date: Fri Aug 25 11:24:20 2017
New Revision: 311788
URL: http://llvm.org/viewvc/llvm-project?rev=311788&view=rev
Log:
[NFC] Remove a cstyle cast and replace some uses of Decl with NamedDecl during
the processing of TemplateParameterLists.
Modified:
cfe/trunk/include/clang/Par
morehouse created this revision.
Herald added a subscriber: hiraditya.
- Don't sanitize __sancov_lowest_stack.
- Don't instrument leaf functions.
- Add CoverageStackDepth to Fuzzer and FuzzerNoLink.
https://reviews.llvm.org/D37156
Files:
clang/lib/Driver/SanitizerArgs.cpp
compiler-rt/test/f
probinson added a comment.
I would prefer a diagnostic if PS4 && >3.2. Whether you map "latest" to 3.2 or
diagnose that also, up to you, I'm okay either way.
Repository:
rL LLVM
https://reviews.llvm.org/D36501
___
cfe-commits mailing list
cfe-c
Author: nico
Date: Fri Aug 25 11:41:41 2017
New Revision: 311790
URL: http://llvm.org/viewvc/llvm-project?rev=311790&view=rev
Log:
Fix typo in comment, no behavior change.
Modified:
cfe/trunk/lib/CodeGen/CGCleanup.cpp
Modified: cfe/trunk/lib/CodeGen/CGCleanup.cpp
URL:
http://llvm.org/viewvc
kcc added a comment.
Did you check this on something other than the unit tests?
E.g. a couple of benchmarks from fuzzer-test-suite?
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:177
+bool IsLeafFunc(const Function &F) {
+ for (const BasicBlock &BB :
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:363
case nonloc::LocAsIntegerKind:
return evalBinOpLL(state, op, lhsL,
rhs.castAs().getLoc(),
@NoQ , @dcoughlin
while we a
rsmith added a comment.
In https://reviews.llvm.org/D36501#852765, @probinson wrote:
> I would prefer a diagnostic if PS4 && >3.2. Whether you map "latest" to 3.2
> or diagnose that also, up to you, I'm okay either way.
On reflection, I don't think doing anything special for PS4 here is reall
Author: djasper
Date: Fri Aug 25 12:14:53 2017
New Revision: 311792
URL: http://llvm.org/viewvc/llvm-project?rev=311792&view=rev
Log:
[Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for
alignments
Indent should be compared before nesting level to determine if a token
is on th
Author: kcc
Date: Fri Aug 25 12:29:47 2017
New Revision: 311794
URL: http://llvm.org/viewvc/llvm-project?rev=311794&view=rev
Log:
[sanitizer-coverage] extend fsanitize-coverage=pc-table with flags for every PC
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerC
rjmccall added a comment.
The only thing I would say here is that, as a platform vendor, I would like the
ability to opt in to ABI fixes that aren't in my base-line version. In
particular, we're generally more aggressive about taking C++ ABI fixes on
Darwin when there's a strong argument that
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3861
< Align.getQuantity()) ||
(ArgInfo.getIndirectByVal() && (RVAddrSpace != ArgAddrSpace))) {
// Create an aligned temporary, and copy to it.
yaxunl wrote
rsmith updated this revision to Diff 112733.
Repository:
rL LLVM
https://reviews.llvm.org/D36501
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/ABIInfo.h
lib/CodeGen/CodeGenTypes.cpp
lib/CodeGen/C
rsmith added a comment.
In https://reviews.llvm.org/D36501#852864, @rjmccall wrote:
> The only thing I would say here is that, as a platform vendor, I would like
> the ability to opt in to ABI fixes that aren't in my base-line version. In
> particular, we're generally more aggressive about tak
r311799. Thanks!
On Thu, Aug 24, 2017 at 7:14 PM, Richard Smith wrote:
> Hi Hans,
>
> This fixes a regression in ubsan's handling of lambda expressions. Seems
> like a reasonable candidate for Clang 5, but it is rather late in the day...
>
>
> On 24 August 2017 at 13:10, Richard Smith via cfe-com
Merged to 5.0 in r311800.
On Fri, Aug 25, 2017 at 12:14 PM, Daniel Jasper via cfe-commits
wrote:
> Author: djasper
> Date: Fri Aug 25 12:14:53 2017
> New Revision: 311792
>
> URL: http://llvm.org/viewvc/llvm-project?rev=311792&view=rev
> Log:
> [Format] Invert nestingAndIndentLevel pair in Whites
morehouse added a comment.
In https://reviews.llvm.org/D37156#852780, @kcc wrote:
> Did you check this on something other than the unit tests?
> E.g. a couple of benchmarks from fuzzer-test-suite?
Just tested on the proj4 and lcms benchmarks and no issues came up.
https://reviews.llvm.org/D
morehouse updated this revision to Diff 112739.
morehouse added a comment.
- Use existing linear scan, and check for InvokeInst.
https://reviews.llvm.org/D37156
Files:
clang/lib/Driver/SanitizerArgs.cpp
compiler-rt/test/fuzzer/deep-recursion.test
llvm/lib/Transforms/Instrumentation/Saniti
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:2934
+ABICompatArg->render(Args, CmdArgs);
+
// Add runtime flag for PS4 when PGO or Coverage are enabled.
```
else if (getToolChain().getTriple().isPS4())
CmdArgs.push_back("-f
faisalv added a comment.
OK - I'll commit this on sunday if no one blocks it by then. (I'll add the
fixme's).
Nice Work!
https://reviews.llvm.org/D36527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: morehouse
Date: Fri Aug 25 14:18:29 2017
New Revision: 311801
URL: http://llvm.org/viewvc/llvm-project?rev=311801&view=rev
Log:
[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer
Summary:
- Don't sanitize __sancov_lowest_stack.
- Don't instrument leaf functions.
- Add Co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311801: [SanitizeCoverage] Enable stack-depth coverage for
-fsanitize=fuzzer (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D37156?vs=112739&id=112746#toc
Repository:
rL L
Author: morehouse
Date: Fri Aug 25 15:01:21 2017
New Revision: 311803
URL: http://llvm.org/viewvc/llvm-project?rev=311803&view=rev
Log:
Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer"
This reverts r311801 due to a bot failure.
Modified:
cfe/trunk/lib/Driver/Sani
rsmith added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:2934
+ABICompatArg->render(Args, CmdArgs);
+
// Add runtime flag for PS4 when PGO or Coverage are enabled.
probinson wrote:
> ```
> else if (getToolChain().getTriple().isPS4())
> C
nevion added a comment.
Can anyone inform me why these don't work on clang-format-diff?
Repository:
rL LLVM
https://reviews.llvm.org/D15465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
morehouse reopened this revision.
morehouse added a comment.
This revision is now accepted and ready to land.
Turns out I should have been testing the benchmarks with
`FUZZING_ENGINE=fsanitize_fuzzer`. My mistake.
After adding the weak reference to SanitizerCoverage.cpp, both lcms and proj4
bu
morehouse updated this revision to Diff 112756.
morehouse added a comment.
- Add weak reference in SanitizerCoverage.cpp
https://reviews.llvm.org/D37156
Files:
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
Index: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
Author: hans
Date: Fri Aug 25 15:51:17 2017
New Revision: 311812
URL: http://llvm.org/viewvc/llvm-project?rev=311812&view=rev
Log:
Creating release candidate rc3 from release_500 branch
Added:
libcxxabi/tags/RELEASE_500/rc3/
- copied from r311811, libcxxabi/branches/release_50/
___
Author: hans
Date: Fri Aug 25 15:51:17 2017
New Revision: 311811
URL: http://llvm.org/viewvc/llvm-project?rev=311811&view=rev
Log:
Creating release candidate rc3 from release_500 branch
Added:
libcxx/tags/RELEASE_500/rc3/ (props changed)
- copied from r311810, libcxx/branches/release_
Author: hans
Date: Fri Aug 25 15:51:25 2017
New Revision: 311818
URL: http://llvm.org/viewvc/llvm-project?rev=311818&view=rev
Log:
Creating release candidate rc3 from release_500 branch
Added:
libunwind/tags/RELEASE_500/rc3/ (props changed)
- copied from r311817, libunwind/branches/re
morehouse updated this revision to Diff 112759.
morehouse added a comment.
Full diff.
https://reviews.llvm.org/D37156
Files:
clang/lib/Driver/SanitizerArgs.cpp
compiler-rt/test/fuzzer/deep-recursion.test
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
llvm/test/Instrumentation
probinson added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:2934
+ABICompatArg->render(Args, CmdArgs);
+
// Add runtime flag for PS4 when PGO or Coverage are enabled.
rsmith wrote:
> probinson wrote:
> > ```
> > else if (getToolChain().get
kzhuravl updated this revision to Diff 112761.
kzhuravl marked an inline comment as done.
kzhuravl retitled this revision from "AMDGPU: Insert __devicename__ macros" to
"AMDGPU: Cleanup most of the macros".
kzhuravl edited the summary of this revision.
kzhuravl added a comment.
fast fmaf macro wi
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:364
if (symLHS && symRHS &&
- (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
+ (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
return
rsmith added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:2934
+ABICompatArg->render(Args, CmdArgs);
+
// Add runtime flag for PS4 when PGO or Coverage are enabled.
probinson wrote:
> rsmith wrote:
> > probinson wrote:
> > > ```
> > > else
probinson added inline comments.
Comment at: lib/CodeGen/CGVTables.cpp:157
+ if (DebugInfo)
+DebugInfo->replaceTemporaryNodes();
+
aprantl wrote:
> Have you looked at what it would take to only finalize the nodes reachable
> via the function?
> Otherwise —
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Only typographical nits and post-commit suggestions, so please go ahead. Thanks!
Comment at: include/clang/Serialization/ModuleManager.h:63
+ /// \brief Preprocessor's Heade
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3861
< Align.getQuantity()) ||
(ArgInfo.getIndirectByVal() && (RVAddrSpace != ArgAddrSpace))) {
// Create an aligned temporary, and copy to it.
rjmccall wrote
probinson added a comment.
Sorry it took so long to wrap my head around this, but it has been about 20
years since I've had to accommodate an intentional ABI breakage, and that's
actually what you want to do. Remembering that case, I have a model for this
one, and I understand what you are doi
Author: rsmith
Date: Fri Aug 25 18:04:35 2017
New Revision: 311823
URL: http://llvm.org/viewvc/llvm-project?rev=311823&view=rev
Log:
Add flag to request Clang is ABI-compatible with older versions of itself
This patch adds a flag -fclang-abi-compat that can be used to request that
Clang attempts
rsmith closed this revision.
rsmith added a comment.
Committed as 311823.
Repository:
rL LLVM
https://reviews.llvm.org/D36501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Hans,
We should get this into Clang 5 so that people can opt out of the ABI
bugfix for passing C++ class types by value.
On 25 August 2017 at 18:04, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Fri Aug 25 18:04:35 2017
> New Revision: 311823
>
>
faisalv added inline comments.
Comment at: lib/AST/ExprCXX.cpp:979
+SourceRange LambdaExpr::getExplicitTemplateParameterListRange() const {
+ TemplateParameterList *List = getTemplateParameterList();
hamzasood wrote:
> faisalv wrote:
> > I think this should re
jklaehn marked 2 inline comments as done.
jklaehn added a comment.
In https://reviews.llvm.org/D35271#850472, @vsk wrote:
> Thanks, LGTM! This seems like a pretty straightforward bug fix. Since it's
> not my usual area maybe it'd be worth waiting a day or so for more feedback.
Thanks! I do not
Author: sylvestre
Date: Fri Aug 25 01:44:56 2017
New Revision: 311766
URL: http://llvm.org/viewvc/llvm-project?rev=311766&view=rev
Log:
clang also supports C++14 & 17 + remove trailing whitespaces
Modified:
cfe/trunk/www/index.html
Modified: cfe/trunk/www/index.html
URL:
http://llvm.org/vie
Author: sylvestre
Date: Fri Aug 25 01:47:57 2017
New Revision: 311767
URL: http://llvm.org/viewvc/llvm-project?rev=311767&view=rev
Log:
Remove the old meeting links. Also available from the link:
http://llvm.org/devmtg/
Modified:
cfe/trunk/www/menu.html.incl
Modified: cfe/trunk/www/menu.htm
alexfh added a comment.
Thank you for the prompt fix!
Repository:
rL LLVM
https://reviews.llvm.org/D37120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo created this revision.
https://reviews.llvm.org/D37133
Files:
utils/merge_archives.py
Index: utils/merge_archives.py
===
--- utils/merge_archives.py
+++ utils/merge_archives.py
@@ -120,6 +120,8 @@
files = glob.glo
mstorsjo created this revision.
Herald added a subscriber: mgorny.
In cross build setups, the ar used in merge_archives.py might not be the right
one for the target (and the invocation doesn't include the 's' modifier for
updating the archive index); make sure to rebuild the index for the static
krasimir created this revision.
Herald added a subscriber: klimek.
This patch detects the leading '<' in likely xml files and stops formatting in
that case. A recent use of a Qt xml file with a .ts extension triggered this:
http://doc.qt.io/qt-4.8/linguist-ts-file-format.html
https://reviews.llv
Author: krobelus
Date: Fri Aug 25 02:49:49 2017
New Revision: 311770
URL: http://llvm.org/viewvc/llvm-project?rev=311770&view=rev
Log:
[clang-diff] Remove NodeCountVisitor, NFC
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D37000
Modified:
cfe/trunk/lib/To
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311770: [clang-diff] Remove NodeCountVisitor, NFC (authored
by krobelus).
Changed prior to commit:
https://reviews.llvm.org/D37000?vs=112132&id=112670#toc
Repository:
rL LLVM
https://reviews.llvm.or
johannes updated this revision to Diff 112671.
johannes retitled this revision from "[AST] Make
TraverseTemplateParameterListHelper public" to "[AST] Traverse templates in
LexicallyOrderedRecursiveASTVisitor".
johannes edited the summary of this revision.
johannes added a reviewer: arphaman.
joha
johannes added inline comments.
Comment at: unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp:146
+ DummyMatchVisitor Visitor;
+ Visitor.ExpectMatch("/f/T", 2, 11);
+ Visitor.ExpectMatch("/f/f/", 2, 20);
This test also works before the change; what
johannes updated this revision to Diff 112673.
johannes edited the summary of this revision.
johannes added a comment.
use LexicallyOrderedRecursiveASTVisitor
https://reviews.llvm.org/D37003
Files:
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/Inputs/clang-diff-basic-src.cpp
test/Tooling/c
Author: arphaman
Date: Fri Aug 25 03:07:00 2017
New Revision: 311772
URL: http://llvm.org/viewvc/llvm-project?rev=311772&view=rev
Log:
[IRGen] Evaluate constant static variables referenced through member
expressions
C++ allows us to reference static variables through member expressions. Prior to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311772: [IRGen] Evaluate constant static variables
referenced through member (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36876?vs=112360&id=112675#toc
Repository:
rL LL
spetrovic added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Awesome, thanks!
Comment at: unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp:146
+ DummyMatchVisitor Visitor;
+ Visitor.ExpectMatch("/f/T", 2, 11);
+ Visitor.ExpectMatch("/f/f/", 2, 20);
johannes wrote:
> This test als
92 matches
Mail list logo
