yvvan abandoned this revision.
yvvan added a comment.
In https://reviews.llvm.org/D34873#841624, @rnk wrote:
> This shouldn't be necessary after https://reviews.llvm.org/rL310905.
https://reviews.llvm.org/D34873
___
cfe-commits mailing list
cfe-co
Author: chandlerc
Date: Wed Aug 16 00:22:49 2017
New Revision: 310994
URL: http://llvm.org/viewvc/llvm-project?rev=310994&view=rev
Log:
Fix a UBSan failure where this boolean was copied when uninitialized.
When r310905 moved the pointer and bool out of a PointerIntPair, it made
them end up uninit
teemperor added a comment.
That's a really nice approach to this problem, good job Yuka! See my inline
comments for some minor remarks.
Comment at: clang/include/clang/Driver/CC1Options.td:104
+ const char* Values =
+#define GET_CHECKERS
+#define CHECKER(FULLNAME, CLASS, DESC
johannes updated this revision to Diff 111316.
johannes edited the summary of this revision.
johannes removed a subscriber: rsmith.
johannes added a comment.
- fix comments
- add unittest for the new node kinds
- make `addData()` take a const reference
https://reviews.llvm.org/D36664
Files:
i
johannes updated this revision to Diff 111317.
johannes added a subscriber: rsmith.
johannes added a comment.
add
https://reviews.llvm.org/D36664
Files:
include/clang/AST/DataCollection.h
include/clang/Analysis/CloneDetection.h
lib/AST/CMakeLists.txt
lib/AST/DataCollection.cpp
lib/AST
johannes added a comment.
In https://reviews.llvm.org/D36664#841758, @teemperor wrote:
> Very well done, I really like this patch! I added a few remarks mostly about
> the comments that need some small adjusting.
>
> I'm wondering what would be a nice way of creating a StmtDataCollector that
>
djasper added inline comments.
Comment at: unittests/Format/FormatTest.cpp:2281
TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) {
verifyFormat("#define A \\\n"
mzeren-vmw wrote:
> mzeren-vmw wrote:
> > Experimenting with the patch locally
yamaguchi updated this revision to Diff 111318.
yamaguchi marked 7 inline comments as done.
yamaguchi added a comment.
Update diff according to Raphael's comments.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test
hokein created this revision.
Herald added subscribers: xazax.hun, JDevlieghere.
The current fix will break the compilation -- because braced list is not
deducible in std::make_unique (with the use of forwarding) without
specifying the type explicitly.
We could support it in the future.
https:/
teemperor added inline comments.
Comment at: clang/lib/Driver/DriverOptions.cpp:14
#include "llvm/Option/Option.h"
+#include
I think the C++ version of the assert header is more consistent: `#include
`
Comment at: llvm/utils/TableGen/OptPa
m.ostapenko updated this revision to Diff 111322.
m.ostapenko added a comment.
Ping^3
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/Analysis/Anal
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits.
Comment at: clang-tidy/android/CloexecCheck.h:95
+ /// Binding name of the FuncDecl of a function call.
+ static const char *FuncDeclBindingStr;
+
---
alexfh added a comment.
In https://reviews.llvm.org/D34440#825924, @vladimir.plyashkun wrote:
> > Many build systems normally generate response files on-fly in some
> > circumstances (e.g. if command line is longer than some platform-imposed
> > limit). So IMO response files should be a perfect
hamzasood added a comment.
Ping
https://reviews.llvm.org/D36527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
johannes updated this revision to Diff 111328.
johannes edited the summary of this revision.
johannes added a comment.
accept a commit range
https://reviews.llvm.org/D36686
Files:
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.cpp
===
vladimir.plyashkun added a comment.
@alexf
Thanks for the response!
Yes, we re-implemented logic and now use JSON compilation database to pass
compiler options to Clang-Tidy.
Anyway, i think in general it's useful to support @response_files, see my
comment: https://reviews.llvm.org/D34440#813411
Anastasia added a comment.
Ping! :)
https://reviews.llvm.org/D36410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
Prior to this patch, messages to `self` in class methods were treated as
instance methods to a `Class` value. When these methods returned `instancetype`
the compiler only saw `id` through the `instancetype`, and not the `Interface
*`. This caused problems when th
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:191
+ // Initialization of owners.
+ else if (OwnerInitialization != nullptr) {
+diag(OwnerInitialization->getLocStart(),
aaron.ballman wrote:
> No else afte
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:146
+
+if (const auto *Parent = Par->getParentFunctionOrMethod()) {
+ if (const auto *F = dyn_cast(Parent)) {
Please do not use `auto` here, as the type is
Author: abataev
Date: Wed Aug 16 07:01:00 2017
New Revision: 311007
URL: http://llvm.org/viewvc/llvm-project?rev=311007&view=rev
Log:
[OPRNMP] Fix for PR33445: ICE: OpenMP target containing ordered for.
If exceptions are enabled, there may be a problem with the codegen of
the finalization functio
coby created this revision.
Herald added a subscriber: eraman.
Repository:
rL LLVM
https://reviews.llvm.org/D36794
Files:
test/CodeGen/mozilla-ms-inline-asm.c
test/CodeGen/ms-inline-asm-64.c
test/CodeGen/ms-inline-asm.c
test/CodeGen/ms-inline-asm.cpp
test/CodeGenCXX/ms-inline-asm-ret
nik added a reviewer: ilya-biryukov.
nik added a comment.
Ping.
I guess locking the file less helps also clangd?!
https://reviews.llvm.org/D35200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
eandrews updated this revision to Diff 111341.
eandrews added a comment.
Corrected spelling error.
https://reviews.llvm.org/D36712
Files:
docs/LangRef.rst
Index: docs/LangRef.rst
===
--- docs/LangRef.rst
+++ docs/LangRef.rst
@@
yaxunl added a comment.
Sorry for the delay.
I feel forbidding user taking address of captured variable is too restrictive
and make blocks less useful.
A block is quite like a normal function with a generic pointer argument. Users
take the responsibility to make sure the cast of a generic poin
dcoughlin added a comment.
Thanks for doing this!
https://reviews.llvm.org/D36737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In https://reviews.llvm.org/D34440#843192, @vladimir.plyashkun wrote:
> @alexfh
> Thanks for the response!
> Yes, we re-implemented logic and now use JSON compilation database to pass
> compiler options to Clang-Tidy.
> Anyway, i think in general it's useful to support
rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.
Class methods can be inherited; this entire approach is bogus.
Repository:
rL LLVM
https://reviews.llvm.org/D36790
___
cfe-commi
boris added a comment.
In https://reviews.llvm.org/D35678#842891, @rsmith wrote:
> I'd still like the id flattening moved to the caller. [...] I'm fine with
> that being done as a separate change after this one, though, if you'd prefer.
Yes, that would probably be easier.
> Do you need someon
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/android/CloexecAcceptCheck.cpp:42
+ "prefer accept4() to accept() because accept4() allows SOCK_CLOEXEC",
+ /*FixMsg=*/Replace
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D35365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D35363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/android/CloexecEpollCreateCheck.cpp:27-31
+ replaceFunc(Result, /*WarningMsg=*/
+ "prefer epoll_create() to epoll_create1(
rjmccall resigned from this revision.
rjmccall added a comment.
I don't think I'm best-equipped to review this, sorry.
https://reviews.llvm.org/D36527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: test/clang-tidy/modernize-make-unique.cpp:253
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead
- // CHECK-FIXES: std::unique_ptr P
eandrews added a comment.
In https://reviews.llvm.org/D36712#842477, @kparzysz wrote:
> In the cases when the section is explicitly given on a definition, it was
> likely imposed by something like the "section" attribute in the source. I
> don't think it's unreasonable to expect that the declar
kparzysz added a comment.
In https://reviews.llvm.org/D36712#843387, @eandrews wrote:
> Does this result in unexpected behavior though? Won't this just result in the
> global being defined in the specified section?
If there is no section given explicitly, there is function
SelectSectionForGlo
arphaman added a comment.
Of course, right. I will change the approach.
Repository:
rL LLVM
https://reviews.llvm.org/D36790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Wed Aug 16 08:58:46 2017
New Revision: 311013
URL: http://llvm.org/viewvc/llvm-project?rev=311013&view=rev
Log:
[OPENMP] Fix for PR28581: OpenMP linear clause - wrong results.
If worksharing construct has at least one linear item, an implicit
synchronization point must be em
kparzysz added a comment.
The problem is that the mismatch between sections does not have to lead to any
undesirable behavior. Whether it does or not depends on a particular case. I
think we should be consistent though---if we decide that a mismatch between the
section for a declaration and t
dcoughlin added a comment.
> By the way, plist-based tests in retain-release.m are disabled since r163536
> (~2012), and need to be updated. It's trivial to re-enable them but annoying
> to maintain - would we prefer to re-enable or delete them or replace with
> -analyzer-output=text tests?
Th
arphaman added a comment.
@rjmccall Do you think that the rules for the return types in overridden
methods that return `instancetype` should be strengthened first? For example,
if we have the following code:
@interface Unrelated
- (void)method:(int)x;
@end
@interface CallsSelfSuper:
Nebiroth updated this revision to Diff 111368.
Nebiroth marked 8 inline comments as done.
Nebiroth added a comment.
Fixed diff comments.
https://reviews.llvm.org/D36150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ProtocolHandlers.cpp
clangd/P
faisalv added a comment.
I'll try and get you some feedback on this over the next couple of days (unless
someone else jumps in).
Thanks for working on this!
https://reviews.llvm.org/D36527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
chh updated this revision to Diff 111372.
chh marked 3 inline comments as done.
https://reviews.llvm.org/D36761
Files:
clang-tidy/android/CloexecCheck.cpp
clang-tidy/android/CloexecCheck.h
clang-tidy/android/CloexecCreatCheck.cpp
clang-tidy/android/CloexecCreatCheck.h
clang-tidy/android
Author: chh
Date: Wed Aug 16 09:59:26 2017
New Revision: 311020
URL: http://llvm.org/viewvc/llvm-project?rev=311020&view=rev
Log:
[clang-tidy] Use CloexecCheck as base class.
Summary:
Simplify registerMatchers and check functions in CloexecCreatCheck,
CloexecSocketCheck, CloexecFopenCheck, and Cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311020: [clang-tidy] Use CloexecCheck as base class.
(authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D36761?vs=111372&id=111373#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: jvesely
Date: Wed Aug 16 10:08:56 2017
New Revision: 311021
URL: http://llvm.org/viewvc/llvm-project?rev=311021&view=rev
Log:
amdgcn: Implement {read_,write_,}mem_fence builtin
v2: add more detailed comment about waitcnt instruction
Signed-off-by: Jan Vesely
Reviewed-by: Aaron Watry
Te
Author: jvesely
Date: Wed Aug 16 10:09:00 2017
New Revision: 311022
URL: http://llvm.org/viewvc/llvm-project?rev=311022&view=rev
Log:
amdgcn: rewrite barrier() using fence and clang __builtin_amdgcn_s_barrier
Specs require using fences when barrier() is invoked:
"The barrier function will either
chh commandeered this revision.
chh added a reviewer: yawanng.
chh added inline comments.
Comment at: clang-tidy/android/CloexecAcceptCheck.cpp:42
+ "prefer accept4() to accept() because accept4() allows SOCK_CLOEXEC",
+ /*FixMsg=*/ReplacementText);
+}
chh updated this revision to Diff 111377.
https://reviews.llvm.org/D35362
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecAcceptCheck.cpp
clang-tidy/android/CloexecAcceptCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/an
Author: chh
Date: Wed Aug 16 10:18:16 2017
New Revision: 311024
URL: http://llvm.org/viewvc/llvm-project?rev=311024&view=rev
Log:
[clang-tidy] Add a close-on-exec check on accept() in Android module.
Summary:
accept() is better to be replaced by accept4() with SOCK_CLOEXEC
flag to avoid file desc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311024: [clang-tidy] Add a close-on-exec check on accept()
in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35362?vs=111377&id=111378#toc
Repository:
rL LLVM
twoh added a comment.
Ping. Thanks!
https://reviews.llvm.org/D36474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
Friendly ping. @davidxl, I think there's no harm to make clang consistent with
gcc for compiler options, and I wonder if you have any concerns that I may
miss. Thanks!
https://reviews.llvm.org/D34796
___
cfe-commits mailing l
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D36474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311027: [clang-tidy] Add a close-on-exec check on accept4()
in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35363?vs=110755&id=111383#toc
Repository:
rL LLVM
Author: chh
Date: Wed Aug 16 10:46:18 2017
New Revision: 311027
URL: http://llvm.org/viewvc/llvm-project?rev=311027&view=rev
Log:
[clang-tidy] Add a close-on-exec check on accept4() in Android module.
Summary:
accept4() is better to set SOCK_CLOEXEC flag to avoid file descriptor leakage.
Differe
Author: chh
Date: Wed Aug 16 10:53:12 2017
New Revision: 311028
URL: http://llvm.org/viewvc/llvm-project?rev=311028&view=rev
Log:
[clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.
Summary:
epoll_create1() is better to set EPOLL_CLOEXEC flag to avoid file descriptor
lea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311028: [clang-tidy] Add a close-on-exec check on
epoll_create1() in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35365?vs=110752&id=111385#toc
Repository:
rL
Author: chh
Date: Wed Aug 16 11:02:49 2017
New Revision: 311029
URL: http://llvm.org/viewvc/llvm-project?rev=311029&view=rev
Log:
[clang-tidy] Add a close-on-exec check on epoll_create() in Android module.
Summary:
epoll_create() is better to be replaced by epoll_create1() with EPOLL_CLOEXEC
flag
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311029: [clang-tidy] Add a close-on-exec check on
epoll_create() in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35367?vs=110751&id=111386#toc
Repository:
rL
chh added inline comments.
Comment at: clang-tidy/android/CloexecEpollCreateCheck.cpp:27-31
+ replaceFunc(Result, /*WarningMsg=*/
+ "prefer epoll_create() to epoll_create1() "
+ "because epoll_create1() allows "
+ "EPOLL_CLOEXEC", /*FixMsg=
rjmccall added a reviewer: doug.gregor.
rjmccall added a comment.
Tagging Doug.
Repository:
rL LLVM
https://reviews.llvm.org/D36790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng.
https://reviews.llvm.org/D36802
Files:
lib/Basic/Targets/AMDGPU.cpp
lib/Basic/Targets/AMDGPU.h
test/Driver/amdgcn-mcpu-macro.cl
test/Driver/r600-mcpu-macro.cl
test/Driver/r600-mcpu.c
kzhuravl added a comment.
In https://reviews.llvm.org/D36771#842837, @arsenm wrote:
> We should also be defining __devicename__ macros. I opened a bug for this
> last week
https://reviews.llvm.org/D36802
https://reviews.llvm.org/D36771
___
cfe-c
kzhuravl added a comment.
Do we need this for r600?
https://reviews.llvm.org/D36802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eandrews updated this revision to Diff 111388.
eandrews added a comment.
Updated the patch to include Krzysztof's comment about explicitly stating
undefined behavior for section information mismatch in global variable
declaration and definition. This should cover the case where section is
expli
modocache added a comment.
Friendly ping! I think this is ready to be reviewed. It adds an additional row,
`Preprocessing`, to the `Miscellaneous Ungrouped Timers` section of the `clang
-ftime-report` output:
===-===
eandrews added a comment.
In https://reviews.llvm.org/D36712#843414, @kparzysz wrote:
> The problem is that the mismatch between sections does not have to lead to
> any undesirable behavior. Whether it does or not depends on a particular
> case. I think we should be consistent though---if we
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D36492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: phosek
Date: Wed Aug 16 12:06:04 2017
New Revision: 311033
URL: http://llvm.org/viewvc/llvm-project?rev=311033&view=rev
Log:
[CMake] Build sanitized C++ runtimes for Fuchsia
Differential Revision: https://reviews.llvm.org/D36349
Modified:
cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
Author: phosek
Date: Wed Aug 16 12:06:05 2017
New Revision: 311034
URL: http://llvm.org/viewvc/llvm-project?rev=311034&view=rev
Log:
[Driver] SafeStack does not need a runtime library on Fuchsia
Patch by Roland McGrath
Differential Revision: https://reviews.llvm.org/D36779
Modified:
cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311033: [CMake] Build sanitized C++ runtimes for Fuchsia
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D36349?vs=110311&id=111399#toc
Repository:
rL LLVM
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311034: [Driver] SafeStack does not need a runtime library
on Fuchsia (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D36779?vs=111301&id=111400#toc
Repository:
rL LLVM
https
Author: chh
Date: Wed Aug 16 12:13:35 2017
New Revision: 311035
URL: http://llvm.org/viewvc/llvm-project?rev=311035&view=rev
Log:
[clang-tidy] Use const char* to compile with VC cl.exe.
Summary:
cl.exe does not accept constexpr char FuncBindingStr[] = ...
Differential Revision: https://reviews.l
Author: twoh
Date: Wed Aug 16 12:36:24 2017
New Revision: 311037
URL: http://llvm.org/viewvc/llvm-project?rev=311037&view=rev
Log:
Use the file name from linemarker for debug info if an input is preprocessed
source.
Summary:
Even in the case of the input file is a preprocessed source, clang uses
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311037: Use the file name from linemarker for debug info if
an input is preprocessed… (authored by twoh).
Repository:
rL LLVM
https://reviews.llvm.org/D36474
Files:
cfe/trunk/lib/CodeGen/CGDebugInfo
srhines created this revision.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D36806
Files:
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
===
--- lib/Tooling/Core/Replacement.cpp
+++ lib/To
srhines added a comment.
https://reviews.llvm.org/D36806 switches this to cantFail(). Thanks for helping
me better understand LLVM's error strategy.
Repository:
rL LLVM
https://reviews.llvm.org/D36728
___
cfe-commits mailing list
cfe-commits@lis
Hi,
this change breaks build:
clang-tools-extra/clang-tidy/android/CloexecSocketCheck.cpp:20:30:
error: unused variable 'SOCK_CLOEXEC'
[-Werror,-Wunused-const-variable]
static constexpr const char *SOCK_CLOEXEC = "SOCK_CLOEXEC";
Please test with LLVM_ENABLE_WERROR=ON before submitting!
On Wed,
erik.pilkington added a comment.
This looks really usefull, thanks for working on this!
Comment at: lib/Lex/Preprocessor.cpp:746
void Preprocessor::Lex(Token &Result) {
+ llvm::TimeRegion(PPOpts->getTimer());
+
Doesn't this just start a timer and immediately
Author: chh
Date: Wed Aug 16 14:00:06 2017
New Revision: 311040
URL: http://llvm.org/viewvc/llvm-project?rev=311040&view=rev
Log:
[clang-tidy] Remove unused static variable.
Differential Revision: https://reviews.llvm.org/D36761
Modified:
clang-tools-extra/trunk/clang-tidy/android/CloexecSo
modocache planned changes to this revision.
modocache added inline comments.
Comment at: lib/Lex/Preprocessor.cpp:746
void Preprocessor::Lex(Token &Result) {
+ llvm::TimeRegion(PPOpts->getTimer());
+
erik.pilkington wrote:
> Doesn't this just start a timer and
Thanks. The fix is in https://reviews.llvm.org/rL311040.
On Wed, Aug 16, 2017 at 1:39 PM, Evgenii Stepanov wrote:
> Hi,
>
> this change breaks build:
> clang-tools-extra/clang-tidy/android/CloexecSocketCheck.cpp:20:30:
> error: unused variable 'SOCK_CLOEXEC'
> [-Werror,-Wunused-const-variable]
ruiu added a comment.
This patch allows us to embed a piece of C++ code to each command line option
to construct a list of argument candidates at runtime. With this patch, .inc
files generated by OptParserEmitter contain C macros that in turn include other
.inc files. That is a flexible mechani
malhar1995 updated this revision to Diff 111420.
malhar1995 added a comment.
This patch adds the functionality of performing reference counting on the
callee side for Integer Set Library (ISL) to Clang Static Analyzer's
RetainCountChecker.
Reference counting on the callee side can be extensivel
Author: hfinkel
Date: Wed Aug 16 14:34:27 2017
New Revision: 311041
URL: http://llvm.org/viewvc/llvm-project?rev=311041&view=rev
Log:
Base optimization-record file names on the final output
Using Output.getFilename() to construct the file name used for optimization
recording in Clang::ConstructJo
saugustine added a comment.
Anyone have any opinions on this?
https://reviews.llvm.org/D36764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aheejin resigned from this revision.
aheejin added a comment.
I don't have enough context or knowledge on this code base. Sorry!
https://reviews.llvm.org/D36764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: hfinkel
Date: Wed Aug 16 14:51:31 2017
New Revision: 311043
URL: http://llvm.org/viewvc/llvm-project?rev=311043&view=rev
Log:
Don't use -no-integrated-as in test/Driver/opt-record.c
-no-integrated-as is not supported on some targets (e.g.,
x86_64-pc-windows-msvc). Testing using -save-temp
Author: phosek
Date: Wed Aug 16 14:58:09 2017
New Revision: 311045
URL: http://llvm.org/viewvc/llvm-project?rev=311045&view=rev
Log:
[libcxxabi] When built with ASan, __cxa_throw calls __asan_handle_no_return
The ASan runtime on many systems intercepts cxa_throw just so it
can call asan_handle_no
Author: phosek
Date: Wed Aug 16 15:05:54 2017
New Revision: 311047
URL: http://llvm.org/viewvc/llvm-project?rev=311047&view=rev
Log:
Revert "[libcxxabi] When built with ASan, __cxa_throw calls
__asan_handle_no_return"
This reverts commit r311045 because it's causing an error on
libcxx-libcxxabi-
Author: gbiv
Date: Wed Aug 16 15:44:17 2017
New Revision: 311051
URL: http://llvm.org/viewvc/llvm-project?rev=311051&view=rev
Log:
Fix typos in comments; NFC
Modified:
cfe/trunk/include/clang/Lex/MultipleIncludeOpt.h
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/include/clang/Lex/M
Author: benlangmuir
Date: Wed Aug 16 16:12:21 2017
New Revision: 311053
URL: http://llvm.org/viewvc/llvm-project?rev=311053&view=rev
Log:
[index] Add indexing for unresolved-using declarations
In dependent contexts we end up referencing these, so make sure they
have USRs, and have their declarati
t-tye added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.cpp:364-367
+ if (GPUName.empty())
+return;
+
+ Builder.defineMacro(Twine("__") + Twine(GPUName) + Twine("__"));
Should this be the following since extra macros could be after it in the futur
euhlmann updated this revision to Diff 111433.
euhlmann marked 13 inline comments as done.
euhlmann edited the summary of this revision.
euhlmann added a comment.
Allows comments before the include guard opens. However, if there's a single
non-comment line before an include-guard-like structure t
yamaguchi updated this revision to Diff 111457.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
yamaguchi added a comment.
@ruiu
I understand your concern. However by doing this (rather than building
functions for each flag), we will be able to get all information in OptTable
itself. It is true that this is quite fragile, but adding ValuesCode to new
flag is not complicated, so I believe
Author: dcoughlin
Date: Wed Aug 16 21:19:07 2017
New Revision: 311063
URL: http://llvm.org/viewvc/llvm-project?rev=311063&view=rev
Log:
[analyzer] Add support for reference counting of parameters on the callee side
This commit adds the functionality of performing reference counting on the
callee
1 - 100 of 106 matches
Mail list logo
