[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

NoQ added a comment. In https://reviews.llvm.org/D35109#837673, @zaks.anna wrote: > > What do you suggest? Should we widen the type of the difference, or abandon > > this patch and revert back to the local solution I originally used in the > > iterator checker? > > Does the local solution you u

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. I'm still seeing a failure after r301549: https://gist.github.com/jtbandes/de6118abaadc6c5a5c9b4223a62f596c Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp:483-498 +void MagentaHandleChecker::checkPreStmt(const ReturnStmt *RS, +CheckerContext &Ctx) const { + ProgramStateRef State = Ctx.getState(); + c

[PATCH] D35205: [Clang][x86][Inline Asm] support for GCC style inline asm - Y constraints

coby abandoned this revision. coby added a comment. superseded by https://reviews.llvm.org/D36371 Repository: rL LLVM https://reviews.llvm.org/D35205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

It looks like I can not reproduce it on osx (non-arm)... :( On 09/08/17 22:54, Diana Picus wrote: Reverting this also fixed the selfhost bots: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/2142 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2309

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi Vassil, My build is in progress, but since it's a full build it's probably going to take another couple of hours to complete. I'll let you know when it's done. Thanks, Diana On 10 August 2017 at 10:09, Vassil Vassilev wrote: > It looks like I can not reproduce it on osx (non-arm)... :( > On

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi Diana, Thanks for helping us out! Cheers, Vassil On 10/08/17 11:28, Diana Picus wrote: Hi Vassil, My build is in progress, but since it's a full build it's probably going to take another couple of hours to complete. I'll let you know when it's done. Thanks, Diana On 10 August 2017 at 10

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp:483-498 +void MagentaHandleChecker::checkPreStmt(const ReturnStmt *RS, +CheckerContext &Ctx) const { + ProgramStateRef State = Ctx.getState()

[clang-tools-extra] r310558 - [clang-tidy] Add missing doc in cppcoreguidelines-c-copy-assignment-signature check.

Author: hokein Date: Thu Aug 10 02:12:32 2017 New Revision: 310558 URL: http://llvm.org/viewvc/llvm-project?rev=310558&view=rev Log: [clang-tidy] Add missing doc in cppcoreguidelines-c-copy-assignment-signature check. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-c

[clang-tools-extra] r310559 - [clang-tidy] Minor documentation improvement

Author: xazax Date: Thu Aug 10 02:13:26 2017 New Revision: 310559 URL: http://llvm.org/viewvc/llvm-project?rev=310559&view=rev Log: [clang-tidy] Minor documentation improvement Patch by: Lilla Barancsuk Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-static-accessed-thr

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#836831, @whisperity wrote: > Apart from those in the in-line comments, I have a question: how safe is this > library to `Release` builds? I know this is only a submodule dependency for > the "real deal" in https://reviews.llvm.org/D3

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:296-297 +def warn_drv_unsupported_longcalls : Warning< + "ignoring '-mlong-calls' option as it cannot be used with " + "%select{|the implicit usage of }0-mabicalls">, + InGroup; ---

[clang-tools-extra] r310560 - [clang-tidy] Fix a check-fixes line

Author: xazax Date: Thu Aug 10 02:29:39 2017 New Revision: 310560 URL: http://llvm.org/viewvc/llvm-project?rev=310560&view=rev Log: [clang-tidy] Fix a check-fixes line Modified: clang-tools-extra/trunk/test/clang-tidy/readability-static-accessed-through-instance.cpp Modified: clang-tools-e

[PATCH] D35932: [clang-tidy] Add integer division check

rnkovacs updated this revision to Diff 110539. rnkovacs marked 3 inline comments as done. rnkovacs edited the summary of this revision. rnkovacs added a comment. Thanks for the comments. I improved the docs and truncated the messages in the test file. We also had concerns about the nested `hasAn

[PATCH] D9912: PR20958 Allow redeclaration of type-generic builtins

ilya-palachev added a comment. Hi! Thanks for this patch. We're building Android6 with Clang (in order to apply static analyzer on it), and without this patch we've 613 build failures. This patch helps to get rid of 521 of those build failures (85%). "Works for me". Comment

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp:483-498 +void MagentaHandleChecker::checkPreStmt(const ReturnStmt *RS, +CheckerContext &Ctx) const { + ProgramStateRef State = Ctx.getState(); + c

[PATCH] D34512: Add preliminary Cross Translation Unit support library

whisperity added inline comments. Comment at: include/clang/CrossTU/CrossTranslationUnit.h:42 +/// Note that this class also implements caching. +class CrossTranslationUnit { +public: xazax.hun wrote: > whisperity wrote: > > Does the name of this class make sense

r310576 - [Lexer] Finding beginning of token with escaped new line

Author: alexfh Date: Thu Aug 10 03:06:16 2017 New Revision: 310576 URL: http://llvm.org/viewvc/llvm-project?rev=310576&view=rev Log: [Lexer] Finding beginning of token with escaped new line Summary: Lexer::GetBeginningOfToken produced invalid location when backtracking across escaped new lines.

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

This revision was automatically updated to reflect the committed changes. Closed by commit rL310576: [Lexer] Finding beginning of token with escaped new line (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D30748?vs=110029&id=110544#toc Repository: rL LLVM https://re

[clang-tools-extra] r310577 - [clang-tidy] add forwarders in the aliased checks from hicpp module

Author: hokein Date: Thu Aug 10 03:12:31 2017 New Revision: 310577 URL: http://llvm.org/viewvc/llvm-project?rev=310577&view=rev Log: [clang-tidy] add forwarders in the aliased checks from hicpp module Summary: Adds redirections notes and the actual redirections in the documentation for hicpp Pa

[clang-tools-extra] r310578 - [clang-tidy] Fix an error in the doc.

Author: hokein Date: Thu Aug 10 03:15:48 2017 New Revision: 310578 URL: http://llvm.org/viewvc/llvm-project?rev=310578&view=rev Log: [clang-tidy] Fix an error in the doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.rst Modified: cl

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

klimek added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:470-471 + int FD; + auto EC = llvm::sys::fs::createTemporaryFile(Prefix, Suffix, /*ref*/ FD, + /*ref*/ File); if (EC) I don't underst

[PATCH] D35449: [X86] Implement __builtin_cpu_is

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. SGTM. -eric https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

r310580 - Revert r310489 and follow-up commits r310505, r310519, r310537 and r310549

Author: arphaman Date: Thu Aug 10 03:34:46 2017 New Revision: 310580 URL: http://llvm.org/viewvc/llvm-project?rev=310580&view=rev Log: Revert r310489 and follow-up commits r310505, r310519, r310537 and r310549 Commit r310489 caused 'openmp-offload.c' test failures on Darwin and other platforms: h

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. 1. I'm sorry, but I had to revert r310489 and follow-up commits r310505, r310519, r310537 and r310549 since it looks like the failures are accumulating. The revert commit was r310580. The following run lines were failing for me because of various assertion failures and

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

ilya-biryukov added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:470-471 + int FD; + auto EC = llvm::sys::fs::createTemporaryFile(Prefix, Suffix, /*ref*/ FD, + /*ref*/ File); if (EC) klimek w

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

sdardis added a comment. Slight tweak to the summary: > The -mabicalls option does not have a sense in case of non position > independent code on N64 ABI. After this change driver starts to show a > warning that -mabicalls is ignored in that case. The -mabicalls option does not make sense in t

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 110547. JonasToth marked 10 inline comments as done. JonasToth added a comment. [Misc] address issues from aaron, especially refactor the big check function https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 110548. JonasToth added a comment. [Fix] typo https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

johannes updated this revision to Diff 110552. johannes added a comment. add test for 'Move' and 'Update and Move' in output https://reviews.llvm.org/D36179 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp tes

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

johannes updated this revision to Diff 110553. johannes edited the summary of this revision. johannes added a comment. change tests https://reviews.llvm.org/D36182 Files: test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-html.test too

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

hamzasood created this revision. This patch implements P0409R2 . '*this' capture is allowed pre-C++17 as an extension. So I've also allowed [=, this] pre-C++2a as an extension (with appropriate warnings) for consistency. https://reviews.llvm.org/D36572 Files: inclu

[PATCH] D36183: [clang-diff] Simplify mapping

johannes updated this revision to Diff 110554. johannes added a comment. remove unused https://reviews.llvm.org/D36183 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-basic.cpp Index: te

[PATCH] D36184: [clang-diff] Filter AST nodes

johannes updated this revision to Diff 110555. johannes added a comment. refactor isNodeExcluded https://reviews.llvm.org/D36184 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-json.cpp Index: test/Tooling/clang-diff-json.cpp ===

r310582 - [ValueTracking] Enabling ValueTracking patch by default (recommit). Part 1.

Author: n.bozhenov Date: Thu Aug 10 04:22:52 2017 New Revision: 310582 URL: http://llvm.org/viewvc/llvm-project?rev=310582&view=rev Log: [ValueTracking] Enabling ValueTracking patch by default (recommit). Part 1. The original patch was an improvement to IR ValueTracking on non-negative integers.

[PATCH] D36187: [clang-diff] Use the relative name for NamedDecls

johannes updated this revision to Diff 110557. johannes added a comment. substr https://reviews.llvm.org/D36187 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-html

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG, as discussed in person, it's probably a good idea to try to get rid of the non-file-creating version, if possible, or at least fix the comments on the functions to make this behavior clear

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 110559. xazax.hun marked 4 inline comments as done. xazax.hun added a comment. - Address review comments https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt include/clang/Basic/Diagnostic.td

[clang-tools-extra] r310584 - [clang-tidy] Add modernize-use-emplace.IgnoreImplicitConstructors option

Author: alexfh Date: Thu Aug 10 05:19:05 2017 New Revision: 310584 URL: http://llvm.org/viewvc/llvm-project?rev=310584&view=rev Log: [clang-tidy] Add modernize-use-emplace.IgnoreImplicitConstructors option Added: clang-tools-extra/trunk/test/clang-tidy/modernize-use-emplace-ignore-implicit-c

[clang-tools-extra] r310585 - [clang-tidy] Enable test for http://llvm.org/PR26228

Author: alexfh Date: Thu Aug 10 05:24:52 2017 New Revision: 310585 URL: http://llvm.org/viewvc/llvm-project?rev=310585&view=rev Log: [clang-tidy] Enable test for http://llvm.org/PR26228 Modified: clang-tools-extra/trunk/test/clang-tidy/readability-braces-around-statements.cpp Modified: cla

Re: [clang-tools-extra] r310584 - [clang-tidy] Add modernize-use-emplace.IgnoreImplicitConstructors option

I think you also need to add the doc for the option in modernize-use-emplace.rst. On Thu, Aug 10, 2017 at 2:19 PM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Thu Aug 10 05:19:05 2017 > New Revision: 310584 > > URL: http://llvm.org/viewvc/llvm

r310544 - [clang-format] let PointerAlignment dictate spacing of function ref qualifiers

Author: jtbandes Date: Wed Aug 9 18:30:22 2017 New Revision: 310544 URL: http://llvm.org/viewvc/llvm-project?rev=310544&view=rev Log: [clang-format] let PointerAlignment dictate spacing of function ref qualifiers Summary: The original changes for ref qualifiers in rL272537 and rL272548 allowed

[clang-tools-extra] r310586 - [clang-tidy] Add a test.

Author: alexfh Date: Thu Aug 10 05:38:46 2017 New Revision: 310586 URL: http://llvm.org/viewvc/llvm-project?rev=310586&view=rev Log: [clang-tidy] Add a test. Modified: clang-tools-extra/trunk/unittests/clang-tidy/ReadabilityModuleTest.cpp Modified: clang-tools-extra/trunk/unittests/clang-tid

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

atanasyan updated this revision to Diff 110561. atanasyan edited the summary of this revision. atanasyan added a comment. - Addressed review comments. Repository: rL LLVM https://reviews.llvm.org/D36550 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.c

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan updated this revision to Diff 110562. atanasyan added a comment. - Addressed review comments. Repository: rL LLVM https://reviews.llvm.org/D36551 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp test/Driver/mips-features.c test/Driver/

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added a comment. + Introduce refactoring diagnostics. Repository: rL LLVM https://reviews.llvm.org/D36075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman updated this revision to Diff 110563. arphaman edited the summary of this revision. arphaman added a comment. - Simplify error/diagnostic handling. Use `DiagnosticOr` instead of `DiagOr`. - Simplify the code for the selection requirements by removing lambda deducers and instead using sp

[PATCH] D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action

arphaman created this revision. Herald added a subscriber: mgorny. This patch depends on https://reviews.llvm.org/D36075 and https://reviews.llvm.org/D36156. It introduces the `clang-refactor` tool alongside the `local-rename` action which is uses the existing renaming engine used by `clang-ren

[clang-tools-extra] r310587 - [clang-tidy] Updated docs and release notes for r310584

Author: alexfh Date: Thu Aug 10 05:54:05 2017 New Revision: 310587 URL: http://llvm.org/viewvc/llvm-project?rev=310587&view=rev Log: [clang-tidy] Updated docs and release notes for r310584 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/clang-tidy/chec

Re: [clang-tools-extra] r310584 - [clang-tidy] Add modernize-use-emplace.IgnoreImplicitConstructors option

Thanks for noticing this! Committed in r310587. On Thu, Aug 10, 2017 at 2:33 PM, Haojian Wu wrote: > I think you also need to add the doc for the option in > modernize-use-emplace.rst. > > On Thu, Aug 10, 2017 at 2:19 PM, Alexander Kornienko via cfe-commits < > cfe-commits@lists.llvm.org> wrote:

[PATCH] D35932: [clang-tidy] Add integer division check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s Can you put this in test/Driver/mips-ab

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a few nits. Comment at: clang-tidy/android/CloexecCheck.cpp:49 + Finder->addMatcher( + ast_matchers::callExpr( + ast_matchers::callee(

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s sdardis wrote: > Can you put this in

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s sdardis wrote: > atanasyan wrote: > >

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

sdardis added a comment. Nit: my comment on line 297, "non position-independent code and N64 ABI" should be "non position-independent code and the N64 ABI". LGTM otherwise. Repository: rL LLVM https://reviews.llvm.org/D36550 ___ cfe-commits ma

[clang-tools-extra] r310589 - [clang-tidy] Add integer division check

Author: xazax Date: Thu Aug 10 06:30:30 2017 New Revision: 310589 URL: http://llvm.org/viewvc/llvm-project?rev=310589&view=rev Log: [clang-tidy] Add integer division check Patch by: Reka Nikolett Kovacs Differential Revision: https://reviews.llvm.org/D35932 Added: clang-tools-extra/trunk/cl

[PATCH] D35932: [clang-tidy] Add integer division check

This revision was automatically updated to reflect the committed changes. Closed by commit rL310589: [clang-tidy] Add integer division check (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D35932?vs=110539&id=110570#toc Repository: rL LLVM https://reviews.llvm.org/D35

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Hi Alex, I have no idea what the errors you mention are. I worked until very late last night to fix the previous error with the compute capability. Maybe fixing that unlocked some other errors. I would need a lot of help to figure out what's going on since I probably

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

yaxunl created this revision. https://reviews.llvm.org/D36580 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/SyncScope.h lib/CodeGen/CGAtomic.cpp lib/Sema/SemaChecking.cpp test/CodeGenOpenCL/atomic-ops-libcall.cl test/CodeGenOpenCL/atomic-ops.cl test/SemaOpenC

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

modocache added a reviewer: vsk. modocache planned changes to this revision. modocache added a comment. Thanks for the feedback, @vsk, I really appreciate it! I have some other work done for this on my local checkout, but I was going a little bonkers working on it without knowing whether people

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

r310600 - [sanitizer-coverage] Change cmp instrumentation to distinguish const operands

Author: glider Date: Thu Aug 10 08:00:13 2017 New Revision: 310600 URL: http://llvm.org/viewvc/llvm-project?rev=310600&view=rev Log: [sanitizer-coverage] Change cmp instrumentation to distinguish const operands This implementation of SanitizerCoverage instrumentation inserts different callbacks d

[PATCH] D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!

xazax.hun added a comment. In https://reviews.llvm.org/D34508#791048, @NoQ wrote: > Currently, we already highlight the last assignments for the "interesting" > variables, which is implemented through, for example, > `bugreporter::trackNullOrUndefValue()` - see how various checkers use it. > T

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. While I do get the time pressure and such, doing it at the expense of others is not cool. Many teams work process is broken for days, folks are busy looking into it, investigating and reverting, other breakages are masked by these failures etc. If your test depend o

r310605 - [Modules] Prevent #import to reenter header if not building a module.

Author: bruno Date: Thu Aug 10 08:16:24 2017 New Revision: 310605 URL: http://llvm.org/viewvc/llvm-project?rev=310605&view=rev Log: [Modules] Prevent #import to reenter header if not building a module. When non-modular headers are imported while not building a module but in -fmodules mode, be con

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after all the reverts in r310580, our tests are still failing (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7080). not surprising, but very disrupting. Please have a plan to fix it soon, otherwise I'll have to revert it even further. Re

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache added a comment. Oops, sorry. I couldn't find anyone recent in the commit history. I hope no one minds if I just go ahead and commit this. https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

r310609 - [Parse] Document PrintStats, SkipFunctionBodies

Author: modocache Date: Thu Aug 10 08:30:35 2017 New Revision: 310609 URL: http://llvm.org/viewvc/llvm-project?rev=310609&view=rev Log: [Parse] Document PrintStats, SkipFunctionBodies Summary: Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL310609: [Parse] Document PrintStats, SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36530 Files: cfe/trunk/include/clang/Parse/ParseAST.h Index: cfe/trun

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. First of all, I apologize if I've upset you with my previous post. I am actively working on understanding what is causing these issues. It is not my intention to write tests that work on local configurations only. I am upset to see that these tests keep failing for you

Re: [clang-tools-extra] r310559 - [clang-tidy] Minor documentation improvement

On Thu, Aug 10, 2017 at 11:13 AM, Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Thu Aug 10 02:13:26 2017 > New Revision: 310559 > > URL: http://llvm.org/viewvc/llvm-project?rev=310559&view=rev > Log: > [clang-tidy] Minor documentation improvement > > Pa

r310614 - [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

Author: atanasyan Date: Thu Aug 10 08:42:25 2017 New Revision: 310614 URL: http://llvm.org/viewvc/llvm-project?rev=310614&view=rev Log: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options While we do not support `-mshared / -mno-shared` properly, show warning and ignore `-ml

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL310613: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D36550?vs=110561&id=110585#toc Repository: rL LLV

r310613 - [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

Author: atanasyan Date: Thu Aug 10 08:42:16 2017 New Revision: 310613 URL: http://llvm.org/viewvc/llvm-project?rev=310613&view=rev Log: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI The -mabicalls option does not make sense in the case of non position independent code for the

r310615 - [mips] Group all `-mabicalls` related checks in the single place. NFC

Author: atanasyan Date: Thu Aug 10 08:42:31 2017 New Revision: 310615 URL: http://llvm.org/viewvc/llvm-project?rev=310615&view=rev Log: [mips] Group all `-mabicalls` related checks in the single place. NFC Removed: cfe/trunk/test/Driver/mips-longcalls-warning.c Modified: cfe/trunk/test/Dr

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

This revision was automatically updated to reflect the committed changes. Closed by commit rL310614: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D36551?vs=110562&id=110586#toc Repository:

r310616 - Place implictly declared functions at block scope

Author: chill Date: Thu Aug 10 08:43:06 2017 New Revision: 310616 URL: http://llvm.org/viewvc/llvm-project?rev=310616&view=rev Log: Place implictly declared functions at block scope Such implicitly declared functions behave as if the enclosing block contained the declaration extern int name() (C9

[PATCH] D33676: Place implictly declared functions at block scope

This revision was automatically updated to reflect the committed changes. Closed by commit rL310616: Place implictly declared functions at block scope (authored by chill). Changed prior to commit: https://reviews.llvm.org/D33676?vs=109366&id=110587#toc Repository: rL LLVM https://reviews.ll

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

hfinkel added a comment. In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > First of all, I apologize if I've upset you with my previous post. I am > actively working on understanding what is causing these issues. It is not my > intention to write tests that work on local configurati

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

arphaman added a comment. Generally such NFC patches can be committed directly as they can be reviewed after the commit Repository: rL LLVM https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [clang-tools-extra] r310559 - [clang-tidy] Minor documentation improvement

On 10 August 2017 at 17:40, Alexander Kornienko wrote: > > > On Thu, Aug 10, 2017 at 11:13 AM, Gabor Horvath via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: xazax >> Date: Thu Aug 10 02:13:26 2017 >> New Revision: 310559 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=31055

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

doug.gregor added a comment. LGTM, thank you! Repository: rL LLVM https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > First of all, I apologize if I've upset you with my previous post. I am > actively working on understanding what is causing these issues. It is not my > intention to write tests that work on local configur

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. The failures were very widespread, e.g. there's a linux buildbot that was red until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you have access to a linux machine you should be able to reproduce the failures that the bot experienced by using the

Re: [clang-tools-extra] r310559 - [clang-tidy] Minor documentation improvement

There's also `C::x; // 2` below, so I'd add this comment back at least for consistency. On Thu, Aug 10, 2017 at 5:53 PM, Gábor Horváth wrote: > > > On 10 August 2017 at 17:40, Alexander Kornienko wrote: > >> >> >> On Thu, Aug 10, 2017 at 11:13 AM, Gabor Horvath via cfe-commits < >> cfe-commits@

r310618 - Fixed a race condition in PrecompiledPreamble.

Author: ibiryukov Date: Thu Aug 10 09:10:40 2017 New Revision: 310618 URL: http://llvm.org/viewvc/llvm-project?rev=310618&view=rev Log: Fixed a race condition in PrecompiledPreamble. Summary: Two PrecompiledPreambles, used in parallel on separate threads, could be writing preamble to the same tem

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310618: Fixed a race condition in PrecompiledPreamble. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36529 Files: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp Index: cfe

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. @gtbercea Hi, I just saw your comment on my gist. (Unfortunately github does not send email notifications about gist comments; commenting here is probably better.) If you have Docker installed, it should be easy to get whatever output you like — just change the Dockerf

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > The failures were very widespread, e.g. there's a linux buildbot that was red > until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you > have access to a linux machine you should be abl

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

Hi Hans, can we please get this merged into 5.0? Thanks, On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Thu Aug 10 08:16:24 2017 > New Revision: 310605 > > URL: http://llvm.org/viewvc/llvm-project?rev=310605&view=rev > Log: > [Modules] Preven

r310622 - Add a getName accessor for ModuleMacros.

Author: bwilson Date: Thu Aug 10 09:42:46 2017 New Revision: 310622 URL: http://llvm.org/viewvc/llvm-project?rev=310622&view=rev Log: Add a getName accessor for ModuleMacros. Swift would like to be able to access the name of a ModuleMacro. There was some discussion of this in https://github.com/a

[PATCH] D36563: Add a getName accessor for ModuleMacros

bob.wilson added a comment. Committed in r310622 https://reviews.llvm.org/D36563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. I've traced the output across all the reverted commits: F5233517: testFailures.md Note that after r310549 the last 9 RUN lines started failing because of the same crash: clang version 6.0.0 (http://llvm.org/git/llvm.git 00708415

[PATCH] D36584: Implemented P0704R1 - Fixing const-qualified pointers to members

hamzasood created this revision. This patch provides an implementation for P0704R1 . I also made it work pre-C++2a as an extension (with a warning) since that's how Clang seems to deal with small additions like this. Hopefully someone more knowledgable on the matter ca

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp:483-498 +void MagentaHandleChecker::checkPreStmt(const ReturnStmt *RS, +CheckerContext &Ctx) const { + ProgramStateRef State = Ctx.getState(); +

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann updated this revision to Diff 110602. euhlmann edited the summary of this revision. euhlmann added a comment. The patch now uses `PPBranchLevel` to track indent level. It allows `PPBranchLevel` to go back down to -1. The existing `PPBranchLevel >= 0` checks appear to prevent indexing in

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#838185, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > > > First of all, I apologize if I've upset you with my previous post. I am > > actively working on understanding what is causing these issues.

r310627 - [Parse] Document Parser::SkipFunctionBodies

Author: modocache Date: Thu Aug 10 10:02:04 2017 New Revision: 310627 URL: http://llvm.org/viewvc/llvm-project?rev=310627&view=rev Log: [Parse] Document Parser::SkipFunctionBodies Reviewers: erikjv, doug.gregor Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D36531 Mod

  1   2   >