rsmith added a comment.
Organizationally, this seems fine. Carry on :)
Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:229-231
+def err_fnmap_parsing : Error<
+ "error parsing CrossTU index file: '%0' line: %1 'USR filename' format "
+ "expected">;
johannes added a comment.
In https://reviews.llvm.org/D36184#828866, @klimek wrote:
> Why? Also, missing tests.
implicit nodes are noisy / they generally don't add information; I guess one
could also keep them.
I excluded nodes outside of the main file are because the visualisation only
work
mcgrathr updated this revision to Diff 109428.
mcgrathr added a comment.
Added tests.
https://reviews.llvm.org/D35922
Files:
cmake/caches/Fuchsia-stage2.cmake
lib/Driver/SanitizerArgs.cpp
lib/Driver/ToolChains/Fuchsia.cpp
test/Driver/fuchsia.c
Index: test/Driver/fuchsia.c
=
johannes added inline comments.
Comment at: test/Tooling/clang-diff-bottomup.cpp:3
+// RUN: %clang_cc1 -E %s > %t.dst.cpp -DDEST
+// RUN: clang-diff -m -no-compilation-database -s=0 %t.src.cpp %t.dst.cpp |
FileCheck %s
+//
klimek wrote:
> Instead of using -no-co
v.g.vassilev added inline comments.
Comment at: lib/CodeGen/CGCXXABI.cpp:43
if (RD->hasNonTrivialDestructor())
return false;
rjmccall wrote:
> Does canPassInRegisters() not subsume all of these earlier checks?
No, if I remove them here I get a lot of te
johannes added inline comments.
Comment at: test/Tooling/clang-diff-ast.cpp:32
+
+// CHECK: TypedefDecl: nat;unsigned int;(
+typedef unsigned nat;
klimek wrote:
> For my curiosity: why are there semicolons here? Is the format documented
> somewhere?
To avoid col
Author: d0k
Date: Wed Aug 2 14:16:50 2017
New Revision: 309888
URL: http://llvm.org/viewvc/llvm-project?rev=309888&view=rev
Log:
Remove unused diagnostic. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
URL
Instead of creating two variables, wouldn't it be better to just remove the
second definition and clear m_ec? You don't need to use both error codes
side by side, as the second usage of m_ec occurs after the first one is
finished. So you could remove the second definition and call clear() on it,
to
tstellar added a comment.
Ping.u1
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar updated this revision to Diff 109438.
tstellar added a comment.
Add links to index.rst and UsersManual.rst, and fix link to bug.
https://reviews.llvm.org/D34212
Files:
docs/BinaryCompatibilityWithOtherCompilers.rst
docs/UsersManual.rst
docs/index.rst
Index: docs/index.rst
=
On 31 July 2017 at 09:11, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard, Gor asked for this to be merged to 5.0. What do you think?
Sounds good to me.
On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe-commits
> wrote:
> > Author: gornishanov
> > Date: Tue Ju
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Hmm. So the documentation is wrong, but not "fully wrong". If you simply try
applying this patch and compiling with GCC you'll still encounter a bunch of
instances of `warning: type
saugustine created this revision.
These tests assume intel-80 bit floats, as noted in their comments. Rather than
having each target discover the incompatibility and disable them ad-hoc, mark
them as requiring x86.
Repository:
rL LLVM
https://reviews.llvm.org/D36249
Files:
compiler-rt/te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309901: [coverage] Make smaller regions for the first case
of a switch. (authored by efriedma).
Changed prior to commit:
https://reviews.llvm.org/D34801?vs=104581&id=109456#toc
Repository:
rL LLVM
h
Author: efriedma
Date: Wed Aug 2 16:22:50 2017
New Revision: 309901
URL: http://llvm.org/viewvc/llvm-project?rev=309901&view=rev
Log:
[coverage] Make smaller regions for the first case of a switch.
We never overwrite the end location of a region, so we would end up with
an overly large region wh
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
First, this patch would need tests before continuing, Could you please them?
The list tests live under `test/std/containers/sequences/list`. Let me know if
you have any questions or
efriedma created this revision.
The code after a noreturn call doesn't execute.
The pattern in the testcase is pretty common in LLVM (a switch with a default
case that calls llvm_unreachable).
Repository:
rL LLVM
https://reviews.llvm.org/D36250
Files:
lib/CodeGen/CoverageMappingGen.cpp
haowei created this revision.
Herald added a subscriber: xazax.hun.
This patch will suppress handle leak warnings if the path of a bug reported by
MagentaHandleChecker will reach a no return function or will reach the end of
main function. As these two scenarios mean program crash and the leaked
timshen created this revision.
Herald added a subscriber: sanjoy.
The mis-compile is triggered by internal code, but I haven't reduced it to a
small piece of code. Add a FIXME here, since a decent fix doesn't seem to be
trivial.
The decent fix can be changing Decl::Init to PointerUnion, and mak
mcgrathr created this revision.
The .gnu_hash format is superior, and all versions of the Fuchsia
dynamic linker support it.
Repository:
rL LLVM
https://reviews.llvm.org/D36254
Files:
lib/Driver/ToolChains/Fuchsia.cpp
Index: lib/Driver/ToolChains/Fuchsia.cpp
=
Author: timshen
Date: Wed Aug 2 17:18:11 2017
New Revision: 309908
URL: http://llvm.org/viewvc/llvm-project?rev=309908&view=rev
Log:
[Sema] Add a comment on an identified bug on default arguments.
Summary:
The mis-compile is triggered by internal code, but I haven't reduced it to a
small piece
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309908: [Sema] Add a comment on an identified bug on default
arguments. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D36253?vs=109461&id=109464#toc
Repository:
rL LLVM
ht
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm.
Repository:
rL LLVM
https://reviews.llvm.org/D36250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hintonda updated this revision to Diff 109472.
hintonda added a comment.
- Use cat|xargs which should work on window -- used in other tests.
https://reviews.llvm.org/D36252
Files:
test/Misc/find-diagnostic-id.c
tools/diagtool/FindDiagnosticID.cpp
Index: tools/diagtool/FindDiagnosticID.cpp
phosek accepted this revision.
phosek added a comment.
LGTM
https://reviews.llvm.org/D35922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rafael
Date: Wed Aug 2 19:16:28 2017
New Revision: 309912
URL: http://llvm.org/viewvc/llvm-project?rev=309912&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.org/viewvc/llvm-proje
Author: ericwf
Date: Wed Aug 2 19:50:43 2017
New Revision: 309917
URL: http://llvm.org/viewvc/llvm-project?rev=309917&view=rev
Log:
Add system header pragma to BSD locale fallback headers.
This prevent leaking warnings to the user about use of C++11
extensions in C++03.
Modified:
libcxx/tru
t-tye added inline comments.
Comment at: include/clang/Basic/SyncScope.h:23
+enum class SyncScope {
+ OpenCLWorkItem = 0,
+ OpenCLWorkGroup = 1,
The OpenCL workitem scope is only used for image fences and does not apply to
atomic operations so not sure that it
Hello everyone,
LLVM buildmaster will be updated and restarted approximately at 08:00 AM
PDT 4th August.
--
Best Regards,
Victor Leschuk | Software Engineer |Access Softek
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: ericwf
Date: Wed Aug 2 21:28:10 2017
New Revision: 309920
URL: http://llvm.org/viewvc/llvm-project?rev=309920&view=rev
Log:
Fix libcxx build with glibc 2.26+ by removing xlocale.h include.
Patch by Khem Raj. Reviewed as D35697. Also see PR33729.
Modified:
libcxx/trunk/include/__loc
phosek updated this revision to Diff 109485.
Repository:
rL LLVM
https://reviews.llvm.org/D35820
Files:
include/clang/Driver/ToolChain.h
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
Index: lib/Driver/ToolChain.cpp
===
--
yaxunl created this revision.
OpenCL spec v2.0 s6.13.6:
gentype select (gentype a,
gentype b,
igentype c)
gentype select (gentype a,
gentype b,
ugentype c)
igentype and ugentype must have the same number
of elements and bits as gentype.
https://reviews.llvm.org/D36259
Files:
lib/Headers/op
rjmccall added a comment.
The patch generally looks good, but if you need to handle non-constant scopes,
you should submit a new patch to address that.
Comment at: lib/CodeGen/CGAtomic.cpp:896
+return V;
+ auto DestAS = getContext().getTargetAddressSpace(LangAS::o
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCXXABI.cpp:43
if (RD->hasNonTrivialDestructor())
return false;
v.g.vassilev wrote:
> rjmccall wrote:
> > Does canPassInRegisters() not subsume all of these earlier checks?
> No, if I remove them
weimingz added a comment.
I tried to address it via checking pre-defined macros:
https://reviews.llvm.org/D31573
As long as the macros are defined correctly by clang, we don't need to worry
about the specific target machine. How do you think about it?
Repository:
rL LLVM
https://reviews.llv
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
Out of curiosity: how did you detect this?
Can we use the same approach for writing tests?
https://reviews.llvm.org/D36259
___
cfe-commits mailing
atanasyan added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5979-5981
+if (S.Context.getTargetInfo().getABI() != "o32")
+ S.Diag(Attr.getLoc(), diag::err_attribute_supported_by_o32)
+ << Attr.getName() << D->getLocation();
aaron.ballm
101 - 137 of 137 matches
Mail list logo
