v.g.vassilev added inline comments.
================
Comment at: lib/CodeGen/CGCXXABI.cpp:43
if (RD->hasNonTrivialDestructor())
return false;
----------------
rjmccall wrote:
> Does canPassInRegisters() not subsume all of these earlier checks?
No, if I remove them here I get a lot of test failures. I cannot move them
(yet?) in Sema, because I need to call `Sema::CheckCompletedCXXClass` in
`Sema::ActOnFields` to compute the triviality of the decl. Only then it would
be safe move these checks in `CanPassInRegisters`.
https://reviews.llvm.org/D35056
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
