[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

2017-07-13 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs updated this revision to Diff 106381. https://reviews.llvm.org/D32700 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/SuspiciousMemsetUsageCheck.cpp clang-tidy/bugprone/SuspiciousMemsetUsageCheck

[PATCH] D32700: [clang-tidy] Add bugprone-suspicious-memset-usage check.

2017-07-13 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs marked an inline comment as done. rnkovacs added inline comments. Comment at: docs/clang-tidy/checks/bugprone-suspicious-memset-usage.rst:10 + +**Case 1: Fill value is a character '0'** + whisperity wrote: > Shouldn't this `'0'` be enclosed within backti

[PATCH] D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant

2017-07-13 Thread Olivier Goffart via Phabricator via cfe-commits
ogoffart added a comment. Thanks for the link to the bug report. This patch mostly address the evaluation within a constexpr, which is orthogonal to the changes in the backend suggered in that bug report. https://reviews.llvm.org/D35190 ___ cfe-com

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

2017-07-13 Thread Egor Churaev via Phabricator via cfe-commits
echuraev added a comment. In https://reviews.llvm.org/D35000#801132, @Anastasia wrote: > In https://reviews.llvm.org/D35000#799705, @Anastasia wrote: > > > Btw, is there any reason to add testing specifically for half? Is there > > anything specific to half in the implementation of this? > > > T

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-13 Thread Amara Emerson via Phabricator via cfe-commits
aemerson added a comment. In https://reviews.llvm.org/D35118#806730, @rengolin wrote: > @jmolloy Can you check this change, please? I'm not really removing FPUMode, I'm just converting an enum to a bit field. FPUMode, i.e. no NEON, after this change is now represented by simply having all bit

[PATCH] D33440: clang-format: better handle statement and namespace macros

2017-07-13 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-13 Thread Renato Golin via Phabricator via cfe-commits
rengolin added a comment. In https://reviews.llvm.org/D35118#807712, @aemerson wrote: > In https://reviews.llvm.org/D35118#806730, @rengolin wrote: > > > @jmolloy Can you check this change, please? > > > I'm not really removing FPUMode, I'm just converting an enum to a bit field. > FPUMode, i.e.

r307898 - [refactor][rename] Use a single base class for class that finds

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 03:36:33 2017 New Revision: 307898 URL: http://llvm.org/viewvc/llvm-project?rev=307898&view=rev Log: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration

[PATCH] D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration

2017-07-13 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307898: [refactor][rename] Use a single base class for class that finds (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34949?vs=105084&id=106388#toc Repository: rL LLVM h

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-13 Thread Amara Emerson via Phabricator via cfe-commits
aemerson updated this revision to Diff 106386. aemerson added a comment. The reason it's removed is because it's not actually used anywhere, just as a default value. I'm not going to debate it further though so I've put it back in. Repository: rL LLVM https://reviews.llvm.org/D35118 Files:

r307901 - [index] Objective-C method declarations and message sends with

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 03:50:21 2017 New Revision: 307901 URL: http://llvm.org/viewvc/llvm-project?rev=307901&view=rev Log: [index] Objective-C method declarations and message sends with an empty first selector piece should store the location of the first ':' rdar://33188656 Modified:

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-13 Thread Renato Golin via Phabricator via cfe-commits
rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Repository: rL LLVM https://reviews.llvm.org/D35118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D35268: [ObjC] Ambiguous property synthesis should pick the 'readwrite' property and check for incompatible attributes

2017-07-13 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307903: [ObjC] Pick a 'readwrite' property when synthesizing ambiguous (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D35268?vs=106060&id=106394#toc Repository: rL LLVM ht

r307903 - [ObjC] Pick a 'readwrite' property when synthesizing ambiguous

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 04:06:22 2017 New Revision: 307903 URL: http://llvm.org/viewvc/llvm-project?rev=307903&view=rev Log: [ObjC] Pick a 'readwrite' property when synthesizing ambiguous property and check for incompatible attributes This commit changes the way ambiguous property synth

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

2017-07-13 Thread Fedor Sergeev via Phabricator via cfe-commits
fedor.sergeev updated this revision to Diff 106392. fedor.sergeev added a comment. Added Solaris targets to clang driver test checking for -fuse-init-array. https://reviews.llvm.org/D35337 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Solaris.cpp lib/Driver/ToolChains/Solaris

r307905 - Remove 'using namespace llvm' from the USRFinder.h header

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 04:27:12 2017 New Revision: 307905 URL: http://llvm.org/viewvc/llvm-project?rev=307905&view=rev Log: Remove 'using namespace llvm' from the USRFinder.h header This should fix the modules build (http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 106402. vladimir.plyashkun added a comment. 1. split revision into two 2. fix failing tests Repository: rL LLVM https://reviews.llvm.org/D34404 Files: include/clang/Tooling/DiagnosticsYaml.h unittests/Tooling/CMakeLists.txt unittests/Too

[PATCH] D35349: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added a project: clang-tools-extra. Herald added subscribers: xazax.hun, JDevlieghere, mgorny. To get properly integration Clang-Tidy with CLion IDE, next things were implemented: - Preserve `Message`, `FileOffset`, `FilePath` in the c

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. I've splitted single revision into two different revisions: https://reviews.llvm.org/D34404 https://reviews.llvm.org/D35349 Also, i fixed failing test-cases in clang-apply-replacements due to changes in output format (so they shouldn't be a problem anymore) R

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

2017-07-13 Thread Maxim Ostapenko via Phabricator via cfe-commits
m.ostapenko updated this revision to Diff 106408. m.ostapenko retitled this revision from "Add scope information to CFG" to "Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements". m.ostapenko added a comment. Updating the diff. I've dropped SwitchStmt support, let's im

[PATCH] D35349: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. This is second part of review: https://reviews.llvm.org/D34404 which is contains changes related to clang-tools-extra repository. Repository: rL LLVM https://reviews.llvm.org/D35349 ___ cfe-commits mailing lis

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

2017-07-13 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:723 FormatDecision LastFormat = Node->State.NextToken->Decision; if (LastFormat == FD_Unformatted || LastFormat == FD_Continue) +addNextStateToQueue(Penalty, Node, /*NewLine=*/fals

r307908 - Remove another 'using namespace llvm' from the

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 05:49:22 2017 New Revision: 307908 URL: http://llvm.org/viewvc/llvm-project?rev=307908&view=rev Log: Remove another 'using namespace llvm' from the RecursiveSymbolVisitor.h header This should fix the modules build (http://lab.llvm.org:8011/builders/clang-x86_64-l

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

2017-07-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This looks reasonable to me, but I am not overly familiar with this part of the toolchain. You should wait for another LG before committing. https://reviews.llvm.org/D35337 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

2017-07-13 Thread Francois Ferrand via Phabricator via cfe-commits
Typz marked 2 inline comments as done. Typz added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:723 FormatDecision LastFormat = Node->State.NextToken->Decision; if (LastFormat == FD_Unformatted || LastFormat == FD_Continue) +addNextState

r307910 - [OPENMP] Generalization of codegen for reduction clauses.

2017-07-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 13 06:36:14 2017 New Revision: 307910 URL: http://llvm.org/viewvc/llvm-project?rev=307910&view=rev Log: [OPENMP] Generalization of codegen for reduction clauses. Reworked codegen for reduction clauses for future support of reductions in task-based directives. Modifi

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D35081#807497, @mehdi_amini wrote: > In https://reviews.llvm.org/D35081#807172, @fhahn wrote: > > > It's @yunlian, so if the issue you described above covers his failure, than > > that's great. @tejohnson do you have time to work on a fix so

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-07-13 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. I think we should exclude unsigned types completely. `A >= B` is converted to `A - B >= 0`, thus the range of `A - B` is `[0 .. INT_MAX]` which is the full range for the unsigned type. This implies that upon any conditional statement `if (A >= B) ...` the ran

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-07-13 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan created this revision. When we have enabled cache for global completions we did not have diagnostics for Bar and could not complete Ba as in provided code example. template struct Foo { T member; }; template using Bar = Foo; int main() { Ba } https://reviews.llvm.org/D35355 Files

r307911 - [OPENMP] Fix reduction tests, NFC.

2017-07-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 13 07:29:19 2017 New Revision: 307911 URL: http://llvm.org/viewvc/llvm-project?rev=307911&view=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

2017-07-13 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:511 + SSE->getLHS()->getType()->isSignedIntegerOrEnumerationType() || + SSE->getLHS()->getType()->isPointerType()) { + return negV->Negate(BV, F);

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-07-13 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. I tested the latest revision (this fronted patch already included) on my test file in https://reviews.llvm.org/D33537. Disregarding of the (not so important) check-specific parameters (`EnabledFunctions` and `IgnoredExceptions`) I do not get warnings for any

[PATCH] D33537: [clang-tidy] Exception Escape Checker

2017-07-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D33537#801889, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote: > > > The check in https://reviews.llvm.org/D3 is using a CFG, not just > > checking direct throws. > > > I tested the latest r

r307912 - [OPENMP] Fix reduction tests, NFC.

2017-07-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 13 07:54:42 2017 New Revision: 307912 URL: http://llvm.org/viewvc/llvm-project?rev=307912&view=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

r307914 - [OPENMP] Further reduction test fix, NFC.

2017-07-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 13 08:02:27 2017 New Revision: 307914 URL: http://llvm.org/viewvc/llvm-project?rev=307914&view=rev Log: [OPENMP] Further reduction test fix, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Mo

r307915 - [OPENMP] Fix reduction tests, NFC.

2017-07-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 13 08:09:05 2017 New Revision: 307915 URL: http://llvm.org/viewvc/llvm-project?rev=307915&view=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

r307916 - [OPENMP] Fix reduction tests, NFC.

2017-07-13 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jul 13 08:15:25 2017 New Revision: 307916 URL: http://llvm.org/viewvc/llvm-project?rev=307916&view=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

2017-07-13 Thread Davide Italiano via Phabricator via cfe-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Driver/ToolChains/Gnu.cpp:2467 const Generic_GCC::GCCVersion &V = GCCInstallation.getVersion(); bool UseInitArrayDefault = getTriple().getA

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

2017-07-13 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. In https://reviews.llvm.org/D34588#802533, @bruno wrote: > > Thinking more about this, on Windows, is there a strong reason to default > > to a different libc by default on Windows? > > I'm mostly concerned with `-fms-extensions` + darwin, which doesn't apply to > this

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

2017-07-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > Some non-windows targets using MS extensions define _WIN32 for compatibility > with Windows but do not have MSVC compatibility. So, these hypothetical targets have the Win32 API available, but the

RE: D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

2017-07-13 Thread Erik Schwiebert via cfe-commits
These hypothetical targets aren’t so hypothetical. Office for Mac and iOS uses code ported from Windows but actually targeted at running on the Apple (Darwin) platform. We don’t have the MSVC CRT there. 😊 Schwieb -Original Message- From: Reid Kleckner via Phabricator [mailto:revi...@r

r307919 - [AArch64] Add support for handling the +sve target feature.

2017-07-13 Thread Amara Emerson via cfe-commits
Author: aemerson Date: Thu Jul 13 08:36:01 2017 New Revision: 307919 URL: http://llvm.org/viewvc/llvm-project?rev=307919&view=rev Log: [AArch64] Add support for handling the +sve target feature. This also adds the appropriate predefine for SVE if enabled. Differential Revision: https://reviews.l

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-13 Thread Amara Emerson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307919: [AArch64] Add support for handling the +sve target feature. (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D35118?vs=106386&id=106432#toc Repository: rL LLVM https

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

2017-07-13 Thread Peter Szecsi via Phabricator via cfe-commits
szepet added a comment. Hello Maxim! Thanks for working on this! > Ugh, yeah, SwitchStmt is tricky (thank you for pointing to Duff's device > example!). I've tried to resolve several issues with switch revealed by this > testcase, but didn't succeed for now :(. So, it was decided to remove > S

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

2017-07-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In https://reviews.llvm.org/D34331#803452, @EricWF wrote: > In https://reviews.llvm.org/D34331#803105, @dexonsmith wrote: > > > In https://reviews.llvm.org/D34331#802747, @EricWF wrote: > > > > > @dexonsmith Mind if I hijack this and check in your changes to > > > ``

[PATCH] D33537: [clang-tidy] Exception Escape Checker

2017-07-13 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote: > In https://reviews.llvm.org/D33537#771159, @baloghadamsoftware wrote: > > > In https://reviews.llvm.org/D33537#770264, @aaron.ballman wrote: > > > > > I think we should try to get as much of this functionalit

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

2017-07-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think the remaining switch-related code seems to be about C++17 switch condition variables, i.e. `switch (int x = ...)`(?) Repository: rL LLVM https://reviews.llvm.org/D16403 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: unittests/Tooling/CompilationDatabaseTest.cpp:638-652 + ParseCompilationDatabaseFromResponseFileTest() { +std::error_code EC = llvm::sys::fs::createUniqueDirectory("unittest", TestDir); +EXPECT_TRUE(!EC); +llvm::

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

2017-07-13 Thread Maxim Ostapenko via Phabricator via cfe-commits
m.ostapenko added a comment. In https://reviews.llvm.org/D16403#808104, @NoQ wrote: > I think the remaining switch-related code seems to be about C++17 switch > condition variables, i.e. `switch (int x = ...)`(?) Yeah, exactly. I can remove it from this patch if it looks confusing. Repositor

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Teresa: can you describe a bit more how we end up importing two summaries for the same GUID? I would expect that after importing one, we don't even come to try to import another since we already have one. https://reviews.llvm.org/D35081 _

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 106436. vladimir.plyashkun added a comment. - trailing period - moved test-cases to separate file Repository: rL LLVM https://reviews.llvm.org/D34440 Files: lib/Tooling/CommonOptionsParser.cpp unittests/Tooling/CMakeLists.txt unittests/T

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D35081#808124, @mehdi_amini wrote: > Teresa: can you describe a bit more how we end up importing two summaries for > the same GUID? I would expect that after importing one, we don't even come to > try to import another since we already have

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

2017-07-13 Thread Fedor Sergeev via Phabricator via cfe-commits
fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:2467 const Generic_GCC::GCCVersion &V = GCCInstallation.getVersion(); bool UseInitArrayDefault = getTriple().getArch() == llvm::Triple::aarch64 || davide wrote: > this is

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. **To discuss:** This patch is required for correct integration //Clang-Tidy// with //CLion IDE//. By this moment, we unable to use //CompilationDatabase.json// from //CLion //side which is widely used in //Clang-Tidy// and in other common tools. Anyway, there

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Thanks, very clear :) I would expect that if we reprocess a GUID we invalidate the previous import of the same GUID. Right now my impression is that the issue is that ` ImportList[ExportModulePath][VI.getGUID()]` is indexed on the importing module. So it'd require

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

2017-07-13 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D35000#807674, @echuraev wrote: > In https://reviews.llvm.org/D35000#801132, @Anastasia wrote: > > > In https://reviews.llvm.org/D35000#799705, @Anastasia wrote: > > > > > Btw, is there any reason to add testing specifically for half? Is ther

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

2017-07-13 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 106442. Typz added a comment. Move code out of optimizer, directly into ContinuationIndenter::breakProtrudingToken(), to minimize impact on performance. Comment reflowing of breakable items which break the limit will be slightly slower, since we now consider th

r307923 - NFC, Cleanup the code for -Wdeprecated-implementations

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 09:35:59 2017 New Revision: 307923 URL: http://llvm.org/viewvc/llvm-project?rev=307923&view=rev Log: NFC, Cleanup the code for -Wdeprecated-implementations and void capitalization of the warning message rdar://22867595 Modified: cfe/trunk/include/clang/Basic

r307924 - Extend -Wdeprecated-implementations to warn about unavailable methods

2017-07-13 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Jul 13 09:37:11 2017 New Revision: 307924 URL: http://llvm.org/viewvc/llvm-project?rev=307924&view=rev Log: Extend -Wdeprecated-implementations to warn about unavailable methods rdar://22867595 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D35081#808158, @mehdi_amini wrote: > Thanks, very clear :) > > I would expect that if we reprocess a GUID we invalidate the previous import > of the same GUID. Right now my impression is that the issue is that ` > ImportList[ExportModulePat

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D35081#808189, @tejohnson wrote: > > Alternatively (and likely preferably from a compile-time point of view to > > limit the list of import), we could keep a map of GUID->Summary and reuse > > it before trying to select a new callee. > >

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D35081#808204, @mehdi_amini wrote: > In https://reviews.llvm.org/D35081#808189, @tejohnson wrote: > > > > Alternatively (and likely preferably from a compile-time point of view to > > > limit the list of import), we could keep a map of GUID-

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

2017-07-13 Thread David L. Jones via Phabricator via cfe-commits
dlj accepted this revision. dlj added a comment. I think this change is structurally fine, but I'll defer to others on whether it's actually doing the right thing. (I'm pretty sure it is, but I'm far from an expert on Solaris or Sparc.) Comment at: lib/Driver/ToolChains/Gnu.c

[PATCH] D35362: [clang-tidy] Add close-on-exec checks on several functions in Android module.

2017-07-13 Thread Yan Wang via Phabricator via cfe-commits
yawanng created this revision. yawanng added a project: clang-tools-extra. Herald added subscribers: xazax.hun, JDevlieghere, mgorny. accept() is better to be replaced by accept4() with SOCK_CLOEXEC flag to avoid file descriptor leakage. This is one of a bunch of similar APIs as below and they h

r307931 - Fix -Wdocumentation warning. NFCI

2017-07-13 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Jul 13 10:29:48 2017 New Revision: 307931 URL: http://llvm.org/viewvc/llvm-project?rev=307931&view=rev Log: Fix -Wdocumentation warning. NFCI Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm.org/vi

r307932 - Fix spelling mistakes in comments. NFCI.

2017-07-13 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Jul 13 10:34:44 2017 New Revision: 307932 URL: http://llvm.org/viewvc/llvm-project?rev=307932&view=rev Log: Fix spelling mistakes in comments. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm

[PATCH] D32914: Introduce Wzero-as-null-pointer-constant.

2017-07-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. PR #33771 filled. IMHO the problems with this diagnostic should be resolved before 5.0 https://reviews.llvm.org/D32914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D32914: Introduce Wzero-as-null-pointer-constant.

2017-07-13 Thread Nico Weber via cfe-commits
On Thu, Jul 13, 2017 at 1:38 PM, Roman Lebedev via Phabricator via cfe-commits wrote: > lebedev.ri added a comment. > > PR #33771 filled. > IMHO the problems with this diagnostic should be resolved before 5.0 > iirc gcc warns in that case too (?) Als

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

2017-07-13 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Ping - the dependency, https://reviews.llvm.org/D35006, has now been committed. https://reviews.llvm.org/D35008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

2017-07-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/TargetInfo.cpp:8463 Kind = AArch64ABIInfo::DarwinPCS; +else if (Triple.getOS() == llvm::Triple::Win32) + Kind = AArch64ABIInfo::Win64;

r307933 - [AArch64] Produce the right kind of va_arg for windows

2017-07-13 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Thu Jul 13 10:59:14 2017 New Revision: 307933 URL: http://llvm.org/viewvc/llvm-project?rev=307933&view=rev Log: [AArch64] Produce the right kind of va_arg for windows On windows on arm64, the va_list is a plain pointer. Differential Revision: https://reviews.llvm.org/D3500

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

2017-07-13 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307933: [AArch64] Produce the right kind of va_arg for windows (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D35008?vs=105392&id=106471#toc Repository: rL LLVM https://re

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

2017-07-13 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. In https://reviews.llvm.org/D34121#806978, @vsk wrote: > @dtzWill do you have any further comments on this one? > > I'd like to get another 'lgtm' before committing, and it'd be nice to get > this in before llvm 5.0 branches (7/19). > > FWIW we've been living on this for

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

2017-07-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: lib/AST/Expr.cpp:3235 +// has non-default address space it is not treated as nullptr. +bool PointeeHasDefaultAS = false; +if (Ctx.getLangOpts().OpenCL) Anas

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

2017-07-13 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D35081#808207, @tejohnson wrote: > My first option was if any copy is under the threshold, simply pick the > prevailing copy (it may be over threshold, but assume we want that one > anyway). Another possibility is to only allow importing

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

2017-07-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 106486. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D35082 Files: include/clang/Basic/AddressSpaces.h lib/AST/ASTContext.cpp lib/AST/Expr.cpp lib/AST/ItaniumMangle.cpp l

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

2017-07-13 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:377 break; case 1: Error = clang::format::format(FileNames[0]); djasper wrote: > I think we should restructure the code to not have to duplicate what you are > add

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

2017-07-13 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo updated this revision to Diff 106489. mstorsjo retitled this revision from "[RFC] [AArch64] Add support for __builtin_ms_va_list on aarch64" to "[AArch64] Add support for __builtin_ms_va_list on aarch64". mstorsjo edited the summary of this revision. mstorsjo added a comment. Added test

[libcxxabi] r307941 - [demangler] Respect try_to_parse_template_args

2017-07-13 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Thu Jul 13 12:37:37 2017 New Revision: 307941 URL: http://llvm.org/viewvc/llvm-project?rev=307941&view=rev Log: [demangler] Respect try_to_parse_template_args Fixes an exponential parse found by oss-fuzz. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/

[PATCH] D35378: [clang] Add getSignedSizeType method

2017-07-13 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap created this revision. C11 standard refers to the signed counterpart of the size_t type in the paragraph 7.21.6.1 where it defines d, i, o, u, x, or x conversion specifiers (in printf format string). In Clang there is a FIXME (in lib/Analysis/PrintfFormatString.cpp) for this case (which

[PATCH] D35378: [clang] Add getSignedSizeType method

2017-07-13 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 106496. alexshap added a comment. make comments consistent Repository: rL LLVM https://reviews.llvm.org/D35378 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp Index: lib/AST/ASTContext.cpp ==

[PATCH] D35379: Add documentation for @available

2017-07-13 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. Based on https://devstreaming-cdn.apple.com/videos/wwdc/2017/411a7o9phe4uekm/411/411_whats_new_in_llvm.pdf (I couldn't find a way to play the corresponding video on linux, so I didn't look at that.) https://reviews.llvm.org/D35379 Files: docs/LanguageExtension

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

2017-07-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:65 +// Win64-compatible va_list functions +BUILTIN(__builtin_ms_va_start, "vc*&.", "nt") +BUILTIN(__builtin_ms_va_end, "vc*&", "n") I strongly suspect that Microsoft will never adopt a

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

2017-07-13 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. In https://reviews.llvm.org/D34121#808486, @dtzWill wrote: > In https://reviews.llvm.org/D34121#806978, @vsk wrote: > > > @dtzWill do you have any further comments on this one? > > > > I'd like to get another 'lgtm' before committing, and it'd be nice to get > > this in befo

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

2017-07-13 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:65 +// Win64-compatible va_list functions +BUILTIN(__builtin_ms_va_start, "vc*&.", "nt") +BUILTIN(__builtin_ms_va_end, "vc*&", "n") rnk wrote: > I strongly suspect that Microsoft

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

2017-07-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:65 +// Win64-compatible va_list functions +BUILTIN(__builtin_ms_va_start, "vc*&.", "nt") +BUILTIN(__builtin_ms_va_end, "vc*&", "n") mstorsjo wrote: > rnk wrote: > > I strongly suspect

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-13 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Just 2 small nits. Comment at: examples/clang-interpreter/main.cpp:165 + llvm::errs() << "'main' function not found in module.\n"; + return 255; +} 255 -> Res ? Comment at: examples/clang-interpreter/mai

[PATCH] D35378: [clang] Add getSignedSizeType method

2017-07-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D35378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-13 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: examples/clang-interpreter/Manager.cpp:18 +#define NOMINMAX +#include +#endif windows.h with lower case `w` to not break mingw https://reviews.llvm.org/D35103 ___ cfe-com

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

2017-07-13 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov created this revision. Herald added a subscriber: EricWF. https://reviews.llvm.org/D35383 Files: include/clang/AST/StmtCXX.h include/clang/Serialization/ASTBitCodes.h lib/AST/StmtCXX.cpp lib/Serialization/ASTReaderStmt.cpp lib/Serialization/ASTWriterStmt.cpp test/PCH/corou

[PATCH] D35379: Add documentation for @available

2017-07-13 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a reviewer: arphaman. erik.pilkington added a subscriber: arphaman. erik.pilkington added a comment. This looks great, thanks for working on this! LGTM, but @arphaman might have some thoughts. Comment at: docs/LanguageExtensions.rst:1290 -.. _langext-ov

[PATCH] D35379: Add documentation for @available

2017-07-13 Thread Nico Weber via Phabricator via cfe-commits
thakis updated this revision to Diff 106513. thakis marked an inline comment as done. thakis added a comment. comments https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td =

[PATCH] D35379: Add documentation for @available

2017-07-13 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: docs/LanguageExtensions.rst:1290 -.. _langext-overloading: - erik.pilkington wrote: > did you mean to remove this? I meant to move it above the "protocol-qualifier mangling of parameters" section; I think that's where

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

2017-07-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-memfd_create + `_ check Please sort checks in alphabetical order. Repository

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

2017-07-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-inotify-init + `_ check Please sort checks in alphabetical order. Repository

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

2017-07-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-inotify-init1 + `_ check Please sort checks in alphabetical order. Reposito

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

2017-07-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-epoll-create + `_ check Please sort checks in alphabetical order. Repository

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

2017-07-13 Thread Yan Wang via Phabricator via cfe-commits
yawanng updated this revision to Diff 106515. yawanng marked an inline comment as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecMemfdCreateCheck.cpp clang-tidy/android/CloexecMemfdCreateChe

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

2017-07-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tidy/android/CloexecEpollCreate1Check.cpp:21 + +static constexpr const char *EPOLL_CLOEXEC = "EPOLL_CLOEXEC"; + Please make this declaration consent across all checks. In some checks it declared inside name

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

2017-07-13 Thread Yan Wang via Phabricator via cfe-commits
yawanng updated this revision to Diff 106517. yawanng marked an inline comment as done. https://reviews.llvm.org/D35370 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInitCheck.cpp clang-tidy/android/CloexecInotifyInitChe

  1   2   >