tejohnson added a comment. In https://reviews.llvm.org/D35081#808158, @mehdi_amini wrote:
> Thanks, very clear :) > > I would expect that if we reprocess a GUID we invalidate the previous import > of the same GUID. Right now my impression is that the issue is that ` > ImportList[ExportModulePath][VI.getGUID()]` is indexed on the importing > module. So it'd require for every new import to loop over the ImportList map > and delete the GUID on each inner map. Right, that was the processing I was hoping to avoid. > Alternatively (and likely preferably from a compile-time point of view to > limit the list of import), we could keep a map of GUID->Summary and reuse it > before trying to select a new callee. Yep, that was my third option. I only hesitate because it seems like it might be better to select the prevailing copy when we can, but perhaps it doesn't matter much. https://reviews.llvm.org/D35081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
