[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

graydon created this revision. In change 2ba19793512, the ASTReader logic for ObjC interfaces was modified to preserve the first definition-data read, "merging" later definitions into it rather than overwriting it (though this "merging" is, in practice, a no-op that discards the later definition-d

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

xazax.hun updated this revision to Diff 104358. xazax.hun added a comment. - Removed the whitespace changes - Factored out one more condition https://reviews.llvm.org/D34506 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp ==

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

xazax.hun added a comment. In https://reviews.llvm.org/D34506#792313, @akyrtzi wrote: > I'd prefer to avoid including whitespace-only changes (there are a couple of > lines in the diff with only whitespace change), otherwise LGTM! Great, thank you! If no one has objections I will commit this t

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof marked an inline comment as done. christof added a comment. Sorry for missing the API comments. Thanks for the fix chapuni :-) Repository: rL LLVM https://reviews.llvm.org/D31709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:276 +class DeclarationLocationsFinder : public index::IndexDataConsumer { + std::unique_ptr> DeclarationLocations; + const SourceLocation &SearchedLocation; malaperle-ericsson wrote: > malap

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

xazax.hun updated this revision to Diff 104360. xazax.hun marked 2 inline comments as done. xazax.hun retitled this revision from "[clang-tidy] Enable constexpr definitions in headers. " to "[clang-tidy] Enable inline variable definitions in headers. ". xazax.hun edited the summary of this revisi

r306519 - Fix crash in clang while handling __has_trivial_destructor.

Author: karthik Date: Wed Jun 28 01:52:08 2017 New Revision: 306519 URL: http://llvm.org/viewvc/llvm-project?rev=306519&view=rev Log: Fix crash in clang while handling __has_trivial_destructor. Fix crash in clang when an array of unknown bounds of an incomplete type is passed to __has_trivial_de

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

rogfer01 added a comment. I agree with the spirit of the change but I think you want to use `AArch64::` enumerators instead of those in `ARM::` Comment at: lib/Basic/Targets.cpp:6190 unsigned HasFullFP16; + unsigned ArchKind; There is an `AArch64::ArchKi

[PATCH] D34687: [Tooling] CompilationDatabase should be able to strip position arguments when `-fsyntax-only` is used

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D34687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[clang-tools-extra] r306530 - [clangd] Allow to override resource dir in ClangdServer.

Author: ibiryukov Date: Wed Jun 28 03:34:50 2017 New Revision: 306530 URL: http://llvm.org/viewvc/llvm-project?rev=306530&view=rev Log: [clangd] Allow to override resource dir in ClangdServer. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits Tags: #clan

[PATCH] D34470: [clangd] Allow to override resource dir in ClangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306530: [clangd] Allow to override resource dir in ClangdServer. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D34470 Files: clang-tools-extra/trunk/clangd/ClangdServer.cpp

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

xazax.hun updated this revision to Diff 104379. xazax.hun added a comment. - Unbreak the constexpr test. https://reviews.llvm.org/D34449 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp docs/clang-tidy/checks/misc-definitions-in-headers.rst test/clang-tidy/misc-definitions-in-headers-

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > Do not evaluate numbers. > Check for != "=" is needed not to mess with invalid default arguments or > their types (without it I get "const Bar& bar = =" when Bar is not defined) Shouldn't we than instead check

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

xazax.hun added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1 -// RUN: %check_clang_tidy %s misc-definitions-in-headers %t +// RUN: %check_clang_tidy %s misc-definitions-in-headers %t -- -- -std=c++1z hokein wrote: > hokein wrot

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

puneetha added a comment. This is committed by karthik, at r306519. Thank you. https://reviews.llvm.org/D34198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793573, @klimek wrote: > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > Do not evaluate numbers. > > Check for != "=" is needed not to mess with invalid default arguments or > > their types (without it I get "const Bar& b

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

SjoerdMeijer updated this revision to Diff 104380. SjoerdMeijer added a comment. Thanks! I am now using llvm::AArch64::ArchKind. And I agree that the check for setting __ARM_FEATURE_QRDMX is suspicious. I will address this separately. https://reviews.llvm.org/D34686 Files: lib/Basic/Targets.

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > Do not evaluate numbers. > > > Check for != "=" is needed not to mess with invalid

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good, thanks! Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:1 -// RUN: %check_clang_tidy %s misc-definitions-in-headers %t +// RUN: %check_clang_tidy %s m

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793594, @klimek wrote: > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > > > Do not evalu

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#793601, @yvvan wrote: > In https://reviews.llvm.org/D33644#793594, @klimek wrote: > > > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > > > In https://

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

klimek added a comment. The main thing I'm concerned about is having the main code in core, but having all tests in tools-extra. I think if we go that route we should also move clang-rename and its tests to core. Thoughts? Repository: rL LLVM https://reviews.llvm.org/D34696 _

[clang-tools-extra] r306538 - [clang-tidy] Enable inline variable definitions in headers

Author: xazax Date: Wed Jun 28 05:47:35 2017 New Revision: 306538 URL: http://llvm.org/viewvc/llvm-project?rev=306538&view=rev Log: [clang-tidy] Enable inline variable definitions in headers Differential Revision: https://reviews.llvm.org/D34449 Added: clang-tools-extra/trunk/test/clang-tidy

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306538: [clang-tidy] Enable inline variable definitions in headers (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D34449?vs=104379&id=104389#toc Repository: rL LLVM https://r

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

mharoush updated this revision to Diff 104390. mharoush added a comment. Updated inline asm tests to look for decimal immediate value instead of looking for the original string e.g. 10 vs 0xA and other variations. Also updated the test cases to use check-same etc. Repository: rL LLVM https:/

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush updated this revision to Diff 104391. mharoush marked an inline comment as done. mharoush added a comment. simplified the rewrite condition of complex expressions and eliminated the need to use the ReplaceEnumIdentifier flag. This requires making small adjustments to some of the older t

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104394. johannes added a comment. - remove unused struct - rename getNodeValueI -> getNodeValueImpl https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/AST

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush marked 4 inline comments as done. mharoush added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1382 +if (const MCConstantExpr *CE = +dyn_cast_or_null(Val)) { + StringRef ErrMsg; rnk wrote: > rnk wrot

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104395. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt test/Tooling/clan

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180 +class CE { + constexpr static int i = 5; // OK: constexpr definition. +}; xazax.hun wrote: > hokein wrote: > > hokein wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104401. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt test/Tooling/clan

[PATCH] D34686: [AArch64] ARMV8-A archkind and target defines helper functions

SjoerdMeijer updated this revision to Diff 104393. SjoerdMeijer retitled this revision from "[AArch64] Add hasFP16VectorArithmetic helper function. NFCI" to "[AArch64] ARMV8-A archkind and target defines helper functions". SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a co

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM for when the dependent patches are in. https://reviews.llvm.org/D34721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

ioeric added a comment. In https://reviews.llvm.org/D34696#793613, @klimek wrote: > The main thing I'm concerned about is having the main code in core, but > having all tests in tools-extra. I think if we go that route we should also > move clang-rename and its tests to core. Thoughts? Agreed

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

krasimir created this revision. Herald added a subscriber: klimek. This patch makes the `{` in `msg_field{field: OK}` in a proto option scope be treated as an assignment operator. Previosly the added test case was formatted as: option (MyProto.options) = { field_a: OK field_b{field_c: O

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

krasimir updated this revision to Diff 104410. krasimir added a comment. - Add a msg-style test too https://reviews.llvm.org/D34749 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestProto.cpp Index: unittests/Format/FormatTestProto.cpp ===

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

malaperle-ericsson updated this revision to Diff 104413. malaperle-ericsson added a comment. Remove use of unique_ptr https://reviews.llvm.org/D34269 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/Cl

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. hfinkel

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. gtbercea wrote: > hfinkel wrote: > > Why is this a T

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. hfinkel

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. gtbercea wrote: > hfinkel wrote: > > gtbercea wrote:

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

tejohnson added a comment. In https://reviews.llvm.org/D34728#793131, @timshen wrote: > A question I have is that I don't know how to test this. Ideally we want > -debug-pass-manager from opt, but that flag is not part of the LLVM libraries. How about add a clang test that builds with "-mllvm

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

ilya-biryukov created this revision. https://reviews.llvm.org/D34755 Files: unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp === --- unittests/clangd/ClangdTests.cpp +++ unittests/clangd/ClangdTests.cpp @@

[PATCH] D34749: [clang-format] Fix parsing of msg{field}-style proto options

krasimir added a comment. I think this is ready for a review. https://reviews.llvm.org/D34749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

ilya-biryukov added a comment. I wonder if it's gonna fail on Windows. Maybe enable it only on Linux? https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

ilya-biryukov added a comment. I wonder if it's gonna fail on Windows. Maybe enable it only on Linux? https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + +// TODO: get the compute capability from offloading arguments when not +// using the default compute capability of sm_20. hfinkel wrote: > gtbercea wrote: > > hfinkel wrote:

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r306549 - Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

Author: ibiryukov Date: Wed Jun 28 08:06:34 2017 New Revision: 306549 URL: http://llvm.org/viewvc/llvm-project?rev=306549&view=rev Log: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation. Summary: It used to always call into the RealFileSystem before. Reviewers: bkramer, krasimir, k

[PATCH] D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306549: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D34469 Files: cfe/trunk/include/clang/Frontend/Utils.h

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea updated this revision to Diff 104427. gtbercea added a comment. Herald added subscribers: aheejin, jgravelle-google. Updated diff to address comments. Repository: rL LLVM https://reviews.llvm.org/D29647 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Drive

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:217 + std::vector GPUArchNames; + // If this is an OpenMP action we need to extract the device architecture from + // the -march option. hfin

[PATCH] D16971: [Sema] PR26077 Fixed crash when partial specialization is missing required parameters

hintonda added a comment. ping... https://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306555 - [Bash-autocompletion] Check clang version in Bash

Author: yamaguchi Date: Wed Jun 28 08:59:55 2017 New Revision: 306555 URL: http://llvm.org/viewvc/llvm-project?rev=306555&view=rev Log: [Bash-autocompletion] Check clang version in Bash Summary: Add check if user's clang version supports --autocomplete or not. If not, we just autocomplete files.

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

This revision was automatically updated to reflect the committed changes. Closed by commit rL306555: [Bash-autocompletion] Check clang version in Bash (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34607?vs=103884&id=104435#toc Repository: rL LLVM https://review

[PATCH] D29651: [OpenMP] Consider LIBRARY_PATH when selecting library paths for NVPTX targets in OpenMP mode.

gtbercea abandoned this revision. gtbercea added a comment. Not needed. These changes are related to looking up the .bc library for inlining purposes. I believe @arpith-jacob has already handled this in trunk. Therefore this is obsolete code. Repository: rL LLVM https://reviews.llvm.org/D29

[clang-tools-extra] r306558 - [clangd] Add "Go to Declaration" functionality

Author: malaperle Date: Wed Jun 28 09:12:10 2017 New Revision: 306558 URL: http://llvm.org/viewvc/llvm-project?rev=306558&view=rev Log: [clangd] Add "Go to Declaration" functionality Summary: This change allows to navigate to most identifiers' declarations in code. This is a first step towards i

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington updated this revision to Diff 104437. erik.pilkington added a comment. Improve diagnostics for unnamed types. https://reviews.llvm.org/D33816 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DelayedDiagnostic.h include/clang/Sema/Sema.h lib/Sema/Delay

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

yamaguchi created this revision. When user build clang and used completion Eg. `build/bin/clang -fno[tab]`, we want to invoke `build/bin/clang --autocomplete=-fno`, rather than `clang --autocomplete=-fno`. https://reviews.llvm.org/D34761 Files: clang/utils/bash-autocomplete.sh Index: cla

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

ruiu accepted this revision. ruiu added a comment. LGTM https://reviews.llvm.org/D34761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306559 - [Bash-autocompletion] Invoke clang where user called

Author: yamaguchi Date: Wed Jun 28 09:29:26 2017 New Revision: 306559 URL: http://llvm.org/viewvc/llvm-project?rev=306559&view=rev Log: [Bash-autocompletion] Invoke clang where user called Summary: When user build clang and used completion Eg. `build/bin/clang -fno[tab]`, we want to invoke `buil

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

This revision was automatically updated to reflect the committed changes. Closed by commit rL306559: [Bash-autocompletion] Invoke clang where user called (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34761?vs=104438&id=104439#toc Repository: rL LLVM https://rev

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes -march=sm_35

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. In https://reviews.llvm.org/D34158#792858, @fedor.sergeev wrote: > > I will take a look at the final version tomorrow. Fedor, let me address the comments from Jonas (with another revision!) before you take a look. Repository: rL LLVM https://reviews.llvm.org/D3415

Re: r306127 - [GSoC] Add support for CC1 options.

Thank you for your feedback! For options which have `NoDriverOption` Flags (such as -mrelocation-model), I agree that we should expose these flags to users only when `-cc1` is also passed. However, as to `-mrelocation-model [tab]`, I think it is fine to provide possible values for this option (st

RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

Hahnfeld added a comment. Some comments inline. In general you should consider posting an RFC on cfe-dev because this change will basically affect all compilations on GNU/Linux if the file is present. >> Thank you Adding Richard (general maintainer) and Renato (ARM Linux) so they are aware.

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

djasper added a comment. Just make clang-format always do this. I don't think anyone is relying on the current behavior. https://reviews.llvm.org/D33932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D34741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc updated this revision to Diff 104471. chandlerc added a comment. Update based an Daniel's feedback. https://reviews.llvm.org/D33932 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp Index: unittests/Format/SortIncludesTest.cpp ===

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc added a comment. In https://reviews.llvm.org/D33932#793994, @djasper wrote: > Just make clang-format always do this. I don't think anyone is relying on the > current behavior. Done, PTAL. https://reviews.llvm.org/D33932 ___ cfe-commits

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

vsk added a comment. Do you know which function clang was processing when it crashed? That would help us find a test case. https://reviews.llvm.org/D34680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[libcxx] r306580 - Added failing tests for index out of range for tuple_element> and variant_alternative<>

Author: marshall Date: Wed Jun 28 11:18:30 2017 New Revision: 306580 URL: http://llvm.org/viewvc/llvm-project?rev=306580&view=rev Log: Added failing tests for index out of range for tuple_element> and variant_alternative<> Added: libcxx/trunk/test/std/utilities/utility/pairs/pair.astuple/tu

[libcxx] r306581 - Updated notest on 2974

Author: marshall Date: Wed Jun 28 11:19:34 2017 New Revision: 306581 URL: http://llvm.org/viewvc/llvm-project?rev=306581&view=rev Log: Updated notest on 2974 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes -march=sm_3

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

Anastasia added a comment. Sure, no problem! We might add some note on this feature to Clang manual. But we can do it later as well. Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes -march=sm_35

r306583 - [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

Author: graydon Date: Wed Jun 28 11:36:27 2017 New Revision: 306583 URL: http://llvm.org/viewvc/llvm-project?rev=306583&view=rev Log: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. Summary: In change 2ba19793512, the ASTReader logic for ObjC interfaces was modified to

[PATCH] D34741: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306583: [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. (authored by graydon). Repository: rL LLVM https://reviews.llvm.org/D34741 Files: cfe/trunk/include/clang/AST/Redec

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:614 +/// Check -march propagates compute capability to device offloading toolchain. +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes -march=sm_3

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

Anastasia added a comment. In https://reviews.llvm.org/D34342#792350, @bader wrote: > Note: `get_sampler_initializer` from my test case returns integer, not a > sampler, but having function is not relevant to the problem. > Here is a bit simplified test case without function calls that still

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

hokein added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180 +class CE { + constexpr static int i = 5; // OK: constexpr definition. +}; aaron.ballman wrote: > xazax.hun wrote: > > hokein wrote: > > > hokein wrote: > > > > aaron.b

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi created this revision. Herald added a subscriber: hiraditya. We don't want to autocomplete flags whose Flags class has `NoDriverOption` when argv[1] is not `-cc1`. Another idea for this implementation is to make --autocomplete a cc1 option and handle it in clang Frontend, by porting --

[PATCH] D34771: [clang-tidy] follow-up on misc-definitions-in-header check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. - add `-std=c++11` to `.hpp` file by default. - add constexpr function to test and doc. https://reviews.llvm.org/D34771 Files: docs/clang-tidy/checks/misc-definitions-in-headers.rst test/clang-tidy/check_clang_

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104490. yamaguchi added a comment. Update patch. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h llvm/lib/Option/OptTable.cp

[PATCH] D34449: [clang-tidy] Enable inline variable definitions in headers.

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-definitions-in-headers.hpp:180 +class CE { + constexpr static int i = 5; // OK: constexpr definition. +}; hokein wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > hokein wrote: > > > >

[clang-tools-extra] r306598 - [clangd] Cleanup ClangdUnit.cpp, update docs; NFC

Author: omtcyfz Date: Wed Jun 28 13:57:28 2017 New Revision: 306598 URL: http://llvm.org/viewvc/llvm-project?rev=306598&view=rev Log: [clangd] Cleanup ClangdUnit.cpp, update docs; NFC * Enforce 80 characters limit where appropriate * Use slightly more descriptive names for searched locations * Up

[PATCH] D34777: CodeGen: Fix invalid bitcast for coerced function argument

yaxunl created this revision. Herald added a subscriber: Anastasia. Clang assumes coerced function argument is in address space 0, which is not always true and results in invalid bitcasts. This patch fixes failure in OpenCL conformance test api/get_kernel_arg_info with amdgcn---amdgizcl triple,

[PATCH] D34779: Fix floating point promotions for overload purposes

t.p.northover created this revision. Herald added a subscriber: mcrosier. This has a couple of changes to how Clang determines whether a floating-point promotion has occurred for C++ (and `__attribute__((overloadable))`) purposes. First, I think the special rules for C are based on a misconcepti

Re: r306583 - [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.

Hi Graydon, Can you please add a testcase for this? Thanks, On Wed, Jun 28, 2017 at 11:36 AM, Graydon Hoare via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: graydon > Date: Wed Jun 28 11:36:27 2017 > New Revision: 306583 > > URL: http://llvm.org/viewvc/llvm-project?rev=306583&view

[PATCH] D34771: [clang-tidy] follow-up on misc-definitions-in-header check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

gtbercea updated this revision to Diff 104527. gtbercea added a comment. Split previous diff into a "device offloading kind" patch (show here) and a **new** patch which relies on a new compiler flag. A TODO has been added to signal that the compute capability is to be handled in the **new** pat

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea created this revision. OpenMP has the ability to offload target regions to devices which may have different architectures. A new -fopenmp-target-arch flag is introduced to specify the device architecture. In this patch I use the new flag to specify the compute capability of the under

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea updated this revision to Diff 104532. Repository: rL LLVM https://reviews.llvm.org/D34784 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen updated this revision to Diff 104533. timshen marked 5 inline comments as done. timshen added a comment. Added -fexperimental-new-pass-manager=off/on/debug for printing debug information. Added a Clang test. Do tell if you want me to split this patch. I didn't, becuase then I don't have

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:804-807 + case 0: +return PassBuilder::O0; + case 1: tejohnson wrote: > chandlerc wrote: > > Why is this change needed? > I assume it is just cleanup since this isn't currently c

[clang-tools-extra] r306612 - clangDaemon requires clangLex.

Author: chapuni Date: Wed Jun 28 15:57:15 2017 New Revision: 306612 URL: http://llvm.org/viewvc/llvm-project?rev=306612&view=rev Log: clangDaemon requires clangLex. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt URL: http://ll

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 104535. gtbercea added a comment. [Update regression tests] Add a test for propagating the compute capability to the OpenMP device offloading toolchain which targets NVIDIA GPUs. This is a test for patch D34784 which is ena

  1   2   >