Author: xazax
Date: Fri May 12 01:53:55 2017
New Revision: 302879
URL: http://llvm.org/viewvc/llvm-project?rev=302879&view=rev
Log:
[analyzer] Avoid an allocation in Std C function modelling
Differential Revision: https://reviews.llvm.org/D33095
Modified:
cfe/trunk/lib/StaticAnalyzer/Checker
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302879: [analyzer] Avoid an allocation in Std C function
modelling (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D33095?vs=98610&id=98730#toc
Repository:
rL LLVM
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302880: [analyzer] Add modelling of __builtin_assume
(authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D33092?vs=98609&id=98731#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: xazax
Date: Fri May 12 02:02:54 2017
New Revision: 302880
URL: http://llvm.org/viewvc/llvm-project?rev=302880&view=rev
Log:
[analyzer] Add modelling of __builtin_assume
Differential Revision: https://reviews.llvm.org/D33092
Added:
cfe/trunk/test/Analysis/builtin-assume.c
Modified:
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good, thanks!
https://reviews.llvm.org/D33103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:656-659
+ // If the SVal is a LazyCompoundVal it might only cover sub-region of a given
+ // symbol. For example, the LCV might represent a field in an uninitialized
+ // struct. In this case, the
klimek added inline comments.
Comment at: clangd/ClangdLSPServer.h:23
+
+class ClangdLSPServer {
+ class LSPDiagnosticsConsumer;
ilya-biryukov wrote:
> klimek wrote:
> > I'd have expected something that's called LSP server to work on the LSP
> > protocol level
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.h:23
+
+class ClangdLSPServer {
+ class LSPDiagnosticsConsumer;
klimek wrote:
> ilya-biryukov wrote:
> > klimek wrote:
> > > I'd have expected something that's called LSP server to work on t
ilya-biryukov updated this revision to Diff 98745.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
Addressed new comments
https://reviews.llvm.org/D33047
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
cl
arphaman added a comment.
@jroelofs
We'd be ok with tying the test to a specific SDK and maintaining that tie (e.g.
bumping it upstream).
I was planning to investigate how to make the SDK version checks work, but I
don't have the time ATM. Can I get back to you in a week?
https://reviews.llvm
Author: alexfh
Date: Fri May 12 06:24:25 2017
New Revision: 302889
URL: http://llvm.org/viewvc/llvm-project?rev=302889&view=rev
Log:
Fix an assertion failure (PR33020).
Adding a test separately (tools/extra/test/clang-tidy/misc-use-after-move.cpp).
Modified:
cfe/trunk/lib/AST/DeclCXX.cpp
Mo
Author: alexfh
Date: Fri May 12 06:24:58 2017
New Revision: 302890
URL: http://llvm.org/viewvc/llvm-project?rev=302890&view=rev
Log:
[clang-tidy] Add a test for PR33020
Fix committed in clang as r302889.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-use-after-move.cpp
Modified: cla
aaron.ballman added a comment.
In https://reviews.llvm.org/D32332#751785, @george.burgess.iv wrote:
> I'd be happy with that approach. Do you like it, Aaron?
I think that makes a lot of sense.
> FWIW, I did a bit of archaeology, and it looks like the commit that added the
> requirement that a
Author: mprobst
Date: Fri May 12 08:00:33 2017
New Revision: 302893
URL: http://llvm.org/viewvc/llvm-project?rev=302893&view=rev
Log:
clang-format: [JS] support non-null assertions after all identifiers.
Summary:
Previously:
x = namespace !;
Now:
x = namespace!;
Reviewers: djasper
Subs
bcraig added a comment.
> I noticed that the Windows STL headers have to do this dance with `new` (even
> though they do `(foo)(...)` for `min` and `max`). If we're going to need
> to guard against a bunch of macros I would like to use a single approach.
> Other than updating the `#if defined(
Author: kparzysz
Date: Fri May 12 08:18:07 2017
New Revision: 302895
URL: http://llvm.org/viewvc/llvm-project?rev=302895&view=rev
Log:
[Hexagon] Make sure to pass empty struct arguments with nontrivial ctors
Thanks to Richard Smith for the suggested fix.
This fixes llvm.org/PR33009
Modified:
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Comment at: lib/Sema/SemaDecl.cpp:10286
+ // these variables must be a compile time constant.
+ VDecl->getType().getAddressSpace() == LangAS::opencl_constant)
CheckForConstantInitializ
erikjv marked 8 inline comments as done.
erikjv added a comment.
Fixed with the next patch.
https://reviews.llvm.org/D15994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erikjv updated this revision to Diff 98757.
https://reviews.llvm.org/D15994
Files:
include/clang/Lex/Preprocessor.h
include/clang/Lex/PreprocessorLexer.h
include/clang/Lex/PreprocessorOptions.h
include/clang/Serialization/ASTBitCodes.h
lib/Frontend/ASTUnit.cpp
lib/Lex/Lexer.cpp
lib/
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
---
Anastasia added a comment.
In https://reviews.llvm.org/D27334#751921, @echuraev wrote:
> So, I think that we have to do some decision about this patch. @Anastasia,
> What do you think about it? Please see my comment above. What should we do
> with this patch?
I am still not convinced adding t
Author: aaronballman
Date: Fri May 12 09:30:49 2017
New Revision: 302901
URL: http://llvm.org/viewvc/llvm-project?rev=302901&view=rev
Log:
Enabling the /bigobj flag for SemaDeclAttr.cpp.
This resolves compile errors with MSVC 2015 x64 debug builds where
SemaDeclAttr.cpp is hitting the section sy
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:16020
+// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID.
+#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t))
bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);
--
gtbercea updated this revision to Diff 98766.
gtbercea added a comment.
Address comments.
Repository:
rL LLVM
https://reviews.llvm.org/D29654
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChains/CommonArgs.h
lib/Dri
jroelofs added a comment.
Sure. That'd be needed whether they stay, or get moved to test-suite.
https://reviews.llvm.org/D32178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson created this revision.
Herald added subscribers: eraman, mehdi_amini.
Clang changes to remove this option and replace with a parameter
always set in the context of a ThinLTO distributed backend.
Depends on https://reviews.llvm.org/D33133.
https://reviews.llvm.org/D33134
Files:
lib/
Author: jyknight
Date: Fri May 12 11:01:23 2017
New Revision: 302913
URL: http://llvm.org/viewvc/llvm-project?rev=302913&view=rev
Log:
[SPARC] Support 'f' and 'e' inline asm constraints.
Patch by Patrick Boettcher.
Differential Revision: https://reviews.llvm.org/D29117
Added:
cfe/trunk/test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302913: [SPARC] Support 'f' and 'e' inline asm constraints.
(authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D29117?vs=85708&id=98782#toc
Repository:
rL LLVM
https://reviews
Lekensteyn updated this revision to Diff 98781.
Lekensteyn edited the summary of this revision.
Lekensteyn added a comment.
v2: Minor updates (fixed comment: `// ...` to `/// https://reviews.llvm.org/D33093
Files:
include/clang/ASTMatchers/Dynamic/Parser.h
include/clang/ASTMatchers/Dynamic/V
Lekensteyn created this revision.
Needed to support something like "floatLiteral(equals(1.0))". The
parser for floating point numbers is kept simple, so instead of ".1" you
have to use "0.1".
https://reviews.llvm.org/D33135
Files:
include/clang/ASTMatchers/Dynamic/Diagnostics.h
include/clan
sdardis updated this revision to Diff 98783.
sdardis marked an inline comment as done.
sdardis edited the summary of this revision.
sdardis added a comment.
Updated error message for logical operations where one operand is a vector and
the other isn't.
Updated summary.
I'll commit this shortly.
Author: adrian
Date: Fri May 12 11:23:53 2017
New Revision: 302915
URL: http://llvm.org/viewvc/llvm-project?rev=302915&view=rev
Log:
Simplify DINamespace caching in CGDebugInfo
This addresses review feedback from r302840.
By not canonicalizing namespace decls and using lexical decl context
inste
> On May 11, 2017, at 5:05 PM, Adrian Prantl via cfe-commits
> wrote:
>
>>
>> On May 11, 2017, at 4:43 PM, Richard Smith wrote:
>>
>> I don't think that's quite right; the AST doesn't merge NamespaceDecls. It
>> looks like the issue is that we're mapping to the semantic DeclContext
>> (whi
Author: arphaman
Date: Fri May 12 11:32:26 2017
New Revision: 302918
URL: http://llvm.org/viewvc/llvm-project?rev=302918&view=rev
Log:
[index] Index template specialization arguments for function templats
Also ensure that class template specialization arguments are covered
rdar://31812032
Modif
vsk added a comment.
Ping.
https://reviews.llvm.org/D32842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
Bump :)
https://reviews.llvm.org/D32046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:25
///:= true | false
+/// := 1.0 | 2e-3 | 3.45e67
/// := [0-9]+
It'd be good to list the actual grammar rather than a few examples.
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri May 12 13:56:03 2017
New Revision: 302932
URL: http://llvm.org/viewvc/llvm-project?rev=302932&view=rev
Log:
[modules] Simplify module macro handling in non-local-submodule-visibility mode.
When reaching the end of a module, we used to convert its macros to
ModuleMacros bu
Author: hokein
Date: Fri May 12 14:01:02 2017
New Revision: 302934
URL: http://llvm.org/viewvc/llvm-project?rev=302934&view=rev
Log:
[include-fixer] Don't throw exception when parsing unknown arguments in
vim script.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/run-f
Author: sdardis
Date: Fri May 12 14:11:06 2017
New Revision: 302935
URL: http://llvm.org/viewvc/llvm-project?rev=302935&view=rev
Log:
[Sema] Support implicit scalar to vector conversions
This patch teaches clang to perform implicit scalar to vector conversions
when one of the operands of a binary
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302935: [Sema] Support implicit scalar to vector conversions
(authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D25866?vs=98783&id=98815#toc
Repository:
rL LLVM
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302940: Remove ignore-empty-index-file option (authored by
tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D33134?vs=98779&id=98821#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33
Author: tejohnson
Date: Fri May 12 14:32:17 2017
New Revision: 302940
URL: http://llvm.org/viewvc/llvm-project?rev=302940&view=rev
Log:
Remove ignore-empty-index-file option
Summary:
Clang changes to remove this option and replace with a parameter
always set in the context of a ThinLTO distribute
On 11 May 2017 at 21:14, Richard Smith wrote:
> Thanks for the revert, fixed up and recommitted in r302817.
>
> Any idea why not a single buildbot sent me any email about this? :( (A
> couple of them were red at the previous change too, but some of them were
> not (eg. clang-cmake-armv7-a15).
Hm,
Author: sdardis
Date: Fri May 12 14:55:32 2017
New Revision: 302941
URL: http://llvm.org/viewvc/llvm-project?rev=302941&view=rev
Log:
[Sema] Silence buildbot failures introduced by r302935
Attempt to silence buildbot failures by pinning the test to a given
triple rather than the host's triple.
On 12 May 2017 at 20:46, Diana Picus wrote:
> On 11 May 2017 at 21:14, Richard Smith wrote:
>> Thanks for the revert, fixed up and recommitted in r302817.
>>
>> Any idea why not a single buildbot sent me any email about this? :( (A
>> couple of them were red at the previous change too, but some o
On Fri, May 12, 2017 at 9:01 PM, Haojian Wu via cfe-commits
wrote:
> Author: hokein
> Date: Fri May 12 14:01:02 2017
> New Revision: 302934
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302934&view=rev
> Log:
> [include-fixer] Don't throw exception when parsing unknown arguments in
> vim script
Author: caseycarter
Date: Fri May 12 15:33:41 2017
New Revision: 302945
URL: http://llvm.org/viewvc/llvm-project?rev=302945&view=rev
Log:
[test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 2/3.
This C++17 Core Language feature isn't necessary when testing std::byte.
It's a
Author: caseycarter
Date: Fri May 12 15:33:46 2017
New Revision: 302946
URL: http://llvm.org/viewvc/llvm-project?rev=302946&view=rev
Log:
[test] Add specific test for P0138R2, direct-list-init of fixed enums from
integers, part 3/3.
Test the C++17 Core Language feature independently from other s
Author: caseycarter
Date: Fri May 12 15:33:32 2017
New Revision: 302944
URL: http://llvm.org/viewvc/llvm-project?rev=302944&view=rev
Log:
[test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 1/3.
This C++17 Core Language feature isn't necessary when testing std::byte.
It's a
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10286
+ // these variables must be a compile time constant.
+ VDecl->getType().getAddressSpace() == LangAS::opencl_constant)
CheckForConstantInitializer(Init, DclT);
Anasta
Author: rsmith
Date: Fri May 12 15:42:54 2017
New Revision: 302947
URL: http://llvm.org/viewvc/llvm-project?rev=302947&view=rev
Log:
Revert r302932, as it appears to be breaking stage2 for some of our
modules-enabled buildbots.
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/tru
On 12 May 2017 at 13:24, Renato Golin wrote:
> On 12 May 2017 at 20:46, Diana Picus wrote:
> > On 11 May 2017 at 21:14, Richard Smith wrote:
> >> Thanks for the revert, fixed up and recommitted in r302817.
> >>
> >> Any idea why not a single buildbot sent me any email about this? :( (A
> >> cou
I will look at this.
Thanks
Galina
On Fri, May 12, 2017 at 2:00 PM, Richard Smith
wrote:
> On 12 May 2017 at 13:24, Renato Golin wrote:
>
>> On 12 May 2017 at 20:46, Diana Picus wrote:
>> > On 11 May 2017 at 21:14, Richard Smith wrote:
>> >> Thanks for the revert, fixed up and recommitted i
Hi Richard,
I think this broke modules.
If I try to compile a simple test program (@import Foundation;) I get the
following error:
./bin/clang test.m -fmodules -c -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
While building module 'F
On 12 May 2017 at 14:19, Juergen Ributzka wrote:
> Hi Richard,
>
> I think this broke modules.
>
> If I try to compile a simple test program (@import Foundation;) I get the
> following error:
> ./bin/clang test.m -fmodules -c -isysroot /Applications/Xcode.app/
> Contents/Developer/Platforms/MacOS
spyffe marked 2 inline comments as done.
spyffe added inline comments.
Comment at: tools/clang-import-test/clang-import-test.cpp:263
+AddExternalSource(*CI, Imports);
+ }
bruno wrote:
> No need for the curly braces here
Okay.
https://reviews.llvm.org/D32
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D31383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri May 12 18:27:00 2017
New Revision: 302965
URL: http://llvm.org/viewvc/llvm-project?rev=302965&view=rev
Log:
[modules] When creating a declaration, cache its owning module immediately
rather than waiting until it's queried.
Currently this is only applied to local submodule
Author: rsmith
Date: Fri May 12 18:40:52 2017
New Revision: 302966
URL: http://llvm.org/viewvc/llvm-project?rev=302966&view=rev
Log:
Remove unused tracking of owning module for MacroInfo objects.
Modified:
cfe/trunk/include/clang/Lex/MacroInfo.h
cfe/trunk/include/clang/Lex/Preprocessor.h
cynecx added a comment.
Gentle ping.
Repository:
rL LLVM
https://reviews.llvm.org/D25051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri May 12 19:00:16 2017
New Revision: 302969
URL: http://llvm.org/viewvc/llvm-project?rev=302969&view=rev
Log:
Add LangOptions method to query whether we are tracking the owning module for a
local declaration.
In preparation for expanding this behavior to cover additional c
Hello everyone,
LLVM buildmaster and LLVM lab will be unavailable tomorrow Saturday May 13
for about 4 hours (hopefully less) starting 10 AM Pacific time due to
network works.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-
Author: spyffe
Date: Fri May 12 19:46:33 2017
New Revision: 302975
URL: http://llvm.org/viewvc/llvm-project?rev=302975&view=rev
Log:
[ASTImporter] Improve handling of incomplete types
ASTImporter has some bugs when it's importing types
that themselves come from an ExternalASTSource. This
is exp
stringham updated this revision to Diff 98873.
https://reviews.llvm.org/D33029
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
unittests/Fo
Author: ahatanak
Date: Fri May 12 22:14:49 2017
New Revision: 302978
URL: http://llvm.org/viewvc/llvm-project?rev=302978&view=rev
Log:
[libcxxabi] Align unwindHeader on a double-word boundary.
r276215 made a change to annotate _Unwind_Exception with attribute
"aligned" so that an exception object
djasper added a comment.
Probably all of the examples from the original patch description and later
comments should be turned into unit tests.
Comment at: docs/ClangFormatStyleOptions.rst:953
+**DanglingParenthesis** (``bool``)
+ If there is a break after the opening parent
Author: ahatanak
Date: Sat May 13 01:28:17 2017
New Revision: 302981
URL: http://llvm.org/viewvc/llvm-project?rev=302981&view=rev
Log:
[libcxxabi] Do not align field unwindHeader when building for ARM EHABI.
For ARM EHABI, _Unwind_Exception is an alias of _Unwind_Control_Block,
which is not align
69 matches
Mail list logo
