djasper added a comment.
Probably all of the examples from the original patch description and later
comments should be turned into unit tests.
================
Comment at: docs/ClangFormatStyleOptions.rst:953
+**DanglingParenthesis** (``bool``)
+ If there is a break after the opening parenthesis, also break before the
closing parenthesis
----------------
Have you auto-generated this with docs/tools/dump_format_style.py? There seem
to be subtle differences.
================
Comment at: include/clang/Format/Format.h:793
+ /// \endcode
+ bool DanglingParenthesis;
+
----------------
I don't think this is a name that anyone will intuitively understand. I
understand that the naming is hard here. One thing I am wondering is whether
this might ever make sense unless AlignAfterOpenBracket is set to AlwaysBreak?
Unless that option is set, we could have both in the same file:
someFunction(aaaa,
bbbb);
and
someFunction(
aaaa, bbbb
);
Is that intended, i.e. are you actively using that? Answering this is
important, because it influence whether or not we actually need to add another
style option and even how to implement this.
================
Comment at: lib/Format/TokenAnnotator.cpp:2655
- if (Right.is(tok::r_paren) || Right.is(TT_TemplateCloser))
+ if (Right.is(tok::r_paren)) {
+ return Style.DanglingParenthesis;
----------------
No braces
https://reviews.llvm.org/D33029
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
