Hi,
This commit gives a warning with clang 3.6:
In file included from
../tools/clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:17:
../tools/clang/lib/StaticAnalyzer/Checkers/SelectorExtras.h:23:40:
error: braces around scalar initializer [-Werror]
SmallVector II{{&Ctx.Idents
On 05/10/2017 09:37 AM, Mikael Holmén via cfe-commits wrote:
Hi,
This commit gives a warning with clang 3.6:
In file included from
../tools/clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:17:
../tools/clang/lib/StaticAnalyzer/Checkers/SelectorExtras.h:23:40:
error: braces aro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302624: Add ASTMatchRefactorer and ReplaceNodeWithTemplate
to RefactoringCallbacks (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29621?vs=98203&id=98412#toc
Repository:
rL
Author: ioeric
Date: Wed May 10 02:48:45 2017
New Revision: 302624
URL: http://llvm.org/viewvc/llvm-project?rev=302624&view=rev
Log:
Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks
Summary: This is the first change as part of developing a clang-query based
search and r
Author: ericwf
Date: Wed May 10 03:04:50 2017
New Revision: 302627
URL: http://llvm.org/viewvc/llvm-project?rev=302627&view=rev
Log:
Attempt to speculatively unbreak Apple build bots
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
h
Author: ericwf
Date: Wed May 10 03:15:40 2017
New Revision: 302629
URL: http://llvm.org/viewvc/llvm-project?rev=302629&view=rev
Log:
Fix use of removed SH test replacement %exec
Modified:
libcxxabi/trunk/test/incomplete_type.sh.cpp
Modified: libcxxabi/trunk/test/incomplete_type.sh.cpp
URL:
echuraev updated this revision to Diff 98416.
https://reviews.llvm.org/D32898
Files:
lib/Sema/SemaInit.cpp
test/SemaOpenCL/array-init.cl
Index: test/SemaOpenCL/array-init.cl
===
--- /dev/null
+++ test/SemaOpenCL/array-init.cl
@
alexfh added a comment.
In https://reviews.llvm.org/D30748#750626, @idlecode wrote:
> Oh, sorry about this - I forgot. I will send patch during this weekend
No worries, I just stumbled upon the bug and recalled that there had been a
patch to fix it.
https://reviews.llvm.org/D30748
___
EricWF created this revision.
This patch fixes bugs.llvm.org/PR32979.
[util.smartptr.shared.const] says:
> In the constructor definitions below, enables shared_from_this with p, for a
> pointer p of type Y*, means
> that if Y has an unambiguous and accessible base class that is a
> specializa
zizhar added a comment.
Ping
https://reviews.llvm.org/D31383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
This is fantastic, thanks! I really like the shape of how it turned out to work.
Minor stuff and we're landing :)
Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:651
+ProgramStateRef ProgramState::addTaint(SVal V,
+
This revision was automatically updated to reflect the committed changes.
arphaman marked 2 inline comments as done.
Closed by commit rL302632: [index] Index simple dependent declaration
references (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D32972?vs=98184&id=9842
Author: arphaman
Date: Wed May 10 04:47:41 2017
New Revision: 302632
URL: http://llvm.org/viewvc/llvm-project?rev=302632&view=rev
Log:
[index] Index simple dependent declaration references
This commit implements basic support for indexing of dependent declaration
references. Now the indexer tries
Author: echuraev
Date: Wed May 10 03:23:01 2017
New Revision: 302630
URL: http://llvm.org/viewvc/llvm-project?rev=302630&view=rev
Log:
[OpenCL] Added checking OpenCL version for cl_khr_mipmap_image built-ins
Reviewers: Anastasia, cfe-commits
Reviewed By: Anastasia
Subscribers: bader, yaxunl
Di
Author: xazax
Date: Wed May 10 06:16:55 2017
New Revision: 302637
URL: http://llvm.org/viewvc/llvm-project?rev=302637&view=rev
Log:
[clang-tidy] Add new cert-dcl21-cpp check
This check flags postfix operator++/-- declarations,
where the return type is not a const object.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302637: [clang-tidy] Add new cert-dcl21-cpp check (authored
by xazax).
Changed prior to commit:
https://reviews.llvm.org/D32743?vs=98179&id=98426#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Author: echuraev
Date: Wed May 10 05:28:34 2017
New Revision: 302633
URL: http://llvm.org/viewvc/llvm-project?rev=302633&view=rev
Log:
[OpenCL] Handle OpenCL specific subelement types
Reviewers: Anastasia, cfe-commits
Reviewed By: Anastasia
Subscribers: bader, yaxunl
Differential Revision: htt
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: lib/AST/ASTImporter.cpp:1757
D2->setAnonymousStructOrUnion(true);
+if (PrevDecl) {
+ D2->setPreviousDecl(PrevDecl);
chenwj added a comment.
In https://reviews.llvm.org/D32759#748916, @efriedma wrote:
> In https://reviews.llvm.org/D32759#748653, @chenwj wrote:
>
> > In https://reviews.llvm.org/D32759#748007, @efriedma wrote:
> >
> > > The difference between returning true and false here is just the way
> > > e
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mclow.lists added a comment.
In general, I prefer having the space between `static_assert(` and the
condition.
That makes it easy (at least for me) to see if there's a `!` there or not.
Other than that, this LGTM.
FWIW, I think this is a language change that core got wrong, and it has already
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D33006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10286
+ // these variables must be a compile time constant.
+ VDecl->getType().getAddressSpace() == LangAS::opencl_constant)
CheckForConstantInitial
a.sidorin updated this revision to Diff 98441.
a.sidorin added a reviewer: karkhaz.
a.sidorin added a comment.
Address review comments; add the context.
https://reviews.llvm.org/D32751
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/namespace/Inputs/namespace1.cpp
test/ASTMerge/namespace/Inp
Author: serge_sans_paille
Date: Wed May 10 08:22:11 2017
New Revision: 302654
URL: http://llvm.org/viewvc/llvm-project?rev=302654&view=rev
Log:
Use clang++-3.5 compatible initializer_list constructor
Otherwise, a warning is issued.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/SelectorExtr
v.g.vassilev updated this revision to Diff 98445.
v.g.vassilev marked 2 inline comments as done.
v.g.vassilev added a comment.
Reduce the amount of calls to AddLazySpecializations. Remove assert.
In order to create a reasonable test I need to use
`-error-on-deserialized-decl` and I hit a bug:
h
Author: mprobst
Date: Wed May 10 08:53:29 2017
New Revision: 302658
URL: http://llvm.org/viewvc/llvm-project?rev=302658&view=rev
Log:
clang-format: refine calculating brace types.
Summary:
For C++ code, opening parenthesis following a } indicate a braced init. For
JavaScript and other languages,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302658: clang-format: refine calculating brace types.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D33006?vs=98309&id=98448#toc
Repository:
rL LLVM
https://reviews.llvm.o
xazax.hun accepted this revision.
xazax.hun added a reviewer: szepet.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM! Adding Peter as a reviewer, as he is more experienced with the
ASTImporter than me.
https://reviews.llvm.org/D32751
Author: petarj
Date: Wed May 10 09:28:18 2017
New Revision: 302670
URL: http://llvm.org/viewvc/llvm-project?rev=302670&view=rev
Log:
Reland: [mips] Impose a threshold for coercion of aggregates
Modified MipsABIInfo::classifyArgumentType so that it now coerces
aggregate structures only if
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM! A couple of comments below:
Comment at: lib/Sema/SemaExprCXX.cpp:4725
+if (!rhsRecord || !lhsRecord) {
+ const ObjCObjectType *lhsObjTy = LhsT->getAs();
+
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Will submit for you since you don't have an svn account.
https://reviews.llvm.org/D33020
___
cfe-commits mailing list
cfe-commits@lists.llvm.
nik created this revision.
Herald added a subscriber: klimek.
A suspended translation unit uses significantly less memory but on the other
side does not support any other calls than clang_reparseTranslationUnit to
resume it or clang_disposeTranslationUnit to dispose it completely.
This helps IDEs
nik updated this revision to Diff 98461.
https://reviews.llvm.org/D33042
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang
yaxunl updated this revision to Diff 98463.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Use getStorageDuration to decide how to emit a function-scope variable.
https://reviews.llvm.org/D32977
Files:
include/clang/AST/Decl.h
lib/CodeGen/CGDecl.cpp
lib/Sema/SemaDecl.cpp
Author: akirtzidis
Date: Wed May 10 10:10:36 2017
New Revision: 302677
URL: http://llvm.org/viewvc/llvm-project?rev=302677&view=rev
Log:
[libclang] Introduce clang_Cursor_isExternalSymbol that provides info about
decls marked with external_source_symbol attribute
Modified:
cfe/trunk/include/
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
This looks good to me, thanks. Sorry about the slow turnaround. Do you have
commit access? If not, I can land it for you – but it also looks like you've
contributed several patches by now, so
efriedma added a comment.
A testcase would be nice... but otherwise, yes.
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
In https://reviews.llvm.org/D32759#751026, @efriedma wrote:
> A testcase would be nice... but otherwise, yes.
Do you have a suggestion on how to write one? I wasn't able to find any
situation that changed behavior with the different return values.
https://reviews
efriedma added a comment.
The testcase I wrote should change behavior, I think.
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Hmm, looks like libclang/libclangTests/LibclangReparseTest.ReparseWithModule is
flaky?
FAIL: Clang-Unit ::
libclang/libclangTests/LibclangReparseTest.ReparseWithModule (10699 of 10701)
- TEST 'Clang-Unit ::
libclang/libclangTests/LibclangReparseTest.ReparseWithModule' FAI
erichkeane added a comment.
In https://reviews.llvm.org/D32759#751028, @efriedma wrote:
> The testcase I wrote should change behavior, I think.
Alright, I'll look into it again...
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-c
kparzysz added a comment.
In https://reviews.llvm.org/D31885#748889, @rjmccall wrote:
> Sounds to me like we should just not apply struct-path TBAA data that runs
> through a union field because either LLVM's representation can't handle it or
> Clang isn't generating the representation right.
Author: akirtzidis
Date: Wed May 10 10:48:16 2017
New Revision: 302682
URL: http://llvm.org/viewvc/llvm-project?rev=302682&view=rev
Log:
[libclang] Fix typo in doc-comment, NFC
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
http://llvm.org/viewv
thegameg added a comment.
In https://reviews.llvm.org/D26953#751021, @thakis wrote:
> This looks good to me, thanks. Sorry about the slow turnaround. Do you have
> commit access? If not, I can land it for you – but it also looks like you've
> contributed several patches by now, so you could als
kparzysz added a comment.
I'm not intimately familiar with clang, so if you know about a better place for
doing this, please let me know.
Repository:
rL LLVM
https://reviews.llvm.org/D31885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On 10 May 2017 at 16:10, Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: akirtzidis
> Date: Wed May 10 10:10:36 2017
> New Revision: 302677
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302677&view=rev
> Log:
> [libclang] Introduce clang_Cursor_isExternalSymbol
Author: adrian
Date: Wed May 10 10:58:22 2017
New Revision: 302685
URL: http://llvm.org/viewvc/llvm-project?rev=302685&view=rev
Log:
Build the Apple-style stage2 with full debug info
Green dragon had a green stage2 modules bot for a long time now[1] and
it is time to retire it and make a modules
erik.pilkington created this revision.
This patch adds lit testing support for Objective-C++. I'm going to be working
on improving Objective-C++ support in libc++ this summer, and it would be nice
to write tests. I tested this patch on Ubuntu 16.04 with gcc 5.4, and it works
fine (the .mm tests
Author: phosek
Date: Wed May 10 11:20:54 2017
New Revision: 302688
URL: http://llvm.org/viewvc/llvm-project?rev=302688&view=rev
Log:
[clang-tidy][CMake] Make clang-tidy usable as distribution component
Use add_clang_tool rather than add_clang_executable to support
clang-tidy as a distribution com
Author: arphaman
Date: Wed May 10 11:21:00 2017
New Revision: 302689
URL: http://llvm.org/viewvc/llvm-project?rev=302689&view=rev
Log:
[AST] RecursiveASTVisitor should not crash on lambdas with type attributes
rdar://31960860
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302688: [clang-tidy][CMake] Make clang-tidy usable as
distribution component (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D32815?vs=97683&id=98479#toc
Repository:
rL LLVM
BillyONeal added a comment.
In https://reviews.llvm.org/D33021#750831, @mclow.lists wrote:
> FWIW, I think this is a language change that core got wrong, and it has
> already come back to bite us. (https://bugs.llvm.org/show_bug.cgi?id=28527)
Hmm we actually took steps to do the opposite i
That’s a good idea, if you don’t get to it I’ll look into it at some point
later on but it will probably not be soon.
> On May 10, 2017, at 9:10 AM, Alex L wrote:
>
>
>
> On 10 May 2017 at 16:10, Argyrios Kyrtzidis via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: akirtz
rjmccall added a comment.
The right fix is probably just to make sure that EmitLValueForField doesn't add
TBAA information when the base LValue doesn't have it. That will also fix
problems with recursive member access where the base is may_alias.
Repository:
rL LLVM
https://reviews.llvm.or
BillyONeal added a comment.
In https://reviews.llvm.org/D33021#751145, @BillyONeal wrote:
> Hmm we actually took steps to do the opposite in std::copy -- to use
> memcpy even in the presence of volatile -- as a result of this change.
;) http://imgur.com/a/PMKPS
https://reviews.llvm.org/D
mehdi_amini added a comment.
Something still isn't clear to me: the issue IIUC is not with the
`unwindHeader` itself, but with the misaligned thrown object that is allocated
right after the __cxa_exception itself. Isn't it?
Then are you aligning the `unwindHeader` field and by side-effect the s
jtony created this revision.
The vec_xxpermdi builtin is missing from altivec.h. This has been requested by
developers working on libvpx for VP9 support for Google. Initially, I tried to
define a new intrinsic to map it to the corresponding PowerPC hard instruction
(XXPERMDI) directly. But the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302695: [Sema] Objective-C++ support for type trait
__is_base_of (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D32891?vs=97905&id=98490#toc
Repository:
rL LLVM
https://revie
Author: epilk
Date: Wed May 10 12:18:56 2017
New Revision: 302695
URL: http://llvm.org/viewvc/llvm-project?rev=302695&view=rev
Log:
[Sema] Objective-C++ support for type trait __is_base_of
rdar://24308607
Differential revision: https://reviews.llvm.org/D32891
Added:
cfe/trunk/test/SemaObjCX
Hello everyone,
I'm about to set up a new builder which would build LLVM and Clang with
gcc-6 and -DLLVM_ENABLE_WERROR=ON.
Please find the staged builder connected to the silent master. Currently it
shows 14 warnings we would need to resolve before we could promote the
builder to the production.
stringham added a comment.
1. be used in a project of significant size (have dozens of contributors)
- We are using this at Lucid Software (https://www.lucidchart.com &
https://www.lucidpress.com) to format our JS and TS (we are using clang-format
to automatically style over 650,000 lines of c
Author: ericwf
Date: Wed May 10 12:52:53 2017
New Revision: 302698
URL: http://llvm.org/viewvc/llvm-project?rev=302698&view=rev
Log:
Fix use of now removed %exec test substitution
Modified:
libcxxabi/trunk/test/native/arm-linux-eabi/ttype-encoding-00.pass.sh.s
libcxxabi/trunk/test/native/
erichkeane updated this revision to Diff 98495.
erichkeane added a reviewer: eli.friedman.
erichkeane added a comment.
Added a test, found a slight difference in behavior!
https://reviews.llvm.org/D32759
Files:
lib/Sema/SemaType.cpp
test/SemaObjC/method-bad-param.m
Index: lib/Sema/SemaTyp
spyffe updated this revision to Diff 98497.
spyffe added a comment.
• Added a FIXME per Aleksei Sidorin's suggestion.
https://reviews.llvm.org/D32981
Files:
include/clang/AST/ExternalASTMerger.h
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
lib/AST/ExternalASTMerger.cpp
spyffe marked an inline comment as done.
spyffe added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1757
D2->setAnonymousStructOrUnion(true);
+if (PrevDecl) {
+ D2->setPreviousDecl(PrevDecl);
a.sidorin wrote:
> By the way, should we do the
rjmccall added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7291
+ Address adjustAddrSpaceForAutoVar(Address A, const VarDecl *VD,
+ CodeGen::CodeGenFunction &CGF) const override;
};
How about, instead of introducing a second method, we just cha
aaron.ballman added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:583
+// Non-transparent overloadable functions need mangling.
+if (auto *A = FD->getAttr())
+ if (!A->isTransparent())
`const auto *`
Comment at: lib/AST/Mi
efriedma added a comment.
Our behavior for your testcase is less than ideal (we should be generating an
invalid declaration instead of just dropping it on the floor), but that's not
something you need to fix here.
Could you also include the Objective-C++ testcase I wrote? Or does it not work
Author: caseycarter
Date: Wed May 10 14:10:49 2017
New Revision: 302707
URL: http://llvm.org/viewvc/llvm-project?rev=302707&view=rev
Log:
[test] support machinery changes for EDG & C1XX /Za
This change works around a couple of bugs:
1. EDG doesn't like explicit constexpr in a derived class. This
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302707: [test] support machinery changes for EDG & C1XX /Za
(authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D32778?vs=97530&id=98503#toc
Repository:
rL LLVM
https://revi
erichkeane added a comment.
In https://reviews.llvm.org/D32759#751339, @efriedma wrote:
> Our behavior for your testcase is less than ideal (we should be generating an
> invalid declaration instead of just dropping it on the floor), but that's not
> something you need to fix here.
>
> Could you
efriedma added a comment.
Err, I meant the one I wrote earlier in this thread:
https://reviews.llvm.org/D32759#748007
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
rjmccall added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:158
+ // variable in constant address space in OpenCL.
+ if (D.getStorageDuration() != SD_Automatic && !D.hasExternalStorage()) {
llvm::GlobalValue::LinkageTypes Linkage =
Please rearrange
erichkeane added a comment.
In https://reviews.llvm.org/D32759#751350, @efriedma wrote:
> Err, I meant the one I wrote earlier in this thread:
> https://reviews.llvm.org/D32759#748007
AH! I missed that one. I'll create a new file in SemaObjCXX then.
https://reviews.llvm.org/D32759
__
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10286
+ // these variables must be a compile time constant.
+ VDecl->getType().getAddressSpace() == LangAS::opencl_constant)
CheckForConstantInitial
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. The bots are already failing because I upgraded their compilers.
@BillyONeal Can you commit this soon so I can clean up any fallout?
https://reviews.llvm.org/D33021
_
erichkeane updated this revision to Diff 98504.
https://reviews.llvm.org/D32759
Files:
lib/Sema/SemaType.cpp
test/SemaObjC/method-bad-param.m
test/SemaObjCXX/method-bad-param.mm
Index: lib/Sema/SemaType.cpp
===
--- lib/Sema/S
mprobst added a comment.
So, currently clang-format doesn't really understand trailing commas in
parenthesized lists (such as parameter declarations or lists). It should, and
coincidentally I was just yesterday trying to get that working in
https://reviews.llvm.org/D33023.
Regarding the option
Author: ericwf
Date: Wed May 10 14:35:49 2017
New Revision: 302709
URL: http://llvm.org/viewvc/llvm-project?rev=302709&view=rev
Log:
[libc++] Fix PR32979 - types with a private std::enable_shared_from_this base
break shared_ptr
Summary:
This patch fixes bugs.llvm.org/PR32979.
[util.smartptr.sh
BillyONeal updated this revision to Diff 98506.
BillyONeal added a comment.
Added spaces requested by Marshal.
https://reviews.llvm.org/D33021
Files:
test/std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_copyable.pass.cpp
Index:
test/std/utilities/meta/meta.unary/meta.unary.prop
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302710: Update is_trivially_copyable tests with CWG 2094
(authored by bion).
Changed prior to commit:
https://reviews.llvm.org/D33021?vs=98506&id=98508#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: bion
Date: Wed May 10 14:43:31 2017
New Revision: 302710
URL: http://llvm.org/viewvc/llvm-project?rev=302710&view=rev
Log:
Update is_trivially_copyable tests with CWG 2094
Clang 5.0 implements these changes here:
https://github.com/llvm-mirror/clang/commit/87cd035326a39523eeb1b295ad36cff
stringham added a comment.
I think we should have the option whether or not a trailing comma is preset for
a few reasons:
1. clang-format doesn't support enforcing adding trailing commas
2. trailing commas aren't always supported (if you use the rest operator)
- `Uncaught SyntaxError: Rest par
yaxunl updated this revision to Diff 98510.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D32977
Files:
include/clang/AST/Decl.h
lib/CodeGen/CGDecl.cpp
lib/Sema/SemaDecl.cpp
test/CodeGenOpenCL/amdgpu-debug-info-poin
Author: ericwf
Date: Wed May 10 14:55:42 2017
New Revision: 302713
URL: http://llvm.org/viewvc/llvm-project?rev=302713&view=rev
Log:
Clean up LIT failure output by not showing the entire environment
Modified:
libcxx/trunk/utils/libcxx/test/executor.py
Modified: libcxx/trunk/utils/libcxx/test
stringham added a comment.
If the parameter list fits within the column limit, and there are no trailing
commas, then we don't end up wrapping the closing paren.
If it is long enough that it causes wrapping (regardless of trailing commas),
and the wrapping happens directly after the opening par
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
efriedma added a comment.
Err, oh, meant to add one minor comment: please rename "method-bad-param.mm" to
"interface-return-type.mm".
https://reviews.llvm.org/D32759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
alexshap created this revision.
alexshap created this object with visibility "All Users".
1. Add missing "explicit" for single argument constructors
2. Add missing std::move in ReplaceNodeWithTemplate constructor
and switch to pass-by-value idiom
Test plan:
make check-clang
Repository:
rL LL
Author: erichkeane
Date: Wed May 10 15:03:16 2017
New Revision: 302720
URL: http://llvm.org/viewvc/llvm-project?rev=302720&view=rev
Log:
Fix errored return value in CheckFunctionReturnType and add a fixit hint
As discovered by ChenWJ and listed on cfe-dev, the error for Objective C
return type e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302720: Fix errored return value in CheckFunctionReturnType
and add a fixit hint (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D32759?vs=98504&id=98516#toc
Repository:
r
Author: ericwf
Date: Wed May 10 15:09:20 2017
New Revision: 302721
URL: http://llvm.org/viewvc/llvm-project?rev=302721&view=rev
Log:
Fix enable_shared_from_this test in C++11
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.enab/enable_shared_from_this.pass.cpp
M
ddcc added a comment.
In https://reviews.llvm.org/D28952#750558, @iris wrote:
> How can I make z3constraintmanager.cpp work in the command line?Or how to
> make z3 work?
You'll need a bleeding-edge build of Clang/LLVM, since this isn't available in
any stable release yet. First, build or inst
Author: ericwf
Date: Wed May 10 15:19:35 2017
New Revision: 302723
URL: http://llvm.org/viewvc/llvm-project?rev=302723&view=rev
Log:
XFAIL is_trivially_copyable test for compilers that don't implement Core 2094
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_triv
EricWF updated this revision to Diff 98528.
EricWF added a comment.
- General cleanup changes.
Libc++ trunk currently doesn't build under MinGW, so I'm not concerned about
breaking that worse with this patch. I've set up a Appveyor builder to track
MinGW so we can get it green later.
Also I'm
Author: ericwf
Date: Wed May 10 15:37:43 2017
New Revision: 302724
URL: http://llvm.org/viewvc/llvm-project?rev=302724&view=rev
Log:
Implement LWG 2591 - Patch from K-Ballo
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.targ/target.pass.cpp
bcraig added a comment.
LGTM
https://reviews.llvm.org/D32988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
@compnerd I'm going to go ahead and land this and then submit a separate review
for the changes you've requested. I hope you don't mind :-)
https://reviews.llvm.org/D32988
___
cfe-commits maili
Author: ericwf
Date: Wed May 10 15:57:45 2017
New Revision: 302727
URL: http://llvm.org/viewvc/llvm-project?rev=302727&view=rev
Log:
[libc++] Refactor Windows support headers.
Summary:
This patch refactors and tries to remove as much of the Windows support headers
as possible. This is needed bec
1 - 100 of 150 matches
Mail list logo
