thegameg added a comment.

In https://reviews.llvm.org/D26953#751021, @thakis wrote:

> This looks good to me, thanks. Sorry about the slow turnaround. Do you have 
> commit access? If not, I can land it for you – but it also looks like you've 
> contributed several patches by now, so you could also ask for commit access 
> if you don't have it yet.


Thank you for the review. As @gnzlbg pointed out here (PR28867) 
<https://bugs.llvm.org/show_bug.cgi?id=28867>, I tested with 
`AllowShortIfStatementsOnASingleLine` and it does not seem to work as intended. 
I didn't have time to fix that yet, so I'll probably delay this for now. If 
anyone has time, feel free to fix + land this instead of me.


https://reviews.llvm.org/D26953



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D26953: cla... Nico Weber via Phabricator via cfe-commits
    • [PATCH] D26953... Francis Visoiu Mistrih via Phabricator via cfe-commits

Reply via email to