[PATCH] D32696: More detailed docs for UsingShadowDecl

kimgr created this revision. I couldn't make sense of the docs before, so I sent a question to cfe-dev. Richard was gracious enough to fill in the blanks: http://lists.llvm.org/pipermail/cfe-dev/2017-April/053687.html I've tried to transfer some of his response to the Doxygen for UsingShadowDecl

[PATCH] D32700: [clang-tidy] Add misc-suspicious-memset-usage check.

rnkovacs created this revision. Herald added a subscriber: mgorny. This check finds memset calls with potential mistakes in their arguments. Cases covered: - Fill value is a character '0'. Integer 0 might have been intended. - Fill value is out of character range and gets truncated. - The destina

[PATCH] D31646: [coroutines] Build GRO declaration and return GRO statement

GorNishanov added a comment. Traditional weekly ping https://reviews.llvm.org/D31646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

GorNishanov added a comment. Weakly (sp) ping https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r301796 - The -coverage-file flag was removed in r280306, and this piece was missed; NFC.

Author: aaronballman Date: Mon May 1 08:05:04 2017 New Revision: 301796 URL: http://llvm.org/viewvc/llvm-project?rev=301796&view=rev Log: The -coverage-file flag was removed in r280306, and this piece was missed; NFC. Modified: cfe/trunk/lib/Driver/Job.cpp Modified: cfe/trunk/lib/Driver/Job

[PATCH] D32181: Remove use of coverage-file flag

aaron.ballman abandoned this revision. aaron.ballman added a comment. I've commit in r301796. Rather than accept my own review and then close it, I am marking it as abandoned. https://reviews.llvm.org/D32181 ___ cfe-commits mailing list cfe-commits

Hashing the clang resource path

I think we may have stumbled across a bug with CIndexer::getClangResourcesPath(), where on POSIX-y systems it uses dladdr() to get the path of the shared object. It seems that on some systems (in our case, OS X 10.6.8), dladdr() does not return a canonicalized path. We're getting a path like PATH/T

Re: r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

I relaxed the testcase to allow for the extra import in r301805. The extra import is for the anonymous namespace that I added to the testcase, which is the intended behavior on the PS4 platform (DebugExplicitImport). -- adrian > On Apr 28, 2017, at 9:37 PM, Yung, Douglas wrote: > > Hi Adrian,

r301805 - Relax testcase to fix a PS4 buildbot failure.

Author: adrian Date: Mon May 1 10:49:40 2017 New Revision: 301805 URL: http://llvm.org/viewvc/llvm-project?rev=301805&view=rev Log: Relax testcase to fix a PS4 buildbot failure. Modified: cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-names

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added a comment. This revision now requires changes to proceed. Ping https://reviews.llvm.org/D30268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

NoQ created this revision. It seems that we're not capitalizing every word in our bug type descriptions, however `Memory Error` is an exception from this rule. Additionally, one of the nullability checkers actually does spell it as `Memory error`. So i guess it's better to keep everything consi

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

kuhar updated this revision to Diff 97299. kuhar edited the summary of this revision. kuhar added a comment. I went ahead and generalized the patch to support custom tuple-like types and custom make_ functions. I added a bunch of tests and updated the docs. Let me know what you think. https://

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

a.sidorin added a comment. Hi Artem. It is a good point but I think we should have a literal for this instead. https://reviews.llvm.org/D32702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D32702: [analyzer] Fix 'Memory Error' bugtype capitalization.

zaks.anna accepted this revision. zaks.anna added a comment. Thanks! https://reviews.llvm.org/D32702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r301815 - Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC

Author: sanjoy Date: Mon May 1 12:08:00 2017 New Revision: 301815 URL: http://llvm.org/viewvc/llvm-project?rev=301815&view=rev Log: Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp cfe/trunk/lib/CodeGen/CGObjCMac.cpp cfe/trunk/lib/

[PATCH] D32700: [clang-tidy] Add misc-suspicious-memset-usage check.

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/misc-suspicious-memset-usage.rst:6 + +This check finds memset calls with potential mistakes in their arguments. +Considering the functi

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

Richard, et al., Any feedback on my comments below on what C/C++ allows? I'd like to just be missing something ;) Thanks again, Hal On 04/21/2017 06:03 AM, Hal Finkel via Phabricator wrote: ... Our struct-path TBAA does the following: struct X { int a, b; }; X x { 50, 100 }; X *

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Fri, Apr 21, 2017 at 4:03 AM, Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added a comment. > > In https://reviews.llvm.org/D32199#732737, @rsmith wrote: > > > In https://reviews.llvm.org/D32199#732189, @hfinkel wrote: > > > > > In https://reviews.llvm.org/D32199#7314

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

crash-vfs-ivfsoverlay.m does not work http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1322/steps/check-clang%20asan/logs/stdio On Fri, Apr 28, 2017 at 6:51 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Apr 28 20:38:29

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington updated this revision to Diff 97313. erik.pilkington added a comment. Rebase n' ping! https://reviews.llvm.org/D30837 Files: include/memory test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp test/std/utilities/memory/ut

r301822 - Improve handling of arrays of unknown bound in constant expressions.

Author: rsmith Date: Mon May 1 13:49:04 2017 New Revision: 301822 URL: http://llvm.org/viewvc/llvm-project?rev=301822&view=rev Log: Improve handling of arrays of unknown bound in constant expressions. Do not spuriously reject constexpr functions that access elements of an array of unknown bound;

[PATCH] D32372: Arrays of unknown bound in constant expressions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Committed as r301822. Comment at: lib/AST/ExprConstant.cpp:1301 void addUnsizedArray(EvalInfo &Info, QualType ElemTy) { - assert(Designator.Entries.empty() && getTy

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

Looks like this test has found a bug in the compiler. I've not repro'd it yet but my guess is that we're hitting an asan error while attempting to build the preprocessed source. We can temporarily disable this test to get the bot green again if you like. Have you noticed it failing for non-asan'd b

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On 05/01/2017 12:49 PM, Daniel Berlin wrote: On Fri, Apr 21, 2017 at 4:03 AM, Hal Finkel via Phabricator mailto:revi...@reviews.llvm.org>> wrote: hfinkel added a comment. In https://reviews.llvm.org/D32199#732737 , @rsmith wrote: > I

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 12:16 PM, Hal Finkel wrote: > > On 05/01/2017 12:49 PM, Daniel Berlin wrote: > > > > On Fri, Apr 21, 2017 at 4:03 AM, Hal Finkel via Phabricator < > revi...@reviews.llvm.org> wrote: > >> hfinkel added a comment. >> >> In https://reviews.llvm.org/D32199#732737, @rsmith wrote

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

> > >> >> > So you believe that you can index into an object randomly by pointer > arithmetic and pull out a different field? > > For starters, this is illegal because you don't know where the padding > bytes are. > You cannot assume that X.a + 1 == X.b > "Implementation alignment requirements mig

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 97331. gtbercea added a comment. Change output of unbundler to produce cubin files when using OpenMP to offload to NVIDIA GPUs. Repository: rL LLVM https://reviews.llvm.org/D29654 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains/Clang.cpp lib/D

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. @rnk any further thought on the changes to this patch? Thanks :) Repository: rL LLVM https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On 5/1/2017 2:16 PM, Hal Finkel via cfe-commits wrote: On 05/01/2017 12:49 PM, Daniel Berlin wrote: On 04/21/2017 06:03 AM, Hal Finkel via Phabricator wrote: ... Our struct-path TBAA does the following: struct X { int a, b; }; X x { 50, 100 }; X *o = (X*) (((int*) &x) +

r301824 - [sanitizer-coverage] add a deprecation note to coverage_direct=1

Author: kcc Date: Mon May 1 14:52:01 2017 New Revision: 301824 URL: http://llvm.org/viewvc/llvm-project?rev=301824&view=rev Log: [sanitizer-coverage] add a deprecation note to coverage_direct=1 Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

We should file a bug and disable the test. Red bots are inconvenient for build cop. I have not notice this on non-asan builds, but I didn't look. On Mon, May 1, 2017 at 12:14 PM Richard Smith wrote: > Looks like this test has found a bug in the compiler. I've not repro'd it > yet but my guess is

r301825 - Silence unused variable warning. NFC.

Author: d0k Date: Mon May 1 15:00:23 2017 New Revision: 301825 URL: http://llvm.org/viewvc/llvm-project?rev=301825&view=rev Log: Silence unused variable warning. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On 05/01/2017 02:31 PM, Daniel Berlin wrote: So you believe that you can index into an object randomly by pointer arithmetic and pull out a different field? For starters, this is illegal because you don't know where the padding bytes are. You cannot assume that X.a + 1

Fwd: Missing comma diagnostics patch

FYI: Seems like my confirmation string was expired. -- Forwarded message -- From: Zaid Alkhishman Date: Sat, Apr 29, 2017 at 11:44 PM Subject: Missing comma diagnostics patch To: cfe-commits@lists.llvm.org Hello, This patch adds missing comma diagnostics to initializer lists.

r301832 - Object: Remove ModuleSummaryIndexObjectFile class.

Author: pcc Date: Mon May 1 15:42:32 2017 New Revision: 301832 URL: http://llvm.org/viewvc/llvm-project?rev=301832&view=rev Log: Object: Remove ModuleSummaryIndexObjectFile class. Differential Revision: https://reviews.llvm.org/D32195 Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modifie

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin wrote: > So you believe that you can index into an object randomly by pointer >>> arithmetic and pull out a different field? >>> >> >> For starters, this is illegal because you don't know where the padding >> bytes are. >> You cannot assume that X.a

[clang-tools-extra] r301836 - Reorder release notes, fix missing link and a grammar issue.

Author: xazax Date: Mon May 1 16:02:38 2017 New Revision: 301836 URL: http://llvm.org/viewvc/llvm-project?rev=301836&view=rev Log: Reorder release notes, fix missing link and a grammar issue. Patch by Réka Nikolett Kovács! Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv added a comment. ping :) https://reviews.llvm.org/D32332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

thakis added inline comments. Comment at: test/Sema/warn-missing-braces.c:21 + +#endif This looks shorter than the test I pasted on the bug. Does it get the corner case right that my patch on that bug didn't get right? https://reviews.llvm.org/D32646 __

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

eugenis closed this revision. eugenis added a comment. r301225 Repository: rL LLVM https://reviews.llvm.org/D32064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

aaron.ballman added a comment. The attribute is not used anywhere; the initial utility should be part of the patch introducing the attribute, unless that utility makes the patch very large. Comment at: lib/Sema/SemaDeclAttr.cpp:1522-1523 + QualType T = cast(D)->getType(); +

[PATCH] D32332: Add support for transparent overloadable functions in clang

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. I'm adding Richard to the review because he may have opinions on this functionality. Is there a reason we want the second spelling instead of making the current spelling behave in the manner you describe? While the change is

r301840 - Put back REQUIRES: system-darwin to fix asan bot.

Author: rsmith Date: Mon May 1 16:49:54 2017 New Revision: 301840 URL: http://llvm.org/viewvc/llvm-project?rev=301840&view=rev Log: Put back REQUIRES: system-darwin to fix asan bot. These tests do not appear to be Darwin-specific, and this REQUIRES: appears to be hiding a real bug; this change i

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: > On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin wrote: > >> So you believe that you can index into an object randomly by pointer arithmetic and pull out a different field? >>> >>> For starters, this is illegal because you don't know w

r301846 - Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas.

Author: rsmith Date: Mon May 1 17:10:47 2017 New Revision: 301846 URL: http://llvm.org/viewvc/llvm-project?rev=301846&view=rev Log: Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas. If a file has no diagnostic pragmas, we build its diagnostic state lazily, bu

r301847 - New file missed from r301846.

Author: rsmith Date: Mon May 1 17:11:08 2017 New Revision: 301847 URL: http://llvm.org/viewvc/llvm-project?rev=301847&view=rev Log: New file missed from r301846. Added: cfe/trunk/test/Modules/Inputs/diag_flags.h Added: cfe/trunk/test/Modules/Inputs/diag_flags.h URL: http://llvm.org/viewvc/

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 3:09 PM, Daniel Berlin wrote: > > > On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: > >> On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin >> wrote: >> >>> So you believe that you can index into an object randomly by pointer > arithmetic and pull out a different field?

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 6:40 PM, Daniel Berlin wrote: > On Mon, May 1, 2017 at 3:09 PM, Daniel Berlin wrote: > >> On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: >> >>> On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin >>> wrote: >>> So you believe that you can index into an object randomly

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 3:58 PM, John McCall wrote: > On Mon, May 1, 2017 at 6:40 PM, Daniel Berlin wrote: > >> On Mon, May 1, 2017 at 3:09 PM, Daniel Berlin >> wrote: >> >>> On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: >>> On Mon, May 1, 2017 at 3:31 PM, Daniel Berlin wrote: >

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv added a comment. thanks for the feedback! fwiw, at a high level, the main problem i'm trying to solve with this is that you can't really make a `__overloadable_without_mangling` macro without handing it the function name, since you currently need to use `__asm__("name-you'd-l

Re: Hashing the clang resource path

> On May 1, 2017, at 7:51 AM, Aaron Ballman wrote: > > I think we may have stumbled across a bug with > CIndexer::getClangResourcesPath(), where on POSIX-y systems it uses > dladdr() to get the path of the shared object. It seems that on some > systems (in our case, OS X 10.6.8), dladdr() does n

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On 05/01/2017 02:35 PM, Krzysztof Parzyszek via cfe-commits wrote: On 5/1/2017 2:16 PM, Hal Finkel via cfe-commits wrote: On 05/01/2017 12:49 PM, Daniel Berlin wrote: On 04/21/2017 06:03 AM, Hal Finkel via Phabricator wrote: ... Our struct-path TBAA does the following: struct X {

[libcxx] r301861 - Creating release directory for release_401.

Author: tstellar Date: Mon May 1 18:01:02 2017 New Revision: 301861 URL: http://llvm.org/viewvc/llvm-project?rev=301861&view=rev Log: Creating release directory for release_401. Added: libcxx/tags/RELEASE_401/ ___ cfe-commits mailing list cfe-comm

[libcxxabi] r301863 - Creating release directory for release_401.

Author: tstellar Date: Mon May 1 18:01:05 2017 New Revision: 301863 URL: http://llvm.org/viewvc/llvm-project?rev=301863&view=rev Log: Creating release directory for release_401. Added: libcxxabi/tags/RELEASE_401/ ___ cfe-commits mailing list cfe-c

[libcxx] r301862 - Creating release candidate rc1 from release_401 branch

Author: tstellar Date: Mon May 1 18:01:04 2017 New Revision: 301862 URL: http://llvm.org/viewvc/llvm-project?rev=301862&view=rev Log: Creating release candidate rc1 from release_401 branch Added: libcxx/tags/RELEASE_401/rc1/ (props changed) - copied from r301861, libcxx/branches/rele

[libunwind] r301875 - Creating release directory for release_401.

Author: tstellar Date: Mon May 1 18:01:21 2017 New Revision: 301875 URL: http://llvm.org/viewvc/llvm-project?rev=301875&view=rev Log: Creating release directory for release_401. Added: libunwind/tags/RELEASE_401/ ___ cfe-commits mailing list cfe-c

[libcxxabi] r301864 - Creating release candidate rc1 from release_401 branch

Author: tstellar Date: Mon May 1 18:01:07 2017 New Revision: 301864 URL: http://llvm.org/viewvc/llvm-project?rev=301864&view=rev Log: Creating release candidate rc1 from release_401 branch Added: libcxxabi/tags/RELEASE_401/rc1/ (props changed) - copied from r301863, libcxxabi/branche

[libunwind] r301876 - Creating release candidate rc1 from release_401 branch

Author: tstellar Date: Mon May 1 18:01:23 2017 New Revision: 301876 URL: http://llvm.org/viewvc/llvm-project?rev=301876&view=rev Log: Creating release candidate rc1 from release_401 branch Added: libunwind/tags/RELEASE_401/rc1/ (props changed) - copied from r301875, libunwind/branche

[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

vsk created this revision. When building with implicit modules it's possible to hit a scenario where modules are built without -fsanitize=address, and are subsequently imported into CUs with -fsanitize=address enabled. This can cause strange failures at runtime. One case I've seen affects libcxx,

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

CaseyCarter updated this revision to Diff 97366. CaseyCarter added a comment. Fix a missing indent in the `msvc_stdlib_force_include.hpp` change. https://reviews.llvm.org/D32385 Files: include/optional test/libcxx/utilities/optional/optional.object/special_member_gen.pass.cpp test/std/ut

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

CaseyCarter updated this revision to Diff 97367. CaseyCarter added a comment. Fix missing indent in msvc_stdlib_force_include.hpp https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilities/variant/variant.variant/variant

[PATCH] D32726: [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER.

STL_MSFT created this revision. [libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set TEST_STD_VER. _HAS_CXX17 indicates whether MSVC's STL is in C++17 mode. https://reviews.llvm.org/D32726 Files: test/support/msvc_stdlib_force_include.hpp Index: test/support/msvc_stdlib

[PATCH] D32727: [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated".

STL_MSFT created this revision. [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated". In C++17, these iterators are allowed but not required to inherit from the deprecated std::iterator base class. https://reviews.llvm.org/D32727 Files: test/std/ite

r301888 - [sanitizer-coverage] update the SanitizerCoverage docs to reflect the current state

Author: kcc Date: Mon May 1 19:32:57 2017 New Revision: 301888 URL: http://llvm.org/viewvc/llvm-project?rev=301888&view=rev Log: [sanitizer-coverage] update the SanitizerCoverage docs to reflect the current state Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/Sanit

r301891 - Revert r301785 (and r301787) because they caused PR32864.

Author: nicholas Date: Mon May 1 20:06:16 2017 New Revision: 301891 URL: http://llvm.org/viewvc/llvm-project?rev=301891&view=rev Log: Revert r301785 (and r301787) because they caused PR32864. The fix is that ExprEvaluatorBase::VisitInitListExpr should handle transparent exprs instead of exprs w

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On Mon, May 1, 2017 at 7:06 PM, Daniel Berlin wrote: > On Mon, May 1, 2017 at 3:58 PM, John McCall wrote: > >> On Mon, May 1, 2017 at 6:40 PM, Daniel Berlin >> wrote: >> >>> On Mon, May 1, 2017 at 3:09 PM, Daniel Berlin >>> wrote: >>> On Mon, May 1, 2017 at 2:07 PM, John McCall wrote: >>

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim updated this revision to Diff 97385. brenoguim marked an inline comment as done. brenoguim added a comment. Never flag predefinedExpr() types. https://reviews.llvm.org/D31130 Files: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp test/clang-tidy/Inputs/cppcoreg

r301898 - clang/test/Modules/diag-flags.cpp: Appease targeting *-win32 with explicit triple. Fixes r301846.

Author: chapuni Date: Tue May 2 00:12:55 2017 New Revision: 301898 URL: http://llvm.org/viewvc/llvm-project?rev=301898&view=rev Log: clang/test/Modules/diag-flags.cpp: Appease targeting *-win32 with explicit triple. Fixes r301846. MicrosoftRecordLayoutBuilder doesn't have ability of -Wpadded.

Re: r301846 - Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas.

It didn't pass for targeting *-win32, since MicrosoftRecordLayoutBuilder doesn't have ability of -Wpadded. Tweaked in r301898. I guess other diag would be available here but I have no good idea. On Tue, May 2, 2017 at 7:23 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > A

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added a comment. I agree with Aaron, it would be nice if this had some immediate effect. One obvious suggestion: take advantage of it in code generation. LLVM already has a parameter attribute called "nocapture" which conveys exactly the right semantics for noescape pointers and refe

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

jtbandes created this revision. Herald added a subscriber: klimek. This converts the clang-format option `AlignEscapedNewlinesLeft` from a boolean to an enum, named `AlignEscapedNewlines`, with options `Left` (prev. `true`), `Right` (prev. `false`), and a new option `DontAlign`. When set to `Do

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97398. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Fixed spaces and changed SpellingLoc from two lines to one line. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/S

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi added inline comments. Comment at: lib/Sema/SemaInit.cpp:875 if (!VerifyOnly) { StructuredSubobjectInitList->setType(T); ruiu wrote: > Is it intentional that you run the new code only when !VerifyOnly? I think VerifyOnly is used to check if it

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:523 + if (C.NewlinesBefore > 0 && C.ContinuesPPDirective) +C.EscapedNewlineColumn = C.PreviousEndOfTokenColumn + 2; +return; I think we should not duplicate this loop. Tw

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

jtbandes added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:523 + if (C.NewlinesBefore > 0 && C.ContinuesPPDirective) +C.EscapedNewlineColumn = C.PreviousEndOfTokenColumn + 2; +return; djasper wrote: > I think we should not dupli