CaseyCarter updated this revision to Diff 97217.
CaseyCarter added a comment.
Update libc++-specific special member test for extended P0602 implementation.
https://reviews.llvm.org/D32385
Files:
include/optional
test/libcxx/utilities/optional/optional.object/special_member_gen.pass.cpp
t
CaseyCarter added inline comments.
Comment at: test/std/numerics/numeric.ops/numeric.ops.lcm/lcm.pass.cpp:144
+auto res1 = std::lcm(static_cast(1234), INT32_MIN);
+(void)std::lcm(INT_MIN, 2UL); // this used to trigger UBSAN
+static_assert(std::is_same::value, "")
kuhar created this revision.
kuhar added a project: clang-tools-extra.
Conform to llvm naming convention for local variables in modernize-use-emplace
check.
https://reviews.llvm.org/D32678
Files:
clang-tidy/modernize/UseEmplaceCheck.cpp
Index: clang-tidy/modernize/UseEmplaceCheck.cpp
=
v.g.vassilev added a comment.
LGTM, modulo the comment.
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+SemaRef.getSourceManager().isInSystemHeader(SpellingLoc
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D31495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
v.g.vassilev added a comment.
@teemperor, is this ok with you?
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi marked 2 inline comments as done.
yamaguchi added inline comments.
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+SemaRef.getSourceManager().isInSyste
Prazek accepted this revision.
Prazek added a comment.
This revision is now accepted and ready to land.
Lgtm
https://reviews.llvm.org/D32678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
v.g.vassilev added a comment.
I am not very familiar with this code here. This seems a reasonable fix to me.
Unless @rsmith and @ahatanak have objections, please go ahead and land it some
time next week.
Repository:
rL LLVM
https://reviews.llvm.org/D25051
v.g.vassilev added inline comments.
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) {
yamaguchi added inline comments.
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) {
v.
yamaguchi added inline comments.
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) {
ya
yamaguchi updated this revision to Diff 97224.
yamaguchi added a comment.
@v.g.vassilev
I don't think early return is good idea, because someone might want to add some
code under this function in the future.
https://reviews.llvm.org/D32646
Files:
lib/Sema/SemaInit.cpp
test/Sema/warn-missi
v.g.vassilev added a comment.
I don't think we should worry about that. Please also see:
http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
https://reviews.llvm.org/D32646
___
cfe-commits mailing list
cfe-commit
yamaguchi updated this revision to Diff 97227.
yamaguchi marked 5 inline comments as done.
yamaguchi added a comment.
Changed to early return.
https://reviews.llvm.org/D32646
Files:
lib/Sema/SemaInit.cpp
test/Sema/warn-missing-braces.c
Index: test/Sema/warn-missing-braces.c
==
v.g.vassilev added a comment.
Did you incorporate the comment from here:
https://bugs.llvm.org/show_bug.cgi?id=24007#c2
https://reviews.llvm.org/D32646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
yamaguchi updated this revision to Diff 97228.
yamaguchi added a comment.
Add check if there is -Wmissing-braces enabled or not.
https://reviews.llvm.org/D32646
Files:
lib/Sema/SemaInit.cpp
test/Sema/warn-missing-braces.c
Index: test/Sema/warn-missing-braces.c
ruiu added inline comments.
Comment at: lib/Sema/SemaInit.cpp:875
if (!VerifyOnly) {
StructuredSubobjectInitList->setType(T);
Is it intentional that you run the new code only when !VerifyOnly?
Comment at: lib/Sema/SemaInit.cpp:890-891
ruiu added inline comments.
Comment at: lib/Sema/SemaInit.cpp:897
+SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))
+ return;
SemaRef.Diag(StructuredSubobjectInitList->getLocStart(),
Please use clang-format to format your cod
Hello,
This patch adds missing comma diagnostics to initializer lists.
I'm attaching
the .diff (git),
an input .c
and the compilation output .out
Let me know if there are any required changes.
Regards,
Zaid
zaid.al.khish...@gmail.com
(Note, I tried subscribing to cfe-commits but it said the
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D32678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301780: [clang-tidy] Fix naming convention in
modernize-use-emplace (authored by kuhar).
Changed prior to commit:
https://reviews.llvm.org/D32678?vs=97221&id=97243#toc
Repository:
rL LLVM
https://re
Author: kuhar
Date: Sun Apr 30 16:12:56 2017
New Revision: 301780
URL: http://llvm.org/viewvc/llvm-project?rev=301780&view=rev
Log:
[clang-tidy] Fix naming convention in modernize-use-emplace
Summary: Conform to the llvm naming convention for local variables in
modernize-use-emplace check.
Revi
kuhar created this revision.
kuhar added a project: clang-tools-extra.
This patch makes modernize-use-emplace remove unnecessary make_tuple calls from
push_back calls and turn them into emplace_back -- the same way make_pair calls
are handled.
Eq.
std::vector> v;
v.push_back(std::make_tupl
kuhar updated this revision to Diff 97248.
kuhar added a comment.
Cosmetic changes.
https://reviews.llvm.org/D32690
Files:
clang-tidy/modernize/UseEmplaceCheck.cpp
docs/ReleaseNotes.rst
test/clang-tidy/modernize-use-emplace.cpp
Index: test/clang-tidy/modernize-use-emplace.cpp
===
JonasToth added a comment.
Nothing to complain from my side.
Would it make sense to add boost pairs/tuples support?
I could imagine modernize checks that would transform boost structures into
the stl ones, but that's another discussion probably.
Something for a later check: the same logic shoul
kuhar added a comment.
In https://reviews.llvm.org/D32690#741952, @JonasToth wrote:
> Would it make sense to add boost pairs/tuples support?
I think it can be added the same way it is possible to specify smart pointers
and vector-like containers now. It would require users to provide both type
Author: compnerd
Date: Sun Apr 30 19:26:59 2017
New Revision: 301783
URL: http://llvm.org/viewvc/llvm-project?rev=301783&view=rev
Log:
utils: Silence -Wpedantic warning
llvm/tools/clang/utils/TableGen/ClangAttrEmitter.cpp:1673:67: warning: default
argument specified for lambda parameter [-Wpedan
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks. Could you also add something like:
struct A {};
struct B : virtual A {};
constexpr A &a = (A&)*(B*)0;
to test/SemaCXX/constant-expression-cxx11.cpp to ensure we produce a suitabl
nlewycky updated this revision to Diff 97253.
nlewycky added a comment.
Use an RAII object to always evaluate the arguments, except if
HandleFunctionCall does it.
https://reviews.llvm.org/D31839
Files:
lib/AST/ExprConstant.cpp
test/Sema/integer-overflow.c
Index: test/Sema/integer-overflo
Author: nicholas
Date: Sun Apr 30 21:03:23 2017
New Revision: 301785
URL: http://llvm.org/viewvc/llvm-project?rev=301785&view=rev
Log:
Handle expressions with non-literal types like ignored expressions if we are
supposed to continue evaluating them.
Also fix a crash casting a derived nullptr to
Author: dblaikie
Date: Sun Apr 30 21:11:39 2017
New Revision: 301786
URL: http://llvm.org/viewvc/llvm-project?rev=301786&view=rev
Log:
Fix line endings (dos -> unix) and clang-format while I'm here
Modified:
cfe/trunk/test/SemaCXX/cxx1z-lambda-star-this.cpp
Modified: cfe/trunk/test/SemaCXX/c
Author: nicholas
Date: Sun Apr 30 21:20:06 2017
New Revision: 301787
URL: http://llvm.org/viewvc/llvm-project?rev=301787&view=rev
Log:
Fix test that was incorrected merged between patches.
Modified:
cfe/trunk/test/Sema/integer-overflow.c
Modified: cfe/trunk/test/Sema/integer-overflow.c
URL:
hubert.reinterpretcast added a comment.
Has it been discussed whether this is something to be addressed in the
optimizer as opposed to the front-end?
Comment at: lib/CodeGen/CGExprScalar.cpp:3069
+ !isa(RHS)) {
+// Based on comparisons of pointers to dynamic o
Author: sanjoy
Date: Mon May 1 01:12:13 2017
New Revision: 301789
URL: http://llvm.org/viewvc/llvm-project?rev=301789&view=rev
Log:
Remove unneeded struct; NFC
Summary:
Unless I'm missing something, the DeferredGlobal struct's GV field is
unused, removing which makes the struct itself trivial.
35 matches
Mail list logo
