v.g.vassilev added a comment.
LGTM, modulo the comment.
================
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+ SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) {
----------------
I'd avoid double negations. Could you use `isInvalid` instead of `!isValid`.
That would make the condition more readable.
https://reviews.llvm.org/D32646
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
