Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini wrote: > What would be the status of these buildbots? Is it for your private usage? > I intend for them to be public Windows buildbots for libc++. Otherwise having “project' bots” using a non-official mirror may sound like > a strange situation to m

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

jfb added a comment. Is it a goal to support Microsoft's STL with this? If so, how does MSVC's STL implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't seem to have anything ? Presumably they'll have to do *something*. https://reviews.llvm.org/D3

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

EricWF added a comment. In https://reviews.llvm.org/D32265#731709, @jfb wrote: > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's STL > implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't seem to > have anything ? Presumab

[PATCH] D31975: [Analyzer] Iterator Checkers

baloghadamsoftware added a comment. Hello! I am not sure how to split it to incremental patches. As I mentioned in the description, the state of the iterator position is always tracked. So if I remove some of the checks it does not make the patch much smaller, since the checking part is quite s

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM unless Alexey still has objections Repository: rL LLVM https://reviews.llvm.org/D29904 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

r300825 - PR19260: Teach doxygen to spell correctly the include paths.

Author: vvassilev Date: Thu Apr 20 03:57:41 2017 New Revision: 300825 URL: http://llvm.org/viewvc/llvm-project?rev=300825&view=rev Log: PR19260: Teach doxygen to spell correctly the include paths. Currently we have #include in the doxygen page documenting Sema. The patch changes it ot #include "

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev added a comment. Landed in r300825. Maybe we should do something like that for LLVM documentation, too. https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM with one small note Comment at: lib/Driver/Driver.cpp:564 + auto &CudaTC = + ToolChains[TT.str() + "/" + HostTC->getTriple().normalize(

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:337 + const Expr *BlockBytes, + ProgramStateRef State); static ProgramStateRef CallocMem(CheckerContext &C, cons

Re: Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

@Sylvestre Thanks! After getting the permissions setup libc++ now has a new Windows builder! https://ci.appveyor.com/project/EricWF/libcxx /Eric On Thu, Apr 20, 2017 at 2:30 AM, Sylvestre Ledru wrote: > > > > On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier e...@efcs.ca>> wrote: > > > > Hi

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:337 + const Expr *BlockBytes, + ProgramStateRef State); static ProgramStateRef CallocMem(CheckerContext &C, const Call

r300826 - Add #pragma clang attribute support to the availability attribute

Author: arphaman Date: Thu Apr 20 04:35:02 2017 New Revision: 300826 URL: http://llvm.org/viewvc/llvm-project?rev=300826&view=rev Log: Add #pragma clang attribute support to the availability attribute rdar://31707804 Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/lib/Sema/Sema

r300829 - Add Python 3 support to clang.cindex

Author: jbcoe Date: Thu Apr 20 05:11:01 2017 New Revision: 300829 URL: http://llvm.org/viewvc/llvm-project?rev=300829&view=rev Log: Add Python 3 support to clang.cindex Summary: Introduce an interop string to convert from unicode to c-strings where needed. Add missing conversions from _CXString t

[PATCH] D31568: Add Python 3 support to clang.cindex

This revision was automatically updated to reflect the committed changes. Closed by commit rL300829: Add Python 3 support to clang.cindex (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D31568?vs=94120&id=95918#toc Repository: rL LLVM https://reviews.llvm.org/D31568

r300832 - [index] Record class template specializations using a new 'SpecializationOf'

Author: arphaman Date: Thu Apr 20 05:43:22 2017 New Revision: 300832 URL: http://llvm.org/viewvc/llvm-project?rev=300832&view=rev Log: [index] Record class template specializations using a new 'SpecializationOf' relationship rdar://31603531 Differential Revision: https://reviews.llvm.org/D32010

[PATCH] D32010: [indexer] Record class template specializations using a new 'SpecializationOf' relationship

This revision was automatically updated to reflect the committed changes. Closed by commit rL300832: [index] Record class template specializations using a new 'SpecializationOf' (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D32010?vs=95112&id=95927#toc Repository:

[PATCH] D31650: [Analyzer] Detect when function pointer is freed

AndersRonnholm updated this revision to Diff 95929. AndersRonnholm added a comment. Updated after comments Repository: rL LLVM https://reviews.llvm.org/D31650 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c =

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. I don't see anything wrong with this, I think you can commit it in a couple of days if nobody comes up with a reason why the DiagnosticRenderer shouldn't use FullSourceLoc. https://reviews.llv

[PATCH] D32020: [indexer] The relationship between the declarations in template specializations that 'override' declarations in the base template should be recorded

arphaman updated this revision to Diff 95940. arphaman added a comment. Updated the relationship to be 'overrideOf | specializationOf' to differentiate it from regular 'overrideOf'. Repository: rL LLVM https://reviews.llvm.org/D32020 Files: lib/Index/IndexDecl.cpp lib/Index/IndexingCont

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731472, @rsmith wrote: > > As I've currently implemented it, both reads and writes set the type of > > previously-unknown storage, and after that it says fixed (unless you memcpy > > to it, memset it, or its lifetime ends (the type get

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 95945. chrib added a comment. 1. Updating https://reviews.llvm.org/D31972: Do not force the frame pointer by default for ARM EABI # Add test case https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/CodeGen/arm-fp-eabi.c Index

[PATCH] D32291: [analyzer] Implement handling array subscript into null pointer, improve null dereference checks for array subscripts

NoQ created this revision. When encountering an array-to-pointer-decay and the array base is null (or any other concrete pointer value) (eg. it's a member array in a structure, and the structure pointer is null; of course it wouldn't happen to stack-based or global arrays), do not yield Unknown

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:977 + Ex = Op->getSubExpr()->IgnoreParenCasts(); + while (true) { +if (const auto *ME = dyn_cast(Ex)) { zaks.anna wrote: > Why do we need the "whi

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/Store.cpp:440 // well, although in reality we should return the offset added to that - // value. + // value. See also the similar FIXME in getLValueFieldOrIvar(). if (Base.isUnknownOrUndef() || Base.getAs()

r300841 - Delete unused IncompleteFormat variable, NFCi.

Author: krasimir Date: Thu Apr 20 08:37:27 2017 New Revision: 300841 URL: http://llvm.org/viewvc/llvm-project?rev=300841&view=rev Log: Delete unused IncompleteFormat variable, NFCi. Modified: cfe/trunk/lib/Index/CommentToXML.cpp Modified: cfe/trunk/lib/Index/CommentToXML.cpp URL: http://llv

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar created this revision. kuhar added a project: clang-tools-extra. When running run-clang-tidy.py with -fix it tries to apply found replacements at the end. If there are errors running clang-apply-replacements, the script currently crashes or displays no error at all. This patch checks for

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

sanwou01 added a comment. Hi Diana, Thanks! Will do :) Sanne https://reviews.llvm.org/D31709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib updated this revision to Diff 95958. chrib added a comment. - Fix thinko in test https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/CodeGen/arm-fp-eabi.c Index: test/CodeGen/arm-fp-eabi.c === --

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731472, @rsmith wrote: > > As I've currently implemented it, both reads and writes set the type of > > previously-unknown storage, and after that it says fixed (unless you memcpy > > to it, memset it, or its lifetime ends (the type get

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/tool/run-clang-tidy.py:99-101 + except: +print >>sys.stderr, "Unable to run clang-apply-replacements." +sys.exit(1)

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

alexfh added a comment. In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote: > The `modernize-use-default-member-init` check now has an option with the same > effect, but it is called `UseAssignment`. > We should use consistent option names. > Is there any way for multiple checks

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kimgr added a comment. Python 3 concern inline Comment at: clang-tidy/tool/run-clang-tidy.py:100 + except: +print >>sys.stderr, "Unable to run clang-apply-replacements." +sys.exit(1) alexfh wrote: > "Unable to run clang-apply-replacements" without any

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address sp

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

malcolm.parsons added a comment. In https://reviews.llvm.org/D24892#732217, @alexfh wrote: > In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote: > > > Is there any way for multiple checks to share an option? > > > There's OptionsView::getLocalOrGlobal. See how StrictMode option is

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

dcoughlin added inline comments. Comment at: include/clang/AST/Decl.h:53 class VarTemplateDecl; +class CompilerInstance; Is this needed? It seems like a layering violation. Comment at: include/clang/AST/Mangle.h:59 + // the static analyzer.

[PATCH] D32301: Don't pass FPOpFusion::Strict to the backend

anemet created this revision. This restores the behavior prior to https://reviews.llvm.org/D31167 where the code-gen default was FPC_On which mapped to FPOpFusion::Standard. After merging the FE state (on/off) and the code-gen state (on/fast/off), the default became off to match the front-end.

[PATCH] D32301: Don't pass FPOpFusion::Strict to the backend

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 12:39 AM, Eric Fiselier wrote: > > > > On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini > wrote: > What would be the status of these buildbots? Is it for your private usage? > > I intend for them to be public Windows buildbots for libc++. I

r300858 - Don't pass FPOpFusion::Strict to the backend

Author: anemet Date: Thu Apr 20 12:09:35 2017 New Revision: 300858 URL: http://llvm.org/viewvc/llvm-project?rev=300858&view=rev Log: Don't pass FPOpFusion::Strict to the backend This restores the behavior prior to D31167 where the code-gen default was FPC_On which mapped to FPOpFusion::Standard.

[PATCH] D32301: Don't pass FPOpFusion::Strict to the backend

This revision was automatically updated to reflect the committed changes. Closed by commit rL300858: Don't pass FPOpFusion::Strict to the backend (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D32301?vs=95979&id=95982#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D32084: AMDGPU/GFX9: Set +fast-fmaf for >=gfx900 unless -cl-denorms-are-zero is set

kzhuravl added a comment. Ping. https://reviews.llvm.org/D32084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rjmccall added a comment. If you're going to try to enforce the declared type of memory, you'll also need something like the C effective type rule to handle char buffers in C++. As far as I can tell, it's not actually legal under the spec to cast an array of chars to an arbitrary type and acce

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

ahatanak added inline comments. Comment at: test/CodeGen/arm-fp-eabi.c:1 +// RUN: %clang %s -target arm-none-eabi -O2 -S -o nofp.s +// RUN: not grep '.setfp' nofp.s Instead of generating a .s file and looking for ".setfp", you can pass -### and check the presenc

[PATCH] D32192: Enable leak sanitizer builds for darwin

fjricci updated this revision to Diff 95986. fjricci added a comment. Add test cases https://reviews.llvm.org/D32192 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/fsanitize.c test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c =

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#732382, @rjmccall wrote: > If you're going to try to enforce the declared type of memory, you'll also > need something like the C effective type rule to handle char buffers in C++. > As far as I can tell, it's not actually legal under

r300873 - [Driver] Add a missing -no-canonical-prefixes to test.

Author: d0k Date: Thu Apr 20 14:06:24 2017 New Revision: 300873 URL: http://llvm.org/viewvc/llvm-project?rev=300873&view=rev Log: [Driver] Add a missing -no-canonical-prefixes to test. Modified: cfe/trunk/test/Driver/avr-mmcu.c Modified: cfe/trunk/test/Driver/avr-mmcu.c URL: http://llvm.org

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini wrote: > > On Apr 20, 2017, at 12:39 AM, Eric Fiselier wrote: > > > > On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini > wrote: > >> What would be the status of these buildbots? Is it for your private >> usage? >> > > I intend for them to be public Win

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar updated this revision to Diff 96001. kuhar added a comment. Use python3 printing. Move exception handling out of apply_fixes. Now, the code prints the following on failure: Applying fixes ... Error applying fixes. Is clang-apply-replacements binary correctly specified? Traceback (

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar marked 2 inline comments as done. kuhar added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:100 + except: +print >>sys.stderr, "Unable to run clang-apply-replacements." +sys.exit(1) kimgr wrote: > alexfh wrote: > > "Unable to run c

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

ABataev accepted this revision. ABataev added a comment. LG Repository: rL LLVM https://reviews.llvm.org/D29904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

ABataev added a comment. Tests? Comment at: lib/Driver/Driver.cpp:556 else { -const ToolChain &TC = getToolChain(C.getInputArgs(), TT); -C.addOffloadDeviceToolChain(&TC, Action::OFK_OpenMP); +const ToolChain *TC = nullptr; +

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. SGTM provided this continues to work with python 2. https://reviews.llvm.org/D32294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:297 + !Args.hasFlag(options::OPT_fnoopenmp_relocatable_target, +options::OPT_fopenmp_relocatable_target, false)) CmdArgs.push_back("-c"); 1. Add a comment with

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

rnk added inline comments. Comment at: include/clang/Basic/SourceLocation.h:336 + bool hasManager() const { return SrcMgr != nullptr; } /// \pre This FullSourceLoc has an associated SourceManager. SrcMgr is only non-null when the location is invalid, right?

[libcxx] r300881 - Fix comment and remove incorrect linker flags in test configuration

Author: ericwf Date: Thu Apr 20 15:22:19 2017 New Revision: 300881 URL: http://llvm.org/viewvc/llvm-project?rev=300881&view=rev Log: Fix comment and remove incorrect linker flags in test configuration Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

jfb added a comment. In https://reviews.llvm.org/D32265#731710, @EricWF wrote: > In https://reviews.llvm.org/D32265#731709, @jfb wrote: > > > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's > > STL implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't >

[PATCH] D32291: [analyzer] Implement handling array subscript into null pointer, improve null dereference checks for array subscripts

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

r300891 - Begin making git-clang-format python3 compatible.

Author: ericwf Date: Thu Apr 20 16:05:58 2017 New Revision: 300891 URL: http://llvm.org/viewvc/llvm-project?rev=300891&view=rev Log: Begin making git-clang-format python3 compatible. This patch fixes most of the python3 incompatabilities within git-clang-format while keeping the script python2 co

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

jfb added a comment. It looks like Billy is going to do something somewhat similar when he rewrites it: https://twitter.com/jfbastien/status/855168230918307840 For now it's kinda `#define IS_LOCK_FREE ¯\_(ツ)_/¯` https://reviews.llvm.org/D32265 ___

[PATCH] D32192: Enable leak sanitizer builds for darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL300894: Enable leak sanitizer builds for darwin (authored by fjricci). Changed prior to commit: https://reviews.llvm.org/D32192?vs=95986&id=96019#toc Repository: rL LLVM https://reviews.llvm.org/D32

r300895 - Fix Python 2 vs 3 incompatability with dict.items() vs iteritems()

Author: ericwf Date: Thu Apr 20 16:23:58 2017 New Revision: 300895 URL: http://llvm.org/viewvc/llvm-project?rev=300895&view=rev Log: Fix Python 2 vs 3 incompatability with dict.items() vs iteritems() Modified: cfe/trunk/tools/clang-format/git-clang-format Modified: cfe/trunk/tools/clang-form

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. In https://reviews.llvm.org/D32265#732657, @jfb wrote: > It looks like Billy is going to do something somewhat similar when he > rewrites it: https://twitter.com/jfbastien/status/855168230918307840 > For now it's kinda `#define IS_LOCK_FREE ¯\_(ツ)_/¯` Note that my

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

EricWF added a comment. In https://reviews.llvm.org/D32265#732649, @jfb wrote: > In https://reviews.llvm.org/D32265#731710, @EricWF wrote: > > > In https://reviews.llvm.org/D32265#731709, @jfb wrote: > > > > > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's > > > STL im

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. (sorry for double post) And of course since you folks don't care about supporting pre-Vista you probably also don't care about supporting Opterons from 2005, in which case you'd want unconditional cmpxchg16b on amd64 :). In our next major version I added a configura

[PATCH] D30773: Make git-clang-format python 3 compatible

EricWF updated this revision to Diff 96025. EricWF added a comment. I've committed all but the `str` vs `byte` changes upstream. https://reviews.llvm.org/D30773 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. In https://reviews.llvm.org/D32265#731709, @jfb wrote: > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's STL > implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't seem to > have anything ? Pres

[PATCH] D32313: [clang-tidy] Don't turn .push_back({1, 2}) into .emplace_back(1, 2) for pairs

kuhar created this revision. kuhar added a project: clang-tools-extra. This patch prevents modernize-use-emplace from changing push_backs of brace initialized pairs (`.push_back({1, 2})`) to `.emplace_back(1, 2)`. Pair's constructor doesn't have any interesting logic and basically performs aggre

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rsmith added a comment. In https://reviews.llvm.org/D32199#732189, @hfinkel wrote: > In https://reviews.llvm.org/D32199#731472, @rsmith wrote: > > > 1. C's "effective type" rule allows writes to set the type pretty much > > unconditionally, unless the storage is for a variable with a declared ty

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

Prazek accepted this revision. Prazek added a comment. LGTM, but please leave the FIXME comment about the running of apply replacement https://reviews.llvm.org/D32294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I'm not thrilled about adding yet more predefined macros, but it really doesn't make sense for libc++ to depend on `__GCC_*` macros when targeting Windows, nor for these to be Windows-only, so

r300908 - Parse: cleanup some bleeding whitespace

Author: compnerd Date: Thu Apr 20 17:23:07 2017 New Revision: 300908 URL: http://llvm.org/viewvc/llvm-project?rev=300908&view=rev Log: Parse: cleanup some bleeding whitespace Clean up some bleeding whitespace that I noticed. NFC Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified: cfe/tru

r300909 - Sema: protect against ObjC++ typo-correction failure

Author: compnerd Date: Thu Apr 20 17:23:10 2017 New Revision: 300909 URL: http://llvm.org/viewvc/llvm-project?rev=300909&view=rev Log: Sema: protect against ObjC++ typo-correction failure ObjC++ has two different types of "pointer" types (ObjCClassPointerType and PointerType). Both can be indire

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 12:30 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini > wrote: > >> On Apr 20, 2017, at 12:39 AM, Eric Fiselier > > wrote: >> >> >> >> On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini >

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai created this revision. Herald added a subscriber: mgorny. libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it targets the Itanium ABI, whereas MSVC uses the Microsoft ABI. Make the default ABI be vcruntime when targeting MSVC even if libc++abi is present in the tree.

r300914 - Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

Author: ericwf Date: Thu Apr 20 17:53:57 2017 New Revision: 300914 URL: http://llvm.org/viewvc/llvm-project?rev=300914&view=rev Log: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode. Summary: Libc++ currently implements the `ATOMIC__LOCK_FREE` macros using the `__GCC_ATOMI

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

EricWF updated this revision to Diff 96043. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D32265 Files: lib/Frontend/InitPreprocessor.cpp test/Preprocessor/init.c test/Sema/atomic-ops.c Index: test/Sema/atomic-ops.c ==

[PATCH] D32322: Use __CLANG_ATOMIC_TYPE_LOCK_FREE macros in `stdatomic.h`

EricWF created this revision. This patch makes the header `stdatomic.h` work when `-fms-compatibility` is specified. https://reviews.llvm.org/D32322 Files: lib/Headers/stdatomic.h test/Headers/stdatomic.c Index: test/Headers/stdatomic.c ===

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar updated this revision to Diff 96045. kuhar added a comment. After thinking about Piotr's comment, I think that a better way to perform the check would be te invoking clang-apply-replacements with `--version` and seeing if it fails even before running clang-tidy. This way it is possible to

r300917 - [CMake] Enable ARM target in Fuchsia toolchain

Author: phosek Date: Thu Apr 20 18:06:53 2017 New Revision: 300917 URL: http://llvm.org/viewvc/llvm-project?rev=300917&view=rev Log: [CMake] Enable ARM target in Fuchsia toolchain This is still used by some users of Fuchsia toolchain. Also include llc and opt which is useful for development and t

r300919 - Use __CLANG_ATOMIC_TYPE_LOCK_FREE macros in `stdatomic.h`

Author: ericwf Date: Thu Apr 20 18:07:38 2017 New Revision: 300919 URL: http://llvm.org/viewvc/llvm-project?rev=300919&view=rev Log: Use __CLANG_ATOMIC_TYPE_LOCK_FREE macros in `stdatomic.h` Summary: This patch makes the header `stdatomic.h` work when `-fms-compatibility` is specified. Reviewer

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL300917: [CMake] Enable ARM target in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32231?vs=95766&id=96048#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This is sadly not a correct change. The relevant requirements (C11 7.20.3/2) on these macros are: > Each instance of these macros shall be replaced by a constant expression > suitab

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

rsmith added a comment. Please add some test coverage for these triples. Repository: rL LLVM https://reviews.llvm.org/D32269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: CMakeLists.txt:119 +set(LIBCXX_CXX_ABI_LIBNAME "vcruntime") else() +find_path( Nit: I would rather see this be ``` elseif ((NOT

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai added inline comments. Comment at: CMakeLists.txt:119 +set(LIBCXX_CXX_ABI_LIBNAME "vcruntime") else() +find_path( EricWF wrote: > Nit: I would rather see this be > ``` > elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND > IS_D

[libcxx] r300920 - Fix ATOMIC__LOCK_FREE macros on Windows.

Author: ericwf Date: Thu Apr 20 18:22:46 2017 New Revision: 300920 URL: http://llvm.org/viewvc/llvm-project?rev=300920&view=rev Log: Fix ATOMIC__LOCK_FREE macros on Windows. Previously the ATOMIC__LOCK_FREE macros were implemented using __GCC_ATOMIC__LOCK_FREE but GCC specific macros are defined

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. Thanks for the review. `__SIZE_MAX__` makes sense to me; and better even if not for the `#if` requirement. I'll do that for both `SIZE_MAX` and `PTRDIFF_MAX` when I get a chance. Comment at: clang/test/Preprocessor/stdint.c:1411 // JOIN:PTRDIFF_

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai updated this revision to Diff 96055. smeenai added a comment. Reduce nesting (address comments) https://reviews.llvm.org/D32320 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -1

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL300921: [libc++] Default to vcruntime when targeting MSVC (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32320?vs=96055&id=96056#toc Repository: rL LLVM https://reviews.ll

[libcxx] r300921 - [libc++] Default to vcruntime when targeting MSVC

Author: smeenai Date: Thu Apr 20 18:33:49 2017 New Revision: 300921 URL: http://llvm.org/viewvc/llvm-project?rev=300921&view=rev Log: [libc++] Default to vcruntime when targeting MSVC Summary: libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it targets the Itanium ABI, whereas

[libcxxabi] r300925 - Fix PR25874 - cxa_thread_atexit_test.pass.cpp has an incorrect XFAIL.

Author: ericwf Date: Thu Apr 20 18:40:35 2017 New Revision: 300925 URL: http://llvm.org/viewvc/llvm-project?rev=300925&view=rev Log: Fix PR25874 - cxa_thread_atexit_test.pass.cpp has an incorrect XFAIL. Modified: libcxxabi/trunk/test/CMakeLists.txt libcxxabi/trunk/test/cxa_thread_atexit_t

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

alexshap created this revision. alexshap created this object with visibility "All Users". This diff replaces getTypeSize(CondE->getType())) with getIntWidth(CondE->getType())). These calls are not equivalent for bool https://clang.llvm.org/doxygen/ASTContext_8cpp_source.html#l08444 and the anal

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai created this revision. Herald added a subscriber: mgorny. libc++abi can't depend on libc++, so disable extern templates in libc++ headers project-wide. This was previously done in cxa_demangle.cpp, but I consider it more appropriate to do at the cmake level (since none of libc++abi's sourc

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

On 18 April 2017 at 22:41, Chandler Carruth wrote: > Reverted in r300658. > For posterity, the above has an off-by-one error, the revert was r300659. > On Tue, Apr 18, 2017 at 8:30 PM Chandler Carruth > wrote: > >> Consider code like the following: >> >> ``` >> #include >> >> template >> cl

Buildbot numbers for the week of 04/02/2017 - 04/08/2017

Hello everyone, Below are some buildbot numbers for the week of 04/02/2017 - 04/08/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 04/09/2017 - 04/15/2017

Hello everyone, Below are some buildbot numbers for the last week of 04/09/2017 - 04/15/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

r300894 - Enable leak sanitizer builds for darwin

Author: fjricci Date: Thu Apr 20 16:11:51 2017 New Revision: 300894 URL: http://llvm.org/viewvc/llvm-project?rev=300894&view=rev Log: Enable leak sanitizer builds for darwin Summary: Support for leak sanitizer on darwin has been added to compiler-rt, this patch adds compiler support. Reviewers:

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

dexonsmith added a comment. Marshall, are you fine with figuring this out in-tree? Or should I revert to using `std::is_floating_point` for now? https://reviews.llvm.org/D31561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

Prazek added a comment. In https://reviews.llvm.org/D32294#732861, @kuhar wrote: > After thinking about Piotr's comment, I think that a better way to perform > the check would be te invoking clang-apply-replacements with `--version` and > seeing if it fails even before running clang-tidy. > Th

  1   2   >