Author: ericwf
Date: Thu Apr 20 18:40:35 2017
New Revision: 300925
URL: http://llvm.org/viewvc/llvm-project?rev=300925&view=rev
Log:
Fix PR25874 - cxa_thread_atexit_test.pass.cpp has an incorrect XFAIL.
Modified:
libcxxabi/trunk/test/CMakeLists.txt
libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/lit.site.cfg.in
Modified: libcxxabi/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/CMakeLists.txt?rev=300925&r1=300924&r2=300925&view=diff
==============================================================================
--- libcxxabi/trunk/test/CMakeLists.txt (original)
+++ libcxxabi/trunk/test/CMakeLists.txt Thu Apr 20 18:40:35 2017
@@ -18,7 +18,6 @@ pythonize_bool(LIBCXXABI_ENABLE_THREADS)
pythonize_bool(LIBCXXABI_ENABLE_EXCEPTIONS)
pythonize_bool(LIBCXXABI_USE_LLVM_UNWINDER)
pythonize_bool(LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY)
-pythonize_bool(LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL)
set(LIBCXXABI_TARGET_INFO "libcxx.test.target_info.LocalTI" CACHE STRING
"TargetInfo to use when setting up test environment.")
set(LIBCXXABI_EXECUTOR "None" CACHE STRING
Modified: libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp
URL:
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp?rev=300925&r1=300924&r2=300925&view=diff
==============================================================================
--- libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp (original)
+++ libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp Thu Apr 20 18:40:35
2017
@@ -10,11 +10,6 @@
// UNSUPPORTED: libcxxabi-no-threads
// REQUIRES: linux
-// this test will only work if CMake detects a real __cxa_thread_atexit_impl
-// at configure time. This function, however, was added only in glibc 2.18,
-// and there are still plenty of systems only using 2.17 (Ex RHEL 7).
-// XFAIL: libcxxabi-no-cxa-thread-atexit-impl
-
#include <assert.h>
#include <cxxabi.h>
Modified: libcxxabi/trunk/test/libcxxabi/test/config.py
URL:
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/libcxxabi/test/config.py?rev=300925&r1=300924&r2=300925&view=diff
==============================================================================
--- libcxxabi/trunk/test/libcxxabi/test/config.py (original)
+++ libcxxabi/trunk/test/libcxxabi/test/config.py Thu Apr 20 18:40:35 2017
@@ -45,9 +45,6 @@ class Configuration(LibcxxConfiguration)
# test_exception_storage_nodynmem.pass.cpp fails under this specific
configuration
if self.get_lit_bool('cxx_ext_threads', False) and
self.get_lit_bool('libcxxabi_shared', False):
self.config.available_features.add('libcxxabi-shared-externally-threaded')
- if not self.get_lit_bool('has_cxa_thread_atexit_impl', True):
- self.config.available_features.add(
- 'libcxxabi-no-cxa-thread-atexit-impl')
if not self.get_lit_bool('llvm_unwinder', False):
self.config.available_features.add('libcxxabi-has-system-unwinder')
Modified: libcxxabi/trunk/test/lit.site.cfg.in
URL:
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/lit.site.cfg.in?rev=300925&r1=300924&r2=300925&view=diff
==============================================================================
--- libcxxabi/trunk/test/lit.site.cfg.in (original)
+++ libcxxabi/trunk/test/lit.site.cfg.in Thu Apr 20 18:40:35 2017
@@ -21,7 +21,6 @@ config.host_triple = "@LLVM
config.target_triple = "@TARGET_TRIPLE@"
config.use_target = len("@LIBCXXABI_TARGET_TRIPLE@") > 0
config.cxx_ext_threads = "@LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY@"
-config.has_cxa_thread_atexit_impl = "@LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL@"
# Let the main config do the real work.
lit_config.load_config(config, "@LIBCXXABI_SOURCE_DIR@/test/lit.cfg")
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
