EricWF updated this revision to Diff 90752.
EricWF marked an inline comment as done.
EricWF added a comment.
- Address @rsmith's final review comments.
https://reviews.llvm.org/D26057
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/Stmt.h
inc
EricWF added inline comments.
Comment at: include/clang/Sema/ScopeInfo.h:138-140
+ /// \brief Whether this function has already built, or tried to build, the
+ /// the initial and final coroutine suspend points.
+ bool NeedsCoroutineSuspends : 1;
rsmith wrote:
rsmith added inline comments.
Comment at: lib/Sema/TreeTransform.h:6802
+ return getDerived().RebuildDependentCoawaitExpr(
+ E->getKeywordLoc(), Result.get(), E->getOperatorCoawaitLookup());
+}
EricWF wrote:
> rsmith wrote:
> > You need to transform the Unr
Author: ericwf
Date: Mon Mar 6 17:38:15 2017
New Revision: 297093
URL: http://llvm.org/viewvc/llvm-project?rev=297093&view=rev
Log:
[coroutines] Add DependentCoawaitExpr and fix re-building CoroutineBodyStmt.
Summary:
The changes contained in this patch are:
1. Defines a new AST node `CoawaitDe
brad added a comment.
Good to know about the reviewer.
I am not familiar with phabricator and was just trying something with the
addition of the subscriber.
I will keep the amount of context in mind for future diffs.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D30465
_
Author: brad
Date: Mon Mar 6 17:48:31 2017
New Revision: 297098
URL: http://llvm.org/viewvc/llvm-project?rev=297098&view=rev
Log:
Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/init.c
Modified: cfe/
Author: rnk
Date: Mon Mar 6 17:49:18 2017
New Revision: 297099
URL: http://llvm.org/viewvc/llvm-project?rev=297099&view=rev
Log:
Relax stmtexpr.cpp checks for PPC64
Modified:
cfe/trunk/test/CodeGenCXX/stmtexpr.cpp
Modified: cfe/trunk/test/CodeGenCXX/stmtexpr.cpp
URL:
http://llvm.org/viewvc
Author: rnk
Date: Mon Mar 6 17:52:53 2017
New Revision: 297101
URL: http://llvm.org/viewvc/llvm-project?rev=297101&view=rev
Log:
Fix some widespread warnings in headers from the new coroutine code
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/include/clang/Sema/ScopeInfo.h
Modi
Author: ericwf
Date: Mon Mar 6 18:01:13 2017
New Revision: 297105
URL: http://llvm.org/viewvc/llvm-project?rev=297105&view=rev
Log:
Fix unused variable in SemaCoroutine.cpp
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp
URL:
http://llvm.org/vi
Author: ericwf
Date: Mon Mar 6 18:15:18 2017
New Revision: 297106
URL: http://llvm.org/viewvc/llvm-project?rev=297106&view=rev
Log:
Define LLVM_ENABLE_WARNINGS when building standalone clang to ensure warnings
get enabled
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.tx
kmarshall added a comment.
That makes sense. In the cases that I'm finding, the original call site is in
application source code, but the warning is generated from inside a system
header. So, I suppose the suppressions are working as intended, and we just
need to add one-off suppressions for th
kmarshall added a comment.
Also, it looks like some instances of safe unique_ptr assignment using
std::move() are tripping up the analyzer.
Error:
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:190:4:
warning: Pot
dcoughlin added a comment.
We add the suppression for libcxx issues in
LikelyFalsePositiveSuppressionBRVisitor in BugReporterVisitors.cpp. It is
ad-hoc pattern recognition of idioms we know cause false positives rather than
an explicit database.
Repository:
rL LLVM
https://reviews.llvm.org
bruno added a comment.
Hi Alex,
Comment at: lib/Sema/SemaDeclObjC.cpp:4312
+ for (const ParmVarDecl *P : Method->parameters()) {
+if (P->getType()->isVectorType()) {
+ Loc = P->getLocStart();
Assuming objc/c++ can pass/return these, the current check
kmarshall added a comment.
It appears that the "suppress-c++-stdlib" option in
LikelyFalsePositiveSuppressionBRVisitor is yielding promising results. It
removes warnings from the "std" namespace which addresses both false positives
that I cited above.
Repository:
rL LLVM
https://reviews.ll
vsk added a comment.
Thanks for the feedback!
Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:21
+ // CHECK: call void @__ubsan_handle_load_invalid_value
+ return s->e1;
+}
arphaman wrote:
> Can we avoid the check if the bitfield is 2 bits wide?
I don't think
mehdi_amini updated this revision to Diff 90773.
mehdi_amini edited the summary of this revision.
mehdi_amini added a comment.
Rebase
https://reviews.llvm.org/D17469
Files:
test/std/localization/locale.categories/category.ctype/ctype_base.pass.cpp
test/std/localization/locale.categories/ca
malaperle-ericsson updated this revision to Diff 90774.
malaperle-ericsson added a comment.
[clangd] Fix not being able to attach a debugger on macOS
Clangd is often waiting for input on getline as it awaits requests.
If the getline is interrupted, it causes the system call (read) to
fail and the
malaperle-ericsson added a comment.
Please disregard the last diff, I misused arc.
https://reviews.llvm.org/D30476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson updated this revision to Diff 90776.
https://reviews.llvm.org/D30476
Files:
clangd/clients/lsp4e-cpp/.gitignore
clangd/clients/lsp4e-cpp/.mvn/extensions.xml
clangd/clients/lsp4e-cpp/.travis.yml
clangd/clients/lsp4e-cpp/LICENSE
clangd/clients/lsp4e-cpp/README.md
clan
Hello everyone,
Below are some buildbot numbers for the week of 02/19/2017 - 02/25/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 02/26/2017 -
03/04/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
mehdi_amini updated this revision to Diff 90779.
mehdi_amini added a comment.
Add back the python changes (files were moved, I lost them in the rebase)
https://reviews.llvm.org/D17469
Files:
test/std/localization/locale.categories/category.ctype/ctype_base.pass.cpp
test/std/localization/lo
mehdi_amini added inline comments.
Comment at: test/libcxx/test/config.py:66
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
EricWF wrote:
> Was the omission of `self.use_deployment` here intentional? Python linter
Hello everyone,
LLVM buildmaster will be updated and restarted in the nearest hour.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: test/libcxx/test/config.py:66
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
mehdi_amini wrote:
> EricWF wrote:
> > Was the omission of `self.use_deployment` here int
ddcc added a comment.
Thanks for your help! Let me know when the buildbot is ready for this to land.
https://reviews.llvm.org/D28952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
I think this might miss loads from bitfield ivars. Also, what about the
conversion that happens for properties whose backing ivar is a bitfield? (or
does that happen in the runtime? can't remember)
Comment at: test/CodeGenObjC/ubsan-bool.m:25
+ // O
> On Mar 6, 2017, at 10:17 AM, Lobron, David wrote:
>
> Hi Akira,
>
> Pardon my slowness in addressing your question.
>
>> This patch changes the encoding of an id conforming to a protocol, which I
>> think was not intended: For example:
>>
>> @encode(id)
>>
>> Would passing IVD to the call
ahatanak added a comment.
In https://reviews.llvm.org/D30662#693609, @andrew.w.kaylor wrote:
> In https://reviews.llvm.org/D30662#693559, @ahatanak wrote:
>
> > Is it possible to add a test case (possibly in CodeGen)?
>
>
> This is covered by CodeGen/ms-inline-asm.c, which Reid added after I brok
Hello everyone,
LLVM buildmaster will be restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
No the argument is not shown with tilde/column number.
Code example:
void f(int x, ...);
void dostuff() {
int x[10];
f(12,3,4,5,x[3],6,7,8);
}
Output:
C:\Users\danielm>\llvm\build\Debug\bin\clang -cc1 -analyze
-analyzer-checker=core test3.c
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Oh well, that's not good. Probably that's because we always highlight the
current statement in path-sensitive reports. I guess we could improve upon that
in the bug reporter.
Repository:
rL LLVM
101 - 133 of 133 matches
Mail list logo
