mehdi_amini added inline comments.

================
Comment at: test/libcxx/test/config.py:66
         self.env = {}
         self.use_target = False
         self.use_system_cxx_lib = False
----------------
mehdi_amini wrote:
> EricWF wrote:
> > Was the omission of `self.use_deployment` here intentional? Python linters 
> > typically get upset by this.
> I can see how it would be useful not to add it here: we'd want an exception 
> if it is used without being set since we don't expect it to happen.
> 
But if it is not considered "pythonic", I'm fine adding it as well :)


https://reviews.llvm.org/D17469



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to