[libcxx] r296568 - Fix test failures due to bad test hasher

Author: ericwf Date: Tue Feb 28 20:34:27 2017 New Revision: 296568 URL: http://llvm.org/viewvc/llvm-project?rev=296568&view=rev Log: Fix test failures due to bad test hasher Modified: libcxx/trunk/test/std/containers/unord/unord.map/unord.map.cnstr/default_noexcept.pass.cpp libcxx/trunk

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 90114. smeenai added a comment. Rebase https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handlers.hpp src/cxa_n

[PATCH] D26949: [libc++abi] Clean up visibility

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus inline comments. @smeenai confirmed that this patch doesn't change the ABI list for `libc++abi.dylib` using `sym_check.py`. Comment at: src/abort_message.h:19

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added inline comments. Comment at: src/abort_message.h:19 -__attribute__((visibility("hidden"), noreturn)) - void abort_message(const char* format, ...) -__attribute__((format(printf, 1, 2))); - +_LIBCXXABI_HIDDEN __attribute__((noreturn)) void +abort

[libcxx] r296571 - Mark test as unsupported in C++11

Author: ericwf Date: Tue Feb 28 20:52:04 2017 New Revision: 296571 URL: http://llvm.org/viewvc/llvm-project?rev=296571&view=rev Log: Mark test as unsupported in C++11 Modified: libcxx/trunk/test/libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp Modified: libcxx/trunk/t

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

dcoughlin added a comment. Saving the relevant portion of the build bot log output before it disappears from the bot: 0.000 [0/1/0] Running all regression tests -- Testing: 31894 tests, 80 threads -- Traceback (most recent call last): File "", line 1, in File "C:\Python27\lib\mult

r296572 - Add warning for inconsistent overrides on destructor.

Author: rtrieu Date: Tue Feb 28 21:07:55 2017 New Revision: 296572 URL: http://llvm.org/viewvc/llvm-project?rev=296572&view=rev Log: Add warning for inconsistent overrides on destructor. The exisiting warning for inconsistent overrides does not include the destructor as it was noted in review tha

[libcxx] r296573 - [libcxx] Support threads on Fuchsia

Author: phosek Date: Tue Feb 28 21:09:18 2017 New Revision: 296573 URL: http://llvm.org/viewvc/llvm-project?rev=296573&view=rev Log: [libcxx] Support threads on Fuchsia Differential Revision: https://reviews.llvm.org/D30278 Modified: libcxx/trunk/src/thread.cpp Modified: libcxx/trunk/src/th

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

dcoughlin added a comment. I'm not sure what is going on. One thing to try is defining the class in clang/test/lit.cfg -- which seems to work for Swift. (See https://github.com/apple/swift/blob/master/test/lit.cfg#L137) We'd still want to only use that class in Analysis/lit.local.cfg. Another

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 90119. smeenai added a comment. Addressing inline comment https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handl

[libcxxabi] r296576 - [libc++abi] Clean up visibility

Author: smeenai Date: Tue Feb 28 21:55:57 2017 New Revision: 296576 URL: http://llvm.org/viewvc/llvm-project?rev=296576&view=rev Log: [libc++abi] Clean up visibility Use the libc++abi visibility macros instead of pragmas or using visibility attributes directly. Clean up redundant attributes on de

[PATCH] D26949: [libc++abi] Clean up visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL296576: [libc++abi] Clean up visibility (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26949?vs=90119&id=90120#toc Repository: rL LLVM https://reviews.llvm.org/D26949 Fil

[PATCH] D27387: [libc++] Add a key function for bad_function_call

EricWF added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + What's the rationale for making the dtor out-of-line? Couldn't we just use `what()` as the key function? Comment at: lib/

[PATCH] D30268: Avoid copy of __atoms when char_type is char

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. `__num_get` is externally instantiated. Adding non-template methods or changing method signatures is ABI breaking (As shown by the `check-cxx-abilist` rule output

[PATCH] D30459: [libcxxabi] Clean up macro usage

EricWF added a comment. I renamed `LIBCXXABI_ARM_EHABI` to `_LIBCXXABI_ARM_EHABI` so you'll have to merge this change with that. Other than that this LGTM. https://reviews.llvm.org/D30459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

This revision was automatically updated to reflect the committed changes. Closed by commit rL296584: [Sema] Add variable captured by a block to the enclosing lambda's (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D25556?vs=86918&id=90123#toc Repository: rL LLVM h

r296584 - [Sema] Add variable captured by a block to the enclosing lambda's

Author: ahatanak Date: Wed Mar 1 00:11:25 2017 New Revision: 296584 URL: http://llvm.org/viewvc/llvm-project?rev=296584&view=rev Log: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list. Fix Sema::getCurLambda() to return the innermost lambda scope when there

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

rsmith accepted this revision. rsmith added a comment. Yes, I'm OK with this as a stopgap fix for 4.0. I would have preferred a more full fix for 4.0 but we've run out of time for that, and the PCH case does seem more pressing. https://reviews.llvm.org/D29753 ___

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

rsmith added a comment. In https://reviews.llvm.org/D29753#688834, @bruno wrote: > > It seems to me that the problem here is that `DeclMustBeEmitted` is not > > safe to call in the middle of deserialization if anything > > partially-deserialized might be reachable from the declaration we're >

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + EricWF wrote: > What's the rationale for making the dtor out-of-line? Couldn't we just use > `what()` as the key function? We could, but th

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

Nice! -- Sean Silva On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Tue Feb 28 19:01:10 2017 > New Revision: 296554 > > URL: http://llvm.org/viewvc/llvm-project?rev=296554&view=rev > Log: > [PS4] Set our default dial

[PATCH] D27387: [libc++] Add a key function for bad_function_call

EricWF added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + smeenai wrote: > EricWF wrote: > > What's the rationale for making the dtor out-of-line? Couldn't we just use > > `what()` as the key functi

<    1   2