rogfer01 added a comment.
Sorry for the noise. I was expecting some more formal approval in the usual
form of "Ready to land" but if you think it is OK I will commit it shortly.
Regards.
https://reviews.llvm.org/D29986
___
cfe-commits mailing list
Author: kfunk
Date: Fri Feb 24 02:29:46 2017
New Revision: 296098
URL: http://llvm.org/viewvc/llvm-project?rev=296098&view=rev
Log:
Add clazy to external Clang examples page
Reviewers: silvas, rizsotto.mailinglist, sergio.martins
Reviewed By: rizsotto.mailinglist
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296099: Fix crash when an incorrect redeclaration only
differs in __unaligned type… (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D29986?vs=88514&id=89617#toc
Repository:
Author: rogfer01
Date: Fri Feb 24 02:41:09 2017
New Revision: 296099
URL: http://llvm.org/viewvc/llvm-project?rev=296099&view=rev
Log:
Fix crash when an incorrect redeclaration only differs in __unaligned
type-qualifier
Fix an assertion that is hit when a redeclaration with differing types only
On Thu, Feb 23, 2017 at 10:40 PM Sam McCall wrote:
>
>
> On Feb 23, 2017 8:48 PM, "Haojian Wu via Phabricator" <
> revi...@reviews.llvm.org> wrote:
>
> hokein added inline comments.
>
>
>
> Comment at:
> unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:40
> + voi
Author: danielmarjamaki
Date: Fri Feb 24 03:02:44 2017
New Revision: 296100
URL: http://llvm.org/viewvc/llvm-project?rev=296100&view=rev
Log:
[clang-tidy] Fix readability-redundant-declaration false positive
Differential Revision: https://reviews.llvm.org/D27048
Modified:
clang-tools-extra/t
javed.absar created this revision.
This patch enables the msvc pragma section to choose whether zero initialized
variables are to be placed in data_seg or bss_seg. The current
implementation ignores bss_seg directive for variables that are initialized
(i.e. it does not check if the initializat
malcolm.parsons created this revision.
Don't warn about unused lambda captures that involve copying a
value of a type that cannot be trivially copied and destroyed.
Fixes PR31977
https://reviews.llvm.org/D30327
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaLambda.cpp
test/SemaCXX/warn-un
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.h:21
+/// std::random_shuffle will be removed as of C++17. This check will find and
+/// replace all occurences of std::random_shuffle with std::shuffle.
+///
Typo -
ioeric created this revision.
https://reviews.llvm.org/D30328
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
change-namespace/tool/ClangChangeNamespace.cpp
test/change-namespace/Inputs/fake-std.h
test/change-namespace/white-list.cpp
unittests/change-nam
ioeric updated this revision to Diff 89627.
ioeric added a comment.
- removed a debug message
https://reviews.llvm.org/D30328
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
change-namespace/tool/ClangChangeNamespace.cpp
test/change-namespace/Inputs/fake-s
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:78
+// changing namespaces around them.
+constexpr const char *WhiteListedSymbolPatterns[] = {"^std::.*$"};
+
That's two votes for "this is too surprising" - changed.
https://imgflip.com/i/1k93rm
https://68.media.tumblr.com/8db2fe0a6f84ff128157a2b615f519bf/tumblr_inline_nenq4hMoQA1sb080b.gif
On Fri, Feb 24, 2017 at 9:54 AM, Manuel Klimek wrote:
> On Thu, Feb 23, 2017 at 10:40 PM Sam McCall wrote:
>
>>
sammccall updated this revision to Diff 89632.
sammccall added a comment.
Report symbols by reference.
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndex.h
include-fi
hokein added a comment.
Thanks, still LGTM with one nit.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:262
+ if (Filename != "") {
+Reporter->reportSymbols(Filename, std::move(FileSymbols));
+FileSymbols = {};
We don't need `std::move`
sammccall updated this revision to Diff 89636.
sammccall added a comment.
Remove redundant std::move
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndex.h
include-fixe
ioeric updated this revision to Diff 89637.
ioeric marked an inline comment as done.
ioeric added a comment.
- Make the whitelist an option.
https://reviews.llvm.org/D30328
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
change-namespace/tool/ClangChangeName
ioeric added a comment.
PTAL
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:78
+// changing namespaces around them.
+constexpr const char *WhiteListedSymbolPatterns[] = {"^std::.*$"};
+
hokein wrote:
> Maybe consider create a command-line option for
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:189
+ const auto *EReg = dyn_cast_or_null(Reg);
+ return EReg && VaListModelledAsArray ? EReg->getSuperRegion() : Reg;
+}
I would personally recommend parentheses a
hokein added inline comments.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82
+
+llvm::ErrorOr> GetWhiteListedSymbolPatterns() {
+ llvm::SmallVector Lines;
Instead `std::vector`, maybe std::vector is better,
with that we don't need to do transform
ioeric updated this revision to Diff 89640.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D30328
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
change-namespace/tool/ClangChangeNamespace.cpp
ioeric added inline comments.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82
+
+llvm::ErrorOr> GetWhiteListedSymbolPatterns() {
+ llvm::SmallVector Lines;
hokein wrote:
> Instead `std::vector`, maybe std::vector is better,
> with that we don't ne
danielmarjamaki updated this revision to Diff 89641.
danielmarjamaki added a comment.
Fixed review comment. Broke out function.
Repository:
rL LLVM
https://reviews.llvm.org/D28278
Files:
lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp
test/Analysis/uninit-vals-ps.c
Index: test/Analy
Author: ioeric
Date: Fri Feb 24 05:54:45 2017
New Revision: 296110
URL: http://llvm.org/viewvc/llvm-project?rev=296110&view=rev
Log:
[change-namepsace] make it possible to whitelist symbols so they don't get
updated.
Reviewers: hokein
Reviewed By: hokein
Subscribers: cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296110: [change-namepsace] make it possible to whitelist
symbols so they don't get… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D30328?vs=89640&id=89643#toc
Repository:
rL
Thanks Anna, I'm new to the release process here.
Hans: this is a simple fix for a null-dereference in the static analyzer.
Does it make sense to cherrypick?
On Sat, Feb 18, 2017 at 2:46 AM, Anna Zaks via Phabricator <
revi...@reviews.llvm.org> wrote:
> zaks.anna added a comment.
>
> Has this be
Author: ioeric
Date: Fri Feb 24 06:56:51 2017
New Revision: 296113
URL: http://llvm.org/viewvc/llvm-project?rev=296113&view=rev
Log:
[change-namespace] fix asan failure in r296110.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-tools-extra/tr
Author: sepavloff
Date: Fri Feb 24 07:15:08 2017
New Revision: 296116
URL: http://llvm.org/viewvc/llvm-project?rev=296116&view=rev
Log:
Made test more target agnostic
Recommits r295975 (Added regression tests), reverted in r295975,
because it did not work on non-X86 targets.
Added:
cfe/trunk
hokein created this revision.
Also support dumping global variables.
https://reviews.llvm.org/D30337
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/var_test.cpp
test/clang-move/Inputs/var_test.h
test/clang-move/move-var.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unitt
hokein updated this revision to Diff 89659.
hokein added a comment.
No accident changes.
https://reviews.llvm.org/D30337
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/var_test.cpp
test/clang-move/Inputs/var_test.h
test/clang-move/move-var.cpp
unittests/clang-move/ClangMoveTes
rmaprath updated this revision to Diff 89664.
rmaprath added a comment.
Different take on the patch: Externalize this function only for the
externally-thread-api variant.
This is much less intrusive. Note that I haven't added the declaration of
`__libcpp_thread_hw_concurrency()` into `__threadi
rmaprath updated this revision to Diff 89665.
rmaprath added a comment.
Different approach: Externalize these functions only for the
external-thread-api library variant.
(Similar to https://reviews.llvm.org/D29757)
https://reviews.llvm.org/D29818
Files:
src/chrono.cpp
Index: src/chrono.cp
Hello,
Is there any plan from the community to have clang support multiple versions of
VS?
Thanks.
-Zahira
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D30337
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
rs created this revision.
We've been having issues with using libcxxabi and libunwind for baremetal
targets because fprintf is dependent on io functions, this patch disable calls
to fprintf when building for baremetal targets in release mode.
https://reviews.llvm.org/D30339
Files:
src/abort
rs created this revision.
We've been having issues with using libcxxabi and libunwind for baremetal
targets because fprintf is dependent on io functions, this patch disable calls
to fprintf when building for baremetal targets in release mode.
https://reviews.llvm.org/D30340
Files:
src/confi
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
danielmarjamaki created this revision.
This patch clarify the error messages about uninitialized function arguments.
It can be really hard to see the problem if there are 10-20 arguments like:
printf("debug:", a, b.c, d, e, ...);
with no info about which argument is uninitialized and with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296136: [libcxxabi] Disable calls to fprintf for baremetal
targets. (authored by rsingh).
Changed prior to commit:
https://reviews.llvm.org/D30339?vs=89674&id=89681#toc
Repository:
rL LLVM
https://r
Author: rsingh
Date: Fri Feb 24 10:43:36 2017
New Revision: 296136
URL: http://llvm.org/viewvc/llvm-project?rev=296136&view=rev
Log:
[libcxxabi] Disable calls to fprintf for baremetal targets.
We've been having issues with using libcxxabi and libunwind for baremetal
targets because fprintf is dep
Author: rsingh
Date: Fri Feb 24 10:38:05 2017
New Revision: 296135
URL: http://llvm.org/viewvc/llvm-project?rev=296135&view=rev
Log:
[libunwind] Disable calls to fprintf for baremetal targets.
We've been having issues with using libcxxabi and libunwind for baremetal
targets because fprintf is dep
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296135: [libunwind] Disable calls to fprintf for baremetal
targets. (authored by rsingh).
Changed prior to commit:
https://reviews.llvm.org/D30340?vs=89676&id=89679#toc
Repository:
rL LLVM
https://r
EricWF added a comment.
isn't this incorrect because `config.h` always defines LIBCXX_BAREMETAL?
Repository:
rL LLVM
https://reviews.llvm.org/D30339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
jroelofs added a comment.
In https://reviews.llvm.org/D30339#685888, @EricWF wrote:
> isn't this incorrect because `config.h` always defines LIBCXX_BAREMETAL?
Oh, right, it needs to be:
#if !LIBCXXABI_BAREMETAL || !defined(NDEBUG)
Repository:
rL LLVM
https://reviews.llvm.org/D30339
_
Oops, it did. Thanks for reminding me; I've merged that in r296139.
On Thu, Feb 23, 2017 at 11:13 PM, Hahnfeld, Jonas
wrote:
> Hi Hans,
>
> Did r295474 fall off your radar? Sorry that I asked for both commits in one
> email, should I reply to the other original commit?
>
> Thanks,
> Jonas
>
>> -
Merged to 4.0 in r296139 as requested on the r295473 commit thread.
On Fri, Feb 17, 2017 at 10:32 AM, Jonas Hahnfeld via cfe-commits
wrote:
> Author: hahnfeld
> Date: Fri Feb 17 12:32:58 2017
> New Revision: 295474
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295474&view=rev
> Log:
> [OpenMP]
rmaprath added a comment.
Perhaps change `config.h` and remove the definition there and adjust other
places accordingly?
The current form is very easy to trip over.
Repository:
rL LLVM
https://reviews.llvm.org/D30339
___
cfe-commits mailing lis
jroelofs added a comment.
In https://reviews.llvm.org/D30339#685919, @rmaprath wrote:
> Perhaps change `config.h` and remove the definition there and adjust other
> places accordingly?
>
> The current form is very easy to trip over.
Eric's point is that LIBCXXABI_BAREMETAL is a 0/1 flag, not a
Author: arphaman
Date: Fri Feb 24 11:45:16 2017
New Revision: 296140
URL: http://llvm.org/viewvc/llvm-project?rev=296140&view=rev
Log:
[Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma
in macro argument pre-expansion mode when skipping a function body
This commit fixes a
rs created this revision.
Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always
defined, I should have been checking the contents to see if it's enabled
https://reviews.llvm.org/D30343
Files:
src/abort_message.cpp
Index: src/abort_message.cpp
==
rs added a comment.
Ah sorry for the mistake. Fix is here https://reviews.llvm.org/D30343
Repository:
rL LLVM
https://reviews.llvm.org/D30339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296140: [Preprocessor] Fix incorrect token caching that
occurs when lexing _Pragma (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28772?vs=87801&id=89688#toc
Repository:
r
rs added a comment.
Going for post-commit.
https://reviews.llvm.org/D30343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsingh
Date: Fri Feb 24 12:22:59 2017
New Revision: 296146
URL: http://llvm.org/viewvc/llvm-project?rev=296146&view=rev
Log:
[libcxxabi] Fix condition typo in rL296136
Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always
defined, I should have been checking the conte
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296146: [libcxxabi] Fix condition typo in rL296136 (authored
by rsingh).
Changed prior to commit:
https://reviews.llvm.org/D30343?vs=89687&id=89693#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
arphaman created this revision.
This patch refactors the code figures out which block captures need to be
copied/destroyed using special copy/destroy code.
This is a preparation patch for work on merging block copy/destroy routines.
Thanks for taking a look!
Repository:
rL LLVM
https://revi
Merged to 4.0 in r296152.
On Thu, Feb 23, 2017 at 5:16 PM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Thu Feb 23 19:16:34 2017
> New Revision: 296063
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296063&view=rev
> Log:
> Revert r291477 "[Frontend] Correct values of ATOMIC_*_LO
Yes, this looks very straight-forward. Merged in r296154.
On Fri, Feb 24, 2017 at 4:29 AM, Sam McCall via cfe-commits
wrote:
> Thanks Anna, I'm new to the release process here.
>
> Hans: this is a simple fix for a null-dereference in the static analyzer.
> Does it make sense to cherrypick?
>
> On
On Mon, Jan 30, 2017 at 9:23 PM, Sam McCall via cfe-commits
wrote:
> Author: sammccall
> Date: Mon Jan 30 23:23:20 2017
> New Revision: 293604
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293604&view=rev
> Log:
> In VirtualCallChecker, handle indirect calls
>
> Summary:
> In VirtualCallChecker
Author: nico
Date: Fri Feb 24 13:10:12 2017
New Revision: 296160
URL: http://llvm.org/viewvc/llvm-project?rev=296160&view=rev
Log:
clang-format: Fix many Objective-C formatting regressions from r289428
r289428 added a separate language kind for Objective-C, but kept many
"Language == LK_Cpp" chec
Author: nico
Date: Fri Feb 24 13:13:59 2017
New Revision: 296161
URL: http://llvm.org/viewvc/llvm-project?rev=296161&view=rev
Log:
clang-format: Enable include sorting for style=Chromium
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.org
mgorny added a reviewer: doug.gregor.
mgorny added a subscriber: doug.gregor.
mgorny added a comment.
If I read the git correctly, the change that forbid defining builtins was
initially made in https://reviews.llvm.org/rL64639. @doug.gregor, any chance
you could help us over here? Is clang suppo
arphaman added inline comments.
Comment at: include/clang/Basic/Attr.td:308-311
+ // - An attribute requires delayed parsing (LateParsed is on)
+ // - An attribute has no GNU/CXX11 spelling
+ // - An attribute has no subject list
+ // - An attribute derives from a StmtAttr or
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks! I assume you will make corresponding changes in backend.
https://reviews.llvm.org/D30316
___
cfe-commits mailing list
cfe-commits@l
efriedma added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2380
+ CGF.SanOpts.has(SanitizerKind::SignedIntegerOverflow)) &&
+ Ops.Ty->isIntegerType()) {
CodeGenFunction::SanitizerScope SanScope(&CGF);
I don't think you need the isInt
Hi Eric,
I don't know if you are aware, but one of the tests you added in this change is
failing on the PS4 Windows bot. The test is " Clang Tools ::
change-namespace/white-list.cpp". Can you please take a look?
Douglas Yung
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-
EricWF added a comment.
This works for me, but the idiomatic macro usage in libc++, and (hopefully)
libc++abi should always use `defined(FOO)` as opposed to `!FOO`. I'll clean
this up in the next week if nobody else wants to.
Repository:
rL LLVM
https://reviews.llvm.org/D30343
__
EricWF added a comment.
In https://reviews.llvm.org/D30339#685921, @jroelofs wrote:
> In https://reviews.llvm.org/D30339#685919, @rmaprath wrote:
>
> > Perhaps change `config.h` and remove the definition there and adjust other
> > places accordingly?
> >
> > The current form is very easy to trip
Author: jvesely
Date: Fri Feb 24 14:32:18 2017
New Revision: 296164
URL: http://llvm.org/viewvc/llvm-project?rev=296164&view=rev
Log:
.gitignore: Ignore amdgcn-mesa object directory
Modified:
libclc/trunk/.gitignore
Modified: libclc/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-project/
On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote:
EricWF added a comment.
In https://reviews.llvm.org/D30339#685921, @jroelofs wrote:
In https://reviews.llvm.org/D30339#685919, @rmaprath wrote:
Perhaps change `config.h` and remove the definition there and adjust other
places accord
Inserting arbitrary feature macros into CMake should not be a supported
scenario because it results is macros, such as this one, which are
seemingly dead.
/Eric
On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs wrote:
>
>
> On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote:
>
>> EricWF ad
Author: nico
Date: Fri Feb 24 14:49:00 2017
New Revision: 296166
URL: http://llvm.org/viewvc/llvm-project?rev=296166&view=rev
Log:
clang-format: Don't leave behind temp files in -i mode on Windows, PR26125
Fix and analysis by Wei Mao (see bug), test by me.
Added:
cfe/trunk/test/Format/inpla
tigerleapgorge accepted this revision.
tigerleapgorge added a comment.
This revision is now accepted and ready to land.
Of the 3 tests.
format-strings.cpp and printf-cstr.cpp have been commited in r294979
For warn-thread-safety-parsing.cpp, bug 32066 has been filed to track the lack
of thread saf
Author: rtrieu
Date: Fri Feb 24 14:59:28 2017
New Revision: 296170
URL: http://llvm.org/viewvc/llvm-project?rev=296170&view=rev
Log:
[ODRHash] Add handling of bitfields
Differential Revision: https://reviews.llvm.org/D21675
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds
Author: nico
Date: Fri Feb 24 15:01:43 2017
New Revision: 296171
URL: http://llvm.org/viewvc/llvm-project?rev=296171&view=rev
Log:
Try to unbreak tests after r296166
Looks like %T isn't per-test but per-test-directory, and
the rm was deleting temp files written by other tests in
test/Format. Lim
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D20710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
On 2/24/17 1:48 PM, Eric Fiselier wrote:
Inserting arbitrary feature macros into CMake should not be a
supported scenario because it results is macros, such as this one,
which are seemingly dead.
Good point.
Jon
/Eric
On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs
mailto:jonat...@c
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of changes.
Comment at: test/Modules/Inputs/merge-using-decls/a.h:25
+#if __cplusplus <= 199711L // C++11 does not allow access declerations
template st
arsenm added a comment.
In https://reviews.llvm.org/D30316#686089, @yaxunl wrote:
> LGTM. Thanks! I assume you will make corresponding changes in backend.
This is to match r295891, so then https://reviews.llvm.org/D28937 is required
to fix addrspacecast
https://reviews.llvm.org/D30316
___
Author: rsmith
Date: Fri Feb 24 15:18:47 2017
New Revision: 296173
URL: http://llvm.org/viewvc/llvm-project?rev=296173&view=rev
Log:
Factor out more commonality between handling of deletion and exception
specifications for special member functions.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cp
yaxunl added a comment.
AMDGPUTargetMachine::getNullPointerValue needs also be changed to match this,
otherwise the static initializer will be incorrect for null pointer to private
addr space. Do you plan to change that?
https://reviews.llvm.org/D30316
__
arsenm added a comment.
In https://reviews.llvm.org/D30316#686174, @yaxunl wrote:
> AMDGPUTargetMachine::getNullPointerValue needs also be changed to match
> this, otherwise the static initializer will be incorrect for null pointer to
> private addr space. Do you plan to change that?
Yes, t
vsk added a comment.
Looks NFC to me.
Comment at: lib/CodeGen/CGBlocks.cpp:1414
+
+} // end anonymous namespace
+
I don't see the need for two GenericInfo types (although it's plausible it'll
make sense with your upcoming changes!). I had in mind a single 'enu
On 24 February 2017 at 20:49, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Fri Feb 24 14:49:00 2017
> New Revision: 296166
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296166&view=rev
> Log:
> clang-format: Don't leave behind temp files in -i mode on Windows, PR26125
>
> Fix and an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296184: [Test] Make Lit tests C++11 compatible #9 (authored
by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D20710?vs=87309&id=89728#toc
Repository:
rL LLVM
https://reviews.llvm.org/
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Dominic, this (https://reviews.llvm.org/D28952) and
https://reviews.llvm.org/D26061 look get to me! Let's get these two committed!
We'd like to get to a place where in-tree incremental
jbangert updated this revision to Diff 89730.
jbangert marked an inline comment as done.
jbangert added a comment.
use llvm::report_fatal_error instead of unreachable.
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
jbangert added inline comments.
Comment at: lib/Tooling/RefactoringCallbacks.cpp:213
+llvm::errs() << "Node " << Element.Value
+ << " used in replacement template not bound in Matcher
\n";
+llvm_unreachable("Unbound node in replacement templat
vsk updated this revision to Diff 89733.
vsk added a comment.
- Make the suggested readability improvements, and fix a comment in the test
case.
https://reviews.llvm.org/D29369
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/compound-assign-overflow.c
test/CodeGen/ubsan-promoted-arith.c
vsk updated this revision to Diff 89734.
vsk added a comment.
- Add a small test that shows why the 'isIntegerType' check is required (we'd
crash otherwise).
https://reviews.llvm.org/D29437
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/ubsan-promoted-arith.cpp
Index: test/CodeGen/ubsa
tigerleapgorge abandoned this revision.
tigerleapgorge added a comment.
https://reviews.llvm.org/D20710 is a superset of this patch.
https://reviews.llvm.org/D20710 has been committed in
https://reviews.llvm.org/rL296184.
No need for this patch.
https://reviews.llvm.org/D29972
__
tigerleapgorge updated this revision to Diff 89736.
tigerleapgorge added a comment.
Updated patch in accordance to Richard Smith's comments.
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-decls/b.h
test/Modules/merge-using-decls.cpp
test/SemaCXX/PR9572.cpp
test/S
tigerleapgorge marked 2 inline comments as done.
tigerleapgorge added inline comments.
Comment at: test/SemaCXX/PR9572.cpp:34
+// expected-error@-2 {{non-deleted function '~Bar' cannot override a deleted
function}}
+// expected-note@-3 {{while declaring the implicit destructor f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296193: [Test] Make Lit tests C++11 compatible #10 (authored
by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D21626?vs=89736&id=89737#toc
Repository:
rL LLVM
https://reviews.llvm.org
tigerleapgorge closed this revision.
tigerleapgorge added a comment.
warn-thread-safety-parsing.cpp has been commited in
https://reviews.llvm.org/rL296193.
The following FIXME has been added to track this bug.
//FIXME: Bug 32066 - Error should be emitted irrespective of C++ dialect
https://rev
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D29437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: rtrieu
Date: Fri Feb 24 17:35:37 2017
New Revision: 296198
URL: http://llvm.org/viewvc/llvm-project?rev=296198&view=rev
Log:
[ODRHash] Finish FieldDecl support by handling mutable and initializers.
https://reviews.llvm.org/rL296170
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSe
Author: probinson
Date: Fri Feb 24 18:15:45 2017
New Revision: 296209
URL: http://llvm.org/viewvc/llvm-project?rev=296209&view=rev
Log:
[PS4] Set our default dialect to C++11. NFC for other targets.
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Modified: cfe/trunk/lib/Frontend/Comp
dtzWill accepted this revision.
dtzWill added a comment.
This revision is now accepted and ready to land.
Sorry for the delay!
LGTM, thanks!
https://reviews.llvm.org/D29369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
1 - 100 of 127 matches
Mail list logo
